Hi all,
This pull request contains a backport of commit
[013367b4](https://github.com/openjdk/jdk/commit/013367b4831094cdd330564378de69deccd0dc4b)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Jaikiran Pai on 26 Jun 2023 and
was
On Mon, 26 Jun 2023 05:58:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which fixes a javadoc issue
> reported in https://bugs.openjdk.org/browse/JDK-8310868?
>
> I ran `make docs-image` locally with this change and the link is now
> correctly rendered in the g
On Mon, 26 Jun 2023 05:58:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which fixes a javadoc issue
> reported in https://bugs.openjdk.org/browse/JDK-8310868?
>
> I ran `make docs-image` locally with this change and the link is now
> correctly rendered in the g
On Mon, 26 Jun 2023 05:58:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which fixes a javadoc issue
> reported in https://bugs.openjdk.org/browse/JDK-8310868?
>
> I ran `make docs-image` locally with this change and the link is now
> correctly rendered in the g
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15
Can I please get a review of this trivial change which fixes a javadoc issue
reported in https://bugs.openjdk.org/browse/JDK-8310868?
I ran `make docs-image` locally with this change and the link is now correctly
rendered in the generated javadoc.
-
Commit messages:
- 8310868: Thr
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
This pull request has now been integrated.
Changeset: 8242c647
Author:Julian Waters
URL:
https://git.openjdk.org/jdk/commit/8242c647b9d31320757363b69e7048a109ce86df
Stats: 11 lines in 3 fil
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
Our tier 1 builds have passed.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14645#pullrequestreview-1497595990
On Fri, 23 Jun 2023 08:37:16 GMT, Matthias Baesken wrote:
> Chris are you okay with the latest rev. of this change?
Sorry, I've been on vacation the past few days. I will have a look at it
tomorrow.
-
PR Comment: https://git.openjdk.org/jdk/pull/14562#issuecomment-1606661232
On Fri, 23 Jun 2023 16:43:32 GMT, Jatin Bhateja wrote:
> Backing out shuffle related overhaul done with
> [JDK-8304450](https://bugs.openjdk.org/browse/JDK-8304450), we saw
> significant performance degradation in VectorAPI JMH micros and some of our
> internal benchmarks. Following two issues
On Mon, 26 Jun 2023 04:26:47 GMT, David Holmes wrote:
> > as is evident in the tests for this PR
>
> You mean the GHA builds? They don't seem to be building the failing
> `jdk.jdwp.agent-static-libs` target.
I can't recompile the JDK at the moment to compile ArrayReferenceImpl.c, but I
can de
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
Okay I have it running through our tier1 builds at the moment. If that passes I
will approve the PR. Thanks
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606580347
On Mon, 26 Jun 2023 04:23:58 GMT, Julian Waters wrote:
> as is evident in the tests for this PR
You mean the GHA builds? They don't seem to be building the failing
`jdk.jdwp.agent-static-libs` target.
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606573575
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
How was the original change tested? How was this change tested?
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606571300
On Mon, 26 Jun 2023 04:15:09 GMT, David Holmes wrote:
> https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170
:/
> How was the original change tested? How was this change tested?
I made the mistake of testing the original on gcc instead of the native
compiler for Wind
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
_Alignas does work on Microsoft Visual C, fortunately
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606570803
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Microsoft, your C "conformance" is garbage
https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606567568
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Microsoft, your C "conformance" is garbage
@dholmes-ora
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606505881
Microsoft, your C "conformance" is garbage
-
Commit messages:
- ArrayReferenceImpl.c
- GSSLibStub.c
- 8310863
Changes: https://git.openjdk.org/jdk/pull/14645/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14645&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8310863
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase.
On Fri, 31 Mar 2023 06:07:39 GMT, Julian Waters wrote:
> C11 has been stable for a long time on all platforms, so native code can use
> the standard alignas operator for alignment requirements
This pull request has now been integrated.
Changeset: 78c38317
Author:Julian Waters
URL:
On Sun, 25 Jun 2023 15:58:06 GMT, Julian Waters wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 18 commits:
>>
>> - Merge branch 'openjdk:master' into patch-6
>> - Whitespace
>> - Revert
>> - _MSC_VER
>
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
On Sat, 24 Jun 2023 01:29:26 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Sun, 25 Jun 2023 18:42:14 GMT, Pavel Rappo wrote:
> I'll re-run our CI, and if all good, I'll sponsor this PR.
The CI tests I started have just passed. While this PR is already good, I
wonder if we make it even better.
I doubt highly that we need null-checks for CacheKey's name and locale.
On Sun, 25 Jun 2023 16:09:51 GMT, Alan Bateman wrote:
>> @AlanBateman i have modified according to liach's suggestion, it's ready for
>> review also.
>
>> @wenshao I don't think this is feasible, for this uses a new feature and
>> hampers backport to jdk11.
>
> I don't think backporting should
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Sun, 25 Jun 2023 20:19:58 GMT, Andrey Turbanov wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> remove JavaLangAccess#fastUUID
>
> src/java.base/share/classes/java/util/UUID.java line 466:
>
>> 464: @Override
>> 465:
On Sun, 25 Jun 2023 20:20:00 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Sun, 25 Jun 2023 16:09:51 GMT, Alan Bateman wrote:
>> @AlanBateman i have modified according to liach's suggestion, it's ready for
>> review also.
>
>> @wenshao I don't think this is feasible, for this uses a new feature and
>> hampers backport to jdk11.
>
> I don't think backporting should
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Sun, 25 Jun 2023 18:17:31 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request with a new target base due to a
> merge or a rebase. The i
On Fri, 23 Jun 2023 22:02:22 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/util/resources/Bundles.java line 510:
>>
>>> 508: return false;
>>> 509: }
>>> 510: return Objects.equals(locale, otherEntry.locale)
>>
>> While the propos
> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
> outdated. This simple clean-up modernizes them.
Sergey Tsypanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Sun, 25 Jun 2023 17:19:22 GMT, 温绍锦 wrote:
> Should we consider that when COMPACT_STRINGS is false, should it only be
> guaranteed to work correctly, not the best performance. If based on this
> principle, the implementation code will be much simpler.
I'm also curious about this question.
T
On Sun, 25 Jun 2023 12:20:17 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Sun, 25 Jun 2023 12:20:17 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Sun, 25 Jun 2023 16:48:06 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/lang/Long.java line 451:
>>
>>> 449: }
>>> 450:
>>> 451: static String fastUUID(long lsb, long msb) {
>>
>> This method should probably have an assert or something that
>> `COMPACT_STRINGS` is `true`, e.g
On Sun, 25 Jun 2023 16:09:51 GMT, Alan Bateman wrote:
> I don't think this is feasible, for this uses a new feature and hampers
> backport to jdk11.
I don't think affecting backports in general should be a reason to discourage
new features from being used.
https://github.com/wenshao/jdk/commi
On Sun, 25 Jun 2023 16:20:15 GMT, ExE Boss wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add jdk.util.HexDigits, sharing cache array across multiple classes,
>> including :
>> java.lang.Long#fastUUID
>> java.util.Hex
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase.
On Thu, 8 Jun 2023 11:20:05 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix the code that is actually warning
>
> I'll take a look… hopefully next week.
> @aivanov-jdk Is the final change o
On Sat, 24 Jun 2023 01:29:26 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Sun, 25 Jun 2023 12:20:17 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Sun, 25 Jun 2023 12:20:14 GMT, 温绍锦 wrote:
>> @wenshao The patch has changed 19 times in the last 3 days, is it ready for
>> review now?
>
> @AlanBateman i have modified according to liach's suggestion, it's ready for
> review also.
> @wenshao I don't think this is feasible, for this uses a
> On Jun 25, 2023, at 10:41 AM, Alan Snyder wrote:
>
> My certificate is different, as I stated. I don’t know why.
Again, FWIW.
As shown Apple provides some different certificates for different purposes.
What I show works for me.
If in the Keychain Access you have a certificate with a com
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase.
On Thu, 8 Jun 2023 11:20:05 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix the code that is actually warning
>
> I'll take a look… hopefully next week.
@aivanov-jdk Is the final change ok
> On Jun 25, 2023, at 10:21 AM, Alan Snyder wrote:
>
> I’m having trouble using the code signing feature of jpackage for macOS.
>
FWIW, I have…
SIGNING_CERT_3RD_PARTY="3rd Party Mac Developer Application: Michael Hall
(??)"
DEFAULT_SIGNING_CERT="Michael Hall"
DEVELOPER_ID_APPLICATI
My certificate is different, as I stated. I don’t know why.
> On Jun 25, 2023, at 8:34 AM, Michael Hall wrote:
>
>
>
>> On Jun 25, 2023, at 10:21 AM, Alan Snyder wrote:
>>
>> I’m having trouble using the code signing feature of jpackage for macOS.
>>
>
> FWIW, I have…
>
> SIGNING_CERT_3
I’m having trouble using the code signing feature of jpackage for macOS.
The problem appears to be here:
result = MacBaseInstallerBundler.findKey(
"Developer ID Application: ", user, keychain);
}
boolean useAsIs = teamName.startsWith(keyPrefix
On Fri, 23 Jun 2023 19:41:17 GMT, Joe Darcy wrote:
>> Correct misstatement that the Class object for a primitive type can only be
>> be access via fields like java.lang.Integer.TYPE.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Sun, 25 Jun 2023 05:49:09 GMT, Alan Bateman wrote:
>> Latest benchmark results (commit id
>> [0d34655](https://github.com/openjdk/jdk/pull/14578/commits/0d346558e00cfab899e435acd0eb83d39d5b7169)
>> ):
>>
>> *
>> [aliyun_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
>
On Sun, 25 Jun 2023 10:00:23 GMT, 温绍锦 wrote:
>> @wenshao The patch has changed 19 times in the last 3 days, is it ready for
>> review now?
>
> @AlanBateman
>
> i found an implementation with minor changes, but slower when COMPACT_STRINGS
> is false.
>
> https://github.com/wenshao/jdk/commit/
On Sun, 25 Jun 2023 05:49:09 GMT, Alan Bateman wrote:
>> Latest benchmark results (commit id
>> [0d34655](https://github.com/openjdk/jdk/pull/14578/commits/0d346558e00cfab899e435acd0eb83d39d5b7169)
>> ):
>>
>> *
>> [aliyun_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
>
This patch touches java.lang.reflect and java.lang.invoke packages. It replaces
instanceof + cast with pattern matching and updates
Array.newInstance().getClass() patterns with arrayType() for obtaining array
types of a class.
-
Commit messages:
- 8310849: Pattern matching for in
On Fri, 23 Jun 2023 11:24:23 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Sun, 25 Jun 2023 05:49:09 GMT, Alan Bateman wrote:
>> Latest benchmark results (commit id
>> [0d34655](https://github.com/openjdk/jdk/pull/14578/commits/0d346558e00cfab899e435acd0eb83d39d5b7169)
>> ):
>>
>> *
>> [aliyun_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
>
On Fri, 23 Jun 2023 04:52:16 GMT, 温绍锦 wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> remove unused import
>
> Latest benchmark results (commit id
> [0d34655](https://github.com/openjdk/jdk/pull/14578/commits/0d346558e00cf
60 matches
Mail list logo
