Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Jaikiran Pai
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14433#pullrequestreview-1476287791

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Stuart Marks
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. I've been advised by @jddarcy to file a CSR for this, in order to track of serialization compatibility issues. - PR Comment: https://git.openjdk.org/jdk/pull/14433#issuecomment-1588346239

Integrated: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader

2023-06-12 Thread Jaikiran Pai
On Mon, 12 Jun 2023 11:30:19 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which moves the tests from > under `test/jdk/sun/misc/URLClassPath` to > `test/jdk/jdk/internal/loader/URLClassPath`? This addresses > https://bugs.openjdk.org/browse/JDK-8309763. > > As

Re: RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader

2023-06-12 Thread Jaikiran Pai
On Mon, 12 Jun 2023 11:30:19 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which moves the tests from > under `test/jdk/sun/misc/URLClassPath` to > `test/jdk/jdk/internal/loader/URLClassPath`? This addresses > https://bugs.openjdk.org/browse/JDK-8309763. > > As

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Brian Burkhalter
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. Looks fine. - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14433#pullrequestreview-1476004322

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Joe Darcy
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. I skimmed the JDK-8266571: "Sequenced Collections" and didn't see any similar instances, but it would benefit from another look. - Marked as reviewed by darcy (Reviewer). PR Review: https

RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Stuart Marks
Make `putMode` be a transient field. - Commit messages: - 8309882: LinkedHashMap adds an errant serializable field Changes: https://git.openjdk.org/jdk/pull/14433/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

2023-06-12 Thread Mandy Chung
On Mon, 12 Jun 2023 23:17:03 GMT, Chen Liang wrote: >> test/jdk/java/lang/invoke/VarHandles/IndirectVarHandleTest.java line 44: >> >>> 42: var lookup = MethodHandles.lookup(); >>> 43: var intArrayVh = >>> MethodHandles.arrayElementVarHandle(int[].class); >>> 44: var addO

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 22:54:08 GMT, Mandy Chung wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Wrap lines that are too long > > test/jdk/java/lang/invoke/VarHandles/IndirectVarHandleTest.java line 44: > >> 42:

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

2023-06-12 Thread Chen Liang
> Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the > target var handle. In addition, simplified the MH caching in Indirect VH and > removed redundant overrides (already available via var form). This was split > from #13821 as suggested by Mandy Chung, which allows ea

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v2]

2023-06-12 Thread Chen Liang
> Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the > target var handle. In addition, simplified the MH caching in Indirect VH and > removed redundant overrides (already available via var form). This was split > from #13821 as suggested by Mandy Chung, which allows ea

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE

2023-06-12 Thread Mandy Chung
On Mon, 12 Jun 2023 05:27:35 GMT, Chen Liang wrote: > Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the > target var handle. In addition, simplified the MH caching in Indirect VH and > removed redundant overrides (already available via var form). This was split > fr

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-12 Thread Justin Lu
> Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the original file's changes in UTF-8 > native. Those fil

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 22:17:25 GMT, Eirik Bjorsnos wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.propertie

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Eirik Bjorsnos
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
Please review this PR which updates the JDK's localized resources since the previous L10n translation drop (1/26). To help with reviewing the changes, @jonathan-gibbons created a tool which displays the localized changes next to the original file's changes in UTF-8 native. Those files can be vi

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 21:42:24 GMT, Kevin Rushforth wrote: >> @prrace @jonathan-gibbons @pavelrappo @lahodaj @wangweij @igraves >> @AlanBateman @eirbjo could you please review the modules / changes you are >> familiar with, thank you. > > @justin-curtis-lu Unless there is a strong reason to do ot

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Kevin Rushforth
On Mon, 12 Jun 2023 21:27:05 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
Please review this PR which updates the JDK's localized resources since the previous L10n translation drop (1/26). To help with reviewing the changes, @jonathan-gibbons created a tool which displays the localized changes next to the original file's changes in UTF-8 native. Those files can be vi

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v2]

2023-06-12 Thread Daniel Fuchs
On Mon, 12 Jun 2023 17:33:11 GMT, Naoto Sato wrote: >> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 >> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored >> the in-house cache with WeakHashMap, and removed the Key class as it is no >> longer ne

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v5]

2023-06-12 Thread Doug Simon
> This PR reduces the amount of code executed during libgraal initialization. > This not only improves VM startup overall but all fixes a number of JDK test > failures that are caused by Java code executing "too early". For example, > `java/util/Locale/CompatWarning.java` can fail if > `sun.uti

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v21]

2023-06-12 Thread Chris Hennick
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding DoubleZigguratTables.exponential

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-12 Thread Roger Riggs
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Looks fine. - Marked as reviewed by rriggs (Reviewer). PR Review

Withdrawn: 8295146: Clean up native code with newer C/C++ language features

2023-06-12 Thread duke
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote: > After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v4]

2023-06-12 Thread Vladimir Kozlov
On Mon, 12 Jun 2023 09:21:14 GMT, Doug Simon wrote: >> This PR reduces the amount of code executed during libgraal initialization. >> This not only improves VM startup overall but all fixes a number of JDK test >> failures that are caused by Java code executing "too early". For example, >> `ja

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v2]

2023-06-12 Thread Naoto Sato
On Mon, 12 Jun 2023 12:49:05 GMT, Albert Mingkun Yang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing comments (test grouping, synchronization), minor optimization >> on loop lookup > > test/hotspot/jtreg

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Naoto Sato
On Mon, 12 Jun 2023 16:23:29 GMT, Roger Riggs wrote: > One other thing to consider... If the BaseLocale entries are being GC'd > sooner, then perhaps the value of the String.intern() is reduced. Eliminating > `.intern90` would make creating a normalized BaseLocale faster. Some code inside the

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v2]

2023-06-12 Thread Naoto Sato
On Mon, 12 Jun 2023 14:35:15 GMT, Daniel Fuchs wrote: > One thing though - WeakHashMap is not thread safe - and I don't see any locks > or synchronized to protect access to CACHE. Is that going to cause trouble if > two threads compete to add a locale to the map? In other words - how > confide

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v2]

2023-06-12 Thread Naoto Sato
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed (thus the original NPE will no longer be possible). A

Re: RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader

2023-06-12 Thread Mandy Chung
On Mon, 12 Jun 2023 11:30:19 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which moves the tests from > under `test/jdk/sun/misc/URLClassPath` to > `test/jdk/jdk/internal/loader/URLClassPath`? This addresses > https://bugs.openjdk.org/browse/JDK-8309763. > > As

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Roger Riggs
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote: > This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed

Integrated: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-12 Thread Jiangli Zhou
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote: > Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Buil

Re: RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-12 Thread Roger Riggs
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote: > This PR proposes adding `@Stable` to certain wrapper classes' cache arrays > (e.g. `Integer` and `Long`). > > Comments are welcome as to how to improve the VM's handling now that the > backing cache array is `@Stable`. Are there simplifica

Integrated: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Maurizio Cimadamore
On Tue, 23 May 2023 11:48:59 GMT, Maurizio Cimadamore wrote: > As the FFM API evolved over time, some parts of the javadoc went out of sync. > Now that most of the API is stable, it is a good time to look again at the > javadoc as a whole, and bring some more consistency. > > While most of th

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v14]

2023-06-12 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v7]

2023-06-12 Thread Maurizio Cimadamore
On Mon, 12 Jun 2023 10:33:41 GMT, Maurizio Cimadamore wrote: >> As the FFM API evolved over time, some parts of the javadoc went out of >> sync. Now that most of the API is stable, it is a good time to look again at >> the javadoc as a whole, and bring some more consistency. >> >> While most

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v3]

2023-06-12 Thread Tom Rodriguez
On Mon, 12 Jun 2023 09:20:09 GMT, Doug Simon wrote: >> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/services/Services.java line >> 314: >> >>> 312: String key = toJavaString(unsafe, unsafe.getLong(prop + >>> keyOffset)); >>> 313: long valueAddress = unsafe.getLong(pro

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v4]

2023-06-12 Thread Tom Rodriguez
On Mon, 12 Jun 2023 09:21:14 GMT, Doug Simon wrote: >> This PR reduces the amount of code executed during libgraal initialization. >> This not only improves VM startup overall but all fixes a number of JDK test >> failures that are caused by Java code executing "too early". For example, >> `ja

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v13]

2023-06-12 Thread Adam Sotona
On Mon, 12 Jun 2023 11:20:40 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected c

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Maurizio Cimadamore
On Mon, 12 Jun 2023 14:45:48 GMT, Jorn Vernee wrote: > Btw, besides the other 2 issues this solves (from the other PR), I think this > also solves: https://bugs.openjdk.org/browse/JDK-8255350 Thanks for the reminder - JDK-8255350 is not fixed by this, but by https://git.openjdk.org/jdk/pull/14

Integrated: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Maurizio Cimadamore
On Mon, 12 Jun 2023 11:01:08 GMT, Maurizio Cimadamore wrote: > This is the same PR as https://github.com/openjdk/jdk/pull/14098, but > backported to the JDK 21 repo fork. This pull request has now been integrated. Changeset: 20371fd9 Author:Maurizio Cimadamore URL: https://git.ope

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Kevin Rushforth
On Mon, 12 Jun 2023 15:19:51 GMT, Maurizio Cimadamore wrote: >> Btw, besides the other 2 issues this solves (from the other PR), I think >> this also solves: https://bugs.openjdk.org/browse/JDK-8255350 > >> Btw, besides the other 2 issues this solves (from the other PR), I think >> this also s

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v6]

2023-06-12 Thread Maurizio Cimadamore
On Mon, 12 Jun 2023 10:29:07 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 29 commits: >> >> - Merge branch 'master' into javadoc_fixes >> - Fix issue with ArithmeticExce

Integrated: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-12 Thread Chris Hegarty
On Fri, 9 Jun 2023 19:44:32 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit > [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-12 Thread Chris Hegarty
On Fri, 9 Jun 2023 19:44:32 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit > [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-12 Thread Roger Riggs
On Fri, 9 Jun 2023 19:44:32 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit > [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v6]

2023-06-12 Thread Kevin Rushforth
On Mon, 12 Jun 2023 10:29:07 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 29 commits: >> >> - Merge branch 'master' into javadoc_fixes >> - Fix issue with ArithmeticExce

Re: RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader

2023-06-12 Thread Alan Bateman
On Mon, 12 Jun 2023 11:30:19 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which moves the tests from > under `test/jdk/sun/misc/URLClassPath` to > `test/jdk/jdk/internal/loader/URLClassPath`? This addresses > https://bugs.openjdk.org/browse/JDK-8309763. > > As

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Jorn Vernee
On Mon, 12 Jun 2023 11:01:08 GMT, Maurizio Cimadamore wrote: > This is the same PR as https://github.com/openjdk/jdk/pull/14098, but > backported to the JDK 21 repo fork. Btw, besides the other 2 issues this solves (from the other PR), I think this also solves: https://bugs.openjdk.org/browse

Re: RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote: > This PR proposes adding `@Stable` to certain wrapper classes' cache arrays > (e.g. `Integer` and `Long`). > > Comments are welcome as to how to improve the VM's handling now that the > backing cache array is `@Stable`. Are there simplifica

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Daniel Fuchs
On Mon, 12 Jun 2023 14:26:34 GMT, Daniel Fuchs wrote: > The main change is that base locales will now be cached using WeakReference > rather than SoftReference, and thus probably collected more eagerly, but that > actually looks like a positive change. Hmm or not. Nothing references the ke

RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader

2023-06-12 Thread Jaikiran Pai
Can I please get a review of this test-only change which moves the tests from under `test/jdk/sun/misc/URLClassPath` to `test/jdk/jdk/internal/loader/URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8309763. As noted in that issue, in Java 9, the `sun.misc.URLClassPath` was mov

Re: RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-12 Thread Per Minborg
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote: > This PR proposes adding `@Stable` to certain wrapper classes' cache arrays > (e.g. `Integer` and `Long`). > > Comments are welcome as to how to improve the VM's handling now that the > backing cache array is `@Stable`. Are there simplifica

RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-12 Thread Per Minborg
This PR proposes adding `@Stable` to certain wrapper classes' cache arrays (e.g. `Integer` and `Long`). Comments are welcome as to how to improve the VM's handling now that the backing cache array is `@Stable`. Are there simplifications to be made or are there other optimizations we might add?

Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v2]

2023-06-12 Thread Alan Bateman
On Mon, 12 Jun 2023 14:09:59 GMT, Andrew Haley wrote: >> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. >> >> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM >> error occurs it can not recover scoped values. >> >> Moving `runWith()` into the common su

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Daniel Fuchs
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote: > This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Daniel Fuchs
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote: > This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Daniel Fuchs
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote: > This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed

Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v2]

2023-06-12 Thread Andrew Haley
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. > > `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM > error occurs it can not recover scoped values. > > Moving `runWith()` into the common subclass of both `VirtualThread` and > `BoundVirtualThread` fix

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-12 Thread Sergey Tsypanov
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote: > Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Jorn Vernee
On Mon, 12 Jun 2023 11:01:08 GMT, Maurizio Cimadamore wrote: > This is the same PR as https://github.com/openjdk/jdk/pull/14098, but > backported to the JDK 21 repo fork. Already reviewed the other PR. - Marked as reviewed by jvernee (Reviewer). PR Review: https://git.openjdk.or

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-12 Thread Sean Mullan
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Another possibility is to put this under a new option, ex `-XshowSecuritySettings`. - PR Comment: https://git.open

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-12 Thread Albert Mingkun Yang
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote: > This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-12 Thread Erik Joelsson
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote: > Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the > typos you pointed out and removed other redundancies in classfile Util as > well. @asotona Can you please review this when you are free? - PR Commen

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v13]

2023-06-12 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

RFR: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Maurizio Cimadamore
This is the same PR as https://github.com/openjdk/jdk/pull/14098, but backported to the JDK 21 repo fork. - Commit messages: - Initial push Changes: https://git.openjdk.org/jdk21/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=7&range=00 Issue: https://bugs.openj

Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 10:45:03 GMT, ExE Boss wrote: >> Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the >> typos you pointed out and removed other redundancies in classfile Util as >> well. > > src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 90: >

Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread ExE Boss
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote: > Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the > typos you pointed out and removed other redundancies in classfile Util as > well. src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 90: > 88

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v7]

2023-06-12 Thread Maurizio Cimadamore
> As the FFM API evolved over time, some parts of the javadoc went out of sync. > Now that most of the API is stable, it is a good time to look again at the > javadoc as a whole, and bring some more consistency. > > While most of the changes in this PR are stylistic, I'd like to call out few >

Withdrawn: 8308645: Javadoc of FFM API needs to be refreshed

2023-06-12 Thread Maurizio Cimadamore
On Tue, 23 May 2023 11:48:59 GMT, Maurizio Cimadamore wrote: > As the FFM API evolved over time, some parts of the javadoc went out of sync. > Now that most of the API is stable, it is a good time to look again at the > javadoc as a whole, and bring some more consistency. > > While most of th

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v6]

2023-06-12 Thread Maurizio Cimadamore
On Tue, 6 Jun 2023 10:35:09 GMT, Maurizio Cimadamore wrote: >> As the FFM API evolved over time, some parts of the javadoc went out of >> sync. Now that most of the API is stable, it is a good time to look again at >> the javadoc as a whole, and bring some more consistency. >> >> While most o

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

2023-06-12 Thread Maurizio Cimadamore
On Fri, 9 Jun 2023 18:22:48 GMT, Jorn Vernee wrote: >> But, the implementation of `byteOffsetHandle` rejects range elements: >> https://github.com/openjdk/jdk/pull/14098/files/265e0d5b082ad54d1cadea1d4a8bd844e72e3926#diff-90ecdacbee63a90f6e695a8bb4c1ad69b591602501613a774561c4032f01fb95R352 >> >

RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread Chen Liang
Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the typos you pointed out and removed other redundancies in classfile Util as well. - Commit messages: - 8309838: Classfile API Util.toBinaryName and other cleanup Changes: https://git.openjdk.org/jdk/pull/1441

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v6]

2023-06-12 Thread Jaikiran Pai
On Sat, 10 Jun 2023 06:44:56 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8308184? >> >> When an application is launched, the `app` classloader internally uses a >> `jdk.internal.loader.URLC

Integrated: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError

2023-06-12 Thread Jaikiran Pai
On Fri, 9 Jun 2023 14:55:50 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a > `jdk.internal.loader.URLClassPa

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v3]

2023-06-12 Thread Doug Simon
On Mon, 12 Jun 2023 03:00:23 GMT, Tom Rodriguez wrote: >> Doug Simon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> copy system properties into libgraal more efficiently > > src/jdk.internal.vm.ci/share/classe

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v4]

2023-06-12 Thread Doug Simon
> This PR reduces the amount of code executed during libgraal initialization. > This not only improves VM startup overall but all fixes a number of JDK test > failures that are caused by Java code executing "too early". For example, > `java/util/Locale/CompatWarning.java` can fail if > `sun.uti

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-12 Thread Sean Coffey
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Thanks for the reviews to date. All good comments, I'll implement. Yes, the output of `-XShowSettings` is more verbose. Let me t

RFR: 8309819: Fix specification about descriptor inverses in Class and MethodTypeDesc

2023-06-12 Thread Chen Liang
The API specification for descriptorString not being a strict inverse of Class::forName and MethodType::fromDescriptorString are not entirely correct. 1. Class::descriptorString was never an inverse of Class::forName, which takes a binary name instead. Class::getName was a partial inverse instea

Integrated: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly

2023-06-12 Thread Tobias Holenstein
On Thu, 4 May 2023 13:36:22 GMT, Tobias Holenstein wrote: > At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:CompileOnly=package/path/Cla

Integrated: JDK-8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

2023-06-12 Thread Matthias Baesken
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote: > On AIX , new jtreg test > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with > the output : > > --System.err:(294/28579)-- > STARTED DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJavaAg

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]

2023-06-12 Thread Christoph
On Mon, 12 Jun 2023 05:41:08 GMT, Oliver Kopp wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 754: >> >>> 752: // Restore all (!) sets from parameter to >>> local variables >>> 753: