Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

The tests use statically specified Transforms and each transformation also held set of options. Now the transformations hold static instance of Classfile context instead. Junit execute them in parallel for each individual class file being transformed, so one context is used in parallel environmen

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods

On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint > benchmar

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

On Thu, 8 Jun 2023 16:35:28 GMT, Brian Goetz wrote: > I have a hard time imagining heavy parallel use here; concurrency against the > same cache would most likely come from accidental sharing.  So this is not > necessarily a problem.  Are you imagining differnet use cases? I think it is common

Re: RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote: > Thread.interrupted is used to "get and clear" the current thread's interrupt > status. When called from a virtual thread, the current implementation always > clears the carrier's interrupt status. There is no need to do this when the > int

Re: RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote: > Thread.interrupted is used to "get and clear" the current thread's interrupt > status. When called from a virtual thread, the current implementation always > clears the carrier's interrupt status. There is no need to do this when the > int

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. The presubmit failure on linux-x86 looks unrelated to this PR. It is https://b

Integrated: JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr35

On Thu, 8 Jun 2023 21:36:03 GMT, Jonathan Gibbons wrote: > Please review a trivial docs change to fix a URL in a `@spec` tag consistent > with equivalent URLs in other tags. > (Consistency will be required when the External Specifications page is > enabled.) This pull request has now been inte

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. The pre-submit failures for windows are due to https://bugs.openjdk.org/browse

RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

Hi all, Could anyone review this small fix for a data race in java.io.ClassCache$CacheRef? This fix makes the code safer by making the code data-race-free. - Commit messages: - 8309688: Data race on java.io.ClassCache.strongReferent Changes: https://git.openjdk.org/jdk/pull/14386

Re: RFR: JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr35

On Thu, 8 Jun 2023 21:36:03 GMT, Jonathan Gibbons wrote: > Please review a trivial docs change to fix a URL in a `@spec` tag consistent > with equivalent URLs in other tags. > (Consistency will be required when the External Specifications page is > enabled.) My bad. Thanks for fixing the URL.

RFR: JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr35

Please review a trivial docs change to fix a URL in a `@spec` tag consistent with equivalent URLs in other tags. (Consistency will be required when the External Specifications page is enabled.) - Commit messages: - JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]

> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for > stati

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

On Thu, 1 Jun 2023 20:06:32 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix wrong link in layout well-formedness doc > > test/jdk/java/foreign/TestLayoutPaths.java line 125: > >> 123:

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

I still don't understand this point.  Why are separate tests sharing a context at all? On 6/8/2023 9:26 AM, Adam Sotona wrote: Unfortunately thread-unsafe context makes sharing of it in tests executed in parallel a nightmare. I can fix our Corpus tests and hope the race condition won't raise a

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v19]

On Sun, 12 Mar 2023 21:28:59 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javad

Re: RFR: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options

On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote: > The `RuntimeArguments` test verifies the VM arguments returned by > `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails > when running with GraalVM as it was created with `jlink --add-options` and > the application w

Re: RFR: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options

On Thu, 8 Jun 2023 19:01:37 GMT, Doug Simon wrote: > I can confirm the change works on GraalVM but it would make sense to also > test it directly in the JDK by creating a test JDK image with jlink that > includes VM options. Already exists. `test/jdk/tools/jlink/plugins/AddOptionsPluginTest.j

Re: RFR: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options

On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote: > The `RuntimeArguments` test verifies the VM arguments returned by > `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails > when running with GraalVM as it was created with `jlink --add-options` and > the application w

RFR: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options

The `RuntimeArguments` test verifies the VM arguments returned by `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails when running with GraalVM as it was created with `jlink --add-options` and the application will always be launched with that additional set of VM options.

Integrated: 8309196: Remove Thread.countStackFrames

On Thu, 1 Jun 2023 06:40:04 GMT, Alan Bateman wrote: > Thread.countStackFrames is/was an ill-defined method that dates from JDK 1.0 > for counting the stack frames of a suspended Thread. The method was > deprecated in JDK 1.2 (1998), deprecated for removal in Java 9, and > re-specified/degrade

Re: RFR: 8305104: Remove the old core reflection implementation [v3]

On Thu, 8 Jun 2023 16:46:55 GMT, Mandy Chung wrote: >> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has >> been reported. Those issues were related with exception being thrown with >> invalid arguments. We propose to remove the old core reflection >> implementatio

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

On Thu, 8 Jun 2023 01:36:40 GMT, Chen Liang wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix merge issue > > test/jdk/java/lang/reflect/Field/NegativeTest.java line 27: > >> 25: * @test >> 26: * @bug 8277451 >

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

On Thu, 8 Jun 2023 08:42:41 GMT, Alan Bateman wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix merge issue > > src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line > 578: > >> 576: /

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

On Thu, 8 Jun 2023 01:46:55 GMT, David Holmes wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix merge issue > > src/hotspot/share/classfile/verifier.cpp line 298: > >> 296: // NOTE: this is called too early i

Re: RFR: 8305104: Remove the old core reflection implementation [v3]

> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has > been reported. Those issues were related with exception being thrown with > invalid arguments. We propose to remove the old core reflection > implementation in JDK 22. The `-Djdk.reflect.useDirectMethodHandle=fal

Re: RFR: 8309196: Remove Thread.countStackFrames [v3]

> Thread.countStackFrames is/was an ill-defined method that dates from JDK 1.0 > for counting the stack frames of a suspended Thread. The method was > deprecated in JDK 1.2 (1998), deprecated for removal in Java 9, and > re-specified/degraded to throw UOE unconditionally in Java 14. Java 22 wou

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

On Thu, 8 Jun 2023 13:37:33 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods

On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint > benchmar

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

On Thu, 8 Jun 2023 14:07:24 GMT, Brian Goetz wrote: > Here are a few options:  - Make the CHA cache thread-safe using, say, CHM; This is current solution for the default system CH cache. We may also use a bit less strict custom semi-synchronization (just enough to be thread safe) instead o

Integrated: JDK-8306584: Start of release updates for JDK 22

On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... This pull request has now been integrated. Changeset: 5a706fb4 Author:Joe Darcy Committer: Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/5a706fb403df0768ecef5b0ce14a3ca389a51efd Stats:

Re: Leap second handling in Windows timestamps

Hi, I looked into this issue and added comments to the issue tracker. 8308302 Leap second handling in Windows timestamps I don't see an issue with the implementation for past leap-seconds and there is significant discussion about whether if or when

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 15:47:26 GMT, Pavel Rappo wrote: >> I admit I can't parse this sentence: >> >>> then the answer is that it's not necessary for keeping the API >>> documentation unchanged. >> >> Do you mean that you didn't add `@param e {@inheritDoc BlockingDeque}` here >> to keep the docum

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 15:16:09 GMT, Alexey Ivanov wrote: >> The directed `{@inheritDoc }` works for the main description, >> `@throws`, `@param` and `@return` tags. If your question is about why that >> particular doc comment does not use this: >> >> @param e {@inheritDoc BlockingDeque} >> >

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods

On Thu, 8 Jun 2023 15:24:00 GMT, Jim Laskey wrote: >> https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved >> Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks >> when copying the entire array, but it's resulted in a few lurking footprint >> benchmar

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods

On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint > benchmar

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods

On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint > benchmar

RFR: 8309665: Simplify Arrays.copyOf/-Range methods

https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks when copying the entire array, but it's resulted in a few lurking footprint benchmark issues that come down to incurring slightly more JIT activity.

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 11:29:44 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/util/concurrent/LinkedBlockingDeque.java >> line 635: >> >>> 633: * @return {@inheritDoc BlockingDeque} >>> 634: */ >>> 635: public boolean offer(E e) { >> >> Does this work for @param tags to

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

From: core-libs-dev on behalf of Brian Goetz Most entities in the system are immutable and therefore freely sharable without additional coordination. Some have lazily-inflated single-field caches that conform to the "benign race" (there is only one possible non-default value) criteria. The

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

On Wed, 7 Jun 2023 20:33:00 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > > test/langtools/jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodComments

Re: RFR: 8285368: Overhaul doc-comment inheritance [v8]

> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still ca

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v6]

On Thu, 8 Jun 2023 00:37:07 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 39 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master'

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v3]

> At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:CompileOnly=package/path/Class.method` > `-XX:CompileOnly=package/path/Class::method` > `

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

On Thu, 8 Jun 2023 13:37:33 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote: > Thread.interrupted is used to "get and clear" the current thread's interrupt > status. When called from a virtual thread, the current implementation always > clears the carrier's interrupt status. There is no need to do this when the > int

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 11:27:37 GMT, Pavel Rappo wrote: > If we were to (re-)structure doc comments in the way you propose, I'd suggest > we do it in a separate, non-jdk.javadoc PR. I was simply trying to keep JDK > API documentation unchanged. Understood, it was just a passing comment that TreeMa

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

On Thu, 8 Jun 2023 11:26:39 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v6]

On Thu, 8 Jun 2023 00:37:07 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 39 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master'

Re: RFR: 8309196: Remove Thread.countStackFrames [v2]

> Thread.countStackFrames is/was an ill-defined method that dates from JDK 1.0 > for counting the stack frames of a suspended Thread. The method was > deprecated in JDK 1.2 (1998), deprecated for removal in Java 9, and > re-specified/degraded to throw UOE unconditionally in Java 14. Java 22 wou

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

On Thu, 8 Jun 2023 10:21:07 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/lang/VirtualThread.java line 879: >> >>> 877: boolean oldValue = interrupted; >>> 878: if (oldValue) { >>> 879: synchronized (interruptLock) { >> >> Don't you still need to read

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 10:33:17 GMT, Alan Bateman wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: remove unduly restrictive warning > > src/java.base/share/classes/java/util/TreeMap.java line 1199: > >> 1197:

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v8]

On Thu, 8 Jun 2023 11:07:21 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 29 commits: >> >> - removal of ClassHierarchyImpl.DEFAULT_RESOLVER >>introduction of ClassHierarchyResolver::of

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

Re: RFR: 8308780: Fix the Java Integer types on Windows [v4]

On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v8]

On Thu, 8 Jun 2023 09:26:10 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v8]

On Thu, 8 Jun 2023 09:26:10 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

On Thu, 8 Jun 2023 09:38:52 GMT, David Holmes wrote: >> Thread.interrupted is used to "get and clear" the current thread's interrupt >> status. When called from a virtual thread, the current implementation always >> clears the carrier's interrupt status. There is no need to do this when the >>

Re: RFR: 8285368: Overhaul doc-comment inheritance [v7]

> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still ca

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

On Wed, 7 Jun 2023 21:39:33 GMT, Jonathan Gibbons wrote: >> The general criticism here is whether we should restrict in any way the set >> of super types from which one can inherit documentation, and/or what should >> the set of checks be? >> >> For example, if a method in C inherits a method

Re: RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote: > Thread.interrupted is used to "get and clear" the current thread's interrupt > status. When called from a virtual thread, the current implementation always > clears the carrier's interrupt status. There is no need to do this when the > int

Re: RFR: 8285368: Overhaul doc-comment inheritance [v5]

On Thu, 8 Jun 2023 09:26:16 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

On Thu, 8 Jun 2023 09:18:04 GMT, Pavel Rappo wrote: >> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java >> line 289: >> >>> 287: >>> 288: /* >>> 289: * C1.m inherits documentation from B1.m explicitly and undirect. >> >> possible typo: do you mea

Re: RFR: 8285368: Overhaul doc-comment inheritance [v6]

> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still ca

RFR: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

Thread.interrupted is used to "get and clear" the current thread's interrupt status. When called from a virtual thread, the current implementation always clears the carrier's interrupt status. There is no need to do this when the interrupt status is not set, it can just read the interrupt status

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v6]

On Thu, 8 Jun 2023 00:37:07 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 39 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master'

Re: RFR: 8285368: Overhaul doc-comment inheritance [v5]

> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still ca

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

On Wed, 7 Jun 2023 20:23:09 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > > test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritan

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v8]

> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung wrote: >> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has >> been reported. Those issues were related with exception being thrown with >> invalid arguments. We propose to remove the old core reflection >> implementatio

Re: RFR: 8305104: Remove the old core reflection implementation [v2]

On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung wrote: >> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has >> been reported. Those issues were related with exception being thrown with >> invalid arguments. We propose to remove the old core reflection >> implementatio

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

On Wed, 7 Jun 2023 18:55:10 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/Inhe

Re: RFR: 8285368: Overhaul doc-comment inheritance [v4]

> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still ca

Re: RFR: 8285368: Overhaul doc-comment inheritance [v3]

> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still ca

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v4]

On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request incrementally with four additional > commits since th

Re: RFR: 8308780: Fix the Java Integer types on Windows [v4]

On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Integrated: 8304425: ClassHierarchyResolver from Reflection

On Fri, 17 Mar 2023 18:18:48 GMT, Chen Liang wrote: > Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also us

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Integrated: 8306431: File.listRoots method description should be re-examined

On Wed, 19 Apr 2023 07:34:30 GMT, Nagata-Haruhito wrote: > I fixed File.listRoots description. > * remove "the insertion or ejection of removable media" > * change "available" to "existing" > > Please review this change. This pull request has now been integrated. Changeset: 9d64a9d2 Author:

Re: RFR: 8306431: File.listRoots method description should be re-examined [v10]

On Thu, 8 Jun 2023 04:00:31 GMT, Nagata-Haruhito wrote: >> I fixed File.listRoots description. >> * remove "the insertion or ejection of removable media" >> * change "available" to "existing" >> >> Please review this change. > > Nagata-Haruhito has updated the pull request with a new target base