Re: RFR: 8308803: Improve java/util/UUID/UUIDTest.java

2023-05-28 Thread Jaikiran Pai
On Wed, 24 May 2023 19:18:33 GMT, Aleksey Shipilev wrote: > UUID is very important class that is used to track identities of objects in > large scale systems. Yet, the coverage in JDK test is disappointing: it tests > only 100 of UUID instances per test, which is way too small to detect > coll

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-28 Thread David Holmes
On Sat, 27 May 2023 14:21:28 GMT, Alan Bateman wrote: > This looks okay. Have you checked the other usages of > ReleasePrimitiveArrayCritical (e.g. libzip) see if they need the copy back > when releasing? I can immediately see code in `Java_java_util_zip_Inflater_inflateBytesBytes` that needs

Withdrawn: 8301220: Return value of toArray() of Сollection types from java.base should be trusted

2023-05-28 Thread duke
On Thu, 26 Jan 2023 06:46:16 GMT, Glavo wrote: > I checked the `java.base` module, and all the `Collection#toArray()` method > of collections be implemented correctly. > > Their return values can be trusted, so many unnecessary array duplication can > be eliminated. This pull request has been

Re: RFR: 8307795: AArch64: Optimize VectorMask.truecount() on Neon [v4]

2023-05-28 Thread Chang Peng
> In Vector API Java level, vector mask is represented as a boolean array with > 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it > is loaded into vector register, e.g. Neon, the in-memory format will be > converted to in-register format with 0/-1 value for each lane (

Re: RFR: 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem

2023-05-28 Thread Andrey Turbanov
On Thu, 25 May 2023 12:24:59 GMT, Adam Sotona wrote: > Fix of jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo returning correct > zero power of two. > > Please review. > > Thanks, > Adam src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line 177: > 175: > 176: p

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-28 Thread Alan Bateman
On Sat, 27 May 2023 21:04:51 GMT, Joe Darcy wrote: > Straightforward doc refactoring to use snippets. src/java.base/share/classes/java/lang/Class.java line 426: > 424: * {@snippet lang="java" : > 425: * Class.forName("Foo", true, this.getClass().getClassLoader()) > 426: * } Not