Re: RFR: 8308286 Fix clang warnings in linux code

2023-05-27 Thread Kim Barrett
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote: > When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. All of the -Wformat-nonliteral changes make me wonder why we're seeing these with clang but not

Re: RFR: 8308286 Fix clang warnings in linux code

2023-05-27 Thread Kim Barrett
On Fri, 26 May 2023 07:48:06 GMT, Daniel JeliƄski wrote: > According to our docs, [clang is a supported compiler for > Linux](https://github.com/openjdk/jdk/blob/master/doc/building.md#native-compiler-toolchain-requirements). I think that's aspirational rather than actual. Clang has been inclu

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-27 Thread Chen Liang
On Sat, 27 May 2023 21:04:51 GMT, Joe Darcy wrote: > Straightforward doc refactoring to use snippets. src/java.base/share/classes/java/lang/Class.java line 356: > 354: * > 355: * {@snippet lang="java" : > 356: * Class t = Class.forName("java.lang.Thread") This should have a fi

RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-27 Thread Joe Darcy
Straightforward doc refactoring to use snippets. - Commit messages: - JDK-8308987: Update java.lang.Class to use javadoc snippets Changes: https://git.openjdk.org/jdk/pull/14194/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14194&range=00 Issue: https://bugs.openjdk.org/

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-27 Thread Kim Barrett
On Sat, 27 May 2023 11:50:11 GMT, Thomas Stuefe wrote: >>> This one is not just to get rid of a warning. We get real test errors >>> because malloc gets replaced by vec_malloc in log tags. >> >> That does not invalidate my argument, nor does it answer my question. Those >> test errors could be

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array [v2]

2023-05-27 Thread Alan Bateman
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote: >> This change prevents the contents of the internal string array from being >> copied back when releasing it. > > Rudi Horn has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one com

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-27 Thread Thomas Stuefe
On Sat, 27 May 2023 11:25:41 GMT, Thomas Stuefe wrote: >> This one is not just to get rid of a warning. We get real test errors >> because malloc gets replaced by vec_malloc in log tags. > >> This one is not just to get rid of a warning. We get real test errors >> because malloc gets replaced b

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-27 Thread Thomas Stuefe
On Fri, 26 May 2023 20:27:12 GMT, Martin Doerr wrote: > This one is not just to get rid of a warning. We get real test errors because > malloc gets replaced by vec_malloc in log tags. That does not invalidate my argument, nor does it answer my question. Those test errors could be also fixed by