Re: RFR: 8307547: Support variant collations [v4]

2023-05-13 Thread Alan Bateman
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote: >> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default >> collation for Swedish to the modern one. In order to provide a means for >> users who need the old collation, this PR intends to make `Collator` >> recognize th

Re: RFR: 8307547: Support variant collations [v4]

2023-05-13 Thread Alan Bateman
On Fri, 12 May 2023 16:41:20 GMT, Steven Loomis wrote: > > so is this considered a private use language tag > > Not private use at all. The `-u-` subtag is registered, and the links above > are from the registrar, see > > * https://www.rfc-editor.org/info/bcp47 > * https://www.rfc-editor.org/r

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Alan Bateman
On Sun, 14 May 2023 05:47:50 GMT, Tagir F. Valeev wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8308016: Remove ellipses ("...") from snippets > > src/java.base/share/classes/java/io/FilePermission.java line

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Alan Bateman
On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter wrote: >> Replace `{@code ...}` patterns and the like with `{@snippet >> lang=java : ...}`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8308016: Remove ellipses ("

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Tagir F . Valeev
On Fri, 12 May 2023 17:59:32 GMT, Lance Andersen wrote: >> I have been just trying to keep it as similar visually as possible but what >> you say is reasonable. > > Agree, that I would make the code valid when using a snippet There's a replacement tag for this. Some people use label, e.g. code

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Tagir F . Valeev
On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter wrote: >> Replace `{@code ...}` patterns and the like with `{@snippet >> lang=java : ...}`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8308016: Remove ellipses ("

Leap second handling in Windows timestamps

2023-05-13 Thread andreas
Hello, This is my first post to this mailing list. I've been exploring a problem concerning leap seconds that emerged with the Windows 10 October 2018 Update. The current implementation of InstantSource and other classes that interact with FILETIME structures seem to be affected. This problem e

Re: RFR: 8306457: Classfile API components implementations should not be exposed

2023-05-13 Thread Chen Liang
On Wed, 19 Apr 2023 16:58:32 GMT, Chen Liang wrote: > The jdk.internal.classfile.components package's interfaces have > implementations in their nested classes, which are implicitly public and > exported with the package. They are now moved to the impl package to avoid > unwanted exposures. Fi

Re: RFR: 8306457: Classfile API components implementations should not be exposed [v2]

2023-05-13 Thread Chen Liang
> The jdk.internal.classfile.components package's interfaces have > implementations in their nested classes, which are implicitly public and > exported with the package. They are now moved to the impl package to avoid > unwanted exposures. Fixed a few minor javadoc issues in the interfaces as >

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v2]

2023-05-13 Thread Chen Liang
> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`. > > A few implementation-detail methods in VarHandle are now documented with the > implied constraints to avoid subtle problems in the future. Changed > `IndirectVarHandle` to call `asDirect` lazily to accomodate the la