On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
This patch aims to correct handling of annotations on parameters with the help
of `MethodParameters` attribute, which will be always available once #9862 is
integrated.
It utilizes and expands upon the existing parameter matching logic present in
`Executable::getAllGenericParameterTypes`, and d
On Tue, 7 Mar 2023 05:57:34 GMT, Jaikiran Pai wrote:
>>> Finally, are you or someone in your team, in contact with the author(s) of
>>> the custom zlib implementation
>>> [iii-i/zlib@1132034](https://github.com/iii-i/zlib/commit/113203437eda67261848b14b6c80a33ff7e33d34)?
>>> Would you be able
> Please review this PR.
> With this minor change, the javazic compiler (Main.java) can produce the HTML
> files that display given time zone data correctly.
Yoshiki Sato has updated the pull request incrementally with one additional
commit since the last revision:
Insert null check for map
On Mon, 20 Mar 2023 15:21:57 GMT, Adam Sotona wrote:
>> Marked as reviewed by asotona (Committer).
>
>> @asotona So should I simply throw an `IllegalAccessError` when the Lookup
>> encounters a `IllegalAccessException`, or should I return null? I favor
>> throwing an `IllegalAccessError` as the
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Marked as reviewed by darcy (Reviewer).
-
PR Review: ht
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
src/java.base/share/classes/java/math/BigDecimal.java line 308:
> 30
On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual underly
> Please review changes to the IntlTest (test framework) class.
>
> These changes include
> - Logging the actual exception + stack trace. Previously, the test framework
> would throw `InvocationTargetException` but hide the actual underlying
> exception of the failing test unless the test class
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular, `o
Update PSL for JDK 21.
-
Commit messages:
- the upgrade
Changes: https://git.openjdk.org/jdk/pull/13662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13662&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8302182
Stats: 1479 lines in 5 files changed: 647 ins; 697 de
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular, `o
On Sat, 25 Mar 2023 05:52:44 GMT, Chen Liang wrote:
> In `AnnotatedTypeBaseImpl`, a `decl` field is declared, referring to the
> declaration that the AnnotatedType is from. However, this field is not used
> anywhere except passing to constructors of other implementations; it's not
> used in de
On Sat, 25 Mar 2023 05:52:44 GMT, Chen Liang wrote:
> In `AnnotatedTypeBaseImpl`, a `decl` field is declared, referring to the
> declaration that the AnnotatedType is from. However, this field is not used
> anywhere except passing to constructors of other implementations; it's not
> used in de
On Tue, 25 Apr 2023 22:08:09 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual underly
On Wed, 19 Apr 2023 13:37:15 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> ### Specdiff
>> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>>
>> ### Javadoc
>> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/la
On Sat, 25 Mar 2023 05:52:44 GMT, Chen Liang wrote:
> In `AnnotatedTypeBaseImpl`, a `decl` field is declared, referring to the
> declaration that the AnnotatedType is from. However, this field is not used
> anywhere except passing to constructors of other implementations; it's not
> used in de
On Wed, 19 Apr 2023 13:37:15 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> ### Specdiff
>> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>>
>> ### Javadoc
>> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/la
> Please review changes to the IntlTest (test framework) class.
>
> These changes include
> - Logging the actual exception + stack trace. Previously, the test framework
> would throw `InvocationTargetException` but hide the actual underlying
> exception of the failing test unless the test class
On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
It appears that -Xcomp causes the relative timing of the commands to be
disturbed enough to prevent the correct operation of the test. The test should
not be run with -Xcomp
-
Commit messages:
- 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails
Changes: https:/
On Wed, 19 Apr 2023 13:37:15 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> ### Specdiff
>> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>>
>> ### Javadoc
>> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/la
On Mon, 24 Apr 2023 15:58:41 GMT, Aleksey Shipilev wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addresed review comments of @turbanoff, @shipilev and @RogerRiggs
>
> test/jdk/java/io/ObjectInputStream/Negative
Please review changes to the IntlTest (test framework) class.
These changes include
- Logging the actual exception + stack trace. Previously, the test framework
would throw `InvocationTargetException` but hide the actual underlying
exception of the failing test unless the test class was ran wit
On Mon, 17 Apr 2023 19:48:10 GMT, Justin Lu wrote:
> Update the registry and accompanying tests with the **IANA 4/13/2022** update.
>
> This update introduces the case where an IANA entry can have a preferred
> value, but that preferred value has a preferred value as well.
>
> This causes unex
On Tue, 25 Apr 2023 01:44:14 GMT, Brian Burkhalter wrote:
> When appending a `CharBuffer`, perform a specific check for buffer overflow
> before invoking `put()`.
This pull request has now been integrated.
Changeset: e3ccaa65
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy wrote:
> Minor refactoring of FdLibm.java; will consider future refactorings with more
> substantive code changes in the future.
This pull request has now been integrated.
Changeset: d819deba
Author:Joe Darcy
URL:
https://git.openjdk.org/
On Tue, 25 Apr 2023 16:26:01 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added custom toString() methods
>
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 44:
>
>> 42:
On Mon, 24 Apr 2023 22:05:18 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 43:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Mon, 24 Apr 2023 20:56:03 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 30:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 19:04:10 GMT, Brian Burkhalter wrote:
>> When appending a `CharBuffer`, perform a specific check for buffer overflow
>> before invoking `put()`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 83066
On Mon, 24 Apr 2023 21:59:29 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 30:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
> When appending a `CharBuffer`, perform a specific check for buffer overflow
> before invoking `put()`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8306623: Add overlooked issue ID to @bug
-
Changes:
- all: h
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 16:50:10 GMT, Brian Burkhalter wrote:
>> When appending a `CharBuffer`, perform a specific check for buffer overflow
>> before invoking `put()`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 83066
On Tue, 25 Apr 2023 06:25:10 GMT, Alan Bateman wrote:
> [...] I think this regression was missed because this tests didn't check this
> case.
It definitely was.
-
PR Comment: https://git.openjdk.org/jdk/pull/13632#issuecomment-1522142226
On Tue, 18 Apr 2023 05:08:35 GMT, Yoshiki Sato wrote:
> Please review this PR.
> With this minor change, the javazic compiler (Main.java) can produce the HTML
> files that display given time zone data correctly.
I revisited the code, and now think that `mapList` better be `null`, as it
indic
On Tue, 25 Apr 2023 14:17:22 GMT, Roger Riggs wrote:
>> Create an internal Version record to hold and compare versions of the form
>> (major, minor, micro).
>> Add `OperatingSystem.version()` to return the version of the running OS.
>> Replace uses of os.version in java.base.
>> Subsequent PRs w
On Mon, 24 Apr 2023 23:47:05 GMT, Justin Lu wrote:
>> This PR fixes an intermittent failure (that only occurs on Windows) in
>> _DateFormatRegression.java_.
>>
>> With the integration of
>> [JDK-8304982](https://bugs.openjdk.org/browse/JDK-8304982),
>> _LocaleProviderAdapter.java_ now emits a
On Tue, 25 Apr 2023 08:11:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Mon, 24 Apr 2023 16:26:02 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy wrote:
> Minor refactoring of FdLibm.java; will consider future refactorings with more
> substantive code changes in the future.
LGTM2
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13604#pullrequest
> When appending a `CharBuffer`, perform a specific check for buffer overflow
> before invoking `put()`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8306623: Update comment; move test code location
-
Changes:
On Tue, 25 Apr 2023 06:27:12 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8306623: Update comment; move test code location
>
> src/java.base/share/classes/java/nio/X-Buffer.java.template li
On Mon, 24 Apr 2023 21:39:43 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 96 commits:
>
> - Merge branch 'master' into JDK-8266571-Sequen
On Mon, 24 Apr 2023 23:47:05 GMT, Justin Lu wrote:
>> This PR fixes an intermittent failure (that only occurs on Windows) in
>> _DateFormatRegression.java_.
>>
>> With the integration of
>> [JDK-8304982](https://bugs.openjdk.org/browse/JDK-8304982),
>> _LocaleProviderAdapter.java_ now emits a
On Tue, 18 Apr 2023 12:21:11 GMT, Quan Anh Mai wrote:
> Hi,
>
> Please review this patch which fixes the errors on machines where
> TypeMaxVector has a length of 64 bits. I take an extra cautious approach and
> fall back to putting elements one by one if the length is an unexpected value.
>
>
On Tue, 25 Apr 2023 04:05:05 GMT, Leonid Mesnik wrote:
>> test/lib/jdk/test/lib/process/ProcessTools.java line 792:
>>
>>> 790: @Override
>>> 791: public InputStream getInputStream() {
>>> 792: return out;
>>
>> This is a little bit confusing that the `getInputStream
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
This pull request has now been integrated.
Changeset: 17ce0976
Author:Stuart Marks
URL:
https://git.openjdk.org/jdk/commit/17ce0976e442d5fabb14daed40fa9a768989f02e
Stats: 7067 lin
On Mon, 24 Apr 2023 21:39:43 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 96 commits:
>
> - Merge branch 'master' into JDK-8266571-Sequen
> Create an internal Version record to hold and compare versions of the form
> (major, minor, micro).
> Add `OperatingSystem.version()` to return the version of the running OS.
> Replace uses of os.version in java.base.
> Subsequent PRs will apply to uses in other modules including, jdk.jlink,
>
> The `default` method `nextDouble(double origin, double bound)` in
> `java.util.random.RandomGenerator` aims at generating a uniformly and
> spatially equidistributed random `double` in the left-closed and right-open
> range [`origin`, `bound`). It does so by applying the affine transform
> `o
> The `default` method `nextDouble(double origin, double bound)` in
> `java.util.random.RandomGenerator` aims at generating a uniformly and
> spatially equidistributed random `double` in the left-closed and right-open
> range [`origin`, `bound`). It does so by applying the affine transform
> `o
On Tue, 25 Apr 2023 11:57:21 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> style
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 1914:
>
>> 1912: if (vector_klass->const_oop() == NULL |
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote:
>> `Vector::slice` is a method at the top-level class of the Vector API that
>> concatenates the 2 inputs into an intermediate composite and extracts a
>> window equal to the size of the inputs into the result. It is used in vector
>> conver
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> - qualified enum constants are supported for case label
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
> `nanos` to 1ms when doing the actual sleep. This means users can
On Tue, 25 Apr 2023 10:23:11 GMT, Maurizio Cimadamore
wrote:
>> test/langtools/tools/javac/patterns/Exhaustiveness.java line 1:
>>
>>> 1: /*
>>
>> Isn't `Isn't `testCoversType1` the same as `testExhaustiveStatement3` ?
>
> Some of the tests called `testExhaustiveStatement` do not seem to test
On Tue, 25 Apr 2023 10:22:40 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review changes.
>
> test/langtools/tools/javac/patterns/Exhaustiveness.java line 1:
>
>> 1: /*
>
> I
On Tue, 25 Apr 2023 10:33:33 GMT, Maurizio Cimadamore
wrote:
>> Some of the tests called `testExhaustiveStatement` do not seem to test
>> statements at all
>
> In the two `testXYZExhaustiveIntersection` the class hierarchy seems the same
> - can we reuse it across multiple test cases? I see so
On Mon, 24 Apr 2023 15:16:18 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Mon, 24 Apr 2023 15:16:18 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Thu, 20 Apr 2023 16:19:05 GMT, Stuart Marks wrote:
>>> I didn't know about the need to specify `@throws` in order to generate the
>>> throws-clauses in the docs.
>>
>> You need to explicitly inherit `@throws` only for exceptions that aren't
>> mentioned in the `throws` clause.
>>
>>> As a
On Thu, 20 Apr 2023 08:24:40 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java
>> line 86:
>>
>>> 84: }
>>> 85:
>>> 86: public void setMajorVersion(int majorVersion) {
>>
>> We should ensure the version is not changed once writing ha
On Mon, 27 Mar 2023 16:43:17 GMT, Adam Sotona wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes and this patch converts it to use Classfile API.
>>
>> Please review.
>>
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally wit
On Sat, 25 Mar 2023 05:52:44 GMT, Chen Liang wrote:
> In `AnnotatedTypeBaseImpl`, a `decl` field is declared, referring to the
> declaration that the AnnotatedType is from. However, this field is not used
> anywhere except passing to constructors of other implementations; it's not
> used in de
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 07:38:41 GMT, Adam Sotona wrote:
> Note that other `*Impl` classes in `java.lang.constant` perform validation in
> their constructors and provide custom `toString()` formatting and they also
> don’t use records.
BTW: for example `ClassDesc:of(String name)` performs repeated
On Mon, 24 Apr 2023 16:33:58 GMT, Chen Liang wrote:
> Note that other `*Impl` classes in `java.lang.constant` perform validation in
> their constructors and provide custom `toString()` formatting and they also
> don’t use records.
Performing validation in constructors I see as a blocker for po
76 matches
Mail list logo
