On Wed, 22 Mar 2023 14:02:53 GMT, Julian Waters wrote:
> A couple of spots wrongly refer to boolean and jboolean as the same thing.
> While this does still compile thanks to a happy accident and implicit
> conversions, they are not the same at all, and should be fixed before a
> future compile
On Tue, 28 Mar 2023 07:28:01 GMT, Alan Bateman wrote:
> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
> APIs that were preview APIs in Java 19/20 are changed to permanent and their
> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
> JNI
On Sat, 8 Apr 2023 13:26:36 GMT, Julian Waters wrote:
>> A couple of spots wrongly refer to boolean and jboolean as the same thing.
>> While this does still compile thanks to a happy accident and implicit
>> conversions, they are not the same at all, and should be fixed before a
>> future comp
On Wed, 5 Apr 2023 09:19:57 GMT, Viktor Klang wrote:
> Adds overrides for common Map operations to avoid having to allocate the
> entrySet for Collectors$Partition maps.
I don't think there is any useful relationship between this work at
SequencedCollections / SequencedMap. The return type of
On Mon, 10 Apr 2023 17:58:00 GMT, Chen Liang wrote:
> Please review a small patch, fixing extraneous right braces in field javadocs
> of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.
>
> JDK 20:
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/Const
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make app launcher run
> t
On Mon, 3 Apr 2023 21:56:33 GMT, Justin Lu wrote:
> This PR updates the Calendar.DAY_OF_WEEK documentation to make it clear that
> the field accepts _any_ value if the calendar is lenient and then normalizes
> it. Only if the calendar is non-lenient, will the field accept only one of
> SUNDAY
On Mon, 3 Apr 2023 21:56:31 GMT, Justin Lu wrote:
> The GregorianCalendar constructors and Calendar.getInstance() methods that
> take TimeZone or Locale throw a NullPointerException if any values are null.
>
> This PR updates the javadoc to make this apparent.
This pull request has now been i
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make app launcher run
> t
When `--main-jar` is specified and the name of the main class is picked from
the jar's manifest, set `app.jarfile` property in launcher cfg file instead of
`app.mainclass` and `app.classpath` properties to make app launcher run the app
from the jar and not as a class from the classpath.
---
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Keep it open
-
PR Comment: https://git.openjdk.org/jdk/
On Mon, 10 Apr 2023 17:58:00 GMT, Chen Liang wrote:
> Please review a small patch, fixing extraneous right braces in field javadocs
> of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.
>
> JDK 20:
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/Const
On Mon, 10 Apr 2023 18:24:08 GMT, Mandy Chung wrote:
> `s/ConstantBootstraps.staticVarHandle/ConstantBootstraps.staticFieldVarHandle`
This pull request has now been integrated.
Changeset: a43a17c8
Author:Mandy Chung
URL:
https://git.openjdk.org/jdk/commit/a43a17c8eaa68a7a48ff1b9bebd
On Mon, 10 Apr 2023 17:58:00 GMT, Chen Liang wrote:
> Please review a small patch, fixing extraneous right braces in field javadocs
> of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.
>
> JDK 20:
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/Const
On Sun, 12 Mar 2023 21:28:59 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javad
On Mon, 10 Apr 2023 15:16:59 GMT, Jatin Bhateja wrote:
>> Yes I think it is a drawback of this approach, however currently we do not
>> support shuffling for 256-bit vectors on AVX1 machines either, and AVX1
>> seems to be a special case in this regard. This species of float and double
>> may
On Mon, 10 Apr 2023 15:11:55 GMT, Jatin Bhateja wrote:
>> Thanks a lot for your review, I think that transforming a multiplication by
>> a power of 2 into a shift can be done by the C2 compiler. I have added the
>> special case for `start = 0 && step == 1` since it may be more common and
>> ca
On Mon, 10 Apr 2023 18:24:08 GMT, Mandy Chung wrote:
> `s/ConstantBootstraps.staticVarHandle/ConstantBootstraps.staticFieldVarHandle`
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13411#pullrequestreview-1377951955
On Mon, 10 Apr 2023 18:24:08 GMT, Mandy Chung wrote:
> `s/ConstantBootstraps.staticVarHandle/ConstantBootstraps.staticFieldVarHandle`
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13411#pullrequestreview-1377951177
`s/ConstantBootstraps.staticVarHandle/ConstantBootstraps.staticFieldVarHandle`
-
Commit messages:
- 8305808: Typo in javadoc of ConstantDescs::BSM_VARHANDLE_STATIC_FIELD
Changes: https://git.openjdk.org/jdk/pull/13411/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13411&ran
On Mon, 13 Mar 2023 19:24:38 GMT, Roger Riggs wrote:
>> Sergey Tsypanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commit
Please review a small patch, fixing extraneous right braces in field javadocs
of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.
JDK 20:
https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/ConstantDescs.html#BSM_EXPLICIT_CAST
JDK 21:
https://download.java.n
On Mon, 10 Apr 2023 17:05:28 GMT, jmehrens wrote:
>> src/java.base/share/classes/java/lang/String.java line 3466:
>>
>>> 3464: }
>>> 3465: int size = 0;
>>> 3466: for (CharSequence cs: elements) {
>>
>> I would think you have to locally store the result of
>> `elements.
On Fri, 7 Apr 2023 18:04:16 GMT, Quan Anh Mai wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java
>> line 96:
>>
>>> 94: }
>>> 95: Vector shufvec = this.toBitsVector();
>>> 96: VectorMask vecmask = shufvec.compare(VectorOperators.LT
On Mon, 10 Apr 2023 13:17:39 GMT, jmehrens wrote:
>> Tingjun Yuan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use spliterator().estimateSize()
>
> src/java.base/share/classes/java/lang/String.java line 3466:
>
>> 3464: }
>>
On Fri, 7 Apr 2023 18:24:42 GMT, Archie L. Cobbs wrote:
>> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>>
>> When `close()` is invoked on one of these classes, it in turn invokes
>> `close()` on the associated channel (if any). But when the associated
>> channel'
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote:
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets
On Fri, 7 Apr 2023 14:11:36 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello Giulietti
On Fri, 7 Apr 2023 17:12:08 GMT, Quan Anh Mai wrote:
>> Power of two step count may be replaced by logical right shifts. But special
>> handling may impact generic path
>> , currently c2 inline expander handles these special cases.
>>
>> Alternatively we can keep this implementation at its and
On Sat, 8 Apr 2023 10:33:48 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this MR which updates the jar man page to to indicate that
> --generate-index/-I are deprecated and may be removed in a future release
>
> Support for JAR Index is being removed via JDK-8302819.
This pull requ
> Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This
> can be reduced to O(1) improving the code like:
>
> DateTimeFormatter dtf = new DateTimeFormatterBuilder()
> .appendLiteral("Date:")
> .padNext(20, ' ')
> .append(DateTimeFormatter.ISO_DATE)
> .toFormatter();
On Mon, 10 Apr 2023 05:46:23 GMT, Tingjun Yuan wrote:
>> In the current implementation of `String.join(CharSequence, Iterable)`, the
>> temp array `elems` is always initialized with a length of 8. It will cause
>> many array recreations when the `Iterable` contains more than 8 elements.
>> Fur
On Mon, 10 Apr 2023 10:13:52 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review this MR which updates the jar man page to to indicate that
>> --generate-index/-I are deprecated and may be removed in a future release
>>
>> Support for JAR Index is being removed via JDK-8302819.
>
> Lanc
On Thu, 23 Mar 2023 12:05:50 GMT, Eirik Bjorsnos wrote:
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation
On Mon, 10 Apr 2023 10:09:04 GMT, Lance Andersen wrote:
> I think we are good to go.
Thanks, the PR is now ready to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1501666039
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
> Hi all,
>
> Please review this MR which updates the jar man page to to indicate that
> --generate-index/-I are deprecated and may be removed in a future release
>
> Support for JAR Index is being removed via JDK-8302819.
Lance Andersen has updated the pull request incrementally with one addi
On Mon, 10 Apr 2023 10:09:18 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review this MR which updates the jar man page to to indicate that
>> --generate-index/-I are deprecated and may be removed in a future release
>>
>> Support for JAR Index is being removed via JDK-8302819.
>
> Lanc
On Sat, 8 Apr 2023 15:53:17 GMT, Alan Bateman wrote:
> I assume you didn't mean to edit this.
Updated, thank you.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13400#discussion_r1161603585
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Fri, 7 Apr 2023 18:24:42 GMT, Archie L. Cobbs wrote:
>> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>>
>> When `close()` is invoked on one of these classes, it in turn invokes
>> `close()` on the associated channel (if any). But when the associated
>> channel'
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote:
> Please help review this PR which suggests we remove the class
> `java.lang.Compiler`. The class seems non-functional for a decade, and was
> terminally deprecated in Java 9. Time has come to let it go.
This pull request has now been int
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote:
> Please help review this PR which suggests we remove the class
> `java.lang.Compiler`. The class seems non-functional for a decade, and was
> terminally deprecated in Java 9. Time has come to let it go.
Marked as reviewed by jpai (Review
43 matches
Mail list logo
