On Fri, 31 Mar 2023 05:57:01 GMT, Julian Waters wrote:
>> A couple of spots wrongly refer to boolean and jboolean as the same thing.
>> While this does still compile thanks to a happy accident and implicit
>> conversions, they are not the same at all, and should be fixed before a
>> future com
C11 has been stable for a long time on all platforms, so native code can use
the standard alignas operator for alignment requirements
-
Commit messages:
-
- GSSLibStub.c
- ArrayReferenceImpl.c
- Alignment outside of HotSpot should be enforced by alignas instead of
compiler spec
On Fri, 24 Mar 2023 03:02:47 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Explicit conversion to jboolean
>
> src/java.prefs/macosx/native/libprefs/MacOSXPreferencesFile.m line 685:
>
>> 683:
> A couple of spots wrongly refer to boolean and jboolean as the same thing.
> While this does still compile thanks to a happy accident and implicit
> conversions, they are not the same at all, and should be fixed before a
> future compiler error happens if their declarations are touched
Julian
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Fri, 31 Mar 2023 02:28:31 GMT, Chen Liang wrote:
>> This typo doesn't allow creation of malformed ClassDesc or MethodTypeDesc,
>> but it produces an erroneous exception on certain inputs. Running
>> `java.lang.constant.MethodTypeDesc.ofDescriptor("(I[[[V)I")` in Jshell
>> 19.0.2 throws
On Fri, 31 Mar 2023 02:27:05 GMT, Chen Liang wrote:
>> This patch optimizes ClassDesc.resolveConstantDesc for array classes.
>> Otherwise, the performance of reference class resolution remain unchanged.
>>
>> A benchmark comparing resolution for reference arrays, primitive arrays, and
>> class
On Fri, 31 Mar 2023 02:22:55 GMT, Chen Liang wrote:
> The `isPrimitiveArray` check is converted to a private method in
> `ReferenceClassDesc` as it applies only to reference type descriptor strings.
> Also included the rationale for not checking initial `[` in a comment.
This would work.
On Fri, 31 Mar 2023 02:34:26 GMT, Chen Liang wrote:
>> Just to clarify: I'm looking for the kind of errors that don't get caught by
>> just generating the class, but are also more informative than the default
>> VerifyError you would get from loading an invalid class.
>
> Classfile API does hav
On Thu, 30 Mar 2023 14:30:17 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffic
On Fri, 31 Mar 2023 02:27:05 GMT, Chen Liang wrote:
>> This patch optimizes ClassDesc.resolveConstantDesc for array classes.
>> Otherwise, the performance of reference class resolution remain unchanged.
>>
>> A benchmark comparing resolution for reference arrays, primitive arrays, and
>> class
On Thu, 30 Mar 2023 22:09:24 GMT, Jorn Vernee wrote:
>> This seems to be caught without running the verifier as well:
>>
>>
>> Caused by: java.lang.IllegalStateException: Operand stack underflow at
>> bytecode offset 79 of method
>> invoke(SegmentAllocator,MemorySegment,MemorySegment)
>> ..
> This typo doesn't allow creation of malformed ClassDesc or MethodTypeDesc,
> but it produces an erroneous exception on certain inputs. Running
> `java.lang.constant.MethodTypeDesc.ofDescriptor("(I[[[V)I")` in Jshell
> 19.0.2 throws StringIndexOutOfBoundsException, and throws
> IllegalArgu
On Thu, 30 Mar 2023 20:06:02 GMT, Chen Liang wrote:
> This patch optimizes ClassDesc.resolveConstantDesc for array classes.
> Otherwise, the performance of reference class resolution remain unchanged.
>
> A benchmark comparing resolution for reference arrays, primitive arrays, and
> class or i
> This patch optimizes ClassDesc.resolveConstantDesc for array classes.
> Otherwise, the performance of reference class resolution remain unchanged.
>
> A benchmark comparing resolution for reference arrays, primitive arrays, and
> class or interfaces is included in this patch, and the result co
On Fri, 31 Mar 2023 00:02:59 GMT, Yoshiki Sato wrote:
>> Pleases review this PR.
>> The PR includes the following changes.
>> - tzdata 2023c
>> - Hack code to deal with Cairo's DST end, which is same as done in
>> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
>> a
On Thu, 30 Mar 2023 14:41:29 GMT, Quan Anh Mai wrote:
>> Yeah, I agree that saving a node have some benefits like what you said. My
>> concern is there are more and more methods added into `Matcher::` and each
>> platform has to do the different implementation. There is not too much
>> meaning
On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato wrote:
> Pleases review this PR.
> The PR includes the following changes.
> - tzdata 2023c
> - Hack code to deal with Cairo's DST end, which is same as done in
> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
> around
On Thu, 30 Mar 2023 23:13:51 GMT, Mandy Chung wrote:
>> This patch optimizes ClassDesc.resolveConstantDesc for array classes.
>> Otherwise, the performance of reference class resolution remain unchanged.
>> https://jmh.morethan.io/?gist=111095eecf7a735fe8c96e4b952b58c1 It also
>> includes a be
On Thu, 30 Mar 2023 14:30:17 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffic
On Thu, 30 Mar 2023 14:30:17 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffic
Pleases review this PR.
The PR includes the following changes.
- tzdata 2023c
- Hack code to deal with Cairo's DST end, which is same as done in
2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
around the the limitation of JSR 310 compiler, where the time 24:00 is
rec
On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato wrote:
> Pleases review this PR.
> The PR includes the following changes.
> - tzdata 2023c
> - Hack code to deal with Cairo's DST end, which is same as done in
> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
> around
On Thu, 30 Mar 2023 14:30:17 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffic
On Thu, 30 Mar 2023 14:30:17 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffic
On Tue, 21 Mar 2023 20:21:23 GMT, Chen Liang wrote:
>> This typo doesn't allow creation of malformed ClassDesc or MethodTypeDesc,
>> but it produces an erroneous exception on certain inputs. Running
>> `java.lang.constant.MethodTypeDesc.ofDescriptor("(I[[[V)I")` in Jshell
>> 19.0.2 throws
On Thu, 30 Mar 2023 21:33:16 GMT, Justin Lu wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Thu, 30 Mar 2023 20:06:02 GMT, Chen Liang wrote:
> This patch optimizes ClassDesc.resolveConstantDesc for array classes.
> Otherwise, the performance of reference class resolution remain unchanged.
> https://jmh.morethan.io/?gist=111095eecf7a735fe8c96e4b952b58c1 It also
> includes a benchma
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png";>
>
> After:
> src="https:/
On Wed, 29 Mar 2023 22:51:12 GMT, Justin Lu wrote:
> Small typo fix in Locale.lookupTag
>
> _tangs_ should be _tags_
This pull request has now been integrated.
Changeset: 5f7b4b8e
Author:Justin Lu
Committer: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/5f7b4b8e75fdf4a22c108a
On Thu, 30 Mar 2023 20:11:30 GMT, Jorn Vernee wrote:
>> Yes, for instance, the class generation doesn't check operand stack
>> underflow, that you can generate code with invalid pops. The classfile
>> verifier catches this:
>> https://github.com/openjdk/jdk/blob/83cf28f99639d80e62c4031c4c97524
On Wed, 29 Mar 2023 23:14:17 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with five additional
>> commits since the last revision:
>>
>> - Impl cleanup, add Saturday end day conditional
>> - Rename test, clarify test documentation
>> - Add type to static dec
> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
> `DAY_OF_WEEK` combo.
>
> For example, Rolling _Monday, 30 December 2019_ by 1 week produced _Monday,
> 31 December 2018_, which is incorrect. This is
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote:
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
> based on
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
> based on the ensuing discussion and suggestion, is now being handled
On Thu, 30 Mar 2023 19:42:33 GMT, Alan Bateman wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> based on
On Thu, 30 Mar 2023 20:01:57 GMT, Chen Liang wrote:
>> Does this provide additional verification over what is already done just by
>> generating the class?
>>
>> For instance, IIRC the ASM verifier could catch e.g. stack underflow, but
>> that seems to be caught already by the new implementati
This patch optimizes ClassDesc.resolveConstantDesc for array classes.
Otherwise, the performance of reference class resolution remain unchanged.
https://jmh.morethan.io/?gist=111095eecf7a735fe8c96e4b952b58c1 It also includes
a benchmark for MethodTypeDesc resolution, which currently does not yet
On Thu, 30 Mar 2023 19:50:47 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 216:
>>
>>> 214: if (PERFORM_VERIFICATION) {
>>> 215: boolean printResults = false; // only print in case of
>>> exception
>>> 216:
On Wed, 29 Mar 2023 21:43:38 GMT, Paul Sandoz wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix ThreadSleepEvent again
>
> src/java.base/share/classes/java/lang/Thread.java line 1546:
>
>> 1544: // b
On Thu, 30 Mar 2023 18:43:42 GMT, Chen Liang wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use existing MTD_void constant
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
> line 21
> Rewrite BindingSpecializer to use the new class file API.
>
> Note: There is a big try/catch/finally block generated in the `specialize`
> method that currently uses labels. I looked at replacing this with a call to
> `CodeBuilder::trying` but it would require threading the nested code builder
On Thu, 30 Mar 2023 15:29:43 GMT, Serguei Spitsyn wrote:
> This becomes obsolete:
> `src/hotspot/share/prims/jvmtiTagMap.cpp: // disabled if vritual threads are
> enabled with --enable-preview`
A left-over from JDK-8285739, thanks, we can remove that comment.
-
PR Comment: https:/
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote:
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
> based on
On Thu, 30 Mar 2023 17:11:44 GMT, Jorn Vernee wrote:
> Rewrite BindingSpecializer to use the new class file API.
>
> Note: There is a big try/catch/finally block generated in the `specialize`
> method that currently uses labels. I looked at replacing this with a call to
> `CodeBuilder::trying`
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined vi
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
Rewrite BindingSpecializer to use the new class file API.
Note: There is a big try/catch/finally block generated in the `specialize`
method that currently uses labels. I looked at replacing this with a call to
`CodeBuilder::trying` but it would require threading the nested code builders
through
On Thu, 30 Mar 2023 17:10:20 GMT, Mandy Chung wrote:
> yes, that's not used. It was a leftover from JDK-8204981 & JDK-8234596.
Thanks a lot for this clarificaton, Mandy.
https://bugs.openjdk.org/browse/JDK-8204981
https://bugs.openjdk.org/browse/JDK-8234596
-
PR Comment: https://g
Please review a change to add `@spec` tags (and remove some equivalent `@see`
tags) to the main "core-libs" packages in `java.base` module.
This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
based on the ensuing discussion and suggestion, is now being handled with a
se
On Thu, 30 Mar 2023 14:19:55 GMT, Eirik Bjorsnos wrote:
> Is this repurposing of warn.flag.is.deprecated considered ok?
yes, that's not used. It was a leftover from JDK-8204981 & JDK-8234596.
-
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1490647633
On Wed, 29 Mar 2023 21:26:24 GMT, Mandy Chung wrote:
> A simple fix to `Method::invoke` which wraps IAE with
> `InvocationTargetException` twice if it's thrown by a caller-sensitive method
> which has no adapter.
This pull request has now been integrated.
Changeset: 1d7bb1ff
Author:Mandy
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Thu, 23 Mar 2023 02:23:20 GMT, Xiaohong Gong wrote:
>> I think not emitting `VectorLoadShuffleNode` is more common so it is better
>> to emit them only when needed, as it will simplify the graph and may allow
>> better inspections of the indices in the future. Additionally, a do-nothing
>>
On Thu, 30 Mar 2023 14:05:36 GMT, Serguei Spitsyn wrote:
> Just wanted to check if we want to bump `@since` version of
> `OpaqueFrameException` from 19 to 21.
OpaqueFrameException was added as a permanent API in JDK 19 so it doesn't
change.
-
PR Comment: https://git.openjdk.org/j
On Thu, 23 Mar 2023 07:13:55 GMT, Xiaohong Gong wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - move implementations up
>> - Merge branch 'master' into shufflerefactor
>> - Merge branc
> Hi,
>
> This patch reimplements `VectorShuffle` implementations to be a vector of the
> bit type. Currently, VectorShuffle is stored as a byte array, and would be
> expanded upon usage. This poses several drawbacks:
>
> 1. Inefficient conversions between a shuffle and its corresponding vector
On Thu, 30 Mar 2023 13:40:09 GMT, Alan Bateman wrote:
> I think the warning should also communicate that the JAR index is also
> ignored, maybe something like this:
I added the following property to `jar.properties`:
warn.index.is.ignored=\
The JAR index (META-INF/INDEX.LIST) is ignor
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
>>
On Thu, 30 Mar 2023 11:16:14 GMT, Eirik Bjorsnos wrote:
> We seem to have wiggled a bit on this issue, but I'm ok with including it.
I think we've converged on `jar -i` work as before but print a warning. For the
purposes of the CSR and the release note then I think it would be better to
have
On Sun, 29 Jan 2023 15:37:28 GMT, Glavo wrote:
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of t
On Wed, 29 Mar 2023 21:18:02 GMT, Chen Liang wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> In the JEP:
>> A sequenced collection supports common
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally wit
On Thu, 30 Mar 2023 07:05:37 GMT, Alan Bateman wrote:
> For CSR and release note purposes it would be a bit easier if it was this PR,
> would that be okay?
We seem to have wiggled a bit on this issue, but I'm ok with including it.
I have implemented the -i warning using the existing warnings s
On Thu, 30 Mar 2023 07:00:47 GMT, Alan Bateman wrote:
>> Eirik Bjorsnos has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Thu, 30 Mar 2023 06:41:38 GMT, Stuart Marks wrote:
>> In the JEP:
>>> A sequenced collection supports common operations at either end, and it
>>> supports processing the elements from first to last and from last to first
>>> (i.e., forward and reverse).
>>
>>> The reverse-ordered view enabl
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
src/java
On Fri, 24 Mar 2023 21:39:09 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/LinkedHash
On Wed, 29 Mar 2023 08:13:06 GMT, Per Minborg wrote:
> Non-instantiable utility classes should be declared `final` and have a
> private constructors.
>
> See Effective Java, Third Edition, Joshua Bloch (for example, Item 19 or Item
> 22).
This pull request has now been integrated.
Changeset
On Fri, 24 Mar 2023 15:31:32 GMT, Severin Gehwolf wrote:
> Please review this change for symbol visibility of static library artefacts.
> This fixes an issue when
> OpenJDK is being used as a base for generating native images preventing the
> symbols from being
> exported and looked up from the
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote:
>> Please review this change for symbol visibility of static library artefacts.
>> This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the
>> symbols from being
>> exported and looked up fro
On Thu, 30 Mar 2023 01:15:33 GMT, Mandy Chung wrote:
>> A simple fix to `Method::invoke` which wraps IAE with
>> `InvocationTargetException` twice if it's thrown by a caller-sensitive
>> method which has no adapter.
>
> Mandy Chung has updated the pull request incrementally with one additional
On Wed, 29 Mar 2023 19:55:37 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
78 matches
Mail list logo
