Re: RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. [v2]

2023-02-26 Thread David Holmes
On Sat, 25 Feb 2023 00:19:33 GMT, Leonid Mesnik wrote: >> The solution proposed by Stefan K >> >> The startProcess() might wait forever for the expected line if the process >> exits (failed to start). It makes sense to just fail earlier in such cases. >> >> The fix also move >> 'output = new O

Re: RFR: 8143900: OptimizeStringConcat has an opaque dependency on Integer.sizeTable field [v3]

2023-02-26 Thread Yi Yang
> Hi, can I have a review for this patch? I noticed a strange field > Integer.sizeTable which is used by PhaseStringOpts, after digging into the > history, I think it could be replaced by an in-place array allocation and > initialization. Before it, we are fetching from Integer.sizeTable and get

Re: RFR: 8143900: OptimizeStringConcat has an opaque dependency on Integer.sizeTable field [v2]

2023-02-26 Thread Yi Yang
On Sat, 25 Feb 2023 01:34:40 GMT, Vladimir Kozlov wrote: > Testing results seem good. Except one strange failure I put in > [JDK-8143900](https://bugs.openjdk.org/browse/JDK-8143900) comment. You need > second review. This seems related to https://bugs.openjdk.org/browse/JDK-8296914 -

String encoding to ByteBuffer

2023-02-26 Thread Carl M
I'm looking into adding a fast path case for encoding Strings into ByteBuffers, and wanted to get feedback on a possible approach. My use case is taking mostly-ASCII, UTF-8 Strings and writing them to the disk/network. To do this today, there are two approaches which both have drawbacks: 1.

Avoiding module-boundaries when bootstrapping invokedyanmic/constantdynamic

2023-02-26 Thread Rafael Winterhalter
Over the recent years, I have leveraged especially invokedynamic when instrumenting code. For example, when adding some additional behavior to a method, a Java agent can add an invokedynamic instruction to the beginning or the end of it. Of course, the bootstrap method is also supplied by the agent

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-26 Thread Tagir F . Valeev
On Thu, 23 Feb 2023 17:39:10 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PR Cleanup src/java.ba

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-26 Thread Tagir F . Valeev
On Thu, 23 Feb 2023 16:17:00 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1839: >> >>> 1837: * @throws StringIndexOutOfBoundsException if the result >>> overflows the buffer >>> 1838: */ >>> 1839: public AbstractStringBuilder rep