Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-25 Thread Ichiroh Takiguchi
On Fri, 24 Feb 2023 17:19:22 GMT, Naoto Sato wrote: >> Hello @naotoj . >> Sorry for bothering you. >> >> I have following question: >> - Why GB18030.java.template is in >> src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the >> generated code is always stored into sun/nio/cs ?

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Joe Darcy
On Sat, 25 Feb 2023 18:06:46 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add one one unsigned shift comment. > > src/java.base/share/classes/java/lang/FdLibm.java line 639: > >> 637:

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v4]

2023-02-25 Thread Joe Darcy
> The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Joe Darcy has updated the pull request incrementally with on

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Joe Darcy
On Thu, 23 Feb 2023 23:30:46 GMT, Joe Darcy wrote: > I'll revert commenting out the intrinsic annotation before pushing. Turns out some VM updates are needed to preserve the intrinsic if this method declaration is changed; I'll be contacting the HotSpot team for assistance. - PR:

Re: RFR: 8302267: [jittester] Improve separation of test generation and execution [v2]

2023-02-25 Thread Andrey Turbanov
On Wed, 22 Feb 2023 17:43:23 GMT, Evgeny Nikitin wrote: >> Please review a set of improvements that should improve working with other >> fuzzing generators and usage of JitTesterDriver with tests generated not by >> the JITTester: >> >> - Provide better separation of individual test generation

Re: RFR: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider [v3]

2023-02-25 Thread Andrey Turbanov
On Sat, 25 Feb 2023 00:07:45 GMT, Madjosz wrote: >> Fixes JDK-8302983 (and duplicate JDK-8302898) > > Madjosz has refreshed the contents of this pull request, and previous commits > have been removed. The incremental views will show differences compared to > the previous content of the PR. The

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Andrey Turbanov
On Fri, 24 Feb 2023 18:40:38 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-25 Thread Archie L . Cobbs
On Sat, 25 Feb 2023 13:38:05 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Do some refactoring & cleanup suggested in reviews. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Ch

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

2023-02-25 Thread Archie L . Cobbs
On Sat, 25 Feb 2023 04:05:29 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo in one comment and clarify another. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.jav

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v6]

2023-02-25 Thread Archie L . Cobbs
> This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Spliterator.OfInt`, which declares these > two methods: > > void

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-25 Thread Vicente Romero
On Sat, 25 Feb 2023 03:57:30 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-25 Thread Vicente Romero
On Sat, 25 Feb 2023 03:57:30 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-25 Thread Martin Doerr
On Fri, 24 Feb 2023 10:42:06 GMT, Robbin Ehn wrote: > > > > ~I don't think we've done that much testing with UseSystemMemoryBarrier > > > > since it was added~. I'm a bit nervous about turning it on by default > > > > since it's currently also used for JNI. Let's see what Robbin thinks. > > >