Re: RFR: 8302214: Typo in javadoc of Arrays.compare and Arrays.mismatch

2023-02-12 Thread Jaikiran Pai
On Thu, 9 Feb 2023 10:13:03 GMT, Eirik Bjorsnos wrote: > The Javadocs of Arrays.compare and Arrays.mismatch uses the incorrect > capitalization `atoIndex` and `btoIndex` when referencing the corresponding > `aToIndex` and `bToIndex` parameters. > > Sample: > > > * specified ranges [{@code aF

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-12 Thread Xiaowei Lu
On Mon, 13 Feb 2023 03:54:07 GMT, Sergey Kuksenko wrote: > As for TPC-DS [AUTO-RESULT] QueryTotal=1968s vs [AUTO-RESULT] > QueryTotal=1934s that gives ~1.7% of performance difference. Are you sure > that this small diff is a real diff, but not run-to-run variance? These queries are separate an

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-12 Thread Louis Wasserman
Could you do that benchmark with e.g. JMH rather than taking the difference of System.currentTimeMillis? That would probably make it easier to read and trust the results. On Sun, Feb 12, 2023, 7:56 PM Sergey Kuksenko wrote: > On Fri, 10 Feb 2023 10:00:05 GMT, Xiaowei Lu wrote: > > > [JDK-82696

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-12 Thread Sergey Kuksenko
On Fri, 10 Feb 2023 10:00:05 GMT, Xiaowei Lu wrote: > [JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667) has uncovered the > poor performance of BigDecimal.divide under certain circumstance. > > We confront similar situations when benchmarking Spark3 on TPC-DS test kit. > According to

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-12 Thread Xiaowei Lu
On Sat, 11 Feb 2023 16:03:24 GMT, Sergey Kuksenko wrote: > "The performance looks good." - Could you support this statement with some > benchmark results? Thank you. Hi, here is a detailed result 1. I have run the benchmark in [JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667), which c

Re: RFR: JDK-8301444: Port fdlibm hyperbolic transcendental functions to Java [v9]

2023-02-12 Thread Joe Darcy
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to > refactor the regression tests a bit to reduce duplication, but the actual > ports should be ready for review. > > Diff'ing the ports as before, original vs transliteration port: > > > $ diff -w Hyperbolic.c Hyperbolic.tr

Re: RFR: JDK-8301444: Port fdlibm hyperbolic transcendental functions to Java [v8]

2023-02-12 Thread Joe Darcy
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to > refactor the regression tests a bit to reduce duplication, but the actual > ports should be ready for review. > > Diff'ing the ports as before, original vs transliteration port: > > > $ diff -w Hyperbolic.c Hyperbolic.tr

Re: RFR: 8301627: System.exit and Runtime.exit debug logging

2023-02-12 Thread Alan Bateman
On Fri, 10 Feb 2023 20:33:39 GMT, Roger Riggs wrote: > It can be difficult to find the cause of calls to > `java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java > runtime exits. > The status value and stack trace are logged using the System Logger named > `java.lang.Runti

Re: RFR: 8301627: System.exit and Runtime.exit debug logging

2023-02-12 Thread Alan Bateman
On Fri, 10 Feb 2023 20:33:39 GMT, Roger Riggs wrote: > It can be difficult to find the cause of calls to > `java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java > runtime exits. > The status value and stack trace are logged using the System Logger named > `java.lang.Runti

Integrated: JDK-8301833: Add wide-ranging tests for FDLIBM porting

2023-02-12 Thread Joe Darcy
On Mon, 6 Feb 2023 01:50:55 GMT, Joe Darcy wrote: > To help add assurances that the main-line port of FDLIBM to Java is working > correctly, added some long-running manual tests to probe that the > transliteration port and the corresponding StrictMath method are in agreement > on a large numbe

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-12 Thread Alan Bateman
On Fri, 10 Feb 2023 17:10:46 GMT, Brian Burkhalter wrote: > Another possibility would be to add a native method to the test itself to > invoke > [GetDiskSpaceInformationW](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskspaceinformationw) > to obtain the value of

Re: RFR: 8300819: -Dfile.encoding=Cp943C option does not work as expected since jdk18 [v2]

2023-02-12 Thread Alan Bateman
On Sun, 22 Jan 2023 23:17:10 GMT, Ichiroh Takiguchi wrote: >> On jdk17, following testcase works fine on Linux platform. >> >> Testcase >> >> $ cat cstest1.java >> import java.nio.charset.*; >> >> public class cstest1 { >> public static void main(String[] args) throws Exception { >> Cha

Re: RFR: JDK-8301833: Add wide-ranging tests for FDLIBM porting [v3]

2023-02-12 Thread Alan Bateman
On Sat, 11 Feb 2023 03:04:51 GMT, Joe Darcy wrote: >> To help add assurances that the main-line port of FDLIBM to Java is working >> correctly, added some long-running manual tests to probe that the >> transliteration port and the corresponding StrictMath method are in >> agreement on a large