Integrated: JDK-8301396: Port fdlibm expm1 to Java

2023-02-03 Thread Joe Darcy
On Thu, 2 Feb 2023 22:18:32 GMT, Joe Darcy wrote: > Next on the FDLIBM C -> Java port, expm1. > Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! > > For expm1, the C vs transliteration port show the usual kind of differences, > beside formatting of the constants, the use of the __HI

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-03 Thread Brian Burkhalter
On Fri, 3 Feb 2023 21:04:15 GMT, Joe Darcy wrote: >> Next on the FDLIBM C -> Java port, expm1. >> Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! >> >> For expm1, the C vs transliteration port show the usual kind of differences, >> beside formatting of the constants, the use of the

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-03 Thread Joe Darcy
On Fri, 3 Feb 2023 07:03:51 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback; use // comments > > src/java.base/share/classes/java/lang/FdLibm.java line 1147: > >> 1145:

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-03 Thread Joe Darcy
> Next on the FDLIBM C -> Java port, expm1. > Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! > > For expm1, the C vs transliteration port show the usual kind of differences, > beside formatting of the constants, the use of the __HI macro on the > left-hand side needs to be replaced

RFR: JDK-8301621: libzip should use pread instead of lseek+read

2023-02-03 Thread Justin King
Avoid using `lseek` + `read` in favor of `pread`. For Windows, we can do the same thing by using `OVERLAPPED`, as we are in synchronous mode we can use `Offset` and `OffsetHigh` to achieve the same thing. Additionally I updated open to use `O_CLOEXEC` when available, as that really should be us

Integrated: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

2023-02-03 Thread Bill Huang
On Tue, 31 Jan 2023 22:35:21 GMT, Bill Huang wrote: > Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. This pull request has now been integrated. Changeset: 20579e48

Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v5]

2023-02-03 Thread Rajan Halade
On Fri, 3 Feb 2023 00:41:29 GMT, Bill Huang wrote: >> Root.java is changed to a manual test because it requires test to be run >> with the root user privilege, and it requires to modify the user policy file >> in the home director. > > Bill Huang has updated the pull request incrementally with

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-03 Thread Maurizio Cimadamore
On Fri, 3 Feb 2023 17:46:32 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Classfile API moved under jdk.internal.classfile package > > src/java.base/share/classes/jdk/internal/classfile/C

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-03 Thread Maurizio Cimadamore
On Fri, 3 Feb 2023 14:31:24 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

JEP415: FilterInThread Example

2023-02-03 Thread Dr Heinz M. Kabutz
I was trying to get my head around the FilterInThread example in JEP 415 (https://openjdk.org/jeps/415) and the JavaDoc for the ObjectInputFilter (https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/ObjectInputFilter.html) For example, let's assume we have three filters. The fi

Re: RFR: 8293198: [vectorapi] Improve the implementation of VectorMask.indexInRange() [v2]

2023-02-03 Thread Quan Anh Mai
On Fri, 3 Feb 2023 07:13:10 GMT, Xiaohong Gong wrote: >> The Vector API `"indexInRange(int offset, int limit)"` is used >> to compute a vector mask whose lanes are set to true if the >> index of the lane is inside the range specified by the `"offset"` >> and `"limit"` arguments, otherwise the lan

Re: RFR: 8301737: java/rmi/server/UnicastRemoteObject/serialFilter/FilterUROTest.java fail with -Xcomp

2023-02-03 Thread Daniel Fuchs
On Fri, 3 Feb 2023 03:52:39 GMT, SUN Guoyun wrote: > Hi all, > When -Xcomp be used, java thread to block for longer, then causing this test > failed frequently on the AArch64 and LoongArch64 architecture. > > This PR fix the issue, Please help review it. > > Thanks. test/jdk/java/rmi/server/U

Re: RFR: 8301552: Use AtomicReferenceArray for caching instead of CHM in ZoneOffset [v6]

2023-02-03 Thread Roger Riggs
On Thu, 2 Feb 2023 15:44:54 GMT, Per Minborg wrote: >> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for >> values in the range [-18h, 18h] for each second that is on an even quarter >> of an hour (i.e. at most 2*18*4+1 = 145 values). >> >> Instead of using a `ConcurrentH

Re: RFR: 8294961: java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes [v2]

2023-02-03 Thread Adam Sotona
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes > and this patch converts it to use Classfile API. > > This pull request suppose to chain on the 8294982: Implementation of > Classfile API https://github.com/openjdk/jdk/pull/10982 > > Please review. > > Thank you

Re: RFR: 8301737: java/rmi/server/UnicastRemoteObject/serialFilter/FilterUROTest.java fail with -Xcomp

2023-02-03 Thread Roger Riggs
On Fri, 3 Feb 2023 03:52:39 GMT, SUN Guoyun wrote: > Hi all, > When -Xcomp be used, java thread to block for longer, then causing this test > failed frequently on the AArch64 and LoongArch64 architecture. > > This PR fix the issue, Please help review it. > > Thanks. What is the connection bet

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-02-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java

2023-02-03 Thread Raffaello Giulietti
On Thu, 2 Feb 2023 22:18:32 GMT, Joe Darcy wrote: > Next on the FDLIBM C -> Java port, expm1. > Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! > > For expm1, the C vs transliteration port show the usual kind of differences, > beside formatting of the constants, the use of the __HI

Withdrawn: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available

2023-02-03 Thread duke
On Thu, 14 Apr 2022 01:40:50 GMT, Brian Burkhalter wrote: > Modify native multi-byte read-write code used by the `java.io` classes to > limit the size of the allocated native buffer thereby decreasing off-heap > memory footprint and increasing throughput. This pull request has been closed with