On Mon, 30 Jan 2023 07:16:17 GMT, SUN Guoyun wrote:
> Hi all,
> I think `BackgroundCompilation` should not be set to false when `-Xcomp` be
> used, which causes the java thread to block for longer, then causing the
> following tests failed frequently on the AArch64 and LoongArch64 architecture.
On Tue, 31 Jan 2023 02:52:45 GMT, Joe Darcy wrote:
> Another day, another PR to port FDLBIM to Java, this time for the log1p
> method.
>
> Other than using the two-argument form of the __HI method in Java
> transliteration version rather than C macro, there are no appreciable
> differences be
Another day, another PR to port FDLBIM to Java, this time for the log1p method.
Other than using the two-argument form of the __HI method in Java
transliteration version rather than C macro, there are no appreciable
differences between the original C source in
src/java.base/share/native/libfdl
In this reply I'll focus on the null handling issues in collections.
As you've noted, there are really (at least) two distinct issues here: whether a
collection permits nulls, and the behavior of contains(null) queries. There have
been continual complaints about both, and the issues are somewha
On Mon, 30 Jan 2023 21:13:12 GMT, Daniel D. Daugherty
wrote:
>> Hi all,
>> I think `BackgroundCompilation` should not be set to false when `-Xcomp` be
>> used, which causes the java thread to block for longer, then causing the
>> following tests failed frequently on the AArch64 and LoongArch64
On Tue, 27 Dec 2022 20:12:51 GMT, Christian Wimmer wrote:
> The method `String.split` contains a fast-path when the regular expression
> parameter is not really a regular expression, but just a single split
> character.
> This fast path vs. slow path check can be constant folded when the regula
On Mon, 30 Jan 2023 18:06:12 GMT, Mandy Chung wrote:
> jdeps -profile option shows which compact profile of the types that a class
> depends on instead. By default jdeps shows the types and their modules that
> a class depend on. Compact profiles becomes legacy since Java SE 9 when
> modules
On Mon, 30 Jan 2023 07:16:17 GMT, SUN Guoyun wrote:
> Hi all,
> I think `BackgroundCompilation` should not be set to false when `-Xcomp` be
> used, which causes the java thread to block for longer, then causing the
> following tests failed frequently on the AArch64 and LoongArch64 architecture.
On Fri, 27 Jan 2023 06:52:31 GMT, Joe Darcy wrote:
> Restarting the port of FDLIBM to Java with the log10 method.
>
> There are two port, the first a near-transliteration from C port to use as a
> test reference in
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java
>
> and a more idiomatic
> Restarting the port of FDLIBM to Java with the log10 method.
>
> There are two port, the first a near-transliteration from C port to use as a
> test reference in
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java
>
> and a more idiomatic Java port in
>
> src/java.base/share/classes/java/
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Mon, 30 Jan 2023 19:48:50 GMT, Joe Darcy wrote:
>> The bug id was added there because I'm not sure there's a way to add the
>> @bug line to Basic-X.java.template`.
>
> I see; it might suffice in this case to rely on the bug information in the
> SCM history, but I don't have a strong opinion.
On Fri, 27 Jan 2023 17:53:40 GMT, Joe Darcy wrote:
>> Restarting the port of FDLIBM to Java with the log10 method.
>>
>> There are two port, the first a near-transliteration from C port to use as a
>> test reference in
>>
>> test/jdk/java/lang/StrictMath/FdlibmTranslit.java
>>
>> and a more i
On Mon, 30 Jan 2023 18:52:11 GMT, Raffaello Giulietti
wrote:
>> test/jdk/java/util/Formatter/Basic-X.java.template line 935:
>>
>>> 933:
>>> 934:
>>> //-
>>> 935: // %e - adoption of Double.toString(double) al
On Mon, 30 Jan 2023 11:06:05 GMT, Daniel Jeliński wrote:
> Please review this patch that reduces the socket timeout used in
> HandshakeTimeout test to its minimum value of 1 millisecond.
>
> This change makes the test complete 10 seconds faster; before this change it
> took 5 seconds for the h
On Mon, 30 Jan 2023 14:33:06 GMT, Raffaello Giulietti
wrote:
>> Align `double` and `float` decimal conversions in `java.util.Formatter` with
>> the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since
> Align `double` and `float` decimal conversions in `java.util.Formatter` with
> the algorithm used in `Double.toString(double)`.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8300869: Make use of the Double.toString(double)
Hi,
I just saw the pull request for 8217920 (Lookup.defineClass injects a class
that can access private members of any class in its own module.)
The PR details how you can generate a class in a package that has been opened
to you via a module declaration. This generated class can then create a ne
On Mon, 30 Jan 2023 18:47:31 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8300869: Make use of the Double.toString(double) algorithm in
>> java.util.Formatter
>
> test/jdk/java/util/Format
On Mon, 30 Jan 2023 14:33:06 GMT, Raffaello Giulietti
wrote:
>> Align `double` and `float` decimal conversions in `java.util.Formatter` with
>> the algorithm used in `Double.toString(double)`.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since
On Fri, 27 Jan 2023 18:22:11 GMT, Raffaello Giulietti
wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8300869: Make use of the Double.toString(double) algorithm in
>> java.util.Formatter
>>
>> Added t
On Mon, 30 Jan 2023 18:06:12 GMT, Mandy Chung wrote:
> jdeps -profile option shows which compact profile of the types that a class
> depends on instead. By default jdeps shows the types and their modules that
> a class depend on. Compact profiles becomes legacy since Java SE 9 when
> modules
jdeps -profile option shows which compact profile of the types that a class
depends on instead. By default jdeps shows the types and their modules that a
class depend on. Compact profiles becomes legacy since Java SE 9 when modules
are defined. The `-profile` option can be deprecated and rem
On Tue, 24 Jan 2023 21:13:30 GMT, Naoto Sato wrote:
> This issue was found during the review of this PR:
> https://github.com/openjdk/jdk/pull/12132 where `Charset` class was
> loaded/initialized at the phase 1 of the startup process. Since `Charset`
> depends on `StaticProperty`, loading of `
On Mon, 9 Jan 2023 09:22:25 GMT, Per Minborg wrote:
>> Currently, `java.io.Bits` is using explicit logic to read/write various
>> primitive types to/from byte arrays. Switching to the use of `VarHandle`
>> access would provide better performance and less code.
>>
>> Also, using a standard API
On Mon, 30 Jan 2023 14:08:49 GMT, Daniel Jeliński wrote:
>> test/jdk/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java line 59:
>>
>>> 57: public static void main(String[] args) throws Exception {
>>> 58:
>>> 59: System.setProperty("sun.rmi.transport.tcp.handshakeTimeout",
> Align `double` and `float` decimal conversions in `java.util.Formatter` with
> the algorithm used in `Double.toString(double)`.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8300869: Make use of the Double.toString(double)
On Mon, 30 Jan 2023 12:54:34 GMT, Vyom Tewari wrote:
> I can see that this test uses "TIMEOUT" down in test
Right, this is why I didn't remove the TIMEOUT constant
> i will suggest you to reduce the "TIMEOUT" constant instead of hard coding it
> to "1" second.
I can't; this would make the test
On Mon, 30 Jan 2023 11:06:05 GMT, Daniel Jeliński wrote:
> Please review this patch that reduces the socket timeout used in
> HandshakeTimeout test to its minimum value of 1 millisecond.
>
> This change makes the test complete 10 seconds faster; before this change it
> took 5 seconds for the h
On Sat, Jan 28, 2023 at 5:29 PM Lance Andersen
wrote:
> I also would prefer to see the test based off of an actual ZIP(or at least
> have the current/modified version of the test).
>
Consensus seems to be we leave the existing manual test alone. I've updated
the PR to leave the existing test as-
One of the meanings is debug.
Now it is even difficult to detect whether a list has these features
through assertions.
We want to see exceptions, but when we actually call unsupported methods,
the wrong object
may have been propagated to other methods or even threads, so that we can't
see the prob
Please review this patch that reduces the socket timeout used in
HandshakeTimeout test to its minimum value of 1 millisecond.
This change makes the test complete 10 seconds faster; before this change it
took 5 seconds for the handshake to timeout, and the test attempts 2 handshakes.
The change
On Mon, 30 Jan 2023 at 09:11, Glavo wrote:
> Now that we have the interface default method, can we add a new method to the
> Collection to obtain the support status of the feature, like this:
>
> public record CollectionFeature(String name) {
> public enum Status {
> SUPPORTED, UNSUPP
Thank you for your reply, which explains why there are so few interfaces in
the collection framework.
But I think it still doesn't answer my question: Why doesn't it provide a
means to judge the features supported by the collection?
Now that we have the interface default method, can we add a new m
On Mon, 30 Jan 2023 08:41:25 GMT, Per Minborg wrote:
> > java.time.ZoneOffset
>
> Maybe I am blind but can you provide a direct reference to an exising JDK
> method in `java.time` where we can apply similar optimizations?
No problem! We can start from `java.time.ZoneOffset` and its `parse` and
On Wed, 4 Jan 2023 13:16:26 GMT, Andriy Plokhotnyuk wrote:
> java.time.ZoneOffset
Maybe I am blind but can you provide a direct reference to an exising JDK
method in `java.time` where we can apply similar optimizations?
-
PR: https://git.openjdk.org/jdk/pull/11840
On Mon, 30 Jan 2023 08:24:27 GMT, Jaikiran Pai wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recove
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recove
On Fri, 27 Jan 2023 08:33:32 GMT, Matthias Baesken wrote:
> On our Linux ppc64le test machines we quite often see compilation timeouts in
> the test jdk/internal/vm/Continuation/Fuzz.java.
> (especially when running with fastdebug binaries)
> So it probably makes sense to use a higher compilatio
DeInflate.java test fails on s390x platform because size for out1 array which
is responsible for storing the compressed data is insufficient. And being
unable to write whole compressed data on array, on s390 whole data can't be
recovered after compression. So this fix increase Array size (for s3
41 matches
Mail list logo
