Integrated: 8299441: Fix typos in some test files under core-libs component

2023-01-02 Thread Jaikiran Pai
On Mon, 2 Jan 2023 09:52:59 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the final few typos in > test files in the core-libs area? This addresses the remaining core-libs > related typos from the original PR https://github.com/openjdk/jdk/pull/10029. This pul

Re: RFR: 8299441: Fix typos in some test files under core-libs component

2023-01-02 Thread Jaikiran Pai
On Mon, 2 Jan 2023 09:52:59 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the final few typos in > test files in the core-libs area? This addresses the remaining core-libs > related typos from the original PR https://github.com/openjdk/jdk/pull/10029. Thank yo

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v9]

2023-01-02 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods Oli

Re: RFR: JDK-8299336 - InputStream::DEFAULT_BUFFER_SIZE should be 16384

2023-01-02 Thread Markus KARG
On Mon, 2 Jan 2023 10:03:02 GMT, Peter Levart wrote: > Here, the benefit of increasing buffer from 8k to 16k gets from about 10% > (doing IO) up to 20% (reading from cache) increase in performance. I think 10% to 20% is good enough as an argument to go with 16k instead of 8k. - PR

Integrated: 8298590: Refactor LambdaForm constructors

2023-01-02 Thread Jorn Vernee
On Fri, 9 Dec 2022 18:02:53 GMT, Jorn Vernee wrote: > Refactor LambdaForm constructors into static factories. > > In the new code, there's only 1 constructor, which simply initializes all > fields. Multiple factory methods are built on top of this, which add various > argument validation/pre-p

Re: RFR: 8299441: Fix typos in some test files under core-libs component

2023-01-02 Thread Lance Andersen
On Mon, 2 Jan 2023 09:52:59 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the final few typos in > test files in the core-libs area? This addresses the remaining core-libs > related typos from the original PR https://github.com/openjdk/jdk/pull/10029. Marked a

Re: RFR: JDK-8299336 - InputStream::DEFAULT_BUFFER_SIZE should be 16384

2023-01-02 Thread Peter Levart
On Fri, 23 Dec 2022 22:28:34 GMT, Markus KARG wrote: > I/O had always been much slower than CPU and memory access, and thanks to > physical constraints, always will be. > While CPUs can get shrinked more and more, and can hold more and more memory > cache on or nearby a CPU core, the distance b

RFR: 8299441: Fix typos in some test files under core-libs component

2023-01-02 Thread Jaikiran Pai
Can I please get a review of this change which fixes the final few typos in test files in the core-libs area? This addresses the remaining core-libs related typos from the original PR https://github.com/openjdk/jdk/pull/10029. - Commit messages: - 8299441: Fix typos in some test fi