On Wed, 21 Dec 2022 20:54:25 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8299194: CustomTzIDCheckDST.java may fail at future date
>
> Thanks for the fix. Looks good overall. A couple of min
> test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date.
> I used following standalone testcase
>
> import java.util.Calendar;
> import java.util.Date;
> import java.util.SimpleTimeZone;
>
> public class CheckDST {
> private static String CUSTOM_TZ = "MEZ-1MESZ,M3.5.0,M1
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>> java/s
On Wed, 21 Dec 2022 21:37:27 GMT, Bill Huang wrote:
>> I have not seen this used in any other tests. It is a good learning, I
>> didn't knew that multiple tests in single file are run in parallel. It seems
>> like good option. Do you know of any other regression test written this way?
>
> I did
On Wed, 21 Dec 2022 20:03:38 GMT, Alexey Ivanov wrote:
>> @jaikiran Thank you for the details. I'll check if the duration of run
>> differed drastically. I thought all the client tests run in non-concurrent
>> mode by default or does this differ for headful and headless test?
>
> *Headful* test
On Wed, 21 Dec 2022 20:39:03 GMT, Rajan Halade wrote:
>> Multiple "run" in a single test fails the whole test when one test run fails
>> and all subsequent test run get terminated. Multiple tests with only one
>> "run" each allows all test run to be excused, and they can be run in
>> parallel.
On Wed, 21 Dec 2022 15:57:29 GMT, Ichiroh Takiguchi
wrote:
> test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date.
> I used following standalone testcase
>
> import java.util.Calendar;
> import java.util.Date;
> import java.util.SimpleTimeZone;
>
> public class CheckDST
On Wed, 21 Dec 2022 19:58:18 GMT, Bill Huang wrote:
>> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33:
>>
>>> 31:
>>> 32: /*
>>> 33: * @test
>>
>> Why are these tags duplicated here?
>
> Multiple "run" in a single test fails the whole test when one test run fails
> and all
On Tue, 20 Dec 2022 23:25:30 GMT, Harshitha Onkar wrote:
> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added
> robot.setAutoWaitForIdle() to ViewportOverlapping and its base class
> (OverlappingTestBase) to stabilize the test.
>
> Additionally added awt & swings tes
On Wed, 21 Dec 2022 18:51:32 GMT, Rajan Halade wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33:
>
>> 31:
>> 32: /*
>
On Wed, 21 Dec 2022 17:25:20 GMT, Harshitha Onkar wrote:
>> test/jdk/TEST.ROOT line 36:
>>
>>> 34: com/sun/net/httpserver/simpleserver \
>>> 35: java/awt \
>>> 36: javax/swing
>>
>> Hello Harshitha, I don't have any knowledge of the client area, but I see
>> that there are a large number of te
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote:
>> Are you saying that we don't need to run the ExtDir2.policy and
>> ExtDir3.policy?
>
> Its fine, ignore my previous comment.
you can add multiple run tags under same test tag, no need to repeat tag, bug,
and summary tags.
---
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>> java/s
On Wed, 21 Dec 2022 17:29:23 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote:
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
This pull request has now been integrated.
Chang
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revisi
On Wed, 21 Dec 2022 11:18:25 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced assert with requireNonNull
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 60:
>
>>
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
On Wed, 21 Dec 2022 01:12:12 GMT, Jaikiran Pai wrote:
>> ViewportOverlapping was failing intermittently on Windows (Win10 & 11).
>> Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class
>> (OverlappingTestBase) to stabilize the test.
>>
>> Additionally added awt & swings t
On Wed, 21 Dec 2022 01:02:35 GMT, Sandhya Viswanathan
wrote:
>> Claes Redestad has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 64 commits:
>>
>> - Pass the constant mode node through, removing need for all but one
>> instruct d
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date.
I used following standalone testcase
import java.util.Calendar;
import java.util.Date;
import java.util.SimpleTimeZone;
public class CheckDST {
private static String CUSTOM_TZ = "MEZ-1MESZ,M3.5.0,M10.5.0";
public
On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to
>> take the same types of arguments as jmod, thus bringing the two into
>> alignment. This likely requires a CSR and a discussion on whether we should
>> deprecate
On Wed, 21 Dec 2022 02:30:21 GMT, Naoto Sato wrote:
>> Moving the built-in implementation of `Console` from `java.io` package into
>> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
>> accessed through `ProxyingConsole`.
>
> Naoto Sato has updated the pull request inc
24 matches
Mail list logo
