Can I please get a review for this doc only change which fixes the javadoc of
java.util.zip.Inflater class? As noted in
https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
This commit fixes that.
-
Commit messages:
- 8297129: Inflater documentation refers t
Update the spec of Class.getModifiers to match long-standing behavior for
primitive and array classes. Remove unneeded implementation flexibility with
regard to setting other bit positions. This work was prompted to better support
anticipated future Valhalla changes.
Please also review the CSR:
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote:
> Please review an update for the troff man pages, following the recent update
> to upgrade to use pandoc 2.19.2
> (See https://bugs.openjdk.org/browse/JDK-8297165)
>
> In conjunction with this, one javadoc test also needs to be updated,
On Thu, 17 Nov 2022 20:15:55 GMT, Marcono1234 wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review suggestion - simplify test
>
> src/java.base/share/classes/java/util/Collections.java line 1718:
>
>> 1716:
On Wed, 16 Nov 2022 20:33:50 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
Please review an update for the troff man pages, following the recent update to
upgrade to use pandoc 2.19.2
(See https://bugs.openjdk.org/browse/JDK-8297165)
In conjunction with this, one javadoc test also needs to be updated, to work
with the new form of output generated by the new version of
On Thu, 17 Nov 2022 20:36:01 GMT, Brian Burkhalter wrote:
> Is a CSR needed here?
I will check, though the thought is that these are non-normative clarifications
to the normative changes made by
[8290036](https://bugs.openjdk.org/browse/JDK-8290036).
-
PR: https://git.openjdk.org
Similar to an update recently done for langtools tests, update the libraries
regression tests to take advantage of the @enablePreview jtreg feature.
-
Commit messages:
- JDK-8297215: Update libs tests to use @enablePreview
Changes: https://git.openjdk.org/jdk/pull/11222/files
Webr
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>> do
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>> do
On Wed, 16 Nov 2022 16:55:24 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Javadoc changes.
> - ProblemList.txt cleanup
src/java.base/share/classes/java/lang/Thread.
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do not complete normally or abruptly; no finally clause of any me
On Thu, 17 Nov 2022 20:08:27 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 95:
>>
>>> 93: * threads' current methods do not complete normally or abruptly.
>>> 94: * {@linkplain Thread.UncaughtExceptionHandler Uncaught exception
>>> handlers} are not run
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292317?
>>
>> The `java.util.Iterator` has a `forEachRemaining(Consumer
>> action)` method. As per its contract, the implementations a
On Thu, 17 Nov 2022 19:25:42 GMT, Brent Christian wrote:
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do not
On Thu, 17 Nov 2022 19:39:09 GMT, Brian Burkhalter wrote:
> `try-with-resource` or `try-with-resources`?
Agree should be
[try-with-resources](https://docs.oracle.com/javase/8/docs/technotes/guides/language/try-with-resources.html)
-
PR: https://git.openjdk.org/jdk/pull/11218
On Thu, 17 Nov 2022 19:25:42 GMT, Brent Christian wrote:
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do not
[JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
shutdown sequence, noting that calling Runtime.halt() skips the shutdown
sequence and immediately terminates the VM. Thus, "threads' current methods do
not complete normally or abruptly; no finally clause of any method is
On Thu, 17 Nov 2022 16:53:13 GMT, Paul Sandoz wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Javadoc changes.
>> - ProblemList.txt cleanup
>
> src/hotspot/share/utilities/exceptions.cpp line 166:
>
>> 164:
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Tue, 15 Nov 2022 21:47:40 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringProcessor.java line 31:
>
>> 29:
>> 30: /*
On Wed, 16 Nov 2022 21:43:32 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Requested changes #8
>> - Update StringTemplate javadoc
>
> src/java.base/share/classes/java/lang/template/Str
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote:
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't
> exist
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/9989
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 11 commits:
>
> - Me
On Wed, 16 Nov 2022 21:19:21 GMT, Tagir F. Valeev wrote:
>> src/java.base/share/classes/java/lang/template/StringTemplateImplFactory.java
>> line 202:
>>
>>> 200: @SuppressWarnings({"unchecked", "varargs"})
>>> 201: private static List toList(E... elements) {
>>> 202: return Co
On Wed, 16 Nov 2022 19:07:48 GMT, Naoto Sato wrote:
> Adding a `@sealedGraph` tag to `ZoneId` class.
This pull request has now been integrated.
Changeset: 8b140e2d
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/8b140e2d747676f6c5f53ccb18cee307e7d3da1c
Stats: 1 line in
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
This pull request has now been int
On Wed, 16 Nov 2022 16:55:24 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Javadoc changes.
> - ProblemList.txt cleanup
src/hotspot/share/utilities/exceptions.cpp li
On Wed, 16 Nov 2022 20:22:54 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplateImplFactory.java
> line 187:
>
>>
On Tue, 15 Nov 2022 18:47:39 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 22:23:27 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1826:
>
>> 1824:
>> 1825:
On Tue, 15 Nov 2022 22:15:45 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplateImpl.java line
> 35:
>
>> 33:
>>
On Tue, 15 Nov 2022 22:10:14 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 273:
>
>> 271:
>> 272:
On Tue, 15 Nov 2022 22:05:47 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 249:
>
>> 247:
>> 248:
On Tue, 15 Nov 2022 21:56:36 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 38:
>
>> 36:
>> 37: /**
On Tue, 15 Nov 2022 22:02:53 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 189:
>
>> 187:
>> 188:
On Tue, 15 Nov 2022 21:31:57 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/Carriers.java line 628:
>
>> 626: * types.
>
On Tue, 15 Nov 2022 22:12:05 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 291:
>
>> 289:
>> 290:
On Tue, 15 Nov 2022 20:37:25 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/runtime/TemplateRuntime.java line 116:
>
>> 114: */
>
On Tue, 15 Nov 2022 20:34:30 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/runtime/TemplateRuntime.java line 58:
>
>> 56: * optimize
On Wed, 16 Nov 2022 19:04:04 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
> line 1487:
>
>> 148
On Tue, 15 Nov 2022 20:12:16 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/jdk/internal/util/FormatConcatItem.java line 51:
>
>> 49: *
>>
On Tue, 15 Nov 2022 19:40:35 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/util/FormatProcessor.java line 102:
>
>> 100: * s
I corrected before inserting.
On Nov 16, 2022, at 7:41 PM, John Rose
mailto:john.r.r...@oracle.com>> wrote:
On 16 Nov 2022, at 11:10, Alex Buckley wrote:
…
For example, the following code contains a template expression that uses the
template processor `RAW`, which simply yields the `StringTem
Updating.
> On Nov 16, 2022, at 5:41 PM, Alex Buckley wrote:
>
> The first line says StringTemplates, should say StringTemplate.
>
> The paragraph about the `process(ValidatingProcessor)` method is confusing --
> it's not an alternative to using template expressions if the example needs to
>
On Tue, 8 Nov 2022 11:35:17 GMT, Raffaello Giulietti
wrote:
> A small spec change to match established behavior.
This pull request has now been integrated.
Changeset: 35acb891
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/35acb891660fd5e0fee48b56acb16a6a193417e
On Tue, 8 Nov 2022 00:58:44 GMT, Coleen Phillimore wrote:
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
This pull request has now been integrated.
Changeset: d8c
On Tue, 15 Nov 2022 18:52:37 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incr
On Wed, 9 Nov 2022 14:22:02 GMT, Raffaello Giulietti
wrote:
>> A small spec change to match established behavior.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8296292: Document the default behavior of '$' in regu
On Wed, 9 Nov 2022 14:22:02 GMT, Raffaello Giulietti
wrote:
>> A small spec change to match established behavior.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8296292: Document the default behavior of '$' in regu
On Wed, 16 Nov 2022 16:55:24 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Javadoc changes.
> - ProblemList.txt cleanup
src/jdk.incubator.concurrent/share/classes/jd
On Wed, 16 Nov 2022 16:41:18 GMT, Joe Darcy wrote:
> Helpful improvement.
>
> Are the type names in the diagram links?
The diagram is an SVG image rendered via the DOT description language. I think,
in theory, it would be possible to add links. I did some experiments with this
but decided we
On Fri, 4 Nov 2022 14:13:42 GMT, Alan Bateman wrote:
> java/util/concurrent/forkjoin/AsyncShutdownNow.java takes ~40s as each test
> uses a delay of 5s before it invokes shutdownNow. The test will run in <1s if
> changed to poll the thread state and invoke shutdownNow when the thread waits.
>
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292317?
>>
>> The `java.util.Iterator` has a `forEachRemaining(Consumer
>> action)` method. As per its contract, the implementations a
On 17/11/22 1:36 pm, Alan Bateman wrote:
On Thu, 17 Nov 2022 07:41:09 GMT, Jaikiran Pai wrote:
I think if we want to improve this error message then maybe attempt the
solution proposed by Alan in the JBS issue:
Extend jdk.includeInExceptions to include "file", meaning opt-in in secure
de
On Thu, 17 Nov 2022 07:41:09 GMT, Jaikiran Pai wrote:
> I think if we want to improve this error message then maybe attempt the
> solution proposed by Alan in the JBS issue:
>
> > Extend jdk.includeInExceptions to include "file", meaning opt-in in secure
> > deployments to include the tmp dire
56 matches
Mail list logo
