There's https://bugs.openjdk.org/browse/JDK-8225763. I plan to revive
that effort some time soon, it's been on my todo list for the past few
months.
-Jaikiran
On 16/11/22 4:48 am, some-java-user-99206970363698485...@vodafonemail.de
wrote:
Hello,
java.util.zip.Inflater and java.util.zip.Defla
On Tue, 15 Nov 2022 18:52:37 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incr
On Tue, 15 Nov 2022 02:14:46 GMT, Jorn Vernee wrote:
>> Bo Zhang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit si
> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329),
> previously, the jar validator compare the "version" to validate a
> multi-release jar. The "version" is a mix of the major and minor version
> fused into a single int, which might be a negative number with
> `--enab
Hello,
java.util.zip.Inflater and java.util.zip.Deflater both have an `end()` method
to release native memory. However, both classes
do not implement Closeable. This might prevent IDEs and other tooling from
indicating that users should release the
resources, and prevents usage in try-with-resour
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote:
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
I just wonder if this change warrants a CSR. If it is merely printing out a
warning, it may not require
On Tue, 15 Nov 2022 20:26:37 GMT, Alan Bateman wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
>> line 613:
>>
>>> 611: * @return the value of the scoped value if bound, otherwise
>>> {@code other}
>>> 612: */
>>> 613: public T orEls
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Although there aren't actual code
Problem: IANA Language subtag registry is outdated
Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
-
Commit messages:
- Update date for IANA test
- Merge branch 'master' into 8
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote:
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
src/java.base/share/classes/java/lang/System.java line 2247:
> 2245:
> Unsafe.getUnsafe().ensu
On Tue, 15 Nov 2022 19:19:57 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/Scoped
On Mon, 14 Nov 2022 17:51:24 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
print warning message for java.io.tmpdir when it is set through the command
line and the value is not good for creating file folder.
-
Commit messages:
- remove extra line
- warning message for java.io.tmpdir
Changes: https://git.openjdk.org/jdk/pull/11174/files
Webrev: https://w
On Tue, 15 Nov 2022 18:28:56 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/Scoped
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Tue, 15 Nov 2022 17:36:16 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix failing serviceability tests
src/jdk.incubator.concurrent/share/classes/jdk/incubator/con
On Wed, 9 Nov 2022 09:19:33 GMT, Serguei Spitsyn wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Forgot a null check.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 564:
>
>> 562:
>> 563: for (int i=0;
On Wed, 9 Nov 2022 11:54:55 GMT, Serguei Spitsyn wrote:
>> I don't think this has changed. Right now, if there are no child subgroups
>> then *group_count_ptr will be 0 and *groups_ptr will be NULL as there is no
>> memory to deallocate. JVMTI Deallocate is specified to do nothing when
>> call
On Tue, 8 Nov 2022 23:35:47 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Forgot a null check.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 540:
>
>> 538:
>> 539: jthread *
>> 540: J
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
R
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Mon, 14 Nov 2022 09:37:05 GMT, Jaikiran Pai wrote:
> Should we file a JBS to re-enable this so that we don't forget?
I'll add a note to JDK-8286352 or JDK-8288899, depending on which one is used.
-
PR: https://git.openjdk.org/jdk/pull/10986
On Tue, 15 Nov 2022 17:36:16 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix failing serviceability tests
test/jdk/ProblemList.txt line 804:
> 802:
> 803: # Loom, f
On Tue, 15 Nov 2022 18:09:21 GMT, Jorn Vernee wrote:
>> Err, looks like this works for MSVC, but with GCC I hit a snag eventually
>> (it also require putting `constexpr` on a lot of the `Register`/`VMReg` API).
>>
>> This error occurs:
>>
>>
>> * For target hotspot_variant-server_libjvm_objs_
On Tue, 15 Nov 2022 18:07:18 GMT, Jorn Vernee wrote:
>> Tried this before when `Register` wasn't as `constexpr` friendly due to the
>> reinterpret casts. Seems to work now though (thanks! :)) I'll change all
>> these to `constexpr`.
>
> Err, looks like this works for MSVC, but with GCC I hit a
On Tue, 15 Nov 2022 17:13:58 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/aarch64/vmstorage_aarch64.inline.hpp line 68:
>>
>>> 66: }
>>> 67:
>>> 68: inline VMStorage as_VMStorage(Register reg) {
>>
>> Mark as `constexpr` maybe?
>
> Tried this before when `Register` wasn't as `constexpr` friendly
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Tue, 15 Nov 2022 00:33:35 GMT, Vladimir Ivanov wrote:
> * `VMStorage` looks very similar to `VMReg`. What's the purpose of the
> new representation?
`VMReg` encodes stack offsets in slots (of 32 bits), which is not enough to
represent every call shape on macosx-aarch64. Byte offsets are
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing serviceability tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing serviceability tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/
On Tue, 8 Nov 2022 20:05:09 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Tweak copyright headers
>> - Use @requires to disable some tests on x86
>> - Use AssertionError for internal exc
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/442a04ef.
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description f
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/4bd44d66.
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Tue, 15 Nov 2022 15:22:07 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/Arena.java line 89:
>>
>>> 87:
>>> 88: /**
>>> 89: * Returns a native memory segment with the given size (in bytes)
>>> and alignment constraint (in bytes).
>>
>> It is note
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Tue, 15 Nov 2022 15:31:58 GMT, Per Minborg wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add `since` tag in Module/ModuleLayer preview methods
>
> src/java.base/share/classes/java/lang/foreign/MemorySeg
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 15:09:02 GMT, Per Minborg wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add `since` tag in Module/ModuleLayer preview methods
>
> src/java.base/share/classes/java/lang/foreign/Arena.jav
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 14:15:26 GMT, Andrew Haley wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 318:
>>
>>> 316: }
>>> 317: }
>>> 318: @Hidden
>>
>> Can we rename this to runWith(Runnable, Object) in both Thread and
>> VirtualThread to keep the naming con
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Update test
- Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/1095
On Tue, 15 Nov 2022 14:49:30 GMT, Per Minborg wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add `since` tag in Module/ModuleLayer preview methods
>
> src/java.base/share/classes/java/lang/foreign/Arena.jav
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
line 475:
> 473: // ??? Do we want to search cache for this? In most cases we
> don't expect
> 474: // this {@lin
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/java.base/share/classes/java/lang/Thread.java line 1610:
> 1608: ensureMaterializedForStackWalk(bindings);
> 1609: task.run();
> 1610: Reference.reachabilityFence(bindings);
T
On Mon, 14 Nov 2022 17:34:31 GMT, Alan Bateman wrote:
>> JEP 429 implementation.
>
> src/java.base/share/classes/java/lang/VirtualThread.java line 318:
>
>> 316: }
>> 317: }
>> 318: @Hidden
>
> Can we rename this to runWith(Runnable, Object) in both Thread and
> VirtualThread t
On Fri, 4 Nov 2022 09:53:39 GMT, Andrew Haley wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 1610:
>>
>>> 1608: ensureMaterializedForStackWalk(bindings);
>>> 1609: task.run();
>>> 1610: Reference.reachabilityFence(bindings);
>>
>> This shoul
On Thu, 3 Nov 2022 11:50:17 GMT, ExE Boss wrote:
>> JEP 429 implementation.
>
> src/java.base/share/classes/java/lang/Thread.java line 1610:
>
>> 1608: ensureMaterializedForStackWalk(bindings);
>> 1609: task.run();
>> 1610: Reference.reachabilityFence(bindings
On Thu, 10 Nov 2022 17:42:38 GMT, Andrew Haley wrote:
>> src/hotspot/share/prims/jvm.cpp line 1410:
>>
>>> 1408: loc = 3;
>>> 1409: } else if (method == resolver.thread_run_method) {
>>> 1410: loc = 2;
>>
>> This depends on how javac numbers locals, right? It seems a bit fragil
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/hotspot/share/prims/jvm.cpp line 4072:
> 4070: */
> 4071: JVM_ENTRY(void, JVM_EnsureMaterializedForStackWalk_func(JNIEnv* env,
> jobject vthread, jobject value))
> 4072: //asm("nop");
The asm("nop") was comm
On Fri, 4 Nov 2022 23:17:32 GMT, Dean Long wrote:
>> JEP 429 implementation.
>
> src/hotspot/share/prims/jvm.cpp line 1410:
>
>> 1408: loc = 3;
>> 1409: } else if (method == resolver.thread_run_method) {
>> 1410: loc = 2;
>
> This depends on how javac numbers locals, right? It
On Tue, 15 Nov 2022 01:52:14 GMT, Bo Zhang wrote:
> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329),
> previously, the jar validator compare the "version" to validate a
> multi-release jar. The "version" is a mix of the major and minor version
> fused into a single i
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/hotspot/share/prims/jvm.cpp line 1410:
> 1408: loc = 3;
> 1409: } else if (method == resolver.thread_run_method) {
> 1410: loc = 2;
This depends on how javac numbers locals, right? It seems a bi
JEP 429 implementation.
-
Commit messages:
- Update StressStackOverflow
- Release _scopedValueCache after use
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Update src/java.base/share/classes/jdk/internal/vm/ScopedValueContainer.java
- Renam
On Mon, 14 Nov 2022 16:12:48 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features t
On Wed, 9 Nov 2022 09:00:14 GMT, Aleksey Shipilev wrote:
> $ java -jar
> ../build/linux-x86_64-server-release/images/test/micro/benchmarks.jar
> org.openjdk.bench.javax.tools.Javac.testCompile -f 1 -r 1s -w 1s
> ...
>
> $ ls
> Apan.class
> ```
>
> Additional testing:
> - [x] Eyeballing CWD
> $ java -jar
> ../build/linux-x86_64-server-release/images/test/micro/benchmarks.jar
> org.openjdk.bench.javax.tools.Javac.testCompile -f 1 -r 1s -w 1s
> ...
>
> $ ls
> Apan.class
> ```
>
> Additional testing:
> - [x] Eyeballing CWD and `/tmp` contents after the benchmark -- no leftovers
Al
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Mon, 14 Nov 2022 13:06:28 GMT, Kim Barrett wrote:
>> Yep, just something that C++ does a little neater, at least in my view
>
> We (the HotSpot Group) have not discussed or approved the use of the new C++
> attribute syntax, whether for standard attributes or compiler-specific ones.
> That
On Tue, 15 Nov 2022 06:12:52 GMT, Kim Barrett wrote:
>> Reverted to use the original, less intrusive solution from
>> [8274980](https://github.com/openjdk/jdk/pull/11081/commits/83ed3deb29d7344bbc95a3831f2388d077bc59e9)
>> that initially could not work with the older Visual C++ compiler (With a
Please review a simple change to hide internal classes in generated
documentation by adding doc comments containing a `@hidden` tag. I verified the
fix by making sure `grep -r jdk.internal` returns no matches in the generated
documentation tree.
-
Commit messages:
- JDK-8277074: Q
On Tue, 15 Nov 2022 01:52:14 GMT, Bo Zhang wrote:
> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329),
> previously, the jar validator compare the "version" to validate a
> multi-release jar. The "version" is a mix of the major and minor version
> fused into a single i
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Tue, 15 Nov 2022 10:12:12 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request with
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
76 matches
Mail list logo
