Integrated: 8296108: (tz) Update Timezone Data to 2022f

2022-11-03 Thread Yoshiki Sato
On Wed, 2 Nov 2022 04:10:43 GMT, Yoshiki Sato wrote: > Please review this PR. The PR includes changes in the resource bundle > sources to follow the time zone change observed in America/Chihuahua and > America/Ojinaga. This pull request has now been integrated. Changeset: 9d3b4ef2 Author:

Re: RFR: 8295673: Deprecate legacy parallel class loading workaround for non-parallel-capable class loaders

2022-11-03 Thread David Holmes
On Mon, 24 Oct 2022 12:16:54 GMT, Coleen Phillimore wrote: > This change adds an option **EnableWaitForParallelLoad** to enable the legacy > behavior where the VM will manage synchronization for multiple threads > loading the same class using a non-parallel capable class loader that have > rel

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-11-03 Thread Jim Laskey
On Tue, 1 Nov 2022 15:31:20 GMT, Jan Lahoda wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add @SafeVarargs declarations > > src/java.base/share/classes/java/util/FormatConcatItem.java line 51: > >> 49: */ >> 50:

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v13]

2022-11-03 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation a

Integrated: 8294241: Deprecate URL public constructors

2022-11-03 Thread Daniel Fuchs
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Integrated: JDK-8288232: Address typos in jar man page

2022-11-03 Thread Lance Andersen
On Wed, 2 Nov 2022 14:04:45 GMT, Lance Andersen wrote: > Hi > > Please review this update to the jar man page which removes the "=" for the > non GNU style options > > Best > Lance This pull request has now been integrated. Changeset: 68209adf Author:Lance Andersen URL: https://g

Integrated: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names

2022-11-03 Thread Joe Wang
On Wed, 2 Nov 2022 19:32:47 GMT, Joe Wang wrote: > Fixed an issue where the condition check for limit=0 was missed. This pull request has now been integrated. Changeset: 2ff9d3af Author:Joe Wang URL: https://git.openjdk.org/jdk/commit/2ff9d3af815c0f6ff2643d8fc562cec20ef6c324 Stats:

Re: RFR: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names [v2]

2022-11-03 Thread Joe Wang
On Wed, 2 Nov 2022 20:00:55 GMT, Joe Wang wrote: >> Fixed an issue where the condition check for limit=0 was missed. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > source changes Thanks Lance, Naoto! - PR: https

Integrated: JDK-8292427: Improve specification of InflaterInputStream.fill()

2022-11-03 Thread Lance Andersen
On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen wrote: > Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > b

Re: RFR: 8295673: Deprecate legacy parallel class loading workaround for non-parallel-capable class loaders

2022-11-03 Thread Mandy Chung
On Mon, 24 Oct 2022 12:16:54 GMT, Coleen Phillimore wrote: > This change adds an option **EnableWaitForParallelLoad** to enable the legacy > behavior where the VM will manage synchronization for multiple threads > loading the same class using a non-parallel capable class loader that have > rel

Integrated: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V)

2022-11-03 Thread liach
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote: > Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare > values by identity. Updated API documentation of these two methods > ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v12]

2022-11-03 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation a

Re: RFR: 8294241: Deprecate URL public constructors [v5]

2022-11-03 Thread Daniel Fuchs
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in RFC2396. It is the > responsibility of the caller to e

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v11]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 20:07:50 GMT, Jorn Vernee wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Internalize TemplateSupport > > src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line > 1118: > >> 1

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v11]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 22:50:29 GMT, Vladimir Ivanov wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Internalize TemplateSupport > > src/java.base/share/classes/java/lang/StringConcatHelper.java line 359: > >> 357:

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Michael McMahon
On Thu, 3 Nov 2022 11:20:03 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v11]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 20:07:15 GMT, Jorn Vernee wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Internalize TemplateSupport > > src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line > 1103: > >> 1

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v8]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 18:01:41 GMT, Jorn Vernee wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 22 additional >> commits since

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 17:44:24 GMT, Rémi Forax wrote: >> Will use List.of. I think use case is raw and caching should be left to the >> user. > > i agree I agree. Need a balance of performance and #classes. Just something I'll work on during preview. - PR: https://git.openjdk.org/jd

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v5]

2022-11-03 Thread Volker Simonis
On Wed, 2 Nov 2022 20:42:42 GMT, Lance Andersen wrote: >> Hi all, >> >> This PR will update the javadoc to clarify the existing behavior of >> InflaterInputStream::fill as it currently omits the possibility that a >> EOFException may be thrown and that the protected `len` field is also >> upd

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 17:23:24 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 184: >> >>> 182: MethodHandle mh = >>> MethodHandles.insertArguments(DEFAULT_PROCESS_MH, 0, fragments, processor); >>> 183: mh = mh.withVarargs(true); >

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v8]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 17:53:03 GMT, Jorn Vernee wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 22 additional >> commits since

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 17:06:50 GMT, Jorn Vernee wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add @SafeVarargs declarations > > src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 141: > >> 139:

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-11-03 Thread Jim Laskey
On Wed, 2 Nov 2022 17:04:29 GMT, Jorn Vernee wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add @SafeVarargs declarations > > src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 74: > >> 72: >>

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Aleksei Efimov
On Thu, 3 Nov 2022 11:20:03 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define

Integrated: 8295970: Add vector api sanity tests in tier1

2022-11-03 Thread Jie Fu
On Thu, 27 Oct 2022 03:53:13 GMT, Jie Fu wrote: > Hi all, > > As discussed here > https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it > would be better to add the vector api tests in GHA. > > Thanks. > Best regards, > Jie This pull request has now been integrated. Ch

Re: RFR: 8294241: Deprecate URL public constructors [v3]

2022-11-03 Thread Daniel Fuchs
On Thu, 3 Nov 2022 07:42:44 GMT, ExE Boss wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Daniel Fuchs
On Thu, 3 Nov 2022 10:56:28 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Update src/java.base/share/classes/java/net/URL.java >> >>Co-authored-by: ExE Boss <3889017+exe-b...@user

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Michael McMahon
On Thu, 3 Nov 2022 10:56:28 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Daniel Fuchs
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in RFC2396. It is the > responsibility of the caller to e

Re: RFR: 8295970: Add vector api sanity tests in tier1 [v4]

2022-11-03 Thread Jie Fu
On Thu, 3 Nov 2022 03:31:56 GMT, Jie Fu wrote: >> Hi all, >> >> As discussed here >> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it >> would be better to add the vector api tests in GHA. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request

Re: RFR: 8295970: Add vector api sanity tests in tier1 [v4]

2022-11-03 Thread Aleksey Shipilev
On Thu, 3 Nov 2022 03:31:56 GMT, Jie Fu wrote: >> Hi all, >> >> As discussed here >> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it >> would be better to add the vector api tests in GHA. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request

Re: RFR: 8294241: Deprecate URL public constructors [v3]

2022-11-03 Thread ExE Boss
On Tue, 1 Nov 2022 16:14:20 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define