Integrated: JDK-8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le

2022-10-16 Thread Matthias Baesken
On Fri, 14 Oct 2022 11:16:50 GMT, Matthias Baesken wrote: > The test tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux > ppc64le because it assumes that vm.jvmci is > available on all platforms but this is currently not the case on Linux > ppc64le. > Error is : > > Error: Mod

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-16 Thread Alan Bateman
On Mon, 17 Oct 2022 06:37:24 GMT, Jaikiran Pai wrote: > Looking at the existing code (without the proposed changes in this PR), it > appears that it's not just the number of `moduleInfos` that could impact the > method size but even details like `requires`, `exports`, `opens` and other > such

Re: RFR: JDK-8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le

2022-10-16 Thread Matthias Baesken
On Fri, 14 Oct 2022 11:16:50 GMT, Matthias Baesken wrote: > The test tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux > ppc64le because it assumes that vm.jvmci is > available on all platforms but this is currently not the case on Linux > ppc64le. > Error is : > > Error: Mod

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-16 Thread Jaikiran Pai
On Fri, 14 Oct 2022 23:12:38 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to sp

Re: RFR: 8295231: Move all linking of native libraries to make

2022-10-16 Thread Thomas Stuefe
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote: > Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place,

Re: RFR: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259

2022-10-16 Thread Jaikiran Pai
On Wed, 12 Oct 2022 16:30:07 GMT, Roger Riggs wrote: > Process.waitFor() throws IllegalThreadStateException when a process returns > an exit code of 259. > As described in the bug report, `waitFor()` should not be sensitive to the > exit value. > Previously, it erroneously threw IllegalStateExc

Integrated: 8292698: Improve performance of DataInputStream

2022-10-16 Thread Сергей Цыпанов
On Sun, 21 Aug 2022 06:29:43 GMT, Сергей Цыпанов wrote: > I found out that reading from `DataInputStream` wrapping > `ByteArrayInputStream` (as well as `BufferedInputStream` or any `InputStream` > relying on `byte[]`) can be significantly improved by accessing volatile `in` > field only once p

Re: RFR: 8292698: Improve performance of DataInputStream [v4]

2022-10-16 Thread Jaikiran Pai
On Mon, 29 Aug 2022 08:46:20 GMT, Сергей Цыпанов wrote: >> I found out that reading from `DataInputStream` wrapping >> `ByteArrayInputStream` (as well as `BufferedInputStream` or any >> `InputStream` relying on `byte[]`) can be significantly improved by >> accessing volatile `in` field only on

Re: RFR: 8295231: Move all linking of native libraries to make

2022-10-16 Thread David Holmes
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote: > Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place,

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder() [v3]

2022-10-16 Thread Tagir F . Valeev
On Fri, 14 Oct 2022 19:03:11 GMT, Сергей Цыпанов wrote: >> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance >> is constructed without comparator. This allows to squash two branches in >> `TreeMap.get()` into one. >> >> P.S. I think the comment of `TreeMap.getEntryUsin

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2022-10-16 Thread Alan Bateman
On Fri, 14 Oct 2022 06:10:11 GMT, Jaikiran Pai wrote: > Hello Oliver, the GitHub actions job failures appear related to this change. > For example: > > ``` > Error occurred during initialization of boot layer > java.lang.VerifyError: Method does not expect a return value I think there are stil

Re: RFR: 8292698: Improve performance of DataInputStream [v4]

2022-10-16 Thread Jaikiran Pai
On Wed, 5 Oct 2022 15:24:10 GMT, Сергей Цыпанов wrote: > Anyone to sponsor, or should I get more approves? I see that both Alan and Daniel have approved these changes and there hasn't been a commit in this PR, after the approval (which is a good thing). I'll run some internal tests and if all

Re: RFR: 8295231: Move all linking of native libraries to make

2022-10-16 Thread Alan Bateman
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote: > Some external libraries required by native code are linked via linker > comments embedded in pragmas. Searching for which libraries are linked can > then become frustrating and confusing since they may be included in an > obscure place,

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-16 Thread Jaikiran Pai
On Fri, 14 Oct 2022 23:12:38 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to sp

Re: RFR: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259

2022-10-16 Thread ExE Boss
On Wed, 12 Oct 2022 16:30:07 GMT, Roger Riggs wrote: > Process.waitFor() throws IllegalThreadStateException when a process returns > an exit code of 259. > As described in the bug report, `waitFor()` should not be sensitive to the > exit value. > Previously, it erroneously threw IllegalStateExc

RFR: 8295231: Move all linking of native libraries to make

2022-10-16 Thread Julian Waters
Some external libraries required by native code are linked via linker comments embedded in pragmas. Searching for which libraries are linked can then become frustrating and confusing since they may be included in an obscure place, and for all relevant compilers there is no difference between spe