On Thu, 6 Oct 2022 13:39:25 GMT, Alan Bateman wrote:
>> This is a test only change for two tests for virtual threads that
>> hang/timeout on single core systems. The two tests involve pinning and
>> require at least two carrier threads. The test lib used by these tests is
>> updated to define
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
This pull request has now been integrat
On Wed, 5 Oct 2022 22:17:26 GMT, Justin Lu wrote:
> Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
> Base Calendar.
>
> Fix: Removed all unused variables in bug description except normalizedYear in
> JapaneseImpericalCalendar.getActualMaximum.() as there was no m
On Wed, 5 Oct 2022 22:17:26 GMT, Justin Lu wrote:
> Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
> Base Calendar.
>
> Fix: Removed all unused variables in bug description except normalizedYear in
> JapaneseImpericalCalendar.getActualMaximum.() as there was no m
On Wed, 5 Oct 2022 22:17:26 GMT, Justin Lu wrote:
> Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
> Base Calendar.
>
> Fix: Removed all unused variables in bug description except normalizedYear in
> JapaneseImpericalCalendar.getActualMaximum.() as there was no m
On Wed, 5 Oct 2022 22:17:26 GMT, Justin Lu wrote:
> Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
> Base Calendar.
>
> Fix: Removed all unused variables in bug description except normalizedYear in
> JapaneseImpericalCalendar.getActualMaximum.() as there was no m
Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
Base Calendar.
Fix: Removed all unused variables in bug description except normalizedYear in
JapaneseImpericalCalendar.getActualMaximum.() as there was no matching unused
variable within that method.
Additionally rem
On Thu, 6 Oct 2022 20:43:30 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally with
> Problem: Outdated doc does not match code. Claimed to throw exception and
> compared to Long method.
> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Refact
On Thu, 6 Oct 2022 10:58:36 GMT, Lance Andersen wrote:
> Looks fine Justin.
>
> Please make sure the comments are < 80 characters and if they are longer
> break them into two lines as they seem like they might be long
@LanceAndersen Made the change, thanks Lance
-
PR: https://git
On Thu, 6 Oct 2022 15:31:02 GMT, Chris Plummer wrote:
> If these tests are ever run with the virtual thread wrapper, will we end up
> being short a carrier thread? It's unclear to me if the tests will always
> have at least one unpinned carrier thread to work with.
There's nothing inherit here
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Wed, 5 Oct 2022 15:23:43 GMT, Aleksei Efimov wrote:
> ### Summary of the change
> This change introduces new system and security properties for specifying
> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
> implementations.
>
> These new properties allow more granular contr
On Thu, 6 Oct 2022 13:39:25 GMT, Alan Bateman wrote:
>> This is a test only change for two tests for virtual threads that
>> hang/timeout on single core systems. The two tests involve pinning and
>> require at least two carrier threads. The test lib used by these tests is
>> updated to define
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote:
>> This adds exception documentation to JDK methods that would otherwise lose
>> that documentation once JDK-8287796 is integrated. While adding this
>> exception documentation now does not change [^1] the JDK API Documentation,
>> it will a
On Thu, 6 Oct 2022 14:26:27 GMT, Serguei Spitsyn wrote:
> Just a side note to be aware about a potential problem.
> This won't work correctly if there are more than one such tests executed in
> VM at the same time.
> Then there can be a race to restore the parallelism value.
> But it seems is no
On Fri, 30 Sep 2022 19:15:17 GMT, Phil Race wrote:
> If the docs end up the same as you say that is fine by me since for the two
> ImageIO classes that seems to be what we'd want.
Since this change does not affect HTML pages for java.desktop, I take it as
"approved".
> But inheritDoc behaviou
On Thu, 6 Oct 2022 13:39:25 GMT, Alan Bateman wrote:
>> This is a test only change for two tests for virtual threads that
>> hang/timeout on single core systems. The two tests involve pinning and
>> require at least two carrier threads. The test lib used by these tests is
>> updated to define
On Tue, 14 Jun 2022 13:54:46 GMT, Ludovic Henry wrote:
>> Ludovic Henry has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reenable SpecialArraysHashCode by default
>
> Still working on it, other work priorities have popped up. I'm taking t
On Wed, 5 Oct 2022 20:24:59 GMT, Chris Plummer wrote:
>> No, restoration requires a call to close. Maybe you are assuming that
>> AutoCloseable implementations setup a cleaner to do that?
>
> Yes, that was my point of confusion. I thought collection triggered calling
> close, but I see now when
> This is a test only change for two tests for virtual threads that
> hang/timeout on single core systems. The two tests involve pinning and
> require at least two carrier threads. The test lib used by these tests is
> updated to define a new method that ensures parallelism is at least a given
On Wed, 5 Oct 2022 16:40:16 GMT, Julian Waters wrote:
>> Please review a small patch for dumping the failure reason when the MSVCRT
>> libraries or the Java Virtual Machine fails to load on Windows, which can
>> provide invaluable insight when debugging related launcher issues.
>>
>> See https
> Please review a small patch for dumping the failure reason when the MSVCRT
> libraries or the Java Virtual Machine fails to load on Windows, which can
> provide invaluable insight when debugging related launcher issues.
>
> See https://bugs.openjdk.org/browse/JDK-8292016 and the related Pull R
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
LGTM
-
Marked as reviewed
On Wed, 5 Oct 2022 15:23:43 GMT, Aleksei Efimov wrote:
> ### Summary of the change
> This change introduces new system and security properties for specifying
> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
> implementations.
>
> These new properties allow more granular contr
On Wed, 5 Oct 2022 21:26:09 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally with
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
This pull request has now been integrated.
Changeset: 2ceebf68
Author:Raffaello Gi
On Wed, 5 Oct 2022 14:05:38 GMT, Alan Bateman wrote:
> This is a test-only change. ThreadAPI.testGetStackTrace2 tests the stack
> trace of a virtual thread that has started but has not executed it. The test
> currently attempts to saturate all carrier threads before starting a target
> thread.
On Wed, 5 Oct 2022 09:21:50 GMT, Matthias Baesken wrote:
> Currently the buildNumber check for Windows 2019 server differs in
> os_windows.cpp and java_props_md.c ( java_props_md.c still checks pre GA
> versions , this is probably not necessary any more ).
> The check should be unified.
This p
On Wed, 5 Oct 2022 09:21:50 GMT, Matthias Baesken wrote:
> Currently the buildNumber check for Windows 2019 server differs in
> os_windows.cpp and java_props_md.c ( java_props_md.c still checks pre GA
> versions , this is probably not necessary any more ).
> The check should be unified.
Hi Rog
30 matches
Mail list logo
