Re: RFR: 8234262: Unmask SIGQUIT in a child process [v3]

2022-09-22 Thread Thomas Stuefe
On Thu, 22 Sep 2022 22:41:21 GMT, Roger Riggs wrote: >> Clear the signal mask of the child when launching with posix_spawn. >> >> SIGQUIT signals are handled on non-Java Threads by the VM. >> For Java threads the signal mask blocks SIGQUIT. >> The ProcessBuilder uses posix_spawn on all platfor

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v9]

2022-09-22 Thread Smita Kamath
> 8289552: Make intrinsic conversions between bit representations of half > precision values and floats Smita Kamath has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull req

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v3]

2022-09-22 Thread David Holmes
On Thu, 22 Sep 2022 22:41:21 GMT, Roger Riggs wrote: >> Clear the signal mask of the child when launching with posix_spawn. >> >> SIGQUIT signals are handled on non-Java Threads by the VM. >> For Java threads the signal mask blocks SIGQUIT. >> The ProcessBuilder uses posix_spawn on all platfor

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v2]

2022-09-22 Thread Roger Riggs
On Wed, 21 Sep 2022 21:37:59 GMT, Roger Riggs wrote: >> Clear the signal mask of the child when launching with posix_spawn. >> >> SIGQUIT signals are handled on non-Java Threads by the VM. >> For Java threads the signal mask blocks SIGQUIT. >> The ProcessBuilder uses posix_spawn on all platfor

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v3]

2022-09-22 Thread Roger Riggs
> Clear the signal mask of the child when launching with posix_spawn. > > SIGQUIT signals are handled on non-Java Threads by the VM. > For Java threads the signal mask blocks SIGQUIT. > The ProcessBuilder uses posix_spawn on all platforms to create new processes. > Without a specific request, th

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-22 Thread Brian Burkhalter
On Fri, 9 Sep 2022 12:19:54 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with two additional > commits since the last revision: > > - corrected copyright > - testing transferTo() after reset() test/jdk/java/io/BufferedInp

Re: RFR: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications [v4]

2022-09-22 Thread David Holmes
On Thu, 22 Sep 2022 06:09:46 GMT, Robbin Ehn wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix JniVersion test > > Looks good, thank you! Thanks @robehn ! - PR: https://git.openjdk.org/jdk/pull/103

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v2]

2022-09-22 Thread David Holmes
On Wed, 21 Sep 2022 21:37:59 GMT, Roger Riggs wrote: >> Clear the signal mask of the child when launching with posix_spawn. >> >> SIGQUIT signals are handled on non-Java Threads by the VM. >> For Java threads the signal mask blocks SIGQUIT. >> The ProcessBuilder uses posix_spawn on all platfor

Re: RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

2022-09-22 Thread Mandy Chung
On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote: > We noticed that with certain jar file input, jdeps runs into the following > exception, this happens with jdk11, 17 and 20. > > jdeps.exe --multi-release 11 --module-path . --inverse --package > com.sap.nw.performance.supa.client test

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

2022-09-22 Thread Joe Darcy
On Thu, 22 Sep 2022 18:48:41 GMT, Aleksey Shipilev wrote: >> Reliably reproduces on x86-32 with FPU: >> >> >> $ CONF=linux-x86-server-fastdebug make test >> TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 >> -XX:UseSSE=0" >> ... >> Roundtrip failure on NaN value 7de

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v4]

2022-09-22 Thread Chris Plummer
On Thu, 22 Sep 2022 09:16:28 GMT, Serguei Spitsyn wrote: >> There are several places in VirtualThread class implementation where virtual >> threads are being mounted or unmounted, so there is a transition of the >> JavaThread identity from carrier thread to virtual thread and back. The >> exec

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

2022-09-22 Thread Joe Darcy
On Thu, 22 Sep 2022 18:43:40 GMT, Aleksey Shipilev wrote: >> test/jdk/java/lang/Float/Binary16ConversionNaN.java line 27: >> >>> 25: * @test >>> 26: * @bug 8289551 >>> 27: * @library /test/lib >> >> If we want to simply not run this test on x87, that could be done using >> jtreg @requires t

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

2022-09-22 Thread Aleksey Shipilev
On Thu, 22 Sep 2022 13:26:17 GMT, Raffaello Giulietti wrote: >> test/jdk/java/lang/Float/Binary16ConversionNaN.java line 81: >> >>> 79: >>> 80: private static int sign(short binary16) { >>> 81: return (binary16 & 0xf000); >> >> I think this should read >> `return binary16 & 0x8000;

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

2022-09-22 Thread Aleksey Shipilev
On Thu, 22 Sep 2022 16:41:53 GMT, Joe Darcy wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commit

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

2022-09-22 Thread Aleksey Shipilev
> Reliably reproduces on x86-32 with FPU: > > > $ CONF=linux-x86-server-fastdebug make test > TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 > -XX:UseSSE=0" > ... > Roundtrip failure on NaN value 7de2 got back 7fe2 > Roundtrip failure on NaN value fde2 got back ffe2

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v2]

2022-09-22 Thread Hannes Wallnöfer
On Thu, 22 Sep 2022 17:16:55 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to the preview page to add a list of preview >> features and allow users to explore the preview APIs by feature. >> >> While the changes for the enhancement itself are not overly complex, the >> work ent

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v3]

2022-09-22 Thread Hannes Wallnöfer
> Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work > entailed a moderate cleanup of other summary API lists (Deprecated a

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v2]

2022-09-22 Thread Hannes Wallnöfer
On Thu, 18 Aug 2022 21:42:04 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JDK-8287597 >> - JDK-8287597: List all preview feature

Re: RFR: 8294198: Implement isFinite intrinsic for RISC-V

2022-09-22 Thread Joe Darcy
On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov wrote: > Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic > turned out to be profitable on RISC-V using the same fclass instruction as > for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it > ad

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v2]

2022-09-22 Thread Hannes Wallnöfer
> Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work > entailed a moderate cleanup of other summary API lists (Deprecated a

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

2022-09-22 Thread Joe Darcy
On Mon, 19 Sep 2022 10:25:50 GMT, Aleksey Shipilev wrote: > Reliably reproduces on x86-32 with FPU: > > > $ CONF=linux-x86-server-fastdebug make test > TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 > -XX:UseSSE=0" > ... > Roundtrip failure on NaN value 7de2 got ba

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v2]

2022-09-22 Thread Thomas Stuefe
On Thu, 22 Sep 2022 14:26:51 GMT, Roger Riggs wrote: > Hi Roger, Using the spawn attributes seems more far reaching than simply > temporarily changing the signal mask of the calling thread. I'd be concerned > this has some unintended side-effects. I don't think that is a good idea. If the thre

RFR: 8292177: InitialSecurityProperty JFR event

2022-09-22 Thread Sean Coffey
New JFR event to record state of initial security properties. Debug output is also now added for these properties via -Djava.security.debug=properties - Commit messages: - merge with master - Correct test bug ids - fix up imports - Add security debug test logic - Add JFR testc

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v2]

2022-09-22 Thread Alan Bateman
On Thu, 22 Sep 2022 14:26:51 GMT, Roger Riggs wrote: > The launching of a new executable is a two+ step process. A small executable > (jspawnhelper) is spawned and it does the exec of the requested executable. > An alternate implementation is to have jspawnhelper reset its own signal mask > be

Re: RFR: 8234262: Unmask SIGQUIT in a child process [v2]

2022-09-22 Thread Roger Riggs
On Wed, 21 Sep 2022 23:12:13 GMT, David Holmes wrote: > Hi Roger, Using the spawn attributes seems more far reaching than simply > temporarily changing the signal mask of the calling thread. I'd be concerned > this has some unintended side-effects. @dholmes-ora The signal masks for threads are

Integrated: 8254711: Add java.security.Provider.getService JFR Event

2022-09-22 Thread Sean Coffey
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote: > Add a JFR Event for `java.security.Provider.getService(String type, String > algorithm)` calls. This pull request has now been integrated. Changeset: bc2af47e Author:Sean Coffey URL: https://git.openjdk.org/jdk/commit/bc2af47e1

Re: RFR: 8292016: Better handle intermingling WINAPI and C Runtime errors in the JDK [v20]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

Re: RFR: 8292016: Rework JLI_ReportErrorMessageSys [v19]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

Re: RFR: 8292016: Rework JLI_ReportErrorMessageSys [v18]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

Re: RFR: 8292016: Rework JLI_ReportErrorMessageSys [v17]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

Re: RFR: 8292016: Rework JLI_ReportErrorMessageSys [v16]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

2022-09-22 Thread Raffaello Giulietti
On Thu, 22 Sep 2022 13:23:23 GMT, Raffaello Giulietti wrote: >> Reliably reproduces on x86-32 with FPU: >> >> >> $ CONF=linux-x86-server-fastdebug make test >> TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 >> -XX:UseSSE=0" >> ... >> Roundtrip failure on NaN value

Re: RFR: 8292016: Rework JLI_ReportErrorMessageSys [v15]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

Re: RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

2022-09-22 Thread Raffaello Giulietti
On Mon, 19 Sep 2022 10:25:50 GMT, Aleksey Shipilev wrote: > Reliably reproduces on x86-32 with FPU: > > > $ CONF=linux-x86-server-fastdebug make test > TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 > -XX:UseSSE=0" > ... > Roundtrip failure on NaN value 7de2 got ba

Re: RFR: 8292016: Rework JLI_ReportErrorMessageSys [v14]

2022-09-22 Thread Julian Waters
> Second attempt at resolving > [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less > intrusive approach this time > > Side note: While it might be preferred to remove this entirely, other areas > of the JDK also use the same flawed logic, and removing this would simply > p

RFR: 8294198: Implement isFinite intrinsic for RISC-V

2022-09-22 Thread Aleksei Voitylov
Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic turned out to be profitable on RISC-V using the same fclass instruction as for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it added on RISC-V in this PR. benchmark results: before: Benchmark

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v7]

2022-09-22 Thread Raffaello Giulietti
> Add support for named groups to java.util.regex.MatchResult Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8065554: MatchResult should provide values of named-capturing groups - Changes: - all: https://git.op

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v4]

2022-09-22 Thread Serguei Spitsyn
On Thu, 22 Sep 2022 09:16:28 GMT, Serguei Spitsyn wrote: >> There are several places in VirtualThread class implementation where virtual >> threads are being mounted or unmounted, so there is a transition of the >> JavaThread identity from carrier thread to virtual thread and back. The >> exec

Re: RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

2022-09-22 Thread Andrew Haley
On Thu, 22 Sep 2022 07:02:16 GMT, Hao Sun wrote: > This warning seems to be a false positive, because 1) array "fq" with > elements from index 0 to "jz" has already been initialized as "fw" at line > 290 [1], and 2) variable "jz" should be non-negative from the comment at line > 99 [2]. > > N

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v4]

2022-09-22 Thread Serguei Spitsyn
> There are several places in VirtualThread class implementation where virtual > threads are being mounted or unmounted, so there is a transition of the > JavaThread identity from carrier thread to virtual thread and back. The > execution state in such transitions is inconsistent, and so, has to

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v3]

2022-09-22 Thread Serguei Spitsyn
On Wed, 21 Sep 2022 17:25:42 GMT, Chris Plummer wrote: >> Thank you for reviewing and the comment, Chris. >> I agree, this part and related comment is kind of obscure. >> I'll think how to make the comment better. >> In fact, all temporary VTMS transitions do temporary switch the `JavaThread` >>

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-22 Thread Jaikiran Pai
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally de

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-22 Thread Alan Bateman
On Thu, 22 Sep 2022 07:57:38 GMT, David Holmes wrote: > Why is stop being removed in this PR? It's just the sequencing of the two PRs and avoid merge conflicts. The Thread.stop should really edit this sentence, then this PR will edit it again. It was simpler to just do the SM edits in one PR.

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-22 Thread David Holmes
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally de

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-22 Thread Alan Bateman
On Thu, 22 Sep 2022 04:36:08 GMT, Joe Darcy wrote: > Consider using an implSpec tag here. implSpec is usually for default methods or overrideable methods. In this case, Thread.stop is final so code that extends Thread can't override and change the behavior. So it's not clear to me that implSpe

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-22 Thread Jaikiran Pai
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally de

RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

2022-09-22 Thread Hao Sun
This warning seems to be a false positive, because 1) array "fq" with elements from index 0 to "jz" has already been initialized as "fw" at line 290 [1], and 2) variable "jz" should be non-negative from the comment at line 99 [2]. Note-1: GCC warning option -Wmaybe-uninitialized is not a new one