Re: RFR: JDK-8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present

2022-09-18 Thread Matthias Baesken
On Fri, 16 Sep 2022 19:02:40 GMT, Mandy Chung wrote: > What is the cause of this issue? It expects the dependency can be found but > missing in this case. I wonder if it's due to a `requires static` dependency? Hi Mandy, good question, so far I have just a zip with a coupple of jars inside , s

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v7]

2022-09-18 Thread Alan Bateman
On Sun, 18 Sep 2022 20:43:25 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v6]

2022-09-18 Thread Alan Bateman
On Sun, 18 Sep 2022 20:33:55 GMT, Lance Andersen wrote: > I can remove, but I am not sure I agree we need to describe main vs attribute > here given we are pointing to the Jar spec and if there is any discussion of > Pre-entry attributes, it should be in JarEntry IMHO. I guess the > clarificat

Integrated: 8293499: Provide jmod --compress option

2022-09-18 Thread Aleksey Shipilev
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote: > I have been looking into `make clean-images images` performance, and realized > jmod keeps compressing files with default compression level. Tuning that > toward lighter compression levels improves build performance considerably, > wit

Re: RFR: 8293499: Provide jmod --compress option [v7]

2022-09-18 Thread Aleksey Shipilev
On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote: >> I have been looking into `make clean-images images` performance, and >> realized jmod keeps compressing files with default compression level. Tuning >> that toward lighter compression levels improves build performance >> considerably

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-18 Thread Alan Bateman
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-18 Thread Leslie Zhai
Hi, @dumasun reported the issue: Configured with jfx-ls-modular-sdk: configure --with-import-modules=modular-sdk `make run-test CONF=fastdebug TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: --System.out:(46/3114)-- test VerifyModuleDelegation.checkJavaBase(): s

Re: RFR: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port

2022-09-18 Thread Jaikiran Pai
On Sun, 18 Sep 2022 11:52:28 GMT, Jaikiran Pai wrote: > Can I please get a review of this test only change which proposes to fix the > recent intermittent failures in `RmiBootstrapTest` reported in > https://bugs.openjdk.org/browse/JDK-8030616? > > The test has been intermittently failing with

Re: RFR: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port

2022-09-18 Thread Mark Sheppard
On Sun, 18 Sep 2022 11:52:28 GMT, Jaikiran Pai wrote: > Can I please get a review of this test only change which proposes to fix the > recent intermittent failures in `RmiBootstrapTest` reported in > https://bugs.openjdk.org/browse/JDK-8030616? > > The test has been intermittently failing with

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v7]

2022-09-18 Thread Lance Andersen
> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v6]

2022-09-18 Thread Lance Andersen
On Sun, 18 Sep 2022 19:49:51 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Incorporated latest round of input > > src/java.base/share/classes/java/util/jar/JarInputStream.java line 36: > >> 3

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v6]

2022-09-18 Thread Alan Bateman
On Sat, 17 Sep 2022 14:35:46 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

RFR: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port

2022-09-18 Thread Jaikiran Pai
Can I please get a review of this test only change which proposes to fix the recent intermittent failures in `RmiBootstrapTest` reported in https://bugs.openjdk.org/browse/JDK-8030616? The test has been intermittently failing with `cannot find a free port after 10 tries`. The tests uses the `j

RFR: 8293613: need to properly handle and hide tmp VTMS transitions

2022-09-18 Thread Serguei Spitsyn
There are several places in VirtualThread class implementation where virtual threads are being mounted or unmounted, so there is a transition of the JavaThread identity from carrier thread to virtual thread and back. The execution state in such transitions is inconsistent, and so, has to be inv