On Fri, 9 Sep 2022 06:36:54 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - testing transferTo() when mark was set
>> - testing transferTo() when buffer is non-empty
>
> test/jdk/java/io/Buffere
On Thu, 8 Sep 2022 08:26:43 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - testing transferTo() when mark was set
> - testing transferTo() when buffer is non-empty
On Tue, 9 Aug 2022 20:38:25 GMT, Naoto Sato wrote:
>> To support Windows command prompt's codepage, following charsets should be
>> moved from jdk.charsets module to java.base module.
>>
>> - IBM860
>> - IBM861
>> - IBM863
>> - IBM864
>> - IBM865
>> - IBM869
>
> I looked at this issue a bit mor
On Thu, 8 Sep 2022 19:22:37 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add the change for nio and upda
On Thu, 8 Sep 2022 19:22:37 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add the change for nio and upda
On Thu, 8 Sep 2022 20:26:41 GMT, Roger Riggs wrote:
> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
> multiple gc cycles to queue the expected refs.
> Short the timeout on each cycle to 10 sec.
Hello Roger, just a few additional points that I noticed about this test.
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 15:54:03 GMT, Rajan Halade wrote:
>> Created two files for testing XPath Axes: XPathAncestors.java tests the
>> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the
>> preceding and preceding-sibling axes.
>
> Please fix jcheck issues. Code has trailing
On Thu, 8 Sep 2022 06:19:10 GMT, Rahul Prabhu wrote:
> Created two files for testing XPath Axes: XPathAncestors.java tests the
> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the
> preceding and preceding-sibling axes.
Please fix jcheck issues. Code has trailing white
Created two files for testing XPath Axes: XPathAncestors.java tests the
ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the
preceding and preceding-sibling axes.
-
Commit messages:
- Update XPathAncestorsTest.java to remove whitespace
- 8289508: Update Prec
On Thu, 8 Sep 2022 20:26:41 GMT, Roger Riggs wrote:
> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
> multiple gc cycles to queue the expected refs.
> Short the timeout on each cycle to 10 sec.
test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java l
Modify the LoadLibraryUnload test to call gc() more a few times, allowing
multiple gc cycles to queue the expected refs.
Short the timeout on each cycle to 10 sec.
-
Commit messages:
- Add bugid to LoadLibraryUnloadTest
- Modify the wait loop to repeat the System.gc and count queue
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote:
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't
> exist
1) Remove the setting in java.security, not displaying the folder name of
java.io.tmpdir
2) Add the change for NIO
3) Update the testing files.
4) In te
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't
> exist
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
add the change for nio and update the code according to the comments
-
Changes:
-
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has also been drafted, as there will be behavioral changes
On Wed, 7 Sep 2022 21:27:10 GMT, Stuart Marks wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed the paragraph to @implSpec
>
> src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 47:
>
>> 45
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has also been drafted, as there will be behavioral changes
On Thu, 8 Sep 2022 06:54:45 GMT, Сергей Цыпанов wrote:
>> To ensure the shared types are not too easily exposed, move 317: to inside
>> the `if (realParamData)`.
>> That's also the only scope in which it is used.
>
> But `nonGenericParamTypes` is used in `else` block as well, so should I call
>
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 08:39:21 GMT, Jaikiran Pai wrote:
>> Actually I wrote this code in 2021. What are the official rules here, do I
>> have to use the original date or the latest change date?
>
>> Actually I wrote this code in 2021. What are the official rules here, do I
>> have to use the origi
On Thu, 8 Sep 2022 08:45:02 GMT, Jaikiran Pai wrote:
>> I have just added testing `transferTo` with non-empty buffer and mark set as
>> part of the already existing *randomized* test steps. I think that should be
>> sufficient to detect problems if they really would exist, so there should
>> n
On Thu, 8 Sep 2022 08:22:14 GMT, Markus KARG wrote:
>> Agreed that testing the non-empty-buffer (read-before-transferTo) and the
>> mark-set cases (mark-before-transferTo), but still I do not see any need to
>> take particularly `FileInputStream` into the boat; files only make the test
>> run
On Mon, 5 Sep 2022 12:39:41 GMT, Adam Sotona wrote:
> LocalExecutionControl in jdk.jshell actually uses Thread::stop to cancel
> execution of (long-running or infinite loops) user code in JShell, however
> Thread::stop is deprecated and planned for removal.
>
> Proposed patch instruments all u
On Tue, 6 Sep 2022 09:14:47 GMT, Adam Sotona wrote:
>> LocalExecutionControl in jdk.jshell actually uses Thread::stop to cancel
>> execution of (long-running or infinite loops) user code in JShell, however
>> Thread::stop is deprecated and planned for removal.
>>
>> Proposed patch instruments
On Thu, 8 Sep 2022 08:34:59 GMT, Adam Sotona wrote:
> According to javadoc VarHandle of static field "effectively ignore the
> volatile declaration".
> Volatility of REPL.$Cancel.allStop field is critical for this use case.
VarHandles defines xxxVolatile so it would be feasible but I don't see
On Thu, 8 Sep 2022 06:05:51 GMT, Markus KARG wrote:
> Actually I wrote this code in 2021. What are the official rules here, do I
> have to use the original date or the latest change date?
I remember reading it somewhere but I can't seem to locate the text right now
and it isn't mentioned in t
On Tue, 6 Sep 2022 09:05:53 GMT, Adam Sotona wrote:
>> src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java
>> line 200:
>>
>>> 198: allStop.set(null, true);
>>> 199: } catch (IllegalArgumentException| IllegalAccessException
>>> ex) {
>>> 200
On Wed, 7 Sep 2022 19:48:56 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor formating fixes
>
> src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java
> line 51:
>
>> 49:
On Thu, 8 Sep 2022 06:39:58 GMT, Markus KARG wrote:
>>> Given that the implementation in this PR now calls the wrapped
>>> `InputStream`'s `transferTo` method, should we also include a test where
>>> the wrapped `InputStream` is a `FileInputStream` and the target
>>> `OutputStream` is a `FileO
> Implementation of JDK-8279283
Markus KARG has updated the pull request incrementally with two additional
commits since the last revision:
- testing transferTo() when mark was set
- testing transferTo() when buffer is non-empty
-
Changes:
- all: https://git.openjdk.org/jdk/pul
I have been looking into `make clean-images images` performance, and realized
jmod keeps compressing files with default compression level. Tuning that toward
lighter compression levels improves build performance considerably, without a
heavy loss in *.jmod sizes.
This PR allows JMOD to select
31 matches
Mail list logo
