Re: RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-09-02 Thread Alexey Semenyuk
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v5]

2022-09-02 Thread Raffaello Giulietti
On Fri, 2 Sep 2022 17:33:21 GMT, Stuart Marks wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8065554: MatchResult should provide values of named-capturing groups > > src/java.base/share/classes/java/util/re

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v6]

2022-09-02 Thread Raffaello Giulietti
> Add support for named groups to java.util.regex.MatchResult Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8065554: MatchResult should provide values of named-capturing groups - Changes: - all: https://git.op

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v5]

2022-09-02 Thread Stuart Marks
On Wed, 31 Aug 2022 13:26:32 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v5]

2022-09-02 Thread Stuart Marks
On Wed, 31 Aug 2022 13:26:32 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

2022-09-02 Thread Brent Christian
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to a

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

2022-09-02 Thread Smita Kamath
On Fri, 2 Sep 2022 15:59:23 GMT, Paul Sandoz wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > Can you please file a follow up issue to write a test (gtest?) for the `f2hf` > and `hf2f`

Re: RFR: 8292579: (tz) Update Timezone Data to 2022c

2022-09-02 Thread Naoto Sato
On Thu, 25 Aug 2022 02:26:19 GMT, Yoshiki Sato wrote: > Please review this PR. The PR adopts the official tzdata2022c as it is. > It means the pre-1970s data merged in tzdata2022c doesn't exist. > All tests have been passed with no failures. LGTM - Marked as reviewed by naoto (Rev

Re: RFR: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform

2022-09-02 Thread Naoto Sato
On Fri, 26 Aug 2022 07:26:46 GMT, Ichiroh Takiguchi wrote: > After `test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java` testcase was > integrated, it failed on the AIX platform. > > Error output > > STDERR: > stdout: []; > stderr: [Exception in thread "main" java.lang.RuntimeException: Got

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

2022-09-02 Thread Paul Sandoz
On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revie

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-09-02 Thread Markus KARG
On Fri, 2 Sep 2022 13:37:23 GMT, Jaikiran Pai wrote: > > I mean, there is no button in Github that would allow me to do that. > > On the right side of the page (at the top), search for "Still in progress?" > "Convert to draft". That's a link (and I agree it's not easy to spot) Thanks, this wor

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-09-02 Thread Jaikiran Pai
On Fri, 2 Sep 2022 12:34:49 GMT, Markus KARG wrote: > I mean, there is no button in Github that would allow me to do that. On the right side of the page (at the top), search for "Still in progress?" "Convert to draft". That's a link (and I agree it's not easy to spot) - PR: https:

Re: RFR: 8292579: (tz) Update Timezone Data to 2022c

2022-09-02 Thread Yoshiki Sato
On Thu, 25 Aug 2022 02:26:19 GMT, Yoshiki Sato wrote: > Please review this PR. The PR adopts the official tzdata2022c as it is. > It means the pre-1970s data merged in tzdata2022c doesn't exist. > All tests have been passed with no failures. The test failure seems to be irrelevant to this fix.

RFR: 8292579: (tz) Update Timezone Data to 2022c

2022-09-02 Thread Yoshiki Sato
Please review this PR. The PR adopts the official tzdata2022c as it is. It means the pre-1970s data merged in tzdata2022c doesn't exist. All tests have been passed with no failures. - Commit messages: - Merge branch 'master' into tz2022c - The first fix for tz2022c Changes: https:

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-09-02 Thread Markus KARG
On Fri, 2 Sep 2022 07:50:53 GMT, Alan Bateman wrote: > It's probably best to change to back to draft until there is an updated > proposal. I would love to, but how to do that? I mean, there is no button in Github that would allow *me* to do that. - PR: https://git.openjdk.org/jdk

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-09-02 Thread Alan Bateman
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed missing BufferedInputStream > /open > > I will continue work on this in the next w

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-09-02 Thread Сергей Цыпанов
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed missing BufferedInputStream Will this be reopened somewhen? The proposed changes se