On Fri, 26 Aug 2022 20:59:57 GMT, Сергей Цыпанов wrote:
>> Currently some operations of RandomAccessFile are implemented with multiple
>> read() invocations:
>>
>> public final int readInt() throws IOException {
>> int ch1 = this.read();
>> int ch2 = this.read();
>> int ch3 = this.r
On Fri, 26 Aug 2022 15:06:16 GMT, Aleksey Shipilev wrote:
>> Look at implementation and figure out what happens if you do:
>>
>>
>> computeHash("SHA-1") = someHash;
>> computeHash("SHA-256") = ...?
>>
>>
>> The caching method should actually check the algorithms match.
>>
>> Not a bug at t
On Fri, 26 Aug 2022 06:32:35 GMT, KIRIYAMA Takuya wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is misma
On Fri, 26 Aug 2022 06:32:35 GMT, KIRIYAMA Takuya wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is misma
> The concept of the shutdown sequence needs to be specified more clearly. This
> PR adds text for this into the class specification of `java.lang.Runtime`.
> Also includes adjustments to related areas in `addShutdownHook`, `halt`, and
> in the `System` and `Thread` classes. The changes here sho
On Fri, 26 Aug 2022 21:48:19 GMT, Bill Huang wrote:
>> Provided coverage for XPath operators. Operators include:
>> * Boolean operators: or, and, =, !=, <, <=, >, >=
>> * Number operators: +, -, *, div, mod
>> * Union operator: |
>
> Bill Huang has updated the pull request incrementally with one
On Wed, 3 Aug 2022 17:14:13 GMT, Brian Burkhalter wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> Brian Burkhalter has updated the
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
> Provided coverage for XPath operators. Operators include:
> * Boolean operators: or, and, =, !=, <, <=, >, >=
> * Number operators: +, -, *, div, mod
> * Union operator: |
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
Implemented re
On Fri, 26 Aug 2022 20:57:05 GMT, Stuart Marks wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverting the fix to BreakIterator.isBoundary()
>
> src/java.base/share/classes/java/text/BreakIterator.java line 107:
>
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has also been drafted, as there will be behavioral changes
On 26/08/2022 18:54, Ethan McCue wrote:
If the collections would decide whether or not to copy, I don't think
just requesting an immutable reference would be enough.
static List listCopy(Collection coll) {
if (coll instanceof List12 || (coll instanceof ListN && !
((ListN)coll).al
On Fri, 26 Aug 2022 18:12:04 GMT, Naoto Sato wrote:
>> This is to enhance the character break analysis in `java.text.BreakIterator`
>> to conform to the extended grapheme cluster boundaries defined in
>> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
>> corresponding CSR
> Currently some operations of RandomAccessFile are implemented with multiple
> read() invocations:
>
> public final int readInt() throws IOException {
> int ch1 = this.read();
> int ch2 = this.read();
> int ch3 = this.read();
> int ch4 = this.read();
> if ((ch1 | ch2 | ch3 |
On Fri, 26 Aug 2022 10:36:41 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Fri, 26 Aug 2022 16:48:03 GMT, Bill Huang wrote:
> Provided coverage for XPath operators. Operators include:
> * Boolean operators: or, and, =, !=, <, <=, >, >=
> * Number operators: +, -, *, div, mod
> * Union operator: |
Looks good. A few minor comments below.
test/jaxp/javax/xml/jaxp/unit
CleanerTest is failing intermittently on Aarch64, with -Xcomp, and using a
VirtualThread for the Cleaner in the test.
The extensively relies on references processing and invokes GC on a very short
cycle.
The existing 10ms delay between GC requests is too short for the changes to
reference states
On Wed, 17 Aug 2022 15:31:14 GMT, Roger Riggs wrote:
> Revised test to check and close all of the streams used in the pipeline.
>
> The test now checks the content length and closes each stdout and stderr
> stream.
>
> The previous technique to redirect stderr to stdout was ineffective because
On Fri, 26 Aug 2022 07:26:46 GMT, Ichiroh Takiguchi
wrote:
> After `test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java` testcase was
> integrated, it failed on the AIX platform.
>
> Error output
>
> STDERR:
> stdout: [];
> stderr: [Exception in thread "main" java.lang.RuntimeException: Got
On Fri, 26 Aug 2022 17:02:36 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/native/libjava/io_util.c line 82:
>>
>>> 80:((*(buf + 1) & 0xFF) << 16) +
>>> 81:((*(buf + 2) & 0xFF) << 8) +
>>> 82:((*(buf + 3) & 0xFF));
>>
>> What if the native byt
> Currently some operations of RandomAccessFile are implemented with multiple
> read() invocations:
>
> public final int readInt() throws IOException {
> int ch1 = this.read();
> int ch2 = this.read();
> int ch3 = this.read();
> int ch4 = this.read();
> if ((ch1 | ch2 | ch3 |
On Fri, 26 Aug 2022 18:12:04 GMT, Naoto Sato wrote:
>> This is to enhance the character break analysis in `java.text.BreakIterator`
>> to conform to the extended grapheme cluster boundaries defined in
>> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
>> corresponding CSR
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has also been drafted, as there will be behavioral changes
On Fri, 26 Aug 2022 16:39:01 GMT, Brian Burkhalter wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8292937: Move logic into VM side
>
> src/java.base/share/native/libjava/io_util.c line 82:
>
>> 80:
> Currently some operations of RandomAccessFile are implemented with multiple
> read() invocations:
>
> public final int readInt() throws IOException {
> int ch1 = this.read();
> int ch2 = this.read();
> int ch3 = this.read();
> int ch4 = this.read();
> if ((ch1 | ch2 | ch3 |
Provided coverage for XPath operators. Operators include:
* Boolean operators: or, and, =, !=, <, <=, >, >=
* Number operators: +, -, *, div, mod
* Union operator: |
-
Commit messages:
- Created XPathOperatorExpTest.java
Changes: https://git.openjdk.org/jdk/pull/10047/files
Webrev:
If the collections would decide whether or not to copy, I don't think just
requesting an immutable reference would be enough.
static List listCopy(Collection coll) {
if (coll instanceof List12 || (coll instanceof ListN && !
((ListN)coll).allowNulls)) {
return (List)coll;
On Fri, 26 Aug 2022 12:10:58 GMT, Сергей Цыпанов wrote:
>> Currently some operations of RandomAccessFile are implemented with multiple
>> read() invocations:
>>
>> public final int readInt() throws IOException {
>> int ch1 = this.read();
>> int ch2 = this.read();
>> int ch3 = this.r
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has also been drafted, as there will be behavioral changes
On Fri, 26 Aug 2022 15:06:16 GMT, Aleksey Shipilev wrote:
>> Look at implementation and figure out what happens if you do:
>>
>>
>> computeHash("SHA-1") = someHash;
>> computeHash("SHA-256") = ...?
>>
>>
>> The caching method should actually check the algorithms match.
>>
>> Not a bug at t
On Thu, 25 Aug 2022 09:50:44 GMT, Jonathan Dowland wrote:
> When the container memory exceeds the physical host's memory, the Java
> metrics reporting is wrong.
>
> https://bugs.openjdk.org/browse/JDK-8292541
>
> This is the equivalent core-libs fix for Hotspot's
> [JDK-8292083](https://bugs.
On Fri, 26 Aug 2022 15:06:16 GMT, Aleksey Shipilev wrote:
>> Look at implementation and figure out what happens if you do:
>>
>>
>> computeHash("SHA-1") = someHash;
>> computeHash("SHA-256") = ...?
>>
>>
>> The caching method should actually check the algorithms match.
>>
>> Not a bug at t
On 24/08/2022 15:38, Ethan McCue wrote:
A use case that doesn't cover is adding to a collection.
Say as part of a method's contract you state that you take ownership
of a List. You aren't going to copy even if the list is mutable.
Later on, you may want to add to the list. Add is supported on
On Fri, 26 Aug 2022 14:54:22 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line
> 69:
>
>> 67:
> Look at implementation and figure out what happens if you do:
>
>
> computeHash("SHA-1") = someHash;
> computeHash("SHA-256") = ...?
>
>
> The caching method should actually check the algorithms match.
>
> Not a bug at this point, since only use SHA-256 today, but this is a landmine
> rea
On Fri, 26 Aug 2022 14:23:04 GMT, Aleksey Shipilev wrote:
>> Look at implementation and figure out what happens if you do:
>>
>>
>> computeHash("SHA-1") = someHash;
>> computeHash("SHA-256") = ...?
>>
>>
>> The caching method should actually check the algorithms match.
>>
>> Not a bug at t
All trivial collection operations scream stream api and all stream api
operations imply a full copy or at least a full scan.
> so having trouble to write this kind of code is more a feature than an
issue :)
I love all Java code equally
On Wed, Aug 24, 2022 at 11:21 AM wrote:
>
>
>
On Fri, 26 Aug 2022 14:33:33 GMT, Alan Bateman wrote:
> Can you make sure that you run all jar, jmod and jlink tests? Module hashes
> are generated at packaging time, then checked when generating the
> configuration in early startup.
`java/util/jar`, `jdk/tools/jmod`, `jdk/tools/jlink` -- all
On Fri, 26 Aug 2022 14:23:04 GMT, Aleksey Shipilev wrote:
>> Look at implementation and figure out what happens if you do:
>>
>>
>> computeHash("SHA-1") = someHash;
>> computeHash("SHA-256") = ...?
>>
>>
>> The caching method should actually check the algorithms match.
>>
>> Not a bug at t
On Fri, 26 Aug 2022 14:06:21 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line
> 75:
>
>> 73:
On Fri, 26 Aug 2022 14:14:12 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Touchups
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line
> 70:
>
>> 68: //
> Look at implementation and figure out what happens if you do:
>
>
> computeHash("SHA-1") = someHash;
> computeHash("SHA-256") = ...?
>
>
> The caching method should actually check the algorithms match.
>
> Not a bug at this point, since only use SHA-256 today, but this is a landmine
> rea
On Fri, 26 Aug 2022 14:06:30 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Touchups
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line
> 154:
>
>> 152:
On Fri, 26 Aug 2022 14:14:13 GMT, Aleksey Shipilev wrote:
>> Look at implementation and figure out what happens if you do:
>>
>>
>> computeHash("SHA-1") = someHash;
>> computeHash("SHA-256") = ...?
>>
>>
>> The caching method should actually check the algorithms match.
>>
>> Not a bug at t
> Look at implementation and figure out what happens if you do:
>
>
> computeHash("SHA-1") = someHash;
> computeHash("SHA-256") = ...?
>
>
> The caching method should actually check the algorithms match.
>
> Not a bug at this point, since only use SHA-256 today, but this is a landmine
> rea
On Fri, 26 Aug 2022 14:06:16 GMT, Jonathan Dowland wrote:
>> When the container memory exceeds the physical host's memory, the Java
>> metrics reporting is wrong.
>>
>> https://bugs.openjdk.org/browse/JDK-8292541
>>
>> This is the equivalent core-libs fix for Hotspot's
>> [JDK-8292083](https:
On Fri, 26 Aug 2022 13:32:35 GMT, Severin Gehwolf wrote:
>> Jonathan Dowland has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains ten commits:
>>
>> - Rework testContainerMemExceedsPhysical to use common hostMaxMem
>>
>>For 82
> When the container memory exceeds the physical host's memory, the Java
> metrics reporting is wrong.
>
> https://bugs.openjdk.org/browse/JDK-8292541
>
> This is the equivalent core-libs fix for Hotspot's
> [JDK-8292083](https://bugs.openjdk.org/browse/JDK-8292083)
> (https://github.com/openjd
Look at implementation and figure out what happens if you do:
computeHash("SHA-1") = someHash;
computeHash("SHA-256") = ...?
The caching method should actually check the algorithms match.
Does not seem to be a problem at this point, since we seem to be only calling
that methods with "SHA-25
On Fri, 26 Aug 2022 13:20:58 GMT, Jonathan Dowland wrote:
>> When the container memory exceeds the physical host's memory, the Java
>> metrics reporting is wrong.
>>
>> https://bugs.openjdk.org/browse/JDK-8292541
>>
>> This is the equivalent core-libs fix for Hotspot's
>> [JDK-8292083](https:
On Fri, 26 Aug 2022 12:56:50 GMT, Alan Bateman wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8292937: Move logic into VM side
>
> src/java.base/share/native/libjava/io_util.c line 71:
>
>> 69: jint nread =
> When the container memory exceeds the physical host's memory, the Java
> metrics reporting is wrong.
>
> https://bugs.openjdk.org/browse/JDK-8292541
>
> This is the equivalent core-libs fix for Hotspot's
> [JDK-8292083](https://bugs.openjdk.org/browse/JDK-8292083)
> (https://github.com/openjd
On Thu, 25 Aug 2022 16:15:53 GMT, Jonathan Dowland wrote:
>> When the container memory exceeds the physical host's memory, the Java
>> metrics reporting is wrong.
>>
>> https://bugs.openjdk.org/browse/JDK-8292541
>>
>> This is the equivalent core-libs fix for Hotspot's
>> [JDK-8292083](https:
On Fri, 26 Aug 2022 12:10:58 GMT, Сергей Цыпанов wrote:
>> Currently some operations of RandomAccessFile are implemented with multiple
>> read() invocations:
>>
>> public final int readInt() throws IOException {
>> int ch1 = this.read();
>> int ch2 = this.read();
>> int ch3 = this.r
On Fri, 26 Aug 2022 01:49:06 GMT, Quan Anh Mai wrote:
>>> Maybe you can modify the read0 method to receive a width parameter
>>> additionally.
>>
>> @merykitty sorry, I don't get it. We already have `readBytes0()` returning
>> array. Why do we need to add a new param to `read0`?
>
> @stsypanov
> Currently some operations of RandomAccessFile are implemented with multiple
> read() invocations:
>
> public final int readInt() throws IOException {
> int ch1 = this.read();
> int ch2 = this.read();
> int ch3 = this.read();
> int ch4 = this.read();
> if ((ch1 | ch2 | ch3 |
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Fri, 26 Aug 2022 09:46:16 GMT, Severin Gehwolf wrote:
>> Jonathan Dowland has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a log-line for total physical memory
>>
>> This is relied upon for tests in
>> test/hotspot/jtreg/con
On Thu, 25 Aug 2022 16:15:53 GMT, Jonathan Dowland wrote:
>> When the container memory exceeds the physical host's memory, the Java
>> metrics reporting is wrong.
>>
>> https://bugs.openjdk.org/browse/JDK-8292541
>>
>> This is the equivalent core-libs fix for Hotspot's
>> [JDK-8292083](https:
On Wed, 6 Jul 2022 14:05:39 GMT, Ichiroh Takiguchi
wrote:
> OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and
> DBCS Only charsets.
> |Charset|Mix|SBCS|DBCS|
> | -- | -- | -- | -- |
> | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 |
> | Korean | Cp933 | Cp833 | Cp
After `test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java` testcase was
integrated, it failed on the AIX platform.
Error output
STDERR:
stdout: [];
stderr: [Exception in thread "main" java.lang.RuntimeException: Got unexpected
timezone information: Thu Aug 25 09:29:10 CEST 2022
at Cu
On Mon, 8 Aug 2022 09:22:32 GMT, Alan Bateman wrote:
>> Hello @AlanBateman .
>> Sorry I'm late.
>> I got some responses from ICU.
>> [ICU-22091](https://unicode-org.atlassian.net/browse/ICU-22091)
>> I'm not sure if they're interested in the new charset...
>>
>> As you know `sun.nio.cs.ArrayDec
63 matches
Mail list logo
