Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-21 Thread Alan Bateman
On Sun, 21 Aug 2022 23:19:16 GMT, Naoto Sato wrote: >> Fixing incorrect state handling with EOF in `StreamDecoder`. There's a >> `reset()` call to the decoder seeing the EOF before the last `decode()` >> operation to handle the state correctly. Removing the call should not affect >> other case

Re: RFR: 8291118: [vectorapi] Optimize the implementation of lanewise FIRST_NONZERO

2022-08-21 Thread Xiaohong Gong
On Wed, 17 Aug 2022 15:16:24 GMT, Paul Sandoz wrote: >>> Looks good. >> >> Thanks for looking at this patch @PaulSandoz ! >> >>> Much better to flip the operation and the receiver + first arg to the blend. >> >> I'm not quite understand what the flip operation here mean. The current code >>

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-21 Thread Naoto Sato
On Sat, 20 Aug 2022 08:03:55 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified the test per review suggestion > > test/jdk/java/io/InputStreamReader/StatefulDecoderNearEOF.java line 53: > >>

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-21 Thread Naoto Sato
> Fixing incorrect state handling with EOF in `StreamDecoder`. There's a > `reset()` call to the decoder seeing the EOF before the last `decode()` > operation to handle the state correctly. Removing the call should not affect > other cases because `reset()` is issued down the execution. Naoto S

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v16]

2022-08-21 Thread Laurent Bourgès
On Tue, 2 Aug 2022 13:57:03 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javado

Re: RFR: 8292698: Improve performance of DataInputStream [v3]

2022-08-21 Thread Сергей Цыпанов
> I found out that reading from `DataInputStream` wrapping > `ByteArrayInputStream` (as well as `BufferedInputStream` or any `InputStream` > relying on `byte[]`) can be significantly improved by accessing volatile `in` > field only once per operation. > > Current implementation does it for each

Re: RFR: 8290300: Use standard String-joining tools where applicable [v5]

2022-08-21 Thread Сергей Цыпанов
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote: >> Simplify code with `String.join()` > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8290300: Revert erroneous changes Thanks! - PR: https://git.open

Integrated: 8290300: Use standard String-joining tools where applicable

2022-08-21 Thread Сергей Цыпанов
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote: > Simplify code with `String.join()` This pull request has now been integrated. Changeset: 9a65524e Author:Sergey Tsypanov Committer: Claes Redestad URL: https://git.openjdk.org/jdk/commit/9a65524e2f98c1b4e253dcb637a708cec7b59

Re: RFR: 8290300: Use standard String-joining tools where applicable [v5]

2022-08-21 Thread Сергей Цыпанов
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote: >> Simplify code with `String.join()` > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8290300: Revert erroneous changes Anyone to sponsor? - PR: https

Re: RFR: 8292698: Improve performance of DataInputStream [v2]

2022-08-21 Thread Сергей Цыпанов
> I found out that reading from `DataInputStream` wrapping > `ByteArrayInputStream` (as well as `BufferedInputStream` or any `InputStream` > relying on `byte[]`) can be significantly improved by accessing volatile `in` > field only once per operation. > > Current implementation does it for each

Re: RFR: 8292698: Improve performance of DataInputStream

2022-08-21 Thread Сергей Цыпанов
On Sun, 21 Aug 2022 06:29:43 GMT, Сергей Цыпанов wrote: > I found out that reading from `DataInputStream` wrapping > `ByteArrayInputStream` (as well as `BufferedInputStream` or any `InputStream` > relying on `byte[]`) can be significantly improved by accessing volatile `in` > field only once p

Re: RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v4]

2022-08-21 Thread Fei Yang
On Fri, 19 Aug 2022 18:14:16 GMT, Aleksey Shipilev wrote: >> We have a few reports that existing Weak* VarHandle tests are still flaky, >> for example on large AArch64 machines or small RISC-V machines. >> >> The flakiness is intrinsic to the nature of Weak* operations under tests, >> that can

Re: RFR: 8292698: Improve performance of DataInputStream

2022-08-21 Thread Alan Bateman
On Sun, 21 Aug 2022 06:29:43 GMT, Сергей Цыпанов wrote: > I found out that reading from `DataInputStream` wrapping > `ByteArrayInputStream` (as well as `BufferedInputStream` or any `InputStream` > relying on `byte[]`) can be significantly improved by accessing volatile `in` > field only once p