Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v2]

2022-08-19 Thread Daniel D . Daugherty
> Split the java/util/stream/SpinedBufferTest.java test into two parts: > - java/util/stream/SpinedBufferTest1.java has the first 6 test cases > - java/util/stream/SpinedBufferTes2.java has the second 6 test cases > > I couldn't figure out a way to set a larger timeout value for the entirety > of

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-19 Thread Daniel D . Daugherty
On Fri, 12 Aug 2022 23:44:26 GMT, Jie Fu wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testing run. >> >> The usual Mach5 timeoutFactor is 4.0 w

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-19 Thread Jaikiran Pai
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Looks fine to me. - Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8276651: java/lang/ProcessHandle/InfoTest.java failed with "RuntimeException: Input/output error"

2022-08-19 Thread Jaikiran Pai
On Fri, 19 Aug 2022 17:05:38 GMT, Roger Riggs wrote: > On Mac OS X on aarch64, the timing of the sysctl vs the process life (pid) > can be such that the sysctl returns EIO. > The native implementation is modified to treat EIO the same as EINVAL, > leaving the information to be returned empty. >

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms" [v2]

2022-08-19 Thread Jie Fu
On Fri, 19 Aug 2022 19:48:24 GMT, Daniel D. Daugherty wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testing run. >> >> The usual Mach5 timeoutF

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-19 Thread Alex Menkov
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8292316: Tests should not rely on specific JAR file names (jpackage)

2022-08-19 Thread Alexander Matveev
On Fri, 19 Aug 2022 15:41:47 GMT, Alexey Semenyuk wrote: > Get rid of dependencies on specific jtreg's jars from jpackage junit tests. > > The troublesome statement was `* @library ${jtreg.home}/lib/junit.jar > ${jtreg.home}/lib/hamcrest.jar` in "junit.java". The fix removes "junit.java" > and

Re: RFR: 8292623: Reduce runtime of java.io microbenchmarks

2022-08-19 Thread Roger Riggs
On Fri, 19 Aug 2022 14:16:32 GMT, Eric Caspole wrote: > These changes reduce the run time from about 3h15m to about 2h5m. LGTM - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.org/jdk/pull/9942

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

2022-08-19 Thread Joe Wang
On Fri, 19 Aug 2022 16:32:02 GMT, Naoto Sato wrote: > Fixing incorrect state handling with EOF in `StreamDecoder`. There's a > `reset()` call to the decoder seeing the EOF before the last `decode()` > operation to handle the state correctly. Removing the call should not affect > other cases be

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-19 Thread Daniel D . Daugherty
On Fri, 19 Aug 2022 12:57:38 GMT, Aleksey Shipilev wrote: >> Split the java/util/stream/SpinedBufferTest.java test into two parts: >> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases >> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases >> >> I couldn't figu

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-19 Thread Daniel D . Daugherty
On Tue, 16 Aug 2022 16:45:03 GMT, Paul Sandoz wrote: >> Split the java/util/stream/SpinedBufferTest.java test into two parts: >> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases >> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases >> >> I couldn't figure ou

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms" [v2]

2022-08-19 Thread Daniel D . Daugherty
On Fri, 19 Aug 2022 19:48:24 GMT, Daniel D. Daugherty wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testing run. >> >> The usual Mach5 timeoutF

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms" [v2]

2022-08-19 Thread Daniel D . Daugherty
> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG > setting > when waiting for a compilation to finish. > > This fix is being tested in my jdk-20+10 stress testing run. > > The usual Mach5 timeoutFactor is 4.0 with slower configurations using a > timeoutFactor > of 1

Re: RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v4]

2022-08-19 Thread Aleksey Shipilev
> We have a few reports that existing Weak* VarHandle tests are still flaky, > for example on large AArch64 machines or small RISC-V machines. > > The flakiness is intrinsic to the nature of Weak* operations under tests, > that can spuriously fail. The last attempt to fix these was > [JDK-81557

RFR: 8276651: java/lang/ProcessHandle/InfoTest.java failed with "RuntimeException: Input/output error"

2022-08-19 Thread Roger Riggs
On Mac OS X on aarch64, the timing of the sysctl vs the process life (pid) can be such that the sysctl returns EIO. The native implementation is modified to treat EIO the same as EINVAL, leaving the information to be returned empty. Several tests in java/lang/ProcessHandle failed with the same c

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v6]

2022-08-19 Thread Raffaello Giulietti
On Wed, 25 May 2022 09:40:42 GMT, Raffaello Giulietti wrote: >> Add a family of "safe" cast methods. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8279986: methods Math::asXExact for safely checked primitive casts

Re: RFR: 8205592: BigDecimal.doubleValue() is depressingly slow

2022-08-19 Thread Raffaello Giulietti
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote: > A reimplementation of `BigDecimal.[double|float]Value()` to enhance > performance, avoiding an intermediate string and its subsequent parsing on > the slow path. keep open - PR: https://git.openjdk.org/jdk/pull/9410

RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

2022-08-19 Thread Naoto Sato
Fixing incorrect state handling with EOF in `StreamDecoder`. There's a `reset()` call to the decoder seeing the EOF before the last `decode()` operation to handle the state correctly. Removing the call should not affect other cases because `reset()` is issued down the execution. -

Integrated: JDK-8292576: Improve wording of AccessFlag-related specs

2022-08-19 Thread Joe Darcy
On Thu, 18 Aug 2022 05:05:33 GMT, Joe Darcy wrote: > Spec refinement, including acting on some feedback received for JDK-8266670: > > https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 This pull request has now been integrated. Changeset: 58aae340 Author:Joe Darcy URL:

RFR: 8292316: Tests should not rely on specific JAR file names (jpackage)

2022-08-19 Thread Alexey Semenyuk
Get rid of dependencies on specific jtreg's jars from jpackage junit tests. The troublesome statement was `* @library ${jtreg.home}/lib/junit.jar ${jtreg.home}/lib/hamcrest.jar` in "junit.java". The fix removes "junit.java" and the corresponding "run_junit.sh" file and adds jtreg test declaratio

RFR: 8292623: Reduce runtime of java.io microbenchmarks

2022-08-19 Thread Eric Caspole
These changes reduce the run time from about 3h15m to about 2h5m. - Commit messages: - 8292623: Reduce runtime of java.io microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9942/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9942&range=00 Issue: https://bugs.openjd

Re: RFR: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected [v4]

2022-08-19 Thread Alan Bateman
On Thu, 18 Aug 2022 19:29:05 GMT, Roger Riggs wrote: >> Revised test to check and close all of the streams used in the pipeline. >> >> The test now checks the content length and closes each stdout and stderr >> stream. >> >> The previous technique to redirect stderr to stdout was ineffective b

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-19 Thread Aleksey Shipilev
On Thu, 11 Aug 2022 20:09:06 GMT, Daniel D. Daugherty wrote: > Split the java/util/stream/SpinedBufferTest.java test into two parts: > - java/util/stream/SpinedBufferTest1.java has the first 6 test cases > - java/util/stream/SpinedBufferTes2.java has the second 6 test cases > > I couldn't figur

Integrated: 8289562: Change bugs.java.com and bugreport.java.com URL's to https

2022-08-19 Thread Joe
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote: > 8289562: Change bugs.java.com and bugreport.java.com URL's to https This pull request has now been integrated. Changeset: 1f484dae Author:Joe Committer: Fairoz Matte URL: https://git.openjdk.org/jdk/commit/1f484dae4efaa60cf18a3d4df947c

Re: RFR: JDK-8292576: Improve wording of AccessFlag-related specs [v2]

2022-08-19 Thread Alan Bateman
On Thu, 18 Aug 2022 22:44:53 GMT, Joe Darcy wrote: >> Spec refinement, including acting on some feedback received for JDK-8266670: >> >> https://github.com/openjdk/jdk/pull/7445#discussion_r906846794 > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase.

Re: RFR: 8289562: Change bugs.java.com and bugreport.java.com URL's to https [v2]

2022-08-19 Thread Joe
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https Joe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since