On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote:
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a
> defined, but empty macro in libjli if it is not defined in the build system,
> which is incorrect
Merged with latest, currently awaiting further review and/or sponso
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a
> defined, but empty macro in libjli if it is not defined in the build system,
> which is incorrect
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exclud
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
JLI_ReportErrorMessageSys has a number of issues, as listed below:
- The windows variant prints message, then extra-info if available, but the
Unix variant prints first extra-info, then message on a newline. Standardize
both to print their system errors on newlines below the message.
- The Wind
On Sat, 6 Aug 2022 00:42:23 GMT, Stuart Marks wrote:
>> Initial edits to addShutdownHook from Alex.
>>
>> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> More
On Mon, 8 Aug 2022 02:34:08 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 104:
>>
>>> 102: * The shutdown sequence begins
>>> when all started
>>> 103: * non-daemon threads have terminated. Unstarted non-daemon threads do
>>> not prevent
>>> 104: * the s
On Sat, 6 Aug 2022 08:11:53 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Thread.java line 73:
>
>> 71: * or if it
On Fri, 5 Aug 2022 16:44:37 GMT, Naoto Sato wrote:
>> To support Windows command prompt's codepage, following charsets should be
>> moved from jdk.charsets module to java.base module.
>>
>> - IBM860
>> - IBM861
>> - IBM863
>> - IBM864
>> - IBM865
>> - IBM869
>
> Hi @takiguc,
> I am not quite su
On Thu, 7 Jul 2022 09:47:25 GMT, Alan Bateman wrote:
>> And also there is no reason why db drivers or host connectors should not
>> ship their own charset support \(Oracle JDBC for example had nls\_charset
>> addons\. My employer also ship a custom EBCDIC encoding which includes some
>> compat
Hi Patrick,
On 6/08/2022 7:05 pm, Patrick Pfeifer wrote:
On Mon, 18 Jul 2022 15:22:01 GMT, Jonathan Gibbons wrote:
Please review these changes to the nroff manpage files so that they match their
markdown sources that Oracle maintains.
Not a problem with this PR as such, but we still have a
On Sat, 6 Aug 2022 16:45:06 GMT, Julian Waters wrote:
>> Please review a small patch for dumping the failure reason when the MSVCRT
>> libraries or the Java Virtual Machine fails to load on Windows, which can
>> provide invaluable insight when debugging related launcher issues. This also
>> fi
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Sun, 7 Aug 2022 06:10:21 GMT, Julian Waters wrote:
> Nothing I could find in the tests that suggest they use this message as
> input, and none of them have failed with this patch, so I guess that's a good
> thing? :P
Oh, that is fine :) Thanks for looking. I just mentioned it since you are
On Sun, 7 Aug 2022 07:47:04 GMT, Thomas Stuefe wrote:
> If you open bugs like this, it is always helpful to be precise, and possibly
> append failing output (e.g. in this case the output of DLL load errors).
I agree, I think it would be useful to provide a summary where the launcher
fails and
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Sun, 7 Aug 2022 06:10:21 GMT, Julian Waters wrote:
> I don't quite get what you mean by that, should I revert the changes made to
> the freeit checks?
I looked over this function and found a number of issues with it. I created
https://bugs.openjdk.org/browse/JDK-8292016 to track those (if y
22 matches
Mail list logo
