> Initial edits to addShutdownHook from Alex.
>
> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
More edits from Alex's suggestions.
-
Changes:
- all: h
On Fri, 5 Aug 2022 22:52:10 GMT, Smita Kamath wrote:
>> src/hotspot/share/runtime/sharedRuntime.cpp line 450:
>>
>>> 448: JRT_END
>>> 449:
>>> 450: JRT_LEAF(jshort, SharedRuntime::f2hf(jfloat x))
>>
>> Is it necessary/desirable to have a transliteration of the Java
>> implementation here rat
On Fri, 5 Aug 2022 22:15:37 GMT, Joe Darcy wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 450:
>
>> 448: JRT_END
>> 449:
>> 450: JRT_LEAF(jshort, SharedRuntime::f2hf(jfloat x
On Fri, 5 Aug 2022 21:58:40 GMT, Vladimir Kozlov wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Please add JMH microbenchmark and show results.
@vnkozlov Thank you for your comment. I will add a jmh test case.
-
On Fri, 5 Aug 2022 22:29:00 GMT, David Holmes wrote:
> Forward port JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 87cda21c
Author:David Holmes
URL:
https://git.openjdk.org/jdk/commit/87cda21c5d85f6e6f628849b8670e2ecb4e105dd
Stats: 99 lines in 2 files cha
Forward port JDK 19 -> JDK 20
-
Commit messages:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
The webrevs contain the adjustments done while merging with regards to each
parent branch
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
src/hotspot/share/runtime/sharedRuntime.cpp line 450:
> 448: JRT_END
> 449:
> 450: JRT_LEAF(jshort, SharedRuntime::f2hf(jfloat x))
Is
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Please add JMH microbenchmark and show results.
-
Changes requested by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull
On Fri, 5 Aug 2022 20:20:56 GMT, Remi Forax wrote:
> You only need restart index at the beginning and after a when, so in your
> example, only 0 and 1 are required, you can skip the generation of 2 because
> you will never restart at 2.
>
The bootstrap protocol does not specify which cases ha
On Thu, 4 Aug 2022 09:52:55 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updates after conversation with Alan:
>> - specify that starting a shutdown hook explicitly has an unspecified
>>
On Thu, 4 Aug 2022 10:00:58 GMT, Alan Bateman wrote:
>> Alex and I discussed this and we felt that it was important to call out all
>> three "kinds" of threads explicitly. Earlier versions of the text implied
>> that no non-daemon threads were running at the time the VM terminated, which
>> mi
> Initial edits to addShutdownHook from Alex.
>
> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
More updates after discussion with Alex.
-
Changes:
- a
slam dunk argument for changing that API to use lambda expressions
I think you misunderstood me, I am not arguing that the API should change,
I am saying that enforced try-with-resources is very relevant to almost all
“structured-API”s, and there should be work on it moving forward.
I wrote a sim
> Improve test coverage for XPath functions:
> [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836),
> [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837),
> [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838).
Bill Huang has updated the pull request incrementally with one a
- Original Message -
> From: "Jan Lahoda"
> To: "core-libs-dev"
> Sent: Friday, August 5, 2022 6:22:48 PM
> Subject: RFR: 8291966: SwitchBootstrap.typeSwitch could be faster
> The pattern matching switches are using a bootstrap method
> `SwitchBootstrap.typeSwitch` to implement the jumps
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Hi All,
This change is to provide intrinsic implementation for conversion between
floats and half precision floating point formats.
Kind
8289552: Make intrinsic conversions between bit representations of half
precision values and floats
-
Commit messages:
- Intrinsic conversions between halffloat and floats
Changes: https://git.openjdk.org/jdk/pull/9781/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9781&ra
On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n values
On Thu, 4 Aug 2022 20:30:00 GMT, Alexey Semenyuk wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reg method access, drop l10n entries, label check enhancement
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Win
On Thu, 4 Aug 2022 18:10:18 GMT, Alex Kasko wrote:
> This change adds `ContextMenuCommandLabel` l10n property for file association
> context menu label. It is a follow-up to [this PR
> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>
> Note, non-EN l10n values were
> This change adds `ContextMenuCommandLabel` l10n property for file association
> context menu label. It is a follow-up to [this PR
> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>
> Note, non-EN l10n values were filled using auto-translator and may need to be
> c
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi
wrote:
> To support Windows command prompt's codepage, following charsets should be
> moved from jdk.charsets module to java.base module.
>
> - IBM860
> - IBM861
> - IBM863
> - IBM864
> - IBM865
> - IBM869
Hi @takiguc,
I am not quite sure wha
This change is a follow-up to [this
comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
Override implementation is based on [this
comment](https://bugs.openjdk.org/browse/JDK-82905
The pattern matching switches are using a bootstrap method
`SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically,
for a switch like:
switch (obj) {
case String s when s.isEmpty() -> {}
case String s -> {}
case CharSequence cs -> {}
...
}
this method will
On Mon, 1 Aug 2022 06:51:44 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
Marked as reviewed by bpb (Reviewer).
--
On Mon, 20 Jun 2022 10:47:35 GMT, Claes Redestad wrote:
> - Refactor so that various baseline micros are not run repeatedly with
> different parameter values that does not affect the baseline
> - Tune iteration times, counts, forks..
>
> Reduces runtime of java.util.concurrent micros from an es
On Mon, 1 Aug 2022 06:51:44 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
Marked as reviewed by rriggs (Reviewer).
---
On 04/08/2022 20:35, Holo The Sage Wolf wrote:
||
Some implementations of |Collection| that will always fail, some will
always succeed, and some implementations (like |HashSet|) may be
non-deterministic.
For the uninformed this method makes sense, for each
|PartitiableAction| I create some ki
On Mon, 1 Aug 2022 06:51:44 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
Marked as reviewed by lancea (Reviewer).
---
On Fri, 5 Aug 2022 08:59:00 GMT, ScientificWare wrote:
>> This is tracked in JBS as
>>
>> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by
>> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070)
>>
>> Unused imports in DTDBuider.java.
>>
>>> **Remove unused i
On Thu, 4 Aug 2022 15:55:38 GMT, Alan Bateman wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused JLA, SharedSecrets, added @enablePreview test annotation
>
> test/jdk/jdk/internal/misc/TerminatingThread
> This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s)
> when used internally in JDK for per-carrier-thread caches of native
> ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such
> TerminatingThreadLocal(s) are not registered with the carrier thread for t
On Thu, 4 Aug 2022 15:54:29 GMT, Alan Bateman wrote:
>> This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s)
>> when used internally in JDK for per-carrier-thread caches of native
>> ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such
>> TerminatingThre
On Fri, 5 Aug 2022 07:56:40 GMT, Jaikiran Pai wrote:
>> Just waiting to be reviewed.
>
> Hello @scientificware, what you propose here, I think looks fine.
> Additionally can you also update the copyright years on this file from
> `Copyright (c) 1998, 2020,` to `Copyright (c) 1998, 2022,`?
>
>
> This is tracked in JBS as
>
> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by
> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070)
>
> Unused imports in DTDBuider.java.
>
>> **Remove unused imports from DTDBuilder.java**
>
> Some imports are no more used.
On Thu, 4 Aug 2022 06:25:27 GMT, ScientificWare wrote:
>> ScientificWare has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> com
On Mon, 1 Aug 2022 06:51:44 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
Looks good. The isEmpty was added in Java 11 so I
On Mon, 1 Aug 2022 06:51:44 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
The changes look fine to me.
-
Mark
I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
method.
It's makes code a bit easier to read.
Noticing negation before long chain of method calls is hard.
-
Commit messages:
- [PATCH] Use Optional.isEmpty instead of !Optional.isPresent in java.base
Change
39 matches
Mail list logo
