On Wed, 3 Aug 2022 10:21:43 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this patch to deflate.c which reverts an unintentional change
> that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
> undo (6), replaced withe the official zlib repo fix see#305/#f969409
>
On Wed, 6 Jul 2022 23:56:33 GMT, ScientificWare wrote:
>> This is tracked in JBS as
>>
>> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by
>> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070)
>>
>> Unused imports in DTDBuider.java.
>>
>>> **Remove unused i
On Wed, 3 Aug 2022 22:17:38 GMT, Peter Levart wrote:
>> This is a continuation of effort from
>> https://github.com/openjdk/jdk/pull/9533 to fix the ObjectStreamClassCaching
>> test which is failing with various GCs != G1. The test class contains 2 test
>> methods:
>> - test2CacheReleaseUnderM
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote:
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a
> defined, but empty macro in libjli if it is not defined in the build system,
> which is incorrect
Comment to keep thread alive
-
PR: https://git.openjd
> Initial edits to addShutdownHook from Alex.
>
> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Updates after conversation with Alan:
- specify that starting a shutd
On Wed, 3 Aug 2022 16:19:42 GMT, Alan Bateman wrote:
>> Initial edits to addShutdownHook from Alex.
>>
>> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
>
> src/java.base/share/classes/java/lang/Runtime.java line 79:
>
>> 77: * terminate the JVM via the {@link #halt halt} meth
On Fri, 29 Jul 2022 03:55:54 GMT, Xiaohong Gong wrote:
> Vector API binary op "`FIRST_NONZERO`" represents the vector operation of "`a
> != 0 ? a : b`", which can be implemented with existing APIs like "`compare +
> blend`". The current implementation is more complex especially for the
> float
On Fri, 29 Jul 2022 03:55:54 GMT, Xiaohong Gong wrote:
> Vector API binary op "`FIRST_NONZERO`" represents the vector operation of "`a
> != 0 ? a : b`", which can be implemented with existing APIs like "`compare +
> blend`". The current implementation is more complex especially for the
> float
On Fri, 29 Jul 2022 09:38:13 GMT, Aleksey Shipilev wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Nits from review comments
>
> test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java line 34:
>
>> 32:
On Wed, 3 Aug 2022 11:12:38 GMT, Aleksey Shipilev wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add SerialGC variant
>
> test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java line 2:
>
>> 1: /*
>> 2:
> This is a continuation of effort from
> https://github.com/openjdk/jdk/pull/9533 to fix the ObjectStreamClassCaching
> test which is failing with various GCs != G1. The test class contains 2 test
> methods:
> - test2CacheReleaseUnderMemoryPressure - this one was not logically changed
> at all
On Thu, 28 Jul 2022 16:11:12 GMT, Ao Qi wrote:
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and
> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`
> are added or modified by
> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-828
On Wed, 3 Aug 2022 02:34:48 GMT, Ao Qi wrote:
>> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and
>> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`
>> are added or modified by
>> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
On Wed, 3 Aug 2022 15:42:12 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/RandomAccessFile.java line 112:
>>
>>> 110: }
>>> 111:
>>> 112: int multiple = (len + MIN_BUFFER_SIZE - 1)/MIN_BUFFER_SIZE;
>>
>> isn't that equivalent `(len / MIN_BUFFER_SIZE) + 1`,
On Wed, 3 Aug 2022 13:55:04 GMT, Daniel Jeliński wrote:
> This patch fixes the test to use the same locale as the tested code
LGTM. Thanks for the fix!
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9729
On Fri, 8 Jul 2022 23:00:15 GMT, Stuart Marks wrote:
> Initial edits to addShutdownHook from Alex.
>
> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
src/java.base/share/classes/java/lang/Runtime.java line 69:
> 67: * and
> 68: * {@link #removeShutdownHook removeShutdownHook
These changes reduce the default run time from about 1 day 22 hours to about 6
hours with good stability we can use in weekly testing.
-
Commit messages:
- 8291828: Reduce runtime of java.util.stream microbenchmarks
Changes: https://git.openjdk.org/jdk/pull/9733/files
Webrev: http
On Wed, 3 Aug 2022 14:08:26 GMT, Ichiroh Takiguchi
wrote:
> I'm not sure if this change will solve the reporter's issue...
It does solve the submitter's issue. With this fix:
jshell> HexFormat.ofDelimiter(" ").formatHex("<%adc".getBytes("IBM864"))
$181 ==> "3c 25 61 64 63"
which is exactly th
On Wed, 3 Aug 2022 10:21:43 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this patch to deflate.c which reverts an unintentional change
> that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
> undo (6), replaced withe the official zlib repo fix see#305/#f969409
>
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote:
> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy
> came from the mapping difference between MS and IBM.
This pull request has now been integrated.
Changeset: e52a340d
Author:Naoto Sato
URL:
https://gi
On Wed, 3 Aug 2022 12:54:38 GMT, Daniel Fuchs wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commit
On Wed, 3 Aug 2022 10:21:43 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this patch to deflate.c which reverts an unintentional change
> that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
> undo (6), replaced withe the official zlib repo fix see#305/#f969409
>
Hi,
Please review this patch to deflate.c which reverts an unintentional change
that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
undo (6), replaced withe the official zlib repo fix see#305/#f969409
Mach5 tiers1-3 have been run without failure
-
Commit
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote:
> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy
> came from the mapping difference between MS and IBM.
I think you can ignore my comments.
I'm not sure if this change will solve the reporter's issue...
-
This patch fixes the test to use the same locale as the tested code
-
Commit messages:
- CustomZoneNameTest fails if default locale does not match defaultFormatLocale
Changes: https://git.openjdk.org/jdk/pull/9729/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9729&range=00
On Wed, 20 Jul 2022 23:41:04 GMT, Brian Burkhalter wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> Brian Burkhalter has updated the
On Wed, 3 Aug 2022 06:24:16 GMT, Peter Levart wrote:
>> This is a continuation of effort from
>> https://github.com/openjdk/jdk/pull/9533 to fix the ObjectStreamClassCaching
>> test which is failing with various GCs != G1. The test class contains 2 test
>> methods:
>> - test2CacheReleaseUnderM
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Changes to HttpURLConnection look good to me
On Wed, 3 Aug 2022 02:34:48 GMT, Ao Qi wrote:
>> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and
>> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`
>> are added or modified by
>> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-
On Wed, 3 Aug 2022 10:36:06 GMT, xpbob wrote:
>> Container configuration information is useful for troubleshooting
>> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
>> and other scenarios.
>> Results the following
>> 