On Sat, 30 Jul 2022 01:39:54 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Parse invalid fields correctly
>
> test/jdk/java/util/Locale/bcp47/TExtensionTests.java line 190:
>
>> 188: } catch
> This PR is to propose supporting the `T` extension to the BCP 47 to which
> `java.util.Locale` class conforms. There are two extensions to the BCP 47,
> one is `Unicode Locale Extension` which has been supported since JDK7, the
> other is this `Transformed Content` extension. A CSR has also be
On Tue, 26 Jul 2022 05:26:31 GMT, Stuart Marks wrote:
> Hans Boehm wrote:
>
> > I also have concerns about the use of fullFence here. I believe it should
> > be the case that reachabilityFence guarantees visibility of memory
> > operations program-ordered before the reachabilityFence(p) to the
On Sat, 30 Jul 2022 11:07:25 GMT, Peter Levart wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java
>> line 216:
>>
>>> 214: } finally {
>>> 215: // Ensure Cleaner does not run until after this method
>>> completes
>>> 216:
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Wed, 1 Jun 2022 21:40:43 GMT, Roger Riggs wrote:
> I don't think there is any benefit to the `try{} finally {fence}`. The
> reachabilityFence has no executable code. Its only purpose is to keep the
> reference in scope alive.
...reachability fence has no code, but puting it into finally blo
On Sat, 30 Jul 2022 07:44:11 GMT, David Holmes wrote:
>> Or, Can the VM do this traversal as/more efficiently than doing at the java
>> level?
>
> It is usual for the Java code to do such checks and throw exceptions, so that
> the VM assumes it is correct and only asserts incase something has b
On Fri, 29 Jul 2022 21:19:27 GMT, Roger Riggs wrote:
>> src/hotspot/share/prims/jvm.cpp line 4059:
>>
>>> 4057: return JVM_CLASSFILE_MAJOR_VERSION;
>>> 4058: }
>>> 4059: assert(!java_lang_Class::as_Klass(mirror)->is_array_klass(),
>>> "unexpected array class");
>>
>> Can this throw Ill
Forward port JDK 19 -> JDK 20
-
Commit messages:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8291512: Snippetize modules API examples
The webrevs contain the adjustments done while merging with regards to each
parent branch:
- master: https://webrevs.openjdk.
