Re: RFR: 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

On Fri, 29 Jul 2022 16:49:36 GMT, Roger Riggs wrote: > The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently, > usually associated with fastdebug and -Xcomp. > It reports extra file descriptors are open that not expected. > The test of pipelines did not explicitly use or cl

Integrated: 8290740: Catalog not used when the handler is null

On Fri, 29 Jul 2022 02:38:25 GMT, Joe Wang wrote: > Patch to make sure the Catalog is used even when the handler is null. This pull request has now been integrated. Changeset: 470c0eb2 Author:Joe Wang URL: https://git.openjdk.org/jdk/commit/470c0eb2163a62e5743aefe62c6725e92beea54d S

Re: RFR: 8290740: Catalog not used when the handler is null

On Fri, 29 Jul 2022 02:38:25 GMT, Joe Wang wrote: > Patch to make sure the Catalog is used even when the handler is null. Thanks all! - PR: https://git.openjdk.org/jdk/pull/9682

Re: RFR: 8289227: Support for BCP 47 Extension T - Transformed Content [v5]

On Fri, 29 Jul 2022 23:27:53 GMT, Naoto Sato wrote: >> This PR is to propose supporting the `T` extension to the BCP 47 to which >> `java.util.Locale` class conforms. There are two extensions to the BCP 47, >> one is `Unicode Locale Extension` which has been supported since JDK7, the >> other

Re: RFR: 8289227: Support for BCP 47 Extension T - Transformed Content [v5]

> This PR is to propose supporting the `T` extension to the BCP 47 to which > `java.util.Locale` class conforms. There are two extensions to the BCP 47, > one is `Unicode Locale Extension` which has been supported since JDK7, the > other is this `Transformed Content` extension. A CSR has also be

Re: RFR: 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

On Fri, 29 Jul 2022 21:43:30 GMT, Naoto Sato wrote: >> The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently, >> usually associated with fastdebug and -Xcomp. >> It reports extra file descriptors are open that not expected. >> The test of pipelines did not explicitly use or

Re: RFR: 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

On Fri, 29 Jul 2022 16:49:36 GMT, Roger Riggs wrote: > The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently, > usually associated with fastdebug and -Xcomp. > It reports extra file descriptors are open that not expected. > The test of pipelines did not explicitly use or cl

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 21:05:19 GMT, Roger Riggs wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> ra

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw

Re: Coupling in ExtentLocal

Hi. The difference between ExtentLocals and other TwR constructs is that we’d like to use it for critical, foundational, things where we want guarantees we can rely on, and we haven’t been able to find a way to guarantee them as well as we’d like with TwR, even dynamically. Yes, we are thinkin

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 18:12:22 GMT, Joe Darcy wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> raw

Re: RFR: 8290740: Catalog not used when the handler is null

On Fri, 29 Jul 2022 02:38:25 GMT, Joe Wang wrote: > Patch to make sure the Catalog is used even when the handler is null. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9682

Re: RFR: 8290740: Catalog not used when the handler is null

On Fri, 29 Jul 2022 02:38:25 GMT, Joe Wang wrote: > Patch to make sure the Catalog is used even when the handler is null. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9682

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable [v4]

On Thu, 28 Jul 2022 19:43:04 GMT, Gaurav Chaudhari wrote: >> This is a REDO of the Fix that was incompletely implemented earlier: >> [8285838: Fix for TZ environment variable DST >> rules](https://github.com/openjdk/jdk/pull/8660) >> >> Offset calculation now accounts all the way upto year in o

Re: RFR: 8291360: Create entry points to expose low-level class file information

On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v4]

> open l10n msg drop > All tests passed. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: added comments in CurrencyNames root in base, moved US CurrencyNames back to base, readded original Chinese translation - Changes:

RFR: 8291360: Create entry points to expose low-level class file information

Please review this change to fix JDK-8291360. This fix adds entry points getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. The new entry points return the current class's class file version and its raw access flags. The fix was tested by running Mach5 tiers 1-2 on L

Re: RFR: 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

On Fri, 29 Jul 2022 16:49:36 GMT, Roger Riggs wrote: > The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently, > usually associated with fastdebug and -Xcomp. > It reports extra file descriptors are open that not expected. > The test of pipelines did not explicitly use or cl

Re: RFR: 8290740: Catalog not used when the handler is null

On Fri, 29 Jul 2022 02:38:25 GMT, Joe Wang wrote: > Patch to make sure the Catalog is used even when the handler is null. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9682

RFR: 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently, usually associated with fastdebug and -Xcomp. It reports extra file descriptors are open that not expected. The test of pipelines did not explicitly use or close the stderr streams of each stream except the last. The int

Re: RFR: 8290488: IBM864 character encoding implementation bug

On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Sorry, but I don't have any intention to change the current roundtrip behavior of 0x25 <-> U+066A in Cp/IBM8

Re: RFR: 8290047: (fs) FileSystem.getPathMatcher does not check for ":" at last index [v3]

On Thu, 21 Jul 2022 19:58:50 GMT, Brian Burkhalter wrote: >> For a `String` “s”, `s.indexOf(int)` can never return a value `>= >> s.length()` so change the check >> >> int pos = syntaxAndInput.indexOf(':'); >> if (pos <= 0 || pos == syntaxAndInput.length()) >> >> to >> >>

Re: Coupling in ExtentLocal

Hi, Thanks for the response Kasper, the reason I sent the mail to core-libs is because JDK-8263012 is assigned to "core-libs". I added loom-devs to the chain. What Andrew Haley wrote is correct, it is also correct pretty much for every implementation

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Fri, 29 Jul 2022 09:05:53 GMT, Peter Levart wrote: > This is a continuation of effort from > https://github.com/openjdk/jdk/pull/9533 to fix the ObjectStreamClassCaching > test which is failing with various GCs != G1. The test class contains 2 test > methods: > - test2CacheReleaseUnderMemor

RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

This is a continuation of effort from https://github.com/openjdk/jdk/pull/9533 to fix the ObjectStreamClassCaching test which is failing with various GCs != G1. The test class contains 2 test methods: - test2CacheReleaseUnderMemoryPressure - this one was not logically changed at all - just one m

Re: Coupling in ExtentLocal

On Thu, 28 Jul 2022 at 22:11, Holo The Sage Wolf wrote: > I have a question about the proposal, why not allow try-with-resources > with this API? > Hi, For Loom related questions, loom-...@openjdk.org is probably a better fit. The main problem with TWR is that it cannot guard against non-nested