On Mon, 11 Jul 2022 12:41:48 GMT, Сергей Цыпанов wrote:
> `BigInteger.powerCache` is volatile and should be assigned only once in
> static initializer.
The change looks fine to me. Please wait for at least another review from
someone more familiar with this area, before merging.
-
On Mon, 11 Jul 2022 15:31:46 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As
On Mon, 11 Jul 2022 15:31:46 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As
On Mon, 11 Jul 2022 15:05:34 GMT, Maurizio Cimadamore
wrote:
> This patch fixes an issue where the arena allocator does not detect an
> overflow when attempting to allocate a new slice.
Marked as reviewed by psandoz (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/133
On Mon, 11 Jul 2022 14:45:42 GMT, Maurizio Cimadamore
wrote:
> The default implementation for `SegmentAllocator:allocateArray(MemoryLayout,
> count)` is missing a check for negative array size.
> In the past this used to be caught in the `SequenceLayout` factory, but not
> anymore, as now `Seq
On Mon, 11 Jul 2022 09:46:11 GMT, Maurizio Cimadamore
wrote:
> Some of the accessors in `MemorySegment` and `MemoryAddress` (esp. setters)
> have typos - e.g. they use `from` instead of `into`.
>
> I've tried to simplify the text and made it more regular.
Marked as reviewed by psandoz (Review
On Wed, 29 Jun 2022 21:32:29 GMT, Joe Darcy wrote:
>> JDK-8289106: Add model of class file versions to core reflection
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/
On Mon, 11 Jul 2022 15:07:28 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8287902](https://bugs.openjdk.org/browse/JDK-8287902), commit
> [975316e3](https://github.com/openjdk/jdk/commit/975316e3e5f1208e4e15eadc2493d25c15554647)
> from the [openjd
On Mon, 11 Jul 2022 15:31:46 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As
On Mon, 11 Jul 2022 12:38:11 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: c79baaa8
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/c79baaa811971c43fbdbc251482d0e40903588cc
Stats: 411 lines
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the
> file descriptors it uses to create the pipeline of processes.
>
> The process calling `pipelineStart()` is creating the pipes between the
> stages.
> As each process is launched, the file descriptor is inherited by
Hi all,
This pull request contains a backport of
[JDK-8287902](https://bugs.openjdk.org/browse/JDK-8287902), commit
[975316e3](https://github.com/openjdk/jdk/commit/975316e3e5f1208e4e15eadc2493d25c15554647)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backpo
On Fri, 17 Jun 2022 21:39:16 GMT, Maurizio Cimadamore
wrote:
> This is a dependent PR containing a cleanup of the so called *heap sessions*.
> Heap sessions are used in two cases:
>
> * when a buffer segment is created, to keep the original buffer instance
> reachable
> * when a loader symbol
> This patch changes all VaList implementations to throw
> `NoSuchElementException` when out of bounds reads occur on a VaList that is
> created using the Java builder API. The docs are updated accordingly.
>
> For VaLists that are created from native addresses, we don't know their
> bounds, so
This patch fixes an issue where the arena allocator does not detect an overflow
when attempting to allocate a new slice.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.org/jdk19/pull/133/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=133&range=00
Issue:
I think you are coming at this in the wrong way, Rodion. I am not a JDK
contributor, but these are my thoughts on how this works.
The people that are responsible for the Java collections framework are well
aware of the existence of alternative data structures such as finger trees.
There are al
On Mon, 11 Jul 2022 04:10:49 GMT, David Holmes wrote:
>> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with
>> java.lang.Exception: Reference Handler thread died
>
> src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
> line 296:
>
>> 294:
On Sat, 9 Jul 2022 02:43:55 GMT, David Schlosnagle wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup of PipelineLeaksFD test improving error messages and source
>> cleanup.
>
> test/jdk/java/lang/ProcessBuild
On Mon, 11 Jul 2022 04:16:44 GMT, David Holmes wrote:
>> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with
>> java.lang.Exception: Reference Handler thread died
>
> src/java.base/share/classes/java/util/concurrent/locks/LockSupport.java line
> 463:
>
>> 461: * Preallocated
On Fri, 8 Jul 2022 11:44:53 GMT, Doug Lea wrote:
> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with
> java.lang.Exception: Reference Handler thread died
src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
line 296:
> 294: byte spin
On Fri, 8 Jul 2022 22:42:28 GMT, Doug Lea wrote:
> I keep trying but failing to change commit message to something jcheck likes?
There should be an "Edit" button in the top right that allows you to edit the
title and change it to "8066859 : java/lang/ref/OOMEInReferenceHandler.java
failed ..."
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the
> file descriptors it uses to create the pipeline of processes.
>
> The process calling `pipelineStart()` is creating the pipes between the
> stages.
> As each process is launched, the file descriptor is inherited by
8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with
java.lang.Exception: Reference Handler thread died
-
Commit messages:
- Also update Xcomp problem list
- Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8066859
- Address review comments
- Disable filli
On Fri, 8 Jul 2022 11:44:53 GMT, Doug Lea wrote:
> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with
> java.lang.Exception: Reference Handler thread died
Thanks to @AlanBateman for suggesting to disable possibly misleading stack
traces in pre-allocated exceptions; now updated
I
The default implementation for `SegmentAllocator:allocateArray(MemoryLayout,
count)` is missing a check for negative array size.
In the past this used to be caught in the `SequenceLayout` factory, but not
anymore, as now `SequenceLayout` accepts `-1` as special size where the
sequence element co
> This is a dependent PR containing a cleanup of the so called *heap sessions*.
> Heap sessions are used in two cases:
>
> * when a buffer segment is created, to keep the original buffer instance
> reachable
> * when a loader symbol lookup is created, to keep the classloader instance
> reachabl
On Wed, 15 Jun 2022 18:06:44 GMT, Maurizio Cimadamore
wrote:
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
This pull request has now been integrated.
Changeset: fed3af8a
Author:Maurizio Cimadamore
URL:
https://git.openjdk.org/jdk19/commit/fed3af8ae069fc760a2
`BigInteger.powerCache` is volatile and should be assigned only once in static
initializer.
-
Commit messages:
- 8290079: Reduce interaction with volatile in static initializer of BigInteger
Changes: https://git.openjdk.org/jdk/pull/9451/files
Webrev: https://webrevs.openjdk.org/?
Forwardport JDK 19 -> JDK 20
-
Commit messages:
- Merge
- 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
- 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom
integration
- 8289894: A NullPointerException thrown from guard e
On Mon, 11 Jul 2022 08:02:43 GMT, Сергей Цыпанов wrote:
>> The new constructor looks very odd, especially when it does not have an
>> explanation and doesn't describe the required preconditions for calling it.
>> Is there a better way than adding a non-functional argument?
>> The "unused" name
> We can skip bounds check and null check for Charset in case we use the array
> entirely and the Charset is either default one or proven to be non-null.
>
> Benchmark results:
>
> before
>
> Benchmark Mode Cnt Score
> Error Units
> StringC
ConcurrentLinkedDeque was tested and it has similar thoughput to what we
use, slightly higher memory footprint per element added, so we opted
against it (but might re-eval in the future).
In the specific case of the FFM API, it is not uncommon to have a
session with just 1-2 resources attached
I'm curious, why isn't ArrayDeque or ConcurrentLinkedDeque used instead?
Or is there another requirement?
ArrayDeque has amortized O(1) for inserts at head and tail (and faster
and more memory efficient than LinkedList as it doesn't use nodes).
ConcurrentLinkedDeque would be useful in the fac
On Mon, 11 Jul 2022 09:46:11 GMT, Maurizio Cimadamore
wrote:
> Some of the accessors in `MemorySegment` and `MemoryAddress` (esp. setters)
> have typos - e.g. they use `from` instead of `into`.
>
> I've tried to simplify the text and made it more regular.
Marked as reviewed by uschindler (Aut
The implementation of the Foreign Function & Memory API uses an internal
custom linked list to add native resources to a "memory session"
abstraction (things that need to be cleaned up at a later point).
Linked list is quite critical in our use case because we need something
that has a very fa
Some of the accessors in `MemorySegment` and `MemoryAddress` (esp. setters)
have typos - e.g. they use `from` instead of `into`.
I've tried to simplify the text and made it more regular.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.org/jdk19/pull/131/files
Webre
On Wed, 6 Jul 2022 05:59:21 GMT, Alan Bateman wrote:
>> xpbob has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> update header
>
> It's not clear that introducing this as a standard API is the right thing to
> do. Are you 100% confident th
On Wed, 6 Jul 2022 05:59:21 GMT, Alan Bateman wrote:
>> xpbob has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> update header
>
> It's not clear that introducing this as a standard API is the right thing to
> do. Are you 100% confident th
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
On Fri, 8 Jul 2022 14:04:14 GMT, Roger Riggs wrote:
>> But if I roll back the added constructor I'll go through existing public one
>> `public String(byte[] bytes, int offset, int length, Charset charset)` doing
>> bounds check twice, won't I?
>
> The new constructor looks very odd, especially
> We can skip bounds check and null check for Charset in case we use the array
> entirely and the Charset is either default one or proven to be non-null.
>
> Benchmark results:
>
> before
>
> Benchmark Mode Cnt Score
> Error Units
> StringC
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
42 matches
Mail list logo
