On Mon, 4 Jul 2022 08:42:02 GMT, Alan Bateman wrote:
>> +1 - except for the "deadlock" part (see other comment). I think the old
>> paragraph is at least confusing, and perhaps even just wrong. Let's say
>> we've run `shutdown` so run all the hooks but not halted. Then someone
>> calls `exi
> This is a followup to simplify Shutdown.exit after the removal of
> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
> on the approach has been reached in this PR, a CSR will be filed to
> propose the spec change to Runtime.exit.
Ryan Ernst has updated the pull request in
On Mon, 4 Jul 2022 10:39:20 GMT, Matthias Baesken wrote:
> 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
This pull request has now been integrated.
Changeset: 0dff3276
Author:Matthias Baesken
URL:
https://git.openjdk.org/jdk19/commit/0dff3276e863fcbf496fe6
On Mon, 4 Jul 2022 10:39:20 GMT, Matthias Baesken wrote:
> 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
Thanks for bringing it to jdk19.
-
Marked as reviewed by clanger (Reviewer).
PR: https://git.openjdk.org/jdk19/pull/106
This PR updates the spec and implementation to throw an
`IllegalArgumentException` when an attempt is made to convert a Java string
containing null characters to a C string.
Testing: local run of the `jdk_foreign` test suite.
-
Commit messages:
- Throw IAE when converting string w
On Tue, 28 Jun 2022 10:32:31 GMT, Raffaello Giulietti wrote:
>> `BigDecimal.morePoint[Left|Right]()` should return the target `this` when
>> the argument is 0 _and_ the scale is non-negative.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since t
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Mon, 4 Jul 2022 08:07:25 GMT, Chris Hegarty wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 89:
>>
>>> 87: * of the first invocation will be used; the status codes from
>>> other invocations
>>> 88: * will be ignored. If this method is invoked from a shutdown hook
On Fri, 1 Jul 2022 11:18:35 GMT, Maurizio Cimadamore
wrote:
>> This patch fixes few javadoc issues in the memory layout API.
>> The main issues are that `SequenceLayout::flatten` and
>> `SequenceLayout::reshape` still mention failures caused by a lack of size.
>> But that condition is no longe
This patch changes all VaList implementations to throw `NoSuchElementException`
when out of bounds reads occur on a VaList that is created using the Java
builder API. The docs are updated accordingly.
For VaLists that are created from native addresses, we don't know their bounds,
so we can not
8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
-
Commit messages:
- Backport a8edd7a12f955fe843c7c9ad4273e9c653a80c5a
Changes: https://git.openjdk.org/jdk19/pull/106/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=106&range=00
Issue: https://bug
On Mon, 4 Jul 2022 06:31:15 GMT, Peter Levart wrote:
>> ...neither is obtaining a cloned array and passing its reference to JMH's
>> black hole our usecase... Still, it seems that even part of that has some
>> advantage. I would keep the @stable annotation then.
>
> A more realistic use case wo
On Mon, 4 Jul 2022 07:05:03 GMT, Matthias Baesken wrote:
> Currently the ProcessBuilder/Basic.java test fails on musl.
> We run into
>>'java.io.IOException: Cannot run program "./prog": error=8, Exec format error
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
> at java.ba
On Mon, 4 Jul 2022 07:05:03 GMT, Matthias Baesken wrote:
> Currently the ProcessBuilder/Basic.java test fails on musl.
> We run into
>>'java.io.IOException: Cannot run program "./prog": error=8, Exec format error
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
> at java.ba
On Mon, 4 Jul 2022 08:35:35 GMT, Thomas Stuefe wrote:
> Do you want to leave the "Platform.isMusl()" parts in the code?
I would leave it for now if it is okay.
-
PR: https://git.openjdk.org/jdk/pull/9361
On Mon, 4 Jul 2022 07:05:03 GMT, Matthias Baesken wrote:
> Currently the ProcessBuilder/Basic.java test fails on musl.
> We run into
>>'java.io.IOException: Cannot run program "./prog": error=8, Exec format error
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
> at java.ba
On Mon, 4 Jul 2022 01:59:37 GMT, Kim Barrett wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 89:
>>
>>> 87: * of the first invocation will be used; the status codes from
>>> other invocations
>>> 88: * will be ignored. If this method is invoked from a shutdown hook
On Mon, 4 Jul 2022 07:05:03 GMT, Matthias Baesken wrote:
> Currently the ProcessBuilder/Basic.java test fails on musl.
> We run into
>>'java.io.IOException: Cannot run program "./prog": error=8, Exec format error
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
> at java.ba
On Mon, 4 Jul 2022 01:57:11 GMT, Kim Barrett wrote:
> Is "deadlock" accurate?
Yes.
In the context of the specification, "shutdown hook" means _application_
shutdown hook - as far as the specification is concerned, application shutdown
hooks are the only kind of hooks. Right?
For example, the
On Fri, 1 Jul 2022 09:10:07 GMT, Christoph Langer wrote:
> This pull request contains a backport of
> [JDK-8287672](https://bugs.openjdk.org/browse/JDK-8287672), commit
> [7e211d7d](https://github.com/openjdk/jdk/commit/7e211d7daac32dca8f26f408d1a3b2c7805b5a2e)
> from the [openjdk/jdk](https:/
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Sun, 3 Jul 2022 22:19:50 GMT, David Holmes wrote:
>> Ryan Ernst has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better clarify multiple threads behavior
>
> src/java.base/share/classes/java/lang/Runtime.java line 89:
>
>> 87: *
On Mon, 4 Jul 2022 07:05:03 GMT, Matthias Baesken wrote:
> Currently the ProcessBuilder/Basic.java test fails on musl.
> We run into
>>'java.io.IOException: Cannot run program "./prog": error=8, Exec format error
> at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
> at java.ba
Currently the ProcessBuilder/Basic.java test fails on musl.
We run into
>'java.io.IOException: Cannot run program "./prog": error=8, Exec format error
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
at Basic
On Sun, 3 Jul 2022 19:44:55 GMT, Attila Szegedi wrote:
>> But it will generate garbage: non-static lambda.
>
> It already generates some garbage as it does string concatenation for the
> key. Here's an idea: declare a record class for the key, `record
> CacheKey(DayOfWeek firstDayOfWeek, int mi
On Tue, 21 Jun 2022 17:08:17 GMT, liach wrote:
>> @liach advance apologies for nitpicking: `ConcurrentHashMap` doesn't in
>> general block while the mapping function runs. It can block _some_
>> concurrent updates, namely those that [hash to the same
>> bin](https://github.com/openjdk/jdk/blob
> Instead of separate ConcurrentHashMap.get call, we can use result of previous
> putIfAbsent call.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8288723: Avoid redundant ConcurrentHashMap.get call in java.time
-
C
27 matches
Mail list logo
