Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v7]

2022-06-30 Thread Peter Levart
On Thu, 30 Jun 2022 12:08:19 GMT, Сергей Цыпанов wrote: >> If there are two threads calling `Executable.hasRealParameterData()` under >> race and the first one writes into volatile `Executable.parameters` field >> (doing _releasing store_) and the second thread reads non-null value from >> the

Re: [jdk19] RFR: 8289549: ISO 4217 Amendment 172 Update

2022-06-30 Thread Iris Clark
On Thu, 30 Jun 2022 22:05:38 GMT, Naoto Sato wrote: > Trivial fix to currency data files. The change was only made to its amendment > number, as the new Sierra Leone currency has already been active with > amendment 171. Marked as reviewed by iris (Reviewer). - PR: https://git.op

Withdrawn: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2022-06-30 Thread duke
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: > Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. This pull request has been closed without being integ

[jdk19] RFR: 8289549: ISO 4217 Amendment 172 Update

2022-06-30 Thread Naoto Sato
Trivial fix to currency data files. The change was only made to its amendment number, as the new Sierra Leone currency has already been active with amendment 171. - Commit messages: - 8289549: ISO 4217 Amendment 172 Update Changes: https://git.openjdk.org/jdk19/pull/96/files Webr

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-30 Thread Roger Riggs
On Thu, 30 Jun 2022 18:39:48 GMT, Xue-Lei Andrew Fan wrote: >> test/lib/jdk/test/lib/util/ForceGC.java line 58: >> >>> 56: Reference.reachabilityFence(ref); >>> 57: >>> 58: for (int retries = (int)(timeout / 200); retries >= 0; >>> retries--) { >> >> The logic around the timeo

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v11]

2022-06-30 Thread Roger Riggs
On Thu, 30 Jun 2022 18:44:30 GMT, Xue-Lei Andrew Fan wrote: >> This is a follow up update per comments in [JDK-8287384 >> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in >> open part looks good to me. Please help to run Mach5 just case the closed >> test cases are

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-30 Thread Roger Riggs
On Thu, 30 Jun 2022 18:24:14 GMT, Xue-Lei Andrew Fan wrote: >> test/lib/jdk/test/lib/util/ForceGC.java line 70: >> >>> 68: // But it is fine. For most cases, the 1st GC is >>> sufficient >>> 69: // to trigger and complete the cleanup. >>> 70: que

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

2022-06-30 Thread Naoto Sato
On Thu, 30 Jun 2022 18:29:42 GMT, Gaurav Chaudhari wrote: > One more thing to note/I'd like to make sure is what the output looks like > when TZ is GMT. Want to ensure that the final string being passed down is > just "GMT" and that `strftime` invocation returns an empty result. If the > resul

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable [v2]

2022-06-30 Thread Naoto Sato
On Thu, 30 Jun 2022 18:32:56 GMT, Gaurav Chaudhari wrote: >> This is a REDO of the Fix that was incompletely implemented earlier: >> [8285838: Fix for TZ environment variable DST >> rules](https://github.com/openjdk/jdk/pull/8660) >> >> Offset calculation now accounts all the way upto year in o

Re: RFR: 8289534: Change 'uncomplicated' hotspot runtime options

2022-06-30 Thread Coleen Phillimore
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote: > Please review this small fix to change range constrained JVM runtime options > from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux, > Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64. > > Thanks, Harold Look

RFR: 8289534: Change 'uncomplicated' hotspot runtime options

2022-06-30 Thread Harold Seigel
Please review this small fix to change range constrained JVM runtime options from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64. Thanks, Harold - Commit messages: - 8289534: Change 'uncomplicated' hots

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-30 Thread Xue-Lei Andrew Fan
On Thu, 30 Jun 2022 15:48:07 GMT, Roger Riggs wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 13 commits: >> >> - Master >> - use Reference.refersTo >> - remove trailing whitespaces >> - use timeou

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v11]

2022-06-30 Thread Xue-Lei Andrew Fan
> This is a follow up update per comments in [JDK-8287384 > PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in > open part looks good to me. Please help to run Mach5 just case the closed > test cases are impacted. Xue-Lei Andrew Fan has updated the pull request increme

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

2022-06-30 Thread Gaurav Chaudhari
On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari wrote: > This is a REDO of the Fix that was incompletely implemented earlier: > [8285838: Fix for TZ environment variable DST > rules](https://github.com/openjdk/jdk/pull/8660) > > Offset calculation now accounts all the way upto year in order

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable [v2]

2022-06-30 Thread Gaurav Chaudhari
> This is a REDO of the Fix that was incompletely implemented earlier: > [8285838: Fix for TZ environment variable DST > rules](https://github.com/openjdk/jdk/pull/8660) > > Offset calculation now accounts all the way upto year in order to avoid > cross-day miscalculations as well as to calculat

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-30 Thread Xue-Lei Andrew Fan
On Thu, 30 Jun 2022 15:53:10 GMT, Roger Riggs wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 13 commits: >> >> - Master >> - use Reference.refersTo >> - remove trailing whitespaces >> - use timeou

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG

2022-06-30 Thread Victor Dyakov
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev wrote: > Fixed 3 issues which made signature invalid: > - We should not remove .jpackage.xml from signed app image when creating DMG > or PKG otherwise it invalidates signature. > - .package should be created when app image is generated, so th

RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page

2022-06-30 Thread Hannes Wallnöfer
Please review an enhancement to the preview page to add a list of preview features and allow users to explore the preview APIs by feature. While the changes for the enhancement itself are not overly complex, the work entailed a moderate cleanup of other summary API lists (Deprecated and New API

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v14]

2022-06-30 Thread iaroslavski
> Sorting: > > - adopt radix sort for sequential and parallel sorts on int/long/float/double > arrays (almost random and length > 6K) > - fix tryMergeRuns() to better handle case when the last run is a single > element > - minor javadoc and comment changes > > Testing: > - add new data inputs i

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v13]

2022-06-30 Thread iaroslavski
> Sorting: > > - adopt radix sort for sequential and parallel sorts on int/long/float/double > arrays (almost random and length > 6K) > - fix tryMergeRuns() to better handle case when the last run is a single > element > - minor javadoc and comment changes > > Testing: > - add new data inputs i

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-30 Thread Roger Riggs
On Sat, 18 Jun 2022 05:55:32 GMT, Xue-Lei Andrew Fan wrote: >> This is a follow up update per comments in [JDK-8287384 >> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in >> open part looks good to me. Please help to run Mach5 just case the closed >> test cases are

Re: RFR: 8287596: Reorg jdk.test.lib.util.ForceGC [v10]

2022-06-30 Thread Xue-Lei Andrew Fan
On Sat, 18 Jun 2022 05:55:32 GMT, Xue-Lei Andrew Fan wrote: >> This is a follow up update per comments in [JDK-8287384 >> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in >> open part looks good to me. Please help to run Mach5 just case the closed >> test cases are

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v7]

2022-06-30 Thread Сергей Цыпанов
> If there are two threads calling `Executable.hasRealParameterData()` under > race and the first one writes into volatile `Executable.parameters` field > (doing _releasing store_) and the second thread reads non-null value from the > same field (doing acquiring read) then it must read exactly t

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-30 Thread Сергей Цыпанов
On Wed, 29 Jun 2022 18:11:50 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8288327: Mark ParameterData.parameters as @Stable and rename real -> isReal > > src/java.base/share/classes/java/lang/reflec

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v6]

2022-06-30 Thread Сергей Цыпанов
> If there are two threads calling `Executable.hasRealParameterData()` under > race and the first one writes into volatile `Executable.parameters` field > (doing _releasing store_) and the second thread reads non-null value from the > same field (doing acquiring read) then it must read exactly t

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v5]

2022-06-30 Thread Сергей Цыпанов
> If there are two threads calling `Executable.hasRealParameterData()` under > race and the first one writes into volatile `Executable.parameters` field > (doing _releasing store_) and the second thread reads non-null value from the > same field (doing acquiring read) then it must read exactly t

Integrated: 8288895: LdapContext doesn't honor set referrals limit

2022-06-30 Thread rmartinc
On Thu, 23 Jun 2022 08:20:31 GMT, rmartinc wrote: > Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895). > > Any `LimitExceededException` now quits the referral loop. > > Added class `ReferralLimitSearchTest`. It is a simple jtreg test which checks > that `java.naming.ldap.referra