Re: RFR: 8288895: LdapContext doesn't honor set referrals limit [v3]

2022-06-29 Thread rmartinc
On Tue, 28 Jun 2022 14:56:30 GMT, Aleksei Efimov wrote: >> rmartinc has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8288895: LdapContext doesn't honor set referrals limit (typo) > > Marked as reviewed by aefimov (Committer). Thanks @Ale

Re: RFR: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem [v2]

2022-06-29 Thread Jaikiran Pai
On Wed, 29 Jun 2022 08:20:31 GMT, Andrey Turbanov wrote: >> There is overload method HashMap.remove(key,value) which also checks value >> equality. >> It's shorter and faster than pair get+remove. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since

Re: RFR: 8289484: Cleanup unnecessary null comparison before instanceof check in java.rmi

2022-06-29 Thread Jaikiran Pai
On Wed, 29 Jun 2022 21:11:09 GMT, Andrey Turbanov wrote: > Update code checks both non-null and instance of a class in jdk.hotspot.agent > module classes. > The checks and explicit casts could also be replaced with pattern matching > for the instanceof operator. > > For example, the following

Result: new Core Libraries Group member: Roger Riggs

2022-06-29 Thread Stuart Marks
The vote for Roger Riggs [1] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. s'marks [1] https://mail.openjdk.org/pipermail/core-libs-dev/2022-June/091258.html

Result: new Core Libraries Group member: Naoto Sato

2022-06-29 Thread Stuart Marks
The vote for Naoto Sato [1] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. s'marks [1] https://mail.openjdk.org/pipermail/core-libs-dev/2022-June/091198.html

Integrated: Merge jdk19

2022-06-29 Thread Jesper Wilhelmsson
On Wed, 29 Jun 2022 19:38:59 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 048bffad Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/048bffad79b302890059ffc1bc559bfc601de92c Stats: 116 lines

RFR: Merge jdk19

2022-06-29 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8289252: Recommend Locale.of() method instead of the constructor - 8288596: Random:from() adapter does not delegate to supplied generator in all cases - 8289399: Updat

Re: RFR: JDK-8289106: Add model of class file versions to core reflection

2022-06-29 Thread Joe Darcy
On Wed, 29 Jun 2022 16:51:21 GMT, Roger Riggs wrote: > I'm thinking of the case where I'm reading class file bytes and pull out the > major classfile version and want to map it to the enum. If the semantic was > the "earliest version" supporting the major version then it would be > unambiguous

Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v2]

2022-06-29 Thread Joe Darcy
> JDK-8289106: Add model of class file versions to core reflection Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since

RFR: 8289484: Cleanup unnecessary null comparison before instanceof check in java.rmi

2022-06-29 Thread Andrey Turbanov
Update code checks both non-null and instance of a class in jdk.hotspot.agent module classes. The checks and explicit casts could also be replaced with pattern matching for the instanceof operator. For example, the following code: if ((obj != null) && (obj instanceof TCPEndpoint)) {

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-29 Thread Alexey Semenyuk
On Wed, 29 Jun 2022 12:30:05 GMT, Alex Kasko wrote: > For runtime installers it would be great to have a custom verb label, to be > able to use something like: "Open with VendorName OpenJDK". I intend to > prototype this and file in a separate PR Sounds good. > %* contains all the arguments b

Re: RFR: 8289260: BigDecimal movePointLeft() and movePointRight() do not follow their API spec [v2]

2022-06-29 Thread Joe Darcy
On Tue, 28 Jun 2022 10:32:31 GMT, Raffaello Giulietti wrote: >> `BigDecimal.morePoint[Left|Right]()` should return the target `this` when >> the argument is 0 _and_ the scale is non-negative. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since t

Re: Executable.hasRealParameterData() and Parameter.isNamePresent() don't work as expected

2022-06-29 Thread Joseph D. Darcy
If you want more information about parameters, use javac with its "-parameters" option. -Joe On 6/28/2022 11:54 PM, Сергей Цыпанов wrote: This question was asked originally here: https://stackoverflow.com/questions/72787286/executable-hasrealparameterdata-and-parameter-isnamepresent-dont-work

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-29 Thread liach
On Fri, 17 Jun 2022 11:21:49 GMT, Сергей Цыпанов wrote: >> If there are two threads calling `Executable.hasRealParameterData()` under >> race and the first one writes into volatile `Executable.parameters` field >> (doing _releasing store_) and the second thread reads non-null value from >> the

Re: RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v4]

2022-06-29 Thread Stuart Marks
On Fri, 6 May 2022 22:05:35 GMT, liach wrote: >> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare >> values by identity. Updated API documentation of these two methods >> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec

Re: RFR: JDK-8289106: Add model of class file versions to core reflection

2022-06-29 Thread Roger Riggs
On Mon, 27 Jun 2022 20:26:52 GMT, Joe Darcy wrote: > JDK-8289106: Add model of class file versions to core reflection I'm thinking of the case where I'm reading class file bytes and pull out the major classfile version and want to map it to the enum. If the semantic was the "earliest version"

Re: RFR: 8289260: BigDecimal movePointLeft() and movePointRight() do not follow their API spec [v2]

2022-06-29 Thread Joe Darcy
On Tue, 28 Jun 2022 10:32:31 GMT, Raffaello Giulietti wrote: >> `BigDecimal.morePoint[Left|Right]()` should return the target `this` when >> the argument is 0 _and_ the scale is non-negative. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since t

Re: RFR: JDK-8289106: Add model of class file versions to core reflection

2022-06-29 Thread Joe Darcy
On Wed, 29 Jun 2022 14:42:19 GMT, Roger Riggs wrote: > A static method to map from classfile version (as in the JVMS) to > ClassFileVersion enum will be useful too. Just to confirm, you're asking for a method that would map 63 to RELEASE_19, 64 to RELEASE_20, etc.? Seems reasonable, although

Re: Executable.hasRealParameterData() and Parameter.isNamePresent() don't work as expected

2022-06-29 Thread Daniel Fuchs
Hi Sergey, I believe you need to compile with `-parameters` https://docs.oracle.com/en/java/javase/18/docs/specs/man/javac.html best regards, -- daniel On 29/06/2022 07:54, Сергей Цыпанов wrote: This question was asked originally here: https://stackoverflow.com/questions/72787286/executable

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

2022-06-29 Thread Naoto Sato
On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari wrote: > This is a REDO of the Fix that was incompletely implemented earlier: > [8285838: Fix for TZ environment variable DST > rules](https://github.com/openjdk/jdk/pull/8660) > > Offset calculation now accounts all the way upto year in order

[jdk19] Integrated: 8289252: Recommend Locale.of() method instead of the constructor

2022-06-29 Thread Naoto Sato
On Tue, 28 Jun 2022 17:11:31 GMT, Naoto Sato wrote: > This is a leftover documentation fix to the deprecation of `Locale` > constructors. `Locale.Builder` class had some texts that suggested using one > of those constructors, which need to be replaced with a `Locale.of()` method. > A correspon

Re: RFR: 8288732: Reduce runtime of java.util.concurrent microbenchmarks

2022-06-29 Thread Eric Caspole
On Mon, 20 Jun 2022 10:47:35 GMT, Claes Redestad wrote: > - Refactor so that various baseline micros are not run repeatedly with > different parameter values that does not affect the baseline > - Tune iteration times, counts, forks.. > > Reduces runtime of java.util.concurrent micros from an es

[jdk19] Integrated: 8288596: Random:from() adapter does not delegate to supplied generator in all cases

2022-06-29 Thread Raffaello Giulietti
On Fri, 17 Jun 2022 16:44:30 GMT, Raffaello Giulietti wrote: > Extend delegation by instance returned by Random.from() to all methods > exposed by RandomGenerator. This pull request has now been integrated. Changeset: 57089749 Author:Raffaello Giulietti Committer: Roger Riggs URL:

Re: RFR: JDK-8289106: Add model of class file versions to core reflection

2022-06-29 Thread Roger Riggs
On Mon, 27 Jun 2022 20:26:52 GMT, Joe Darcy wrote: > JDK-8289106: Add model of class file versions to core reflection A static method to map from classfile version (as in the JVMS) to ClassFileVersion enum will be useful too. - PR: https://git.openjdk.org/jdk/pull/9299

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

2022-06-29 Thread Gaurav Chaudhari
On Tue, 28 Jun 2022 22:15:39 GMT, Naoto Sato wrote: >> This is a REDO of the Fix that was incompletely implemented earlier: >> [8285838: Fix for TZ environment variable DST >> rules](https://github.com/openjdk/jdk/pull/8660) >> >> Offset calculation now accounts all the way upto year in order t

Integrated: 8284942: Proxy building can just iterate superinterfaces once

2022-06-29 Thread liach
On Mon, 18 Apr 2022 06:15:54 GMT, liach wrote: > Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, > the interfaces are iterated twice. The two passes can be merged into one, > yielding the whole proxy definition context (module, package, whether there's > package-pri

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v6]

2022-06-29 Thread Jaikiran Pai
On Thu, 26 May 2022 23:20:27 GMT, liach wrote: >> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, >> the interfaces are iterated twice. The two passes can be merged into one, >> yielding the whole proxy definition context (module, package, whether >> there's package

Re: RFR: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V) [v4]

2022-06-29 Thread liach
On Fri, 6 May 2022 22:05:35 GMT, liach wrote: >> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare >> values by identity. Updated API documentation of these two methods >> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-29 Thread Alex Kasko
On Tue, 28 Jun 2022 21:38:50 GMT, Alexey Semenyuk wrote: > The existing behavior simply cuts off all, but the first argument from the > argument array passed to the app launcher. Changing this looks more like a > fix of a bug, than an enhancement. I'd keep it simple: replace the value of > the

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-29 Thread Alex Kasko
On Tue, 28 Jun 2022 21:38:50 GMT, Alexey Semenyuk wrote: > > I assume we will need an additional similar property for a verb label > > displayed in a context menu. > > Agree. At least we need to provide l10n for it. For runtime installers it would be great to have a custom verb label, to be a

Re: RFR: 8288838: jpackage: file association additional arguments [v3]

2022-06-29 Thread Alex Kasko
> jpackage implementation of file association on Windows currently passes a > selected filename as an only argument to associated executable. > > It is proposed to introduce additional option in file association property > file to allow optionally support additional arguments using `%*` batch >

Integrated: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long

2022-06-29 Thread Quan Anh Mai
On Tue, 7 Jun 2022 17:14:18 GMT, Quan Anh Mai wrote: > Hi, > > This patch implements intrinsics for `Integer/Long::compareUnsigned` using > the same approach as the JVM does for long and floating-point comparisons. > This allows efficient and reliable usage of unsigned comparison in Java, > w

Re: RFR: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem [v2]

2022-06-29 Thread Lance Andersen
On Wed, 29 Jun 2022 08:20:31 GMT, Andrey Turbanov wrote: >> There is overload method HashMap.remove(key,value) which also checks value >> equality. >> It's shorter and faster than pair get+remove. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since

Re: RFR: 8288895: LdapContext doesn't honor set referrals limit [v3]

2022-06-29 Thread Daniel Fuchs
On Tue, 28 Jun 2022 14:22:48 GMT, rmartinc wrote: >> Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895). >> >> Any `LimitExceededException` now quits the referral loop. >> >> Added class `ReferralLimitSearchTest`. It is a simple jtreg test which >> checks that `java.naming.ldap.r

Re: RFR: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem [v2]

2022-06-29 Thread Andrey Turbanov
> There is overload method HashMap.remove(key,value) which also checks value > equality. > It's shorter and faster than pair get+remove. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8289431: (zipfs) Avoid redundant HashMap.get

RFR: 8289431: Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem

2022-06-29 Thread Andrey Turbanov
There is overload method HashMap.remove(key,value) which also checks value equality. It's shorter and faster than pair get+remove. - Commit messages: - [PATCH] Remove redundant HashMap.get call before HashMap.remove Changes: https://git.openjdk.org/jdk/pull/9314/files Webrev: http

Re: RFR: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long [v3]

2022-06-29 Thread Quan Anh Mai
On Wed, 22 Jun 2022 03:01:36 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch implements intrinsics for `Integer/Long::compareUnsigned` using >> the same approach as the JVM does for long and floating-point comparisons. >> This allows efficient and reliable usage of unsigned comparison in Java