I see the `@since` tags have not been updated, and that there is still
`{@preview}` text in the doc comment?
Does this need a followup bug?
-- Jon
On 4/6/20 10:30 AM, Jim Laskey wrote:
fixed the @bug - thx Alan
On Apr 6, 2020, at 2:12 PM, Alan Bateman wrote:
On 06/04/2020 16:54, Jim
You might want to check the /generated/ API docs. It doesn't look like
the first {@link} will do what you might be expecting.
-- Jon
On 5/18/20 1:48 PM, Claes Redestad wrote:
Hi,
let's add an isEmpty default method to CharSequence!
Webrev: http://cr.openjdk.java.net/~redestad/8215401/open.00
Please review a trivial docs fix for some invalid HTML in
jdk.zipfs/module-info.java.
In two places, 'href==' is reduced to 'href='
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247880
Patch inline
diff -r cf0df75c75c1 src/jdk.zipfs/share/classes/module-info.java
--- a/src/jdk.zipfs
Please review a trivial fix for an invalid @see tag in
java/lang/management/package.html.
The presumed intent of the original is not a supported variant. The fix
is to remove the
`{@linkplain ...}` wrapper.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247894
Patch inline:
diff -r cf
Please review a trivial fix for a couple of misnamed tags in 2 classes in
the java.io package. In both cases, @throw should be @throws
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247896
Patch inline:
diff -r d66e8770295e src/java.base/share/classes/java/io/PipedWriter.java
--- a/src/
Please review this trivial fix to some minor issues reported by doclint.
In the first change, the `` contained a hangover of some HTML 4
attributes
which are not supported in HTML5. They are simply deleted.
In the second change, a paragraph just contained a comment. While it might
be reasonab
Please review some fixes to address issues found by doclint.
In a couple of places, imports were required in order to resolve symbols.
In another case, the name also had a typo in it.
In the last case, the incorrect syntax was used for a type parameter in
@param.
-- Jon
JBS: https://bugs.open
Please review a couple of trivial fixes for a couple of issues in
java.xml, reported by doclint.
I realize we typically don't touch upstream code, but I'm hoping this is
small enough to
be reasonable.
In the first case, there is an unnecessary `` before a ``.
In the second case, there's a ba
On 8/13/20 10:13 AM, Sean Mullan wrote:
On 8/13/20 11:05 AM, Julia Boes wrote:
Hi Vipin,
Thanks for providing this fix, I'm happy to sponsor your change. To
complete the review, we still need someone to green light the
remaining changes below. I'm looping in net-dev and security-dev to
hav
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy
wrote:
> I have in mind dozens of improvements all over the code like this one.
That sounds scary. Broad updates like these cause unnecessary churn in the
codebase, and can make merging and back
porting harder. Changes should be discussed ah
On Tue, 22 Sep 2020 17:24:19 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from lahodaj/JDK-8216497
>>
>>Automatic
On Mon, 21 Sep 2020 10:47:40 GMT, Hannes Wallnöfer wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR
On Wed, 23 Sep 2020 14:20:12 GMT, Hannes Wallnöfer wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc
> behavior to more closely adhere to JEP 12.
> The notable changes are:
>
> * adding support for Preview APIs (javac un
The change is (just) to remove legacy usages of a JDK-private custom tag.
-
Commit messages:
- JDK-8255262: Remove use of legacy custom @spec tag
Changes: https://git.openjdk.java.net/jdk/pull/814/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=814&range=00
Issue: htt
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
This pull request has now been integrated.
Changeset: 0aa3c925
Author: Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/0aa3c925
St
On Wed, 21 Oct 2020 12:43:51 GMT, Hannes Wallnöfer wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 35 commits:
>>
>> - Merge branch 'JDK-8250768-dev' of https://github.com/lahodaj/jdk into
>> JDK-8250768
>>
class name ;-)
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
line 1039:
> 1037: } else if (utils.isVariableElement(element) ||
> utils.isTypeElement(element)) {
> 1038: return getLink(new LinkInfoImpl(configuration, contex
On Thu, 29 Oct 2020 09:43:56 GMT, Jan Lahoda wrote:
>> I don't think there should be much interaction with -source .
>> We don't support preview features from previous version or preview class
>> files from previous versions, so I think it should be enough to handle the
>> currently present pr
On Thu, 29 Oct 2020 09:26:05 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java
>> line 1288:
>>
>>> 1286: case FIELD: case INSTANCE_INIT: case LOCAL_VARIABLE:
>>> case PARAMETER:
>>> 1287: case RESOURCE_VARIABLE
On Fri, 16 Oct 2020 16:07:41 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating t
On Mon, 2 Nov 2020 18:15:09 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview APIs
On Tue, 27 Oct 2020 16:09:45 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java
>> line 88:
>>
>>> 86:
>>> 87: @Override
>>> 88: protected Content getDeprecatedOrPreviewLink(Element member) {
>>
>> This
On Thu, 5 Nov 2020 12:43:03 GMT, Jan Lahoda wrote:
>> Thanks @jonathan-gibbons for your comments! I've tried to update the code
>> based on them, mostly in
>> https://github.com/lahodaj/jdk/commit/743f516c660b577035cdda4510a0bb97937fd9b2
>> and
>> ht
On Tue, 10 Nov 2020 17:41:28 GMT, Mandy Chung wrote:
> @ExpectedExceptions is no longer available in TestNG 7.*. Update the tests
> to use @Test(expectedExceptions = "...") instead.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1145
On Fri, 6 Nov 2020 18:41:15 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview APIs
Please review a one line change to fix a 404 link in
javax/annotation/processing/Filer.java
With this fix, DocCheck finds no errors in the java.compiler module.
JBS: https://bugs.openjdk.java.net/browse/JDK-8225077
-- Jon
Patch inline:
$ hg diff -R open
diff -r a0d4e61acb6b
src/java.compile
Please review a conceptually simple fix to adjust the rank of the
headings in the following files in 4 management-related modules:
src/java.management.rmi/share/classes/javax/management/remote/rmi/package.html
src/java.management/share/classes/java/lang/management/LockInfo.java
src/java.manageme
Please review a simple docs fix for jdk.zipfs module-info.java.
The ranks of the headings are updated to close up the gaps, and a couple
of superfluous are removed.
Webrev link below, but the patch is small enough to read inline if you want.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/
Please review another round of fixes for HTML issues, this time in
java.naming.
As with the management APIs, there were some inconsistencies in the
ranks for the headings, which have been addressed. The log with the
simplified diff listing is attached.
-- Jon
JBS: https://bugs.openjdk.java
Please review a tiny delete-one-line change to fix the last HTML error
in the java.instrument module.
Note to all: should only be used at the *beginning* of a paragraph.
It is not a terminator or separator.
In the context of a javadoc comment, it should not be used before the
set of block tag
Please review a tiny doc fix to make the headings in this file consistent.
The headings are currently:
$ grep 'h[1-6]'
open/src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncProvider.java
* 1.0 Naming Convention for Implementations
* 2.0 How a RowSet Object Gets Its Provider
* 3.0
Please review another small patch for the jdk.jdi module, to fix a
missing heading in one file and to adjust a heading in another.
No webrev; patch below.
That being said, the file
src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely
warrants being its own file, but even what
Please review a small fix for a couple of broken links in java.base.
Both look like the same copy/paste error, trying to refer to a target id
in another package.
No webrev: patch below.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8225314
$ hg diff -R open
diff -r 64fe51ee940e src/
Please review a fix to remove an unnecessary trailing from the
module-info file for jdk.jfr
Patch below.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8225324
$ hg diff -R open
diff -r e079a4cfad75 src/jdk.jfr/share/classes/module-info.java
--- a/src/jdk.jfr/share/classes/module-info
+1
-- Jon
On 6/5/19 9:49 AM, Joe Darcy wrote:
Hello,
As noticed by Jon, the text for java.lang.Enum refers to a section of
the JLS but does not use @jls tags:
"This is the common base class of all Java language enumeration types.
More information about enums, including descriptions of the
Looks good to me, and to doccheck.
-- Jon
On 06/06/2019 12:33 PM, Jim Laskey wrote:
Please review these changes. A table in the javadoc for
String::translateEscapes was missing some tags.
Thank you.
Cheers,
-- Jim
webrev:
http://cr.openjdk.java.net/~jlaskey/8225448/webrev-01/index.html
+1
-- Jon
On 6/8/19 1:36 PM, Lance Andersen wrote:
Hi all,
Please review this update to the java.sql package javadocs which
addresses a broken URL on OTN as the page is no longer being available.
—
$ !hg
hg diff
diff -r d22206f24d59 src/java.sql/share/classes/java/sql/package-info.ja
Please review a minor change to 3 man pages, updating links to API
elements to point to the API for the current version of those elements.
No semantic change. Note that the links are also updaed to the current
form used in HTML 5.
JBS: https://bugs.openjdk.java.net/browse/JDK-8225627
Webrev:
Yumin,
It looks like you have doclint enabled, and it is warning you that there
is no documentation comment on the public field you have added.
-- Jon
On 6/12/19 12:11 PM, yumin qi wrote:
HI,
I encountered strange compilation warning when building jdk
changeset: 55349:139f21bad9fd
tag:
+1
On 6/12/19 1:35 PM, Joe Darcy wrote:
Hello,
Please review the small patch below to address
JDK-8225675: Outdated citation of JLS in java.lang.ref.Reference
(I'll reflow the paragraph before pushing; wanted to make the nature
of the diff clearer in the review.)
Thanks,
-Joe
diff -r
Please review a tiny fix to the HTML for a table in jdk.zipfs
module-info.java. The fix is just to change some cells from to
. Because of the specified style (striped) for the table, there is
no change in the default appearance of this table.
The change is simple enough to show the patch be
Please review a fix for an accessibility issue reported by Axe in
src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
The issue is a conflict between an explicit `role="main">...`` specified in the file and the automatic
`` added by javadoc. The fix is just to remove the `` element.
Generally, the current idiom in JDK API docs is to use a link beginning
"{@docRoot}/../specs/." such as
"{@docRoot}/../specs/serialization/index.html"
-- Jon
On 07/13/2019 01:16 PM, Joe Darcy wrote:
PS I've uploaded an updated an iteration of the webrev
http://cr.openjdk.java.net/~da
Severin,
This might be a reasonable update to jtreg, to allow /usr/sbin on the path
on Unix-like systems. The intent of jtreg is to protect tests from random
crufty stuff on the PATH, and /usr/sbin is not in that category.
I've created
CODETOOLS-7902505: Consider allowing /usr/sbin on $PATH
htt
Sergey,
While it might be reasonable to improve doclint support with better
checks for serialization,
I think that is better done as a separate task, and not conflated with
Joe's work here.
-- Jon
On 09/10/2019 11:45 AM, Sergey Bylokhov wrote:
Hi, Joe.
Can we as part of this effort improv
Typo "isnull" and/or font issue, in "The format of the null-detail message"
1.
In a failed array access --|Cannot load from object array because
'a[i][j]' is|null|.|-- the second part|'a[i][j]' is null.|suffices
to pinpoint the|null|expression in source code,|a[i][j][k] = 99;|
-- Jon
+1
On 11/12/2019 09:50 AM, Jan Lahoda wrote:
Looks good to me.
Jan
On 12. 11. 19 7:13, Joe Darcy wrote:
Hello,
To remove the need to modify tests when the JDK version is updated,
the tests of the preview API in String should use "${jdk.version}" as
an argument to -source rather than a fix
It's a design constraint that the "single source file mode" does not and
should not support javac-specific command-line options beyond those that
are also runtime options (for example, --class-path).
That being said, since one of the use cases is for beginners learning
Java, it seems reasonabl
Looks good to me.
-- Jon
On 11/22/19 11:17 AM, Mandy Chung wrote:
This patch reorders `@param pos` of MethodHandles.dropArguments
matching the method signature.
It'd be nice if javadoc generates with the ordered list of @params
matching the method signature (I created JDK-8234682).
diff --
LGTM
-- Jon
On 11/27/19 7:44 AM, Joe Darcy wrote:
Hello,
Please review the small doc RFE to address
JDK-8234917: "Explicitly discuss java.lang.Enum in Class.isEnum spec"
Patch below; thanks,
-Joe
--- a/src/java.base/share/classes/java/lang/Class.java Wed Nov 27
06:36:41 2019 -0800
I note that javac now uses the same definition of tryResolveFile in its
handling of Class-Path manifest entries, and so the behavior for the
compiler and runtime should now be aligned.
-- Jon
On 12/09/2019 12:10 PM, Brent Christian wrote:
Hi,
As discussed[1] last month on this alias, JAR Cl
This seems ... surprising.
Why is the instance of jtreg used for all the other tests not good
enough here?
-- Jon
On 12/10/19 1:35 PM, Alexander Matveev wrote:
Please review simple script fix [2] for jpackage bug [1].
- Modified script to download jtreg bundle from URL provided by
environ
I've been trying to contact AdoptOpenJDK folk about this and other
related issues. I've not heard back yet.
In the meantime, I note that these days it is reasonably easy for folk
to build jtreg if they do not have easy access to the latest prebuilt
binaries. There's a README in the root of the
I like what you're trying to do, but the wording used to introduce the
names `cr` and `cp` feels a bit contorted. How about using a single
name, c, introduced up front in this line:
+ * of the argument. Equality of a component {@code c} is determined
as follows:
with the rest of the te
ith which to compare.
- * @return {@code true} if this object is the same as the obj
+ * @return {@code true} if this object is equal to the
* argument; {@code false} otherwise.
*/
@Override
On 1/6/2020 1:22 PM, Jonathan Gibbons wrote:
I like what you'
Sergey,
It is equally bad to create a new class in the java.lang package as it
is to add a new public method to java.lang.String.
-- Jon
On 2/3/20 2:38 PM, Сергей Цыпанов wrote:
Hello,
as of JDK14 java.util.StringJoiner still uses char[] as a storage of glued
Strings.
This applies for the
Mandy,
The desire to "highlight" parts of example code has made it onto the
wishlist for a possible new `{@example}` tag for do comments.
-- Jon
On 2/12/20 11:50 AM, Mandy Chung wrote:
On 2/12/20 11:44 AM, Roger Riggs wrote:
Hi Mandy,
I considered breaking it up but none of the other exa
Igor,
The change to langtools/TEST.ROOT is OK.
That being said, there are some old entries there which could also be
cleaned up (separately?) These lines probably date from the development
of JDK 9 and the evolution of Project Jigsaw.
20 # Use new module options
21 useNewOptions=true
Please review a simple fix regarding the non-standard use of some CSS in
some doc comments.
From the JBS Description:
Recently, for the display of javadoc block tags, javadoc changed from
using an inconsistent set of CSS class names on the generated 'dt'
elements to using a single new name ("
On 12 Mar 2020, at 20:50, Jonathan Gibbons wrote:
Please review a simple fix regarding the non-standard use of some CSS in some
doc comments.
From the JBS Description:
Recently, for the display of javadoc block tags, javadoc changed from using an
inconsistent set of CSS class names on the
double "the"
899 * the format specified in section {@jvms 4.7.9} of the
900 * The Java™ Virtual Machine Specification,
Otherwise OK,
-- Jon
On 3/27/20 9:53 PM, Joe Darcy wrote:
Hello,
As noticed during the CSR review of JDK-8238359, not all the citations
of JVMS and JLS are done consistentl
The langtools test changes look OK. I investigated TestRecordTypes.java
a bit because of the "jdk11" component in the file name, but the changes
look OK, and there is caveat text in the test itself to indicate the
file should be updated at some point to a more recent version anyway.
-- Jon
O
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight a
On Mon, 7 Dec 2020 20:30:07 GMT, Andrey Turbanov
wrote:
> 6882207: Convert javap to use diamond operator internally
Nice; thanks
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1677
On Thu, 3 Dec 2020 09:22:18 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing Record
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
> res
This is for JDK16, as a precursor to fixing JDK-8258002.
While it is good to be using localized strings in the generated output, the
significance for JDK-8258002 is that the strings are now obtained from a
resource file, and not hardcoded in JavaScript file itself.
The source file `search.js` i
On Mon, 14 Dec 2020 09:11:31 GMT, Hannes Wallnöfer wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained from a
>> resource file,
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request with a new ta
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incremental
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incremental
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
> res
On Mon, 21 Dec 2020 14:37:57 GMT, Сергей Цыпанов
wrote:
>> I don't think so, the code is fine, for me.
>
> @forax I've sent a mail into compiler-dev list:
> http://mail.openjdk.java.net/pipermail/compiler-dev/2020-December/015857.html
>
> Let's see what they decide.
FYI, despite the confusing
On 10/31/20 8:37 AM, Kartik Ohri wrote:
Further investigation reveals that some JavaFX specific code is also present in
the `javadoc` tool. For instance,
https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java#L90-L96
https
On Thu, 7 Jan 2021 20:23:16 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview APIs
On Fri, 8 Jan 2021 01:58:07 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - Fixing tests after a merge.
>> - Merging master into JD
Please review a small doc fix to remove some superfluous `` tags and an
erroneous `` tag, all reported by doclint..
-
Commit messages:
- JDK-8262428: doclint warnings in java.xml module
Changes: https://git.openjdk.java.net/jdk/pull/2733/files
Webrev: https://webrevs.openjdk.java.
On Thu, 25 Feb 2021 22:41:46 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to remove some superfluous `` tags and an
> erroneous `` tag, all reported by doclint..
This pull request has now been integrated.
Changeset: 059ede0d
Author:Jonathan Gibbons
URL:
Please review a simple fix to ensure that a link reference is resolved and
displayed correctly.
-
Commit messages:
- JDK-8262433: doclint: reference error in module jdk.incubator.foreign
Changes: https://git.openjdk.java.net/jdk/pull/2739/files
Webrev: https://webrevs.openjdk.java
On Fri, 26 Feb 2021 00:41:18 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to ensure that a link reference is resolved and
> displayed correctly.
This pull request has now been integrated.
Changeset: fce57656
Author:Jonathan Gibbons
URL: https://git.openjdk.java.n
Please review some minor doc fixes, for issues found by _doccheck_.There
are two kinds of errors that are addressed.
1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph.
It is not a terminator, to mark the end of a paragraph, or a separator to mark
the boundary between
icy?
This officially Oracle guide for example has a different example:
https://www.oracle.com/de/technical-resources/articles/java/javadoc-tool.html#format
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: net-dev im Auftrag von Jonathan Gibbons
Gesendet: Tuesda
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a term
Please review a trivial fix to insert a missing word.
-
Commit messages:
- JDK-8262892: minor typo in implSpec comment
Changes: https://git.openjdk.java.net/jdk/pull/2798/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2798&range=00
Issue: https://bugs.openjdk.java.ne
On Tue, 2 Mar 2021 22:01:49 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to insert a missing word.
This pull request has now been integrated.
Changeset: 93ffe6a6
Author: Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/93ffe6a6
Stats: 1 line in 1 f
Please review some simple cleanup for empty `` tags.
Two of the tags are completely redundant, and simply deleted.
The other three, in _package.html_ files are generally undesirable. Although
the presumed intent of the `id` declaration is to label the `@see` info,
proximity in the source code d
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote:
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
I'
On Mon, 26 Apr 2021 17:14:29 GMT, Pavel Rappo wrote:
>> I had been looking for an example of a "properties" file when spotted a typo
>> in `logging.properties`. I decided to proofread the file. That resulted in
>> finding a few other issues.
>
> Pavel Rappo has updated the pull request incremen
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The fi
On Tue, 1 Jun 2021 22:20:25 GMT, Nikita Gubarkov
wrote:
>> The fix fails on a Mac, where `realpath` is not available by default.
>
> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
> probably need to check `realpath` availability in idea.sh and sugges
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The fi
Please review the change to update to using jtreg 6.
The primary change is to the jib-profiles.js file, which specifies the version
of jtreg to use, for those systems that rely on this file. In addition, the
`requiredVersion` has been updated in the various `TEST.ROOT` files.
All the tests tha
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
I file
.ROOT`
> files.
>
> All the tests that could be updated ahead of time have been updated. There
> are a few tests remaining that need to be done at this time, because of the
> change in the module name for TestNG 7.3. It changed from a default of
> `testng` to and explicit `org.testn
Please review a test fix to refer to the new name of the TestNG module.
-
Commit messages:
- JDK-8268147: need to update reference to testng module for jtreg6
Changes: https://git.openjdk.java.net/jdk/pull/4325/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4325&range=
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
This pull request has now been integrated.
Changeset: d46a2c8e
Author: Jonathan Gibbons
URL:
https://git.openjdk.java.net/jdk/com
Please review a small test fix, to include hamcrest.jar, as required by the
latest version of JUnit in jtreg 6.
-
Commit messages:
- JDK-8268150: tier2: test/jdk/tools/jpackage/junit/junit.java needs updating
for jtreg 6
Changes: https://git.openjdk.java.net/jdk/pull/4328/files
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
This pull request has now been integrated.
Changeset: ef01e478
Author:Jonathan Gibbons
URL:
1 - 100 of 1028 matches
Mail list logo
