Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

On 5/6/20 9:01 PM, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ src/java.base/share/native/libjimage/imageDecompressor.cpp     No comments. Thumbs up. I think this qualifies a

Re: RFR(S) 8242504: Enhance the system clock to nanosecond precision

On 5/26/20 12:59 AM, David Holmes wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8242504 webrev: http://cr.openjdk.java.net/~dholmes/8242504/webrev/ src/hotspot/os/posix/os_posix.hpp     No comments. src/hotspot/os/posix/os_posix.inline.hpp     No comments. src/hotspot/os/posix/os_posix

Re: RFR(S) 8242504: Enhance the system clock to nanosecond precision

I'll wait for your thumbs up on the explanation. I'm good with the explanation. Thanks! Dan On 5/27/20 10:08 PM, David Holmes wrote: Hi Dan, Thanks for taking a look. On 28/05/2020 1:09 am, Daniel D. Daugherty wrote: On 5/26/20 12:59 AM, David Holmes wrote:

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

On 5/29/20 11:39 AM, Daniel Fuchs wrote: Hi, I have updated the webrev as suggested by David: http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01 test/jdk/java/util/logging/Logger/bundleLeak/BundleTest.java     No comments. Thumbs up. Dan Unless I hear any objection I'll push tha

RFR(T): 8247492: ProblemList tools/jlink/plugins/CompressorPluginTest.java

Greetings, It's time to reduce the noise in the CI so I'm ProblemListing tests. Here's the bug for failure:     JDK-8247407 tools/jlink/plugins/CompressorPluginTest.java test failing     https://bugs.openjdk.java.net/browse/JDK-8247407 and here's the bug for the ProblemListing:     JDK-824749

Re: RFR(T): 8247492: ProblemList tools/jlink/plugins/CompressorPluginTest.java

Thanks for the fast review! Dan On 6/12/20 12:02 PM, Jim Laskey wrote: +1 On Jun 12, 2020, at 1:00 PM, Daniel D. Daugherty wrote: Greetings, It's time to reduce the noise in the CI so I'm ProblemListing tests. Here's the bug for failure: JDK-8247407 tool

RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bug for the failures:     JDK-8212812 sun/nio/ch/TestMaxCachedBufferSize.java timeout     https://bugs.openjdk.java.net/browse/JDK-8212812

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

meant JDK-8248358 ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX On Jun 25, 2020, at 2:45 PM, Daniel D. Daugherty wrote: Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here&

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

On 6/26/20 2:41 AM, Alan Bateman wrote: On 25/06/2020 22:45, Daniel D. Daugherty wrote: Here's the context diff: $ hg diff diff -r cf65909b98c5 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt    Thu Jun 25 15:00:59 2020 -0400 +++ b/test/jdk/ProblemList.txt    Thu Jun 25 17:39:01

RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

Greetings, A trivial fix to make the validate-header Tier1 task happy. Here's the context diff: $ hg diff -r qparent diff -r c5202ed40b86 test/lib/jdk/test/lib/util/JarBuilder.java --- a/test/lib/jdk/test/lib/util/JarBuilder.java    Wed Jul 08 20:35:36 2020 +0100 +++ b/test/lib/jdk/test/lib/ut

Re: RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

Thanks for the fast review. I was surprised that jcheck -r tip didn't flag that, but... :-) Dan On 7/8/20 5:23 PM, igor.ignat...@oracle.com wrote: LGTM, thanks for fixing, and sorry for introducing that. — Igor On Jul 8, 2020, at 2:22 PM, Daniel D. Daugherty wrote: Greeting

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

On 7/14/20 2:09 PM, Jim Laskey wrote: Adding Daniel Begin forwarded message: *From: *Jim Laskey > *Subject: **RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)* *Date: *July 14, 2020 at 2:01:09 PM ADT *To: *core-libs-dev

RFR(T): 8250236: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-x64

Greetings, I'm making another pass at reducing the noise in the JDK16 CI. There are currently 34 sightings of this test failure since I filed the bug on 2020.07.08. I think it is time to ProblemList this test. For whatever reason, this failures only seems to be happening on Linux-X64 machines.

RFR(T): 8250236: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-x64

Accidentally pushed send before I was done. Please ignore the previous email... Greetings, I'm making another pass at reducing the noise in the JDK16 CI. There are currently 34 sightings of this test failure since I filed the bug on 2020.07.08. I think it is time to ProblemList this test. For

Re: RFR(T): 8250236: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-x64

Thanks for the fast review. Dan On 7/23/20 4:34 PM, Roger Riggs wrote: Looks good, thanks On 7/23/20 4:30 PM, Daniel D. Daugherty wrote: Accidentally pushed send before I was done. Please ignore the previous email... Greetings, I'm making another pass at reducing the noise in the

Re: RFR: 8253496: [BACKOUT] JDK-8253208 Move CDS related code to a separate class

On Tue, 22 Sep 2020 19:48:33 GMT, Ioi Lam wrote: > Please review this BACKOUT for tier-1 failures. I have tested all CDS tests > locally on Linux-x64, including the failed > DeterministicDump.java. > I would like to apply for the "trivial" rule since this is a simple backout > for tier-1 failur

RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on linux-aarch64 - Commit messages: - Merge branch 'master' into JDK-8253667 - Also ProblemList tools/jlink/JLinkReproducible3Test.java due to 8253688. - 8253667: ProblemList tools/jlink/JLinkReproducibleTest.java on l

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

On Mon, 28 Sep 2020 16:05:48 GMT, Daniel D. Daugherty wrote: > 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on > linux-aarch64 @AlanBateman - not sure if 'core-libs' was the right label to add so I figured I would ping you directly for a review.

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

On Mon, 28 Sep 2020 16:22:17 GMT, Igor Ignatyev wrote: >> test/jdk/ProblemList.txt line 859: >> >>> 857: tools/jlink/JLinkReproducibleTest.java >>> 8217166 windows-all >>> 858: tools/jlink/plugins/CompressorPluginTest.java >>> 8247407 generic-all >>>

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64 [v2]

> 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on > linux-aarch64 Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: Update existing entry for tools/jlink/JLinkReproducibleTest.java instead of creating

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64 [v2]

On Mon, 28 Sep 2020 16:28:48 GMT, Yumin Qi wrote: >> Marked as reviewed by iignatyev (Reviewer). > > Should we put this for all platforms? Nope. We're currently seeing these failures on linux-aarch64 so that's what started this ProblemListing adventure... - PR: https://git.openjdk

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64 [v2]

On Mon, 28 Sep 2020 16:16:08 GMT, Daniel Fuchs wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update existing entry for tools/jlink/JLinkReproducibleTest.java instead >> of

Integrated: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

On Mon, 28 Sep 2020 16:05:48 GMT, Daniel D. Daugherty wrote: > 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on > linux-aarch64 This pull request has now been integrated. Changeset: 821bd08c Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char) [v6]

On Wed, 14 Oct 2020 17:59:53 GMT, Roger Riggs wrote: >> This integration without testing with a current merge from the master and >> has caused two build failures. >> >> JDK-8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar >> >> JDK-8254775: Microbenchmark StringIndexOfCha

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v7]

On Wed, 21 Oct 2020 13:00:09 GMT, Martin Doerr wrote: >> CoreyAshford has updated the pull request incrementally with one additional >> commit since the last revision: >> >> CheckGraalIntrinsics.java: fix copy/paste error > > Marked as reviewed by mdoerr (Reviewer). Buried in that GitHub tes

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

Thumbs up. Dan On 5/31/19 8:02 AM, Roger Riggs wrote: +1 On 5/31/19 2:19 AM, David Holmes wrote: Hi Kim, This seems reasonable to me. Thanks, David On 31/05/2019 7:04 am, Kim Barrett wrote: On May 30, 2019, at 3:58 PM, Roger Riggs wrote: Hi Kim, To ensure you see some messages in the

Re: RFR: 8212117 : Class.forName may return a reference to a loaded but not linked Class

Brent, You currently have '-XX:+ClassForNameDeferLinking' as a 'product' option, but product options are harder to remove down the road. Would it be better as a diagnostic option? A diagnostic option requires '-XX:+UnlockDiagnosticVMOptions' to be specified before it can be used, e.g.:     j

Re: RFR: 8212117 : Class.forName may return a reference to a loaded but not linked Class

On 9/5/19 1:36 AM, David Holmes wrote: Hi Dan, With my CSR Group member hat on On 5/09/2019 8:06 am, Daniel D. Daugherty wrote: Brent, You currently have '-XX:+ClassForNameDeferLinking' as a 'product' option, but product options are harder to remove down the road.

Re: 8205132: Remove Thread.countStackFrames()

On 10/23/19 3:25 AM, Alan Bateman wrote: Thread::countStackFrames has been deprecated for 20+ years and has been marked for-removal since Java SE 9. I'd like to remove it for Java SE 14. It's was never a well-defined method and I've been unable to find anything that uses it. The StackWalker A

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

On 10/29/19 3:42 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev: http://cr.openjdk.java.net/~dholmes/8229516/webrev/ make/hotspot/symbols/symbols-unix     No comments. src/hotspot/os/

Re: 8205132: Remove Thread.countStackFrames()

On 10/29/19 12:26 PM, Alan Bateman wrote: On 23/10/2019 08:25, Alan Bateman wrote: Thread::countStackFrames has been deprecated for 20+ years and has been marked for-removal since Java SE 9. I'd like to remove it for Java SE 14. It's was never a well-defined method and I've been unable to fi

Re: Java launcher with `--module=name[/entry-point]` fails on Windows

Forwarding over to core-libs-dev@...  I think that's where launcher issues are addressed. Bcc'ing jdk-dev@... Dan On 11/15/19 6:23 AM, Christian Stein wrote: Hi, relying on the "Note: To specify an argument for a long option, you can use either --name=value or --name value." from [0] and ass

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

On 12/5/19 8:00 AM, David Holmes wrote: Hi Christoph, On 5/12/2019 9:55 pm, Langer, Christoph wrote: Hi David, thanks again for your efforts. Here is a version that ran successfully through jdk-submit (mach5-one-clanger-JDK-8234185-3-20191205-1051-7247172): http://cr.openjdk.java.net/~clang

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

On 12/6/19 3:04 AM, Langer, Christoph wrote: Thanks, David. I'll run the final change once again through jdk-submit befor pushing. Alan, Dan, may I consider this reviewed by either of you? Sorry I haven't done a full review on this change. I just happened to see the typo fly by... Dan Th

RFR(T): 8240134: ProblemList javax/script/Test7.java

Greetings, I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing javax/script/Test7.java on all platforms due to this bug:     JDK-8239361 javax/script/Test7.java failed due to ScriptException     https://bugs.openjdk.java.net/browse/JDK-8239361 I'm using the following subtask to

RFR(T): 8240134: ProblemList javax/script/Test7.java

Greetings, I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing javax/script/Test7.java on all platforms due to this bug:     JDK-8239361 javax/script/Test7.java failed due to ScriptException     https://bugs.openjdk.java.net/browse/JDK-8239361 I'm using the following subtask to

Re: RFR(T): 8240134: ProblemList javax/script/Test7.java

Thanks for the review! Dan On 2/26/20 7:36 PM, David Holmes wrote: Looks good. Thanks, David On 27/02/2020 9:03 am, Daniel D. Daugherty wrote: Greetings, I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing javax/script/Test7.java on all platforms due t

[jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

ProblemList two java/rmi/Naming tests on Windows in order to reduce the noise in the JDK16 CI. This is a trivial fix. - Commit messages: - 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows Changes: https://git.open

Re: [jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

On Tue, 22 Dec 2020 17:14:24 GMT, Phil Race wrote: >> ProblemList two java/rmi/Naming tests on Windows in order to reduce the >> noise in the JDK16 CI. This is a trivial fix. > > overdue Thanks for the fast reviews! - PR: https://git.openjdk.java.net/jdk16/pull/58

[jdk16] Integrated: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty wrote: > ProblemList two java/rmi/Naming tests on Windows in order to reduce the > noise in the JDK16 CI. This is a trivial fix. This pull request has now been integrated. Changeset: eabc9030 Author:Daniel D. Daughert

RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details). - Commit messages: - 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java Changes: https://git.openjdk.java.net/jdk/pull/2

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). @JimLaskey or @sundararajana - If either if you are on-line and can review t

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

On Mon, 1 Feb 2021 22:21:06 GMT, David Holmes wrote: >> A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on >> the >> ProblemList. It was removed in error (see the bug for the details). > > LGTM @dholmes-ora - Thanks for the fast review! - PR: https://git.op

Integrated: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). This pull request has now been integrated. Changeset: 9880c4cd Author:Da

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed

On Fri, 5 Feb 2021 21:09:37 GMT, Alex Menkov wrote: > JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools). > The fix un-problemlists RemovingUnixDomainSocketTest and changes > serviceability tests to use > OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings inste

RFR: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

A trivial fix to ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java in order to reduce noise in the JDK17 CI. - Commit messages: - 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java Changes: https://git.openjdk.java.net/jdk/pull/2531/files Webr

Re: RFR: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

On Thu, 11 Feb 2021 18:04:31 GMT, Harold Seigel wrote: >> A trivial fix to ProblemList >> jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java >> in order to reduce noise in the JDK17 CI. > > Looks good and trivial. > Thanks, Harold @hseigel - Thanks for the fast review! - PR: htt

Integrated: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

On Thu, 11 Feb 2021 17:55:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java > in order to reduce noise in the JDK17 CI. This pull request has now been integrated. Changeset: 75c8489c Author: Daniel D. Daugh

RFR: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

A trivial fix to ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. - Commit messages: - 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows Changes: https://git.openjdk.java.net/jdk/pull/2650/files

Re: RFR: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

On Fri, 19 Feb 2021 16:52:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. @JoeWang-Java - Can you please review this ProblemListing? That will allow us to reduce the noise in Tier2 and gi

Integrated: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

On Fri, 19 Feb 2021 16:52:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. This pull request has now been integrated. Changeset: 8b4fd77f Author:Daniel D. Daugherty URL:

Re: RFR: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

On Fri, 19 Feb 2021 17:29:42 GMT, Joe Wang wrote: >> A trivial fix to ProblemList >> javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. > > Marked as reviewed by joehw (Reviewer). @JoeWang-Java - Thanks for the review! - PR: https://git.openjdk.java.net/jd

Re: RFR: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java

On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato wrote: > The subject test case is failing under the JMS-enabled environment. Changes requested by dcubed (Reviewer). test/jdk/ProblemList.txt line 799: > 797: # jdk_util > 798: > 799: java/util/Locale/LocaleProvidersRun.java

RFR: 8263480: ProblemList two jpackage tests on Windows

A trivial fix to ProblemList two new tests on Windows. - Commit messages: - 8263480: ProblemList two jpackage tests on Windows Changes: https://git.openjdk.java.net/jdk/pull/2952/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2952&range=00 Issue: https://bugs.openjdk

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. @alexeysemenyukoracle or @kevinrushforth - can either of you folks review this ProblemListing? - PR: https://git.openjdk.java.net/jdk/pull/2952

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:50:03 GMT, Kevin Rushforth wrote: >> A trivial fix to ProblemList two new tests on Windows. > > Marked as reviewed by kcr (Author). @kevinrushforth - Thanks for the heads up. I've pinged in the jdk-gatekeeping Slack channel. - PR: https://git.openjdk.java.ne

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:50:03 GMT, Kevin Rushforth wrote: >> A trivial fix to ProblemList two new tests on Windows. > > Marked as reviewed by kcr (Author). @kevinrushforth and @azvegint - Thanks for the reviews! - PR: https://git.openjdk.java.net/jdk/pull/2952

Integrated: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. This pull request has now been integrated. Changeset: cf1c0219 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/cf1c0219 Stats: 2 li

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

On Sat, 13 Mar 2021 06:44:12 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this dull patch that replaces `ClassFileInstaller` >> w/ `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions >> to ensure we won't get split testlibrary, and removes >> `jdk/te

Re: RFR: 8263556: remove `@modules java.base` from tests

On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this trivial cleanup? > from JBS: > >> jtreg `@modules X` directive does two things: >> - exclude a test from execution if JDK under test doesn't have module X >> - if JDK under test has module X, m

Re: RFR: 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters

On Thu, 25 Mar 2021 13:27:45 GMT, Alexey Semenyuk wrote: > Add missing escape single quote (') and typo fix The original change in JDK-8220266 shows the introduction of three single quotes and this fix addresses all three along with another typo. Thumbs up. - Marked as reviewed by

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

On Tue, 6 Apr 2021 16:46:06 GMT, Jim Laskey wrote: >> SecureRandom is stochastic and will become unpredictable over time (hence >> the intermittent nature). > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Add bug number Mar

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

On Tue, 6 Apr 2021 16:45:15 GMT, Joe Darcy wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add bug number > > test/jdk/java/util/Random/RandomTestBsi1999.java line 443: > >> 441: >> 442: if (currentRNG.

RFR: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64

A set of trivial ProblemListing for macos-aarch64 Tier2 test failures: - JDK-8265358 ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 - JDK-8265361 ProblemList a few compiler/whitebox tests on macos-aarch64 - JDK-8265363 ProblemList java/net/Socket/UdpSocket.java on macos-aarch64 - JDK-8

Re: RFR: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 [v2]

t.java on macos-aarch64 > - JDK-8265368 ProblemList 3 java/net/httpclient/websocket tests on > macos-aarch64 > - JDK-8265370 ProblemList java/net/MulticastSocket/Promiscuous.java on > macos-aarch64 Daniel D. Daugherty has updated the pull request incrementally with one additional com

Re: RFR: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 [v2]

On Fri, 16 Apr 2021 19:42:06 GMT, Brian Burkhalter wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove changes for JDK-8265366 at @fguallini's request. > > Marked as

Integrated: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64

On Fri, 16 Apr 2021 18:07:01 GMT, Daniel D. Daugherty wrote: > A set of trivial ProblemListing for macos-aarch64 Tier2 test failures: > > - JDK-8265358 ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 > - JDK-8265361 ProblemList a few compiler/whitebox tests on macos-aar

Re: Integrated: 8267180: Typo in copyright header for HashesTest

On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote: > Please review this fix for a typo in the copyright header in HashTest which > the jdk-tier1 does not catch > > Best > Lance Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR: https://git.o

Integrated: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

A trivial fix to ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java. - Commit messages: - 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java Changes: https://git.openjdk.java.net/jdk/pull/4231/files Webrev:

Re: Integrated: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

On Thu, 27 May 2021 20:22:31 GMT, Stuart Marks wrote: >> A trivial fix to ProblemList >> javax/management/remote/mandatory/connection/RMIConnector_NPETest.java. > > Marked as reviewed by smarks (Reviewer). @stuart-marks - Thanks for the fast review. - PR: https://git.openjdk.java.

Integrated: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

On Thu, 27 May 2021 20:17:59 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > javax/management/remote/mandatory/connection/RMIConnector_NPETest.java. This pull request has now been integrated. Changeset: 8a31c075 Author:Daniel D. Daugherty URL:

Integrated: 8268146: fix for JDK-8266254 fails validate-source

A trivial copyright fix. - Commit messages: - 8268146: fix for JDK-8266254 fails validate-source Changes: https://git.openjdk.java.net/jdk/pull/4323/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4323&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268146

Re: Integrated: 8268146: fix for JDK-8266254 fails validate-source

On Wed, 2 Jun 2021 21:40:59 GMT, Paul Sandoz wrote: >> A trivial copyright fix. > > Marked as reviewed by psandoz (Reviewer). @PaulSandoz - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/pull/4323

Integrated: 8268146: fix for JDK-8266254 fails validate-source

On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote: > A trivial copyright fix. This pull request has now been integrated. Changeset: 76fdf2c8 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/76fdf2c89bb7df9140438fcbaf16ea5fda024551 Stats: 1 l

Re: Integrated: 8268146: fix for JDK-8266254 fails validate-source

On Wed, 2 Jun 2021 21:50:24 GMT, Bradford Wetmore wrote: >> A trivial copyright fix. > > LGTM @bradfordwetmore - Thanks for the review. - PR: https://git.openjdk.java.net/jdk/pull/4323

Re: RFR: 8268131: 2 java/foreign tests timed out

On Wed, 2 Jun 2021 21:20:53 GMT, Maurizio Cimadamore wrote: > This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address

Re: RFR: 8268227: java/foreign/TestUpcall.java still times out

On Fri, 4 Jun 2021 10:53:42 GMT, Maurizio Cimadamore wrote: > Turns out that adding more timeout is a lost cause here. The root cause of > the slowdown when running the test in debug build is: > > https://bugs.openjdk.java.net/browse/JDK-8266074 > > Which has also caused related test issues:

Re: RFR: 8268227: java/foreign/TestUpcall.java still times out

On Fri, 4 Jun 2021 10:53:42 GMT, Maurizio Cimadamore wrote: > Turns out that adding more timeout is a lost cause here. The root cause of > the slowdown when running the test in debug build is: > > https://bugs.openjdk.java.net/browse/JDK-8266074 > > Which has also caused related test issues:

Re: RFR: Merge jdk17

On Mon, 14 Jun 2021 14:28:33 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 Thumbs up! Thanks for doing this sync forward. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4484

[jdk17] RFR: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64. - Commit messages: - 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64 Changes: https://git.openjdk.java.net/jdk17/pull/90/files Webrev: https://webrevs.openjd

Re: [jdk17] RFR: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

On Thu, 17 Jun 2021 16:49:49 GMT, Andy Herrick wrote: >> A trivial fix to ProblemList >> tools/jpackage/windows/WinInstallerIconTest.java on win-x64. > > Marked as reviewed by herrick (Reviewer). @andyherrick - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk17/p

[jdk17] Integrated: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

On Thu, 17 Jun 2021 16:32:52 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java > on win-x64. This pull request has now been integrated. Changeset: b66001a5 Author:Daniel D. Daugherty URL: https://git.openjdk.ja

[jdk17] RFR: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt

A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt - Commit messages: - 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt Changes: https://git.openjdk.java.net/jdk17/pull/164/files Webrev: ht

Re: [jdk17] RFR: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt

On Mon, 28 Jun 2021 17:15:23 GMT, Igor Ignatyev wrote: >> A trivial fix to remove >> java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt > > Marked as reviewed by iignatyev (Reviewer). @iignatev and @tschatzl - Thanks for the fast reviews. - PR: https://git.

[jdk17] Integrated: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt

On Mon, 28 Jun 2021 17:05:49 GMT, Daniel D. Daugherty wrote: > A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java > from ProblemList.txt This pull request has now been integrated. Changeset: 20640a57 Author:Daniel D. Daugherty URL:

[jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

8271412: ProblemList javax/sound/midi/Sequencer/Looping.java - Commit messages: - 8271413: ProblemList 2 locale tests on macOS-x64 - 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java Changes: https://git.openjdk.java.net/jdk17/pull/291/files Webrev: https://webrevs.open

Re: [jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

On Wed, 28 Jul 2021 18:42:11 GMT, Naoto Sato wrote: >> 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk17/pull/291

[jdk17] Integrated: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

On Wed, 28 Jul 2021 17:51:31 GMT, Daniel D. Daugherty wrote: > 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java This pull request has now been integrated. Changeset: 7bf72ce3 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk17/com

Re: Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

On Fri, 6 Aug 2021 13:34:37 GMT, Alan Bateman wrote: >> A trivial fix to ProblemList >> java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 > > Marked as reviewed by alanb (Reviewer). @AlanBateman - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/

Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

On Fri, 6 Aug 2021 13:32:00 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 This pull request has now been integrated. Changeset: f4cf2f7c Author:Daniel D. Daugherty URL:

Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

A trivial fix to ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 - Commit messages: - 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 Changes: https://git.openjdk.java.net/jdk/pull/5032/files Webrev: https://w

Integrated: 8273197: ProblemList 2 jtools tests due to JDK-8273187

Trivial fixes to reduce the noise in the JDK18 CI: JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187 JDK-8273198 ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188 These failures happen in Tier5 so I'm ProblemListing them now to give @naotoj time to wo

Integrated: 8273197: ProblemList 2 jtools tests due to JDK-8273187

On Tue, 31 Aug 2021 19:44:08 GMT, Daniel D. Daugherty wrote: > Trivial fixes to reduce the noise in the JDK18 CI: > JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187 > JDK-8273198 ProblemList > java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-827318

RFR: 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

A trivial fix to ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs. - Commit messages: - 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs Changes: https://git.openjdk.java.net/jdk/pull/5337/files Webrev:

Re: Integrated: 8273197: ProblemList 2 jtools tests due to JDK-8273187

On Tue, 31 Aug 2021 20:02:37 GMT, Naoto Sato wrote: >> Trivial fixes to reduce the noise in the JDK18 CI: >> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187 >> JDK-8273198 ProblemList >> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188 >> >> These failures ha

Integrated: 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

On Wed, 1 Sep 2021 17:33:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs. This pull request has now been integrated. Changeset: 4ee0dace Author:Daniel D. Daugherty URL:

Re: RFR: 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

On Wed, 1 Sep 2021 17:35:12 GMT, Naoto Sato wrote: >> A trivial fix to ProblemList >> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs. > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the review! - PR: https://git.openjdk.java.net/jdk/pull/53

RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this [BACKOUT] has passed the macosx-aarch64 test task that was failing before. - Commit messages: - Revert "8276150: Quarantined jpackage apps are la

Re: RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty wrote: > This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. > > So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this > [BACKOUT] has > passed the macosx-aarch64 test task that was faili

  1   2   3   >