Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8232935/webrev.00/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources.properties.frames.html
Line 58-59: I think we do not need "." at the end of error messages to
make it same as other messages.
Do w
Hi Alexey,
Updated webrev looks fine.
Thanks,
Alexander
On 4/15/20 1:43 PM, Alexey Semenyuk wrote:
On 4/15/2020 4:21 PM, Alexander Matveev wrote:
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8232935/webrev.00/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal
Hi Alexey,
Looks good.
Thanks,
Alexander
On 4/16/20 10:37 AM, Andy Herrick wrote:
OK - I approve. - I have tested on 2 platforms and it looks good.
/Andy
On 4/15/2020 4:13 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Refactor jpackage native code.
- Improve code
Hi Andy,
http://cr.openjdk.java.net/~herrick/8219536/webrev.04/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Arguments.java.frames.html
1) Copyright year needs to be updated. Other files also needs copyright
year to be updated.
2) Line 778: Not sure why it was moved to
Hi Alexey,
Looks fine.
Thanks,
Alexander
On 4/23/20 2:34 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Implement rebranding of exe installers produced by jpackage.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8236129
[2] http://cr.openjdk.java.net/~asemeny
Hi Andy,
Looks good.
Thanks,
Alexander
On 4/28/20 10:49 AM, Alexey Semenyuk wrote:
Looks good!
- Alexey
On 4/28/2020 10:55 AM, Andy Herrick wrote:
Please review webrev at [1] to address issue [2].
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8243673/webrev.01/
[2] - https://bugs.open
Hi Andy,
http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources_ja.properties.frames.html
http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jp
Hi Andy,
Looks fine.
Thanks,
Alexander
On 4/29/20 11:36 AM, Andy Herrick wrote:
I don't think I sent out webrev.5 [6] fixing Alexander's points below.
Please Review:
[6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html
/Andy
On 4/23/2020 7:59 PM, Alexander Mat
/
On 4/29/2020 5:01 PM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 4/29/2020 2:36 PM, Andy Herrick wrote:
I don't think I sent out webrev.5 [6] fixing Alexander's points
below. Please Review:
[6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html
/Andy
On 4/23/202
Hi Andy,
Looks good.
Thanks,
Alexander
On 4/30/20 4:18 PM, Andy Herrick wrote:
revised webrev at [3] - copyrights were updated by previous issue.
/Andy
[3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/
On 4/29/2020 4:56 PM, Alexander Matveev wrote:
Hi Andy,
http
Hi Alexey,
Looks fine.
Thanks,
Alexander
On 5/1/20 1:00 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Fix vs2019 compliation error.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8244220
[2] http://cr.openjdk.java.net/~asemenyuk/8244220/webrev.00
Hi Andy,
Looks good.
Thanks,
Alexander
On 5/6/20 12:13 PM, Andy Herrick wrote:
Please review jpackage test fix to issue [1] at [2]
[1] - https://bugs.openjdk.java.net/browse/JDK-8236518
[2] - http://cr.openjdk.java.net/~herrick/8236518/webrev.01
/Andy
Hi Alexey,
Updating PATH does not look like good solution to me. Did you try to
load jli.dll by specifying full path to jli.dll when calling LoadLibary?
If it does not work, then for AddDllDirectory() did you used
LoadLibrary() or LoadLibraryEx() with LOAD_LIBRARY_SEARCH_USER_DIRS?
According
Hi Andy,
Looks good.
Thanks,
Alexander
On 5/12/2020 6:56 AM, Andy Herrick wrote:
Please review jpackage fix for issue [1] at [2].
The change allows the specified --install-dir (instead of always
/Applications) to be suggested for drag target of a DMG image.
[1] - https://bugs.openjdk.java.
either,
but if so I don't see what else can be done short of putting the
app exe in the bin dir of the runtime.
/Andy
On 5/11/2020 9:37 PM, Alexander Matveev wrote:
Hi Alexey,
Updating PATH does not look like good solution to me. Did you try
to load jli.dll by specifying full path
Hi Andy,
Looks good.
Thanks,
Alexander
On 5/13/20 7:11 AM, Andy Herrick wrote:
Please review jpackage fix for issue [1] at [2].
[1] - https://bugs.openjdk.java.net/browse/JDK-8244576
[2] - http://cr.openjdk.java.net/~herrick/8244576/webrev.01/
/Andy
Hi Andy,
Looks good.
Thanks,
Alexander
On 5/15/20 8:55 AM, Andy Herrick wrote:
Please review fix for issue [1] at [2].
The change enables packaging runtime images as a dmg on MacOS.
[1] - https://bugs.openjdk.java.net/browse/JDK-8237971
[2] - http://cr.openjdk.java.net/~herrick/8237971/webr
Please review the jpackage fix for bug [1] at [2].
- Added support for unpacking pkg.
[1] https://bugs.openjdk.java.net/browse/JDK-8237908
[2] http://cr.openjdk.java.net/~almatvee/8237908/webrev.00/
Thanks,
Alexander
Please review the jpackage fix for bug [1] at [2].
- Detach fails sometimes due to disk image being busy. Not sure what
keeps disk image busy. Probably antivirus or something else. Within
short period of time disk image can be detach. So, fix is just re-try
detach if it did not work right away
Looks good.
Thanks,
Alexander
On 5/26/20 1:43 PM, Andy Herrick wrote:
revised at [3] to combine JavaOptionsTest and JavaOptionsModular tests
[3] - http://cr.openjdk.java.net/~herrick/8245202/webrev.02/
/Andy
On 5/26/2020 8:08 AM, Andy Herrick wrote:
Please review the fix to issue [1] at [2]
Hi Alexey,
Looks good.
Thanks,
Alexander
On 5/26/20 12:26 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Get rid of duplicated code parsing version strings. Move the code
parsing version strings to dedicated classes with unit test coverage.
Also remove Mac specific i
Hi Andy,
Why we need error.lock-resource?
Also, I do not like 194 limit obtained by testing, since once new files
are introduced in runtime this value might not work anymore. Can we
check on actual file paths to make sure they have valid length?
Thanks,
Alexander
On 5/29/20 7:36 AM, Andy He
Please review the jpackage fix for bug [1] at [2].
- I was not able to reproduce this issue. Not sure why this command
returns non zero code in some cases. It still returns output which we
need, so fixed by ignoring exit code, since we will scan output for
presence of certificate anyway.
[1]
Hi Andy,
http://cr.openjdk.java.net/~herrick/8246010/webrev.03/test/jdk/tools/jpackage/share/AddLauncherTest.java.html
* additionallauncherstest*.* installer. The output installer should provide the
Should it be addlaunchertest*.*?
Otherwise looks fine.
Thanks,
Alexander
On 6/1/20 1:40 PM,
Hi Andy,
Looks good now.
Thanks,
Alexander
On 6/1/20 2:43 PM, Andy Herrick wrote:
yes - I will fix that comment in place.
/Andy
On 6/1/2020 5:18 PM, alexander.matv...@oracle.com wrote:
Hi Andy,
http://cr.openjdk.java.net/~herrick/8246010/webrev.03/test/jdk/tools/jpackage/share/AddLauncherT
Please review the jpackage fix for bug [1] at [2].
This is still a workaround for JDK-8236825. Implemented as per Roger
suggestion to redirect output to temp file. I did a lot of testing using
repro case and was not able to reproduce hang anymore.
[1] https://bugs.openjdk.java.net/browse/JDK-
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 9:21 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Replace xargs call with --no-run-if-empty parameter with bash
expressions in run_tests.sh
Call run_tests.sh from test_jpackager.sh in a way to avoid shebang
interpr
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 1:22 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Move functionality to collect data about app (main class name, main
jar, module name, etc) from JLinkBundlerHelper and
StandardBundlerParam classes in dedicated Lau
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 1:46 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Move duplicated functionality from LinuxAppBundler, MacAppBundler and
WinAppBundler classes in the base class.
[2] webrev is on top of [3] webrev.
- Alexey
[1] h
Hi Andy,
Looks good. For changing "jpackagerTest.keychain" to
""jpackageTest.keychain" we can file followup bug for this, since SQE
depend on this value to be "jpackagerTest.keychain".
Thanks,
Alexander
On 6/5/20 2:27 PM, Alexey Semenyuk wrote:
In SigningBase.java:
---
KEYCHAIN = (value ==
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/8/20 7:26 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Add support to jpackage to create Linux packages installing app images
in '/usr' tree with splicing of the app image.
For --install-dir=/usr jpackag option the res
Please review the jpackage fix for bug [1] at [2].
Added support for additional (macOS specific) file association
properties. These additional properties should be set via same property
file which used for file association. Names and values for properties
should match name and values as docume
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8233215/webrev.01/
- TKit.assertStringListEquals() will be used instead. Did not noticed
that we had this method already. I removed my implementation.
- Added "mac." prefix.
Thanks,
Alexander
On 6/8/20 10:57 PM, Alexey Semenyuk wrote:
Alexande
Hi Andy,
http://cr.openjdk.java.net/~almatvee/8233215/webrev.02/
Moved new mac specific parameters to MacAppImageBuilder.
Thanks,
Alexander
On 6/9/20 4:41 AM, Andy Herrick wrote:
I would think the new mac specific BundlerParamInfo would be defined
in MacAppImageBuilder instead of StandardBund
Please review the jpackage fix for bug [1] at [2].
To unpack msi we using /a argument which is not exactly an installation.
In this mode (Administrative installation) msi will extract files and
also creates .msi installer to install these files. For some reason
empty folders are not created du
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/10/20 9:21 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Minor jpackage jtreg tests clean up of issues uncovered during the
recent local test runs.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8247353
[2] htt
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/10/20 9:41 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
On Windows encode arguments for JNI_Launch() call with an encoding of
the current process ANSI code page instead of utf8.
- Alexey
[1] https://bugs.openjdk.java.
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/10/20 2:40 PM, Andy Herrick wrote:
looks good -
This works for me finally.
/Andy
On 6/10/2020 5:29 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Move `.jpackage.xml` file in `app` directory of app image and keep it
in
Looks good.
Thanks,
Alexander
On 6/11/20 1:19 PM, Andy Herrick wrote:
looks good.
/Andy
On 6/11/2020 1:23 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Restore handling not only Java runtime home but also Java runtime
root directory in `--runtime-image` option on M
Hi Andy,
Looks good.
Thanks,
Alexander
On 6/11/20 1:22 PM, Andy Herrick wrote:
Please review the small jpackage test fix at [1] to issue [2].
[1] http://cr.openjdk.java.net/~herrick/8247418/webrev.01/
[2] https://bugs.openjdk.java.net/browse/JDK-8247418
/Andy
Hi Alexey,
Looks good. I think you got links and bug ID incorrect. It should be
JDK-8246244 and you have 8264244. Links also does not work. Working
links are:
https://bugs.openjdk.java.net/browse/JDK-8246244
http://cr.openjdk.java.net/~asemenyuk/8246244/webrev.00/
Thanks,
Alexander
On 6/16/2
Please review the jpackage fix for bug [1] at [2].
Cleanup import statements.
[1] https://bugs.openjdk.java.net/browse/JDK-8225251
[2] http://cr.openjdk.java.net/~almatvee/8225251/webrev.00/
Thanks,
Alexander
Hi Alexey,
Andy mentioned in issue description not to expend static imports, this
is why all static imports were not expended. I can expend them or we can
keep as is. I am fine with either way. Andy any comments why we do not
need to expend static imports?
Thanks,
Alexander
On 6/19/20 10:49
http://cr.openjdk.java.net/~almatvee/8225251/webrev.01/
- Expended "import static org.junit.Assert.*" and "import static
jdk.incubator.jpackage.internal.StandardBundlerParam.*".
- Fixed inconsistency between imported StandardBundlerParam or when used
directly. See
http://cr.openjdk.java.net/~a
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/23/20 10:53 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Fix how icon is configured for installers on Windows. The value of
ARPPRODUCTICON property should point to an entry in Icon table of msi
rather to a path of icon
Please review the jpackage fix for bug [1] at [2].
Added EmptyFolderPackageTest, IconTest, AppImagePackageTest,
SimplePackageTest, BasicTest to ProblemList.txt.
[1] https://bugs.openjdk.java.net/browse/JDK-8248255
[2] http://cr.openjdk.java.net/~almatvee/8248255/webrev.00/
Thanks,
Alexander
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/26/20 9:48 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Put `RemoveExistingProducts` action before `CostInitialize` action in
`InstallExecuteSequence` sequence to uninstall existing product(s)
before installer makes cha
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/26/20 2:02 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Makes value of `JpIcon` wix variable absolute path. This fixes a
regression introduced by the fix of [3] issue.
- Alexey
[1] https://bugs.openjdk.java.net/browse
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/26/20 4:30 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Fix jpackage code to be able to locate app module if it is linked in
external runtime. The suggested fix only verifies if app module exists
in external runtime. It
Please review the jpackage fix for bug [1] at [2].
Added fallback for creating DMG if original approach fails. In original
approach DMG will be created by providing app image to hdiutil. It was
noticed that helper sub-processes run by hdiutil to copy app image
sometimes crashed or failed durin
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8248059/webrev.01/
- Removed getFilesSizeInFolder() method and size will be calculated as
per your suggestion.
Thanks,
Alexander
On 6/26/20 8:16 PM, Alexey Semenyuk wrote:
Hi Alexander,
MacDmgBundler.java:
---
94 } catch (IOException
Hi Alexey,
No, it is not used. I forgot to remove it. Patch updated:
http://cr.openjdk.java.net/~almatvee/8248059/webrev.02/
Thanks,
Alexander
On 6/29/20 7:47 AM, Alexey Semenyuk wrote:
Alexander,
Is `error.cannot-calculate-folder-size` l10n property still used in
the new patch?
- Alexey
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/2/2020 3:53 PM, Andy Herrick wrote:
Please review jpackage fix for issue [1] at [2].
The class path was no longer set correctly when jars are in a
sub-directory of the input dir.
/Andy
[1] - https://bugs.openjdk.java.net/browse/JDK-8248501
[2]
Please review the jpackage fix for bug [1] at [2].
Substituted old File APIs with Path/Files APIs when it was possible and
makes sense.
[1] https://bugs.openjdk.java.net/browse/JDK-8223955
[2] http://cr.openjdk.java.net/~almatvee/8223955/webrev.00/
Thanks,
Alexander
Please review the jpackage fix for bug [1] at [2].
Added timestamp to verbose and test output in form of [HH:mm:ss.SSS].
[1] https://bugs.openjdk.java.net/browse/JDK-8248261
[2] http://cr.openjdk.java.net/~almatvee/8248261/webrev.00/
Thanks,
Alexander
Hi Andy,
Timestamps for error message without verbose output are meaningless in
my opinion. This is why I did not add them. Also, in some cases output
does not look right. For example when timestamp is added to error
message always:
jpackage --someoption
WARNING: Using incubator modules: jdk.
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/8/20 9:18 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 7/8/2020 10:34 AM, Andy Herrick wrote:
Please review change at [1] to issue [2] removing the
"--bind-services" option from jpackage.
/Andy
[1] http://cr.openjdk.java.net/~herrick/824
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8248261/webrev.01/
- Added fatalError() to log fatal errors without timestamp.
- Added missing timestamp to Log.verbose(Throwable t).
Thanks,
Alexander
On 7/8/20 9:34 AM, Alexey Semenyuk wrote:
I still think it would be good to create dedicated m
Hi Alexey,
Looks good. Only suggestion is to move CmdlineExecutor to Executor class
and make it configurable for error message and probably attempts and
timeout in case if we need such functionality in other places.
Thanks,
Alexander
On 7/8/20 6:37 PM, Alexey Semenyuk wrote:
Please review f
Hi Alexey,
Looks good.
Thanks,
Alexander
On 7/9/20 12:49 PM, Alexey Semenyuk wrote:
Hi Alexander,
Agreed with your suggestion. Updated review available at [1].
- Alexey
[1] http://cr.openjdk.java.net/~asemenyuk/8247229/webrev.01/webrev.01/
On 7/9/2020 12:21 AM, alexander.matv...@oracle.com
Please review the jpackage fix for bug [1] at [2].
EmptyFolderPackageTest.java added to ProblemList.
[1] https://bugs.openjdk.java.net/browse/JDK-8249256
[2] http://cr.openjdk.java.net/~almatvee/8249256/webrev.00/
Thanks,
Alexander
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/13/2020 1:26 PM, Andy Herrick wrote:
please review trivial jpackage fix to issue [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8248687
[2] http://cr.openjdk.java.net/~herrick/8248687/webrev.01/
/Andy
Please review the jpackage fix for bug [1] at [2].
Added missing ",".
[1] https://bugs.openjdk.java.net/browse/JDK-8249264
[2] http://cr.openjdk.java.net/~almatvee/8249264/webrev.00/
Thanks,
Alexander
Hi Andy,
Can you double check two other places where File.list() was introduced
with JDK-8223955 for similar issues?
One in MacPkgBundler.java and second in DeployParams.java.
Thanks,
Alexander
On 7/15/20 3:09 PM, Alexey Semenyuk wrote:
Andy,
Stream.close() call is missing on the result of
Please review the jpackage fix for bug [1] at [2].
- "hdiutil detach" resource busy error is fixed in same way as
JDK-8242786 by repeating detach several times.
- pkgbuild timeout will be covered with JDK-8249395.
[1] https://bugs.openjdk.java.net/browse/JDK-8245311
[2] http://cr.openjdk.java.
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/16/20 11:44 AM, Andy Herrick wrote:
yes - revised as suggested - please re review.
/Andy
On 7/15/2020 6:41 PM, alexander.matv...@oracle.com wrote:
Hi Andy,
Can you double check two other places where File.list() was
introduced with JDK-8223955 f
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/16/20 2:23 PM, Andy Herrick wrote:
Please review fix for jpackage bug [1] at [2].
The behavior is to allow (after a warning message) case where user has
multiple certificates matching the given mac-signing-key-user-name,
and to allow the full cert
Hi Alexey,
Fixed as per your suggestion:
http://cr.openjdk.java.net/~almatvee/8245311/webrev.01/
Thanks,
Alexander
On 7/17/20 4:26 PM, Alexey Semenyuk wrote:
Alexander,
The change in RetryExecutor.java results in Executor instance created
only once and not every time command line should be e
Please review the jpackage fix for bug [1] at [2].
It is not clear why script was hanging for more than 7 minutes which
caused test to timeout. Fixed by limiting script execution time to 3
minutes. Also, EmptyFolderPackageTest was removed from ProblemList.
[1] https://bugs.openjdk.java.net/br
http://cr.openjdk.java.net/~almatvee/8248248/webrev.01/
- Added INFINITE_TIMEOUT instead of -1.
- Fix actually did not work correctly and process never timeout, since
we were reading process output and wait with timeout never executed,
since reading output was continue until process terminated.
Looks good.
Thanks,
Alexander
On 7/24/20 12:39 PM, Andy Herrick wrote:
looks good
/Andy
On 7/21/2020 2:27 PM, Alexey Semenyuk wrote:
Hi Aleksei,
Looks good!
- Alexey
On 7/21/2020 11:42 AM, Aleksei Voitylov wrote:
Hi,
This is the updated fix which checks if LD_LIBRARY_PATH has been
chan
Please review the jpackage fix for bug [1] at [2].
- DMG image can get detach even if "hdiutil detach" return resource busy
error. Fixed by stopping trying detach if DMG already got detach.
[1] https://bugs.openjdk.java.net/browse/JDK-8250646
[2] http://cr.openjdk.java.net/~almatvee/8250646/we
Hi Alexey,
Without modifying some logic in Executor, yes stop is needed. After
retryExecutor.stop(); is executed in MacDmgBundler we will still run
command (same with abort), and this command will fail and exception will
be thrown. Stop() is basically like abort, but exception is ignored.
Th
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/
I removed stop method. Also, if we called abort from MacDMGBundler
exception will be ignored.
Thanks,
Alexander
On 8/3/20 10:10 AM, Alexey Semenyuk wrote:
On 7/31/2020 7:36 PM, alexander.matv...@oracle.com wrote:
Hi Alexe
Hi Andy,
Looks good.
Thanks,
Alexander
On 8/5/20 1:17 PM, Andy Herrick wrote:
Please review this jpackage fix at [1] to issue [2]
[1] - http://cr.openjdk.java.net/~herrick/8251184/
[2] - https://bugs.openjdk.java.net/browse/JDK-8251184
/Andy
Please review the jpackage fix for bug [1] at [2].
- Fixed by converting path of executable to real path if
_NSGetExecutablePath() returned symbolic link.
[1] https://bugs.openjdk.java.net/browse/JDK-8248905
[2] http://cr.openjdk.java.net/~almatvee/8248905/webrev.00/
Thanks,
Alexander
Hi Alexey,
Webrev updated:
http://cr.openjdk.java.net/~almatvee/8248905/webrev.01/
Thanks,
Alexander
On 8/7/20 3:36 PM, Alexey Semenyuk wrote:
Looks good. Minor suggestion, please change
---
tstring getRealPath(std::vector in)
---
to
---
tstring getRealPath(const std::vector& in);
---
- Alexe
Hi Alexey,
Looks good.
Thanks,
Alexander
On 8/10/20 9:09 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
The fix adds ability to jpackage to hook up custom WiX localization
files from resource directory. This allows to create .msi installers
with custom locales, not j
Please review the jpackage fix for bug [1] at [2].
- Looks like issue was just in not enough time for test to execute.
Increasing timeout by 1 min fixed issues. In fix it is increased by 50%
just in case. Without timeout increase it was reproducible 100% on one
of test machine. With increased
Hi Andy,
Looks good.
Thanks,
Alexander
On 8/13/20 12:35 PM, Andy Herrick wrote:
Please review this jpackage fix for issue [1] at [2].
In order to show splash screen from statically linked applauncher, we
need to load the dependent libraries of splashscreen.dll first
(java.dll and jvm.dll).
Hi Joe,
None. Most time is spend when pkgbuild is executed which is external
tool. Based on log our code does not consume a lot of time during
execution. Based on one of the runs total time was 11 min: 1 min for
jlink, 4 min for hdutil create and 4 min for pkgbuild, so test itself
took 2 min.
Hi Andy,
Looks good.
Thanks,
Alexander
On 8/14/20 7:05 AM, Andy Herrick wrote:
Please review revised webrev [3] that does not check for client jvm
are (always use server)
/Andy
[3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02
On 8/13/2020 6:03 PM, Philip Race wrote:
Do I underst
Hi Andy,
Looks good.
Thanks,
Alexander
On 8/24/20 4:53 PM, Alexey Semenyuk wrote:
Looks good!
- Alexey
On 8/24/2020 6:23 PM, Andy Herrick wrote:
On 8/24/2020 5:08 PM, Alexey Semenyuk wrote:
Andy,
I'd propose instead of checking if the app is bundled with proper
runtime in the test case,
setlocale() affects several C functions. We do not use most of these functions.
We only using isspace() and toLower().
Based on how we use it I do not see any needs for setlocale(). After removing
it I retested jpackage by changing
locally on machine and using different language as input paramete
On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev
wrote:
> setlocale() affects several C functions. We do not use most of these
> functions. We only using isspace() and toLower().
> Based on how we use it I do not see any needs for setlocale(). After removing
> it I retested
: core-libs-dev im Auftrag von Alexander
Matveev
Gesendet: Saturday, September 12, 2020 4:22:31 AM
An: core-libs-dev@openjdk.java.net
Betreff: RFR: 8223187: Investigate setLocale() call in jpackage native launcher
setlocale() affects several C functions. We do not use most of these functions
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote:
> JDK-8230652
> Extracting the commands displayed by verbose output (including commands
> called thru ToolProvider) , to contain the the
> command, it's output, and it's return value on separate lines and formatted
> in a way that they can b
https://bugs.openjdk.java.net/browse/JDK-8231591
- Added MultiLauncherTwoPhaseTest which uses predefine app image with multiple
launcher and tests to make sure installer
will create shortcuts for all launchers.
- Fixed Linux DesktopIntegration to create shortcuts for additional launcher if
we
On Mon, 21 Sep 2020 14:05:08 GMT, Alexey Semenyuk wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8231591
>>
>> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
>> multiple launcher and tests to make sure installer
>> will create shortcuts for all launchers.
>> - Fixed
On Mon, 21 Sep 2020 14:39:33 GMT, Alexey Semenyuk wrote:
> How about testing of other jpackage command line options in two phase mode?
> Like "--name", "--version"? Any plans to
> add them?
Plan was to file separate bugs for any additional options. I do not think we
should put everything in on
uts for additional launcher
> if we using pre-define app image.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8231591: [TESTBUG] Create additional two phase jpackage tests (revision 1)
-
Changes:
- all: https:/
uts for additional launcher
> if we using pre-define app image.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8231591: [TESTBUG] Create additional two phase jpackage tests (revision 2)
-
Changes:
- all: https:/
On Tue, 22 Sep 2020 11:53:14 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then comple
On Tue, 22 Sep 2020 11:53:14 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then comple
Hi Michael,
For file association you will need to create property file and pass it
to jpackage via --file-associations.
Example property file:
mime-type=text/plain
extension=txt
description=Text file
See following documentation:
https://docs.oracle.com/en/java/javase/15/jpackage/support-applic
On Wed, 23 Sep 2020 13:59:25 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then comple
On Wed, 23 Sep 2020 18:07:18 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8231591: [TESTBUG] Create additional two phase jpackage tests (revision 2)
>
> t
On Thu, 24 Sep 2020 14:14:54 GMT, Andy Herrick wrote:
> 8253379: [windows] Several jpackage tests failed with error code 1638
> two windows specific test fixes in WindowsHelper:
> 1.) do not test that the parent directory of a windows menu shortcut is empty
> after shortcut is uninstalled (there
On Thu, 24 Sep 2020 13:50:07 GMT, Alexey Semenyuk wrote:
>> But test calls AdditionalLauncher.applyTo(JPackageCommand cmd), which does
>> not have reference to PackageTest. Do you
>> know why we need two applyTo()?
>
> Just change the test code to call AdditionalLauncher.applyTo(PackageTest):
>
On Thu, 24 Sep 2020 23:35:15 GMT, Alexander Matveev
wrote:
>> Just change the test code to call AdditionalLauncher.applyTo(PackageTest):
>> `launcher1.applyTo(packageTest);
>> launcher2.applyTo(packageTest)`
>>
>> AdditionalLauncher.applyTo(JPackageComma
1 - 100 of 503 matches
Mail list logo