Re: RFR: JDK-8232935: jpackage failed with NPE whenever --file-associations provided

2020-04-15 Thread Alexander Matveev
Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8232935/webrev.00/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources.properties.frames.html Line 58-59: I think we do not need "." at the end of error messages to make it same as other messages. Do w

Re: RFR: JDK-8232935: jpackage failed with NPE whenever --file-associations provided

2020-04-15 Thread Alexander Matveev
Hi Alexey, Updated webrev looks fine. Thanks, Alexander On 4/15/20 1:43 PM, Alexey Semenyuk wrote: On 4/15/2020 4:21 PM, Alexander Matveev wrote: Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8232935/webrev.00/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-17 Thread Alexander Matveev
Hi Alexey, Looks good. Thanks, Alexander On 4/16/20 10:37 AM, Andy Herrick wrote: OK - I approve. - I have tested on 2 platforms and it looks good. /Andy On 4/15/2020 4:13 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Refactor jpackage native code. - Improve code

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-23 Thread Alexander Matveev
Hi Andy, http://cr.openjdk.java.net/~herrick/8219536/webrev.04/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Arguments.java.frames.html 1) Copyright year needs to be updated. Other files also needs copyright year to be updated. 2) Line 778: Not sure why it was moved to

Re: RFR: JDK-8236129: Exe installers have wrong properties

2020-04-23 Thread Alexander Matveev
Hi Alexey, Looks fine. Thanks, Alexander On 4/23/20 2:34 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Implement rebranding of exe installers produced by jpackage. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8236129 [2] http://cr.openjdk.java.net/~asemeny

Re: RFR: JDK-8243673: Mac signing process should not use --deep arg.

2020-04-28 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 4/28/20 10:49 AM, Alexey Semenyuk wrote: Looks good! - Alexey On 4/28/2020 10:55 AM, Andy Herrick wrote: Please review webrev at [1] to address issue [2]. /Andy [1] - http://cr.openjdk.java.net/~herrick/8243673/webrev.01/ [2] - https://bugs.open

Re: RFR: JDK-8244018: No error message for non-existent icon path

2020-04-29 Thread Alexander Matveev
Hi Andy, http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources_ja.properties.frames.html http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jp

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-29 Thread Alexander Matveev
Hi Andy, Looks fine. Thanks, Alexander On 4/29/20 11:36 AM, Andy Herrick wrote: I don't think I sent out webrev.5 [6] fixing Alexander's points below. Please Review: [6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html /Andy On 4/23/2020 7:59 PM, Alexander Mat

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-30 Thread Alexander Matveev
/ On 4/29/2020 5:01 PM, Alexey Semenyuk wrote: Looks good. - Alexey On 4/29/2020 2:36 PM, Andy Herrick wrote: I don't think I sent out webrev.5 [6] fixing Alexander's points below. Please Review: [6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html /Andy On 4/23/202

Re: RFR: JDK-8244018: No error message for non-existent icon path

2020-04-30 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 4/30/20 4:18 PM, Andy Herrick wrote: revised webrev at [3] - copyrights were updated by previous issue. /Andy [3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/ On 4/29/2020 4:56 PM, Alexander Matveev wrote: Hi Andy, http

Re: RFR: JDK-8244220 : Compiler error in jpackage with VS2019

2020-05-01 Thread Alexander Matveev
Hi Alexey, Looks fine. Thanks, Alexander On 5/1/20 1:00 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Fix vs2019 compliation error. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8244220 [2] http://cr.openjdk.java.net/~asemenyuk/8244220/webrev.00

Re: RFR: JDK-8236518: There is no Native Packages WinUpgradeUUIDTest-2.0.exe after creating Native packages on win

2020-05-06 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 5/6/20 12:13 PM, Andy Herrick wrote: Please review jpackage test fix to issue [1] at [2] [1] - https://bugs.openjdk.java.net/browse/JDK-8236518 [2] - http://cr.openjdk.java.net/~herrick/8236518/webrev.01 /Andy

Re: RFR: JDK-8244634:, LoadLibraryW failed from tools/jpackage tests after JDK-8242302

2020-05-11 Thread Alexander Matveev
Hi Alexey, Updating PATH does not look like good solution to me. Did you try to load jli.dll by specifying full path to jli.dll when calling LoadLibary? If it does not work, then for AddDllDirectory() did you used LoadLibrary() or LoadLibraryEx() with LOAD_LIBRARY_SEARCH_USER_DIRS? According

Re: RFR: JDK-8244758,: DMG bundler ignores --install-dir option.

2020-05-12 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 5/12/2020 6:56 AM, Andy Herrick wrote: Please review jpackage fix for issue [1] at [2]. The change allows the specified --install-dir (instead of always /Applications) to be suggested for drag target of a DMG image. [1] - https://bugs.openjdk.java.

Re: RFR: JDK-8244634:, LoadLibraryW failed from tools/jpackage tests after JDK-8242302

2020-05-12 Thread Alexander Matveev
either, but if so I don't see what else can be done short of putting the app exe in the bin dir of the runtime. /Andy On 5/11/2020 9:37 PM, Alexander Matveev wrote: Hi Alexey, Updating PATH does not look like good solution to me. Did you try to load jli.dll by specifying full path

Re: RFR: JDK-8244576: [macos] Volume icon deleted by osascript for background image

2020-05-13 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 5/13/20 7:11 AM, Andy Herrick wrote: Please review jpackage fix for issue [1] at [2]. [1] - https://bugs.openjdk.java.net/browse/JDK-8244576 [2] - http://cr.openjdk.java.net/~herrick/8244576/webrev.01/ /Andy

Re: RFR: JDK-823797: ,Package type for runtime image on macosx

2020-05-15 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 5/15/20 8:55 AM, Andy Herrick wrote: Please review fix for issue [1] at [2]. The change enables packaging runtime images as a dmg on MacOS. [1] - https://bugs.openjdk.java.net/browse/JDK-8237971 [2] - http://cr.openjdk.java.net/~herrick/8237971/webr

RFR: 8237908: [TESTBUG] [macos] Add support to jtreg helpers to unpack pkg packages

2020-05-21 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - Added support for unpacking pkg. [1] https://bugs.openjdk.java.net/browse/JDK-8237908 [2] http://cr.openjdk.java.net/~almatvee/8237908/webrev.00/ Thanks, Alexander

RFR: 8242786: [macos] tools/jpackage/share/IconTest.java fails: ABORT trying to dequeue work

2020-05-22 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - Detach fails sometimes due to disk image being busy. Not sure what keeps disk image busy. Probably antivirus or something else. Within short period of time disk image can be detach. So, fix is just re-try detach if it did not work right away

Re: RFR: JDK-8245202: Convert existing jpackage tests to newer form.

2020-05-26 Thread alexander . matveev
Looks good. Thanks, Alexander On 5/26/20 1:43 PM, Andy Herrick wrote: revised at [3] to combine JavaOptionsTest and JavaOptionsModular tests [3] - http://cr.openjdk.java.net/~herrick/8245202/webrev.02/ /Andy On 5/26/2020 8:08 AM, Andy Herrick wrote: Please review the fix to issue [1] at [2]

Re: RFR: JDK-8245831: Unify code parsing version strings on Mac and Windows

2020-05-26 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 5/26/20 12:26 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Get rid of duplicated code parsing version strings. Move the code parsing version strings to dedicated classes with unit test coverage. Also remove Mac specific i

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

2020-05-29 Thread alexander . matveev
Hi Andy, Why we need error.lock-resource? Also, I do not like 194 limit obtained by testing, since once new files are introduced in runtime this value might not work anymore. Can we check on actual file paths to make sure they have valid length? Thanks, Alexander On 5/29/20 7:36 AM, Andy He

RFR: 8232841: [TESTBUG] [macos] SigningPackageTest fails when untrusted certificates exist on machine

2020-05-29 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - I was not able to reproduce this issue. Not sure why this command returns non zero code in some cases. It still returns output which we need, so fixed by ignoring exit code, since we will scan output for presence of certificate anyway. [1]

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

2020-06-01 Thread alexander . matveev
Hi Andy, http://cr.openjdk.java.net/~herrick/8246010/webrev.03/test/jdk/tools/jpackage/share/AddLauncherTest.java.html * additionallauncherstest*.* installer. The output installer should provide the Should it be addlaunchertest*.*? Otherwise looks fine. Thanks, Alexander On 6/1/20 1:40 PM,

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

2020-06-01 Thread Alexander Matveev
Hi Andy, Looks good now. Thanks, Alexander On 6/1/20 2:43 PM, Andy Herrick wrote: yes - I will fix that comment in place. /Andy On 6/1/2020 5:18 PM, alexander.matv...@oracle.com wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8246010/webrev.03/test/jdk/tools/jpackage/share/AddLauncherT

RFR: 8236282: [macos] Find permanent solution to macOS test timeout problem JDK-8235738

2020-06-04 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. This is still a workaround for JDK-8236825. Implemented as per Roger suggestion to redirect output to temp file. I did a lot of testing using repro case and was not able to reproduce hang anymore. [1] https://bugs.openjdk.java.net/browse/JDK-

Re: JDK-8238204: run_tests.sh fails on macOS when called from test_jpackage.sh

2020-06-04 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/4/20 9:21 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Replace xargs call with --no-run-if-empty parameter with bash expressions in run_tests.sh Call run_tests.sh from test_jpackager.sh in a way to avoid shebang interpr

Re: RFR: JDK-824662: Refactor JLinkBundlerHelper and StandardBundlerParam classes

2020-06-04 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/4/20 1:22 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Move functionality to collect data about app (main class name, main jar, module name, etc) from JLinkBundlerHelper and StandardBundlerParam classes in dedicated Lau

Re: RFR: JDK-8246627: Consolidate app image bundlers

2020-06-04 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/4/20 1:46 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Move duplicated functionality from LinuxAppBundler, MacAppBundler and WinAppBundler classes in the base class. [2] webrev is on top of [3] webrev. - Alexey [1] h

Re: RFR: JDK-8246706: [macos] Allow SigningPackageTest to be built with real certificates

2020-06-08 Thread alexander . matveev
Hi Andy, Looks good. For changing "jpackagerTest.keychain" to ""jpackageTest.keychain" we can file followup bug for this, since SQE depend on this value to be "jpackagerTest.keychain". Thanks, Alexander On 6/5/20 2:27 PM, Alexey Semenyuk wrote: In SigningBase.java: --- KEYCHAIN = (value ==

Re: RFR: JDK-8231283: Evaluate option to install Linux packages in /usr hierarchy

2020-06-08 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/8/20 7:26 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Add support to jpackage to create Linux packages installing app images in '/usr' tree with splicing of the app image. For --install-dir=/usr jpackag option the res

RFR: 8233215: jpackage doesn't allow enough flexibility for file type binding

2020-06-08 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Added support for additional (macOS specific) file association properties. These additional properties should be set via same property file which used for file association. Names and values for properties should match name and values as docume

Re: RFR: 8233215: jpackage doesn't allow enough flexibility for file type binding

2020-06-08 Thread alexander . matveev
Hi Alexey, http://cr.openjdk.java.net/~almatvee/8233215/webrev.01/ - TKit.assertStringListEquals() will be used instead. Did not noticed that we had this method already. I removed my implementation. - Added "mac." prefix. Thanks, Alexander On 6/8/20 10:57 PM, Alexey Semenyuk wrote: Alexande

Re: RFR: 8233215: jpackage doesn't allow enough flexibility for file type binding

2020-06-09 Thread alexander . matveev
Hi Andy, http://cr.openjdk.java.net/~almatvee/8233215/webrev.02/ Moved new mac specific parameters to MacAppImageBuilder. Thanks, Alexander On 6/9/20 4:41 AM, Andy Herrick wrote: I would think the new mac specific BundlerParamInfo would be defined in MacAppImageBuilder instead of StandardBund

RFR: 8245788: EmptyFolderPackageTest fails on Windows 10

2020-06-10 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. To unpack msi we using /a argument which is not exactly an installation. In this mode (Administrative installation) msi will extract files and also creates .msi installer to install these files. For some reason empty folders are not created du

Re: RFR: JDK-8247353: jtreg tests minor issues clean up

2020-06-10 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/10/20 9:21 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Minor jpackage jtreg tests clean up of issues uncovered during the recent local test runs. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8247353 [2] htt

Re: RFR: JDK-8246042: Non-ASCII characters are not handled correctly in the native launcher

2020-06-10 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/10/20 9:41 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. On Windows encode arguments for JNI_Launch() call with an encoding of the current process ANSI code page instead of utf8. - Alexey [1] https://bugs.openjdk.java.

Re: RFR: JDK-8246792: Mac signing tests failed (unsealed contents present in the bundle root)

2020-06-10 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/10/20 2:40 PM, Andy Herrick wrote: looks good - This works for me finally. /Andy On 6/10/2020 5:29 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Move `.jpackage.xml` file in `app` directory of app image and keep it in

Re: RFR: JDK-8247422: --runtime-image on Mac should work for runtime root

2020-06-11 Thread alexander . matveev
Looks good. Thanks, Alexander On 6/11/20 1:19 PM, Andy Herrick wrote: looks good. /Andy On 6/11/2020 1:23 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Restore handling not only Java runtime home but also Java runtime root directory in `--runtime-image` option on M

Re: RFR: JDK-8247418: Only validate the certificates trust if using the default key user name.

2020-06-11 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 6/11/20 1:22 PM, Andy Herrick wrote: Please review the small jpackage test fix at [1] to issue [2]. [1] http://cr.openjdk.java.net/~herrick/8247418/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8247418 /Andy

Re: RFR: JDK-8264244: BasicShortcutHintTest shortcut can not be found

2020-06-16 Thread Alexander Matveev
Hi Alexey, Looks good. I think you got links and bug ID incorrect. It should be JDK-8246244 and you have 8264244. Links also does not work. Working links are: https://bugs.openjdk.java.net/browse/JDK-8246244 http://cr.openjdk.java.net/~asemenyuk/8246244/webrev.00/ Thanks, Alexander On 6/16/2

RFR: 8225251: Minimise import statements in jpackage sources

2020-06-19 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Cleanup import statements. [1] https://bugs.openjdk.java.net/browse/JDK-8225251 [2] http://cr.openjdk.java.net/~almatvee/8225251/webrev.00/ Thanks, Alexander

Re: RFR: 8225251: Minimise import statements in jpackage sources

2020-06-19 Thread alexander . matveev
Hi Alexey, Andy mentioned in issue description not to expend static imports, this is why all static imports were not expended. I can expend them or we can keep as is. I am fine with either way. Andy any comments why we do not need to expend static imports? Thanks, Alexander On 6/19/20 10:49

Re: RFR: 8225251: Minimise import statements in jpackage sources

2020-06-19 Thread alexander . matveev
http://cr.openjdk.java.net/~almatvee/8225251/webrev.01/ - Expended "import static org.junit.Assert.*" and "import static jdk.incubator.jpackage.internal.StandardBundlerParam.*". - Fixed inconsistency between imported StandardBundlerParam or when used directly. See http://cr.openjdk.java.net/~a

Re: RFR: JDK-8246212: JPKG001-012: application icon is missing in Control Panel Add/Remove

2020-06-23 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/23/20 10:53 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Fix how icon is configured for installers on Windows. The value of ARPPRODUCTICON property should point to an entry in Icon table of msi rather to a path of icon

[15] RFR: 8248255: [macos] Add failing DMG tests to problem list

2020-06-24 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Added EmptyFolderPackageTest, IconTest, AppImagePackageTest, SimplePackageTest, BasicTest to ProblemList.txt. [1] https://bugs.openjdk.java.net/browse/JDK-8248255 [2] http://cr.openjdk.java.net/~almatvee/8248255/webrev.00/ Thanks, Alexander

Re: RFR: JDK-8248264: WinUpgradeUUIDTest application is missing in downgrade scenario

2020-06-26 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 9:48 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Put `RemoveExistingProducts` action before `CostInitialize` action in `InstallExecuteSequence` sequence to uninstall existing product(s) before installer makes cha

Re: RFR: JDK-8248427: jpackage jtreg BasicTest.testTemp() test fails on Windows

2020-06-26 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 2:02 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Makes value of `JpIcon` wix variable absolute path. This fixes a regression introduced by the fix of [3] issue. - Alexey [1] https://bugs.openjdk.java.net/browse

Re: RFR: JDK-8248254: jpackage fails if app module is in external runtime

2020-06-26 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 4:30 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Fix jpackage code to be able to locate app module if it is linked in external runtime. The suggested fix only verifies if app module exists in external runtime. It

RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

2020-06-26 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Added fallback for creating DMG if original approach fails. In original approach DMG will be created by providing app image to hdiutil. It was noticed that helper sub-processes run by hdiutil to copy app image sometimes crashed or failed durin

Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

2020-06-26 Thread alexander . matveev
Hi Alexey, http://cr.openjdk.java.net/~almatvee/8248059/webrev.01/ - Removed getFilesSizeInFolder() method and size will be calculated as per your suggestion. Thanks, Alexander On 6/26/20 8:16 PM, Alexey Semenyuk wrote: Hi Alexander, MacDmgBundler.java: ---   94 } catch (IOException

Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

2020-06-29 Thread alexander . matveev
Hi Alexey, No, it is not used. I forgot to remove it. Patch updated: http://cr.openjdk.java.net/~almatvee/8248059/webrev.02/ Thanks, Alexander On 6/29/20 7:47 AM, Alexey Semenyuk wrote: Alexander, Is `error.cannot-calculate-folder-size` l10n property still used in the new patch? - Alexey

Re: RFR: 824850: [macos] App created with jpackage on Mac fails with error -10810

2020-07-02 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 7/2/2020 3:53 PM, Andy Herrick wrote: Please review jpackage fix for issue [1] at [2]. The class path was no longer set correctly when jars are in a sub-directory of the input dir. /Andy [1] - https://bugs.openjdk.java.net/browse/JDK-8248501 [2]

RFR: 8223955: Eliminate or reduce mixing of old File API and new Path/Files APIs

2020-07-06 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Substituted old File APIs with Path/Files APIs when it was possible and makes sense. [1] https://bugs.openjdk.java.net/browse/JDK-8223955 [2] http://cr.openjdk.java.net/~almatvee/8223955/webrev.00/ Thanks, Alexander

RFR: 8248261: Add timestamps to jpackage and jpackage tests verbose output

2020-07-06 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Added timestamp to verbose and test output in form of [HH:mm:ss.SSS]. [1] https://bugs.openjdk.java.net/browse/JDK-8248261 [2] http://cr.openjdk.java.net/~almatvee/8248261/webrev.00/ Thanks, Alexander

Re: RFR: 8248261: Add timestamps to jpackage and jpackage tests verbose output

2020-07-07 Thread alexander . matveev
Hi Andy, Timestamps for error message without verbose output are meaningless in my opinion. This is why I did not add them. Also, in some cases output does not look right. For example when timestamp is added to error message always: jpackage --someoption WARNING: Using incubator modules: jdk.

Re: RFR: JDK-8247779 Remove deprecated --bind-services option from jpackage

2020-07-08 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 7/8/20 9:18 AM, Alexey Semenyuk wrote: Looks good. - Alexey On 7/8/2020 10:34 AM, Andy Herrick wrote: Please review change at [1] to issue [2] removing the "--bind-services" option from jpackage. /Andy [1] http://cr.openjdk.java.net/~herrick/824

Re: RFR: 8248261: Add timestamps to jpackage and jpackage tests verbose output

2020-07-08 Thread alexander . matveev
Hi Alexey, http://cr.openjdk.java.net/~almatvee/8248261/webrev.01/ - Added fatalError() to log fatal errors without timestamp. - Added missing timestamp to Log.verbose(Throwable t). Thanks, Alexander On 7/8/20 9:34 AM, Alexey Semenyuk wrote: I still think it would be good to create dedicated m

Re: RFR: JDK-8247229: jpackage tests failed due to "semop(1): encountered an error: Invalid argument"

2020-07-08 Thread alexander . matveev
Hi Alexey, Looks good. Only suggestion is to move CmdlineExecutor to Executor class and make it configurable for error message and probably attempts and timeout in case if we need such functionality in other places. Thanks, Alexander On 7/8/20 6:37 PM, Alexey Semenyuk wrote: Please review f

Re: RFR: JDK-8247229: jpackage tests failed due to "semop(1): encountered an error: Invalid argument"

2020-07-09 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 7/9/20 12:49 PM, Alexey Semenyuk wrote: Hi Alexander, Agreed with your suggestion. Updated review available at [1]. - Alexey [1] http://cr.openjdk.java.net/~asemenyuk/8247229/webrev.01/webrev.01/ On 7/9/2020 12:21 AM, alexander.matv...@oracle.com

[15] RFR: 8249256: [macos] Add EmptyFolderPackageTest test to problem list

2020-07-13 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. EmptyFolderPackageTest.java added to ProblemList. [1] https://bugs.openjdk.java.net/browse/JDK-8249256 [2] http://cr.openjdk.java.net/~almatvee/8249256/webrev.00/ Thanks, Alexander

Re: RFR: JDK-8248687: JPackage test extension misspelled "extention"

2020-07-13 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 7/13/2020 1:26 PM, Andy Herrick wrote: please review trivial jpackage fix to issue [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8248687 [2] http://cr.openjdk.java.net/~herrick/8248687/webrev.01/ /Andy

RFR: 8249264: Build validate-headers task fails after JDK-8248261

2020-07-13 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. Added missing ",". [1] https://bugs.openjdk.java.net/browse/JDK-8249264 [2] http://cr.openjdk.java.net/~almatvee/8249264/webrev.00/ Thanks, Alexander

Re: RFR: JDK-8249289: Exception thrown when --temp points to non-existant directory

2020-07-15 Thread alexander . matveev
Hi Andy, Can you double check two other places where File.list() was introduced with JDK-8223955 for similar issues? One in MacPkgBundler.java and second in DeployParams.java. Thanks, Alexander On 7/15/20 3:09 PM, Alexey Semenyuk wrote: Andy, Stream.close() call is missing on the result of

RFR: 8245311: [macos] misc package tests failed due to "execution error: Finder got an error: AppleEvent timed out."

2020-07-15 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - "hdiutil detach" resource busy error is fixed in same way as JDK-8242786 by repeating detach several times. - pkgbuild timeout will be covered with JDK-8249395. [1] https://bugs.openjdk.java.net/browse/JDK-8245311 [2] http://cr.openjdk.java.

Re: RFR: JDK-8249289: Exception thrown when --temp points to non-existant directory

2020-07-16 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 7/16/20 11:44 AM, Andy Herrick wrote: yes - revised as suggested - please re review. /Andy On 7/15/2020 6:41 PM, alexander.matv...@oracle.com wrote: Hi Andy, Can you double check two other places where File.list() was introduced with JDK-8223955 f

Re: RFR: JDK-8247734: [macos] jpackage fails to retrieve signing certificate when there are multiple

2020-07-16 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 7/16/20 2:23 PM, Andy Herrick wrote: Please review fix for jpackage bug [1] at [2]. The behavior is to allow (after a warning message) case where user has multiple certificates matching the given mac-signing-key-user-name, and to allow the full cert

Re: RFR: 8245311: [macos] misc package tests failed due to "execution error: Finder got an error: AppleEvent timed out."

2020-07-17 Thread alexander . matveev
Hi Alexey, Fixed as per your suggestion: http://cr.openjdk.java.net/~almatvee/8245311/webrev.01/ Thanks, Alexander On 7/17/20 4:26 PM, Alexey Semenyuk wrote: Alexander, The change in RetryExecutor.java results in Executor instance created only once and not every time command line should be e

8248248: [macos] EmptyFolderPackageTest.java fails EmptyFolderPackageTest-dmg-setup.scpt exited with 134 code

2020-07-20 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. It is not clear why script was hanging for more than 7 minutes which caused test to timeout. Fixed by limiting script execution time to 3 minutes. Also, EmptyFolderPackageTest was removed from ProblemList. [1] https://bugs.openjdk.java.net/br

Re: 8248248: [macos] EmptyFolderPackageTest.java fails EmptyFolderPackageTest-dmg-setup.scpt exited with 134 code

2020-07-23 Thread alexander . matveev
http://cr.openjdk.java.net/~almatvee/8248248/webrev.01/ - Added INFINITE_TIMEOUT instead of -1. - Fix actually did not work correctly and process never timeout, since we were reading process output and wait with timeout never executed, since reading output was continue until process terminated.

Re: RFR: JDK-8248239: jpackage adds some arguments twice in case it is re-executed by JLI

2020-07-24 Thread alexander . matveev
Looks good. Thanks, Alexander On 7/24/20 12:39 PM, Andy Herrick wrote: looks good /Andy On 7/21/2020 2:27 PM, Alexey Semenyuk wrote: Hi Aleksei, Looks good! - Alexey On 7/21/2020 11:42 AM, Aleksei Voitylov wrote: Hi, This is the updated fix which checks if LD_LIBRARY_PATH has been chan

RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-30 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy error. Fixed by stopping trying detach if DMG already got detach. [1] https://bugs.openjdk.java.net/browse/JDK-8250646 [2] http://cr.openjdk.java.net/~almatvee/8250646/we

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-07-31 Thread alexander . matveev
Hi Alexey, Without modifying some logic in Executor, yes stop is needed. After retryExecutor.stop(); is executed in MacDmgBundler we will still run command (same with abort), and this command will fail and exception will be thrown. Stop() is basically like abort, but exception is ignored. Th

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

2020-08-03 Thread alexander . matveev
Hi Alexey, http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/ I removed stop method. Also, if we called abort from MacDMGBundler exception will be ignored. Thanks, Alexander On 8/3/20 10:10 AM, Alexey Semenyuk wrote: On 7/31/2020 7:36 PM, alexander.matv...@oracle.com wrote: Hi Alexe

Re: RFR: JDK-8251184: File association without description causes exception

2020-08-05 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 8/5/20 1:17 PM, Andy Herrick wrote: Please review this jpackage fix at [1] to issue [2] [1] - http://cr.openjdk.java.net/~herrick/8251184/ [2] - https://bugs.openjdk.java.net/browse/JDK-8251184 /Andy

RFR: 8248905: [macos] symbolic links not properly resolved

2020-08-07 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - Fixed by converting path of executable to real path if _NSGetExecutablePath() returned symbolic link. [1] https://bugs.openjdk.java.net/browse/JDK-8248905 [2] http://cr.openjdk.java.net/~almatvee/8248905/webrev.00/ Thanks, Alexander

Re: RFR: 8248905: [macos] symbolic links not properly resolved

2020-08-07 Thread alexander . matveev
Hi Alexey, Webrev updated: http://cr.openjdk.java.net/~almatvee/8248905/webrev.01/ Thanks, Alexander On 8/7/20 3:36 PM, Alexey Semenyuk wrote: Looks good. Minor suggestion, please change --- tstring getRealPath(std::vector in) --- to --- tstring getRealPath(const std::vector& in); --- - Alexe

Re: RFR: JDK-8232621: L10n issues with msi installers

2020-08-10 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 8/10/20 9:09 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix adds ability to jpackage to hook up custom WiX localization files from resource directory. This allows to create .msi installers with custom locales, not j

RFR: 8250803: pkgbuild failed with exit code 134

2020-08-13 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing timeout by 1 min fixed issues. In fix it is increased by 50% just in case. Without timeout increase it was reproducible 100% on one of test machine. With increased

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 8/13/20 12:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll).

Re: RFR: 8250803: pkgbuild failed with exit code 134

2020-08-13 Thread alexander . matveev
Hi Joe, None. Most time is spend when pkgbuild is executed which is external tool. Based on log our code does not consume a lot of time during execution. Based on one of the runs total time was 11 min: 1 min for jlink, 4 min for hdutil create and 4 min for pkgbuild, so test itself took 2 min.

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-14 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 8/14/20 7:05 AM, Andy Herrick wrote: Please review revised webrev [3] that does not check for client jvm are (always use server) /Andy [3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02 On 8/13/2020 6:03 PM, Philip Race wrote: Do I underst

Re: RFR: JDK-8251988: jpackage --runtime-image fails on mac when using JDK11 based runtime.

2020-08-24 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 8/24/20 4:53 PM, Alexey Semenyuk wrote: Looks good! - Alexey On 8/24/2020 6:23 PM, Andy Herrick wrote: On 8/24/2020 5:08 PM, Alexey Semenyuk wrote: Andy, I'd propose instead of checking if the app is bundled with proper runtime in the test case,

RFR: 8223187: Investigate setLocale() call in jpackage native launcher

2020-09-11 Thread Alexander Matveev
setlocale() affects several C functions. We do not use most of these functions. We only using isspace() and toLower(). Based on how we use it I do not see any needs for setlocale(). After removing it I retested jpackage by changing locally on machine and using different language as input paramete

Integrated: 8223187: Remove setLocale() call in jpackage native launcher

2020-09-14 Thread Alexander Matveev
On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev wrote: > setlocale() affects several C functions. We do not use most of these > functions. We only using isspace() and toLower(). > Based on how we use it I do not see any needs for setlocale(). After removing > it I retested

Re: Fwd: RFR: 8223187: Investigate setLocale() call in jpackage native launcher

2020-09-14 Thread alexander . matveev
: core-libs-dev im Auftrag von Alexander Matveev Gesendet: Saturday, September 12, 2020 4:22:31 AM An: core-libs-dev@openjdk.java.net Betreff: RFR: 8223187: Investigate setLocale() call in jpackage native launcher setlocale() affects several C functions. We do not use most of these functions

Re: RFR: JDK-8230652: Improve verbose output

2020-09-14 Thread Alexander Matveev
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote: > JDK-8230652 > Extracting the commands displayed by verbose output (including commands > called thru ToolProvider) , to contain the the > command, it's output, and it's return value on separate lines and formatted > in a way that they can b

RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests

2020-09-18 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8231591 - Added MultiLauncherTwoPhaseTest which uses predefine app image with multiple launcher and tests to make sure installer will create shortcuts for all launchers. - Fixed Linux DesktopIntegration to create shortcuts for additional launcher if we

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests

2020-09-21 Thread Alexander Matveev
On Mon, 21 Sep 2020 14:05:08 GMT, Alexey Semenyuk wrote: >> https://bugs.openjdk.java.net/browse/JDK-8231591 >> >> - Added MultiLauncherTwoPhaseTest which uses predefine app image with >> multiple launcher and tests to make sure installer >> will create shortcuts for all launchers. >> - Fixed

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests

2020-09-21 Thread Alexander Matveev
On Mon, 21 Sep 2020 14:39:33 GMT, Alexey Semenyuk wrote: > How about testing of other jpackage command line options in two phase mode? > Like "--name", "--version"? Any plans to > add them? Plan was to file separate bugs for any additional options. I do not think we should put everything in on

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v2]

2020-09-21 Thread Alexander Matveev
uts for additional launcher > if we using pre-define app image. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8231591: [TESTBUG] Create additional two phase jpackage tests (revision 1) - Changes: - all: https:/

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v3]

2020-09-22 Thread Alexander Matveev
uts for additional launcher > if we using pre-define app image. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8231591: [TESTBUG] Create additional two phase jpackage tests (revision 2) - Changes: - all: https:/

Re: RFR: 8253149: Building an installer from invalid app image fails on Window… [v3]

2020-09-22 Thread Alexander Matveev
On Tue, 22 Sep 2020 11:53:14 GMT, Andy Herrick wrote: >> 8253149: Building an installer from invalid app image fails on Windows and >> Linux >> When jpackage builds a package from an app-image that was not generated by >> jpackage, the tool should give user a >> warning message, and then comple

Re: RFR: 8253149: Building an installer from invalid app image fails on Window… [v3]

2020-09-22 Thread Alexander Matveev
On Tue, 22 Sep 2020 11:53:14 GMT, Andy Herrick wrote: >> 8253149: Building an installer from invalid app image fails on Windows and >> Linux >> When jpackage builds a package from an app-image that was not generated by >> jpackage, the tool should give user a >> warning message, and then comple

Re: Jpackage file assocations OS X

2020-09-22 Thread alexander . matveev
Hi Michael, For file association you will need to create property file and pass it to jpackage via --file-associations. Example property file: mime-type=text/plain extension=txt description=Text file See following documentation: https://docs.oracle.com/en/java/javase/15/jpackage/support-applic

Re: RFR: 8253149: Building an installer from invalid app image fails on Window… [v4]

2020-09-23 Thread Alexander Matveev
On Wed, 23 Sep 2020 13:59:25 GMT, Andy Herrick wrote: >> 8253149: Building an installer from invalid app image fails on Windows and >> Linux >> When jpackage builds a package from an app-image that was not generated by >> jpackage, the tool should give user a >> warning message, and then comple

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v3]

2020-09-23 Thread Alexander Matveev
On Wed, 23 Sep 2020 18:07:18 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8231591: [TESTBUG] Create additional two phase jpackage tests (revision 2) > > t

Re: RFR: 8253379: [windows] Several jpackage tests failed with error code 1638

2020-09-24 Thread Alexander Matveev
On Thu, 24 Sep 2020 14:14:54 GMT, Andy Herrick wrote: > 8253379: [windows] Several jpackage tests failed with error code 1638 > two windows specific test fixes in WindowsHelper: > 1.) do not test that the parent directory of a windows menu shortcut is empty > after shortcut is uninstalled (there

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v3]

2020-09-24 Thread Alexander Matveev
On Thu, 24 Sep 2020 13:50:07 GMT, Alexey Semenyuk wrote: >> But test calls AdditionalLauncher.applyTo(JPackageCommand cmd), which does >> not have reference to PackageTest. Do you >> know why we need two applyTo()? > > Just change the test code to call AdditionalLauncher.applyTo(PackageTest): >

Re: RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v3]

2020-09-24 Thread Alexander Matveev
On Thu, 24 Sep 2020 23:35:15 GMT, Alexander Matveev wrote: >> Just change the test code to call AdditionalLauncher.applyTo(PackageTest): >> `launcher1.applyTo(packageTest); >> launcher2.applyTo(packageTest)` >> >> AdditionalLauncher.applyTo(JPackageComma

  1   2   3   4   5   6   >