Re: Thread stack size issue related to glibc TLS bug

Hi Jiangli, On 31/05/2019 1:23 am, Jiangli Zhou wrote: Hi David, This is a link to __pthread_get_minstack that I find in the public domain: https://code.woboq.org/userspace/glibc/nptl/nptl-init.c.html. It has copyright of 2002-2019, so it's probably the latest version. size_t __pthread_get_min

Re: RFR: 8224974: Implement JEP 352

Hi Vladimir, Thanks for the follow-up and for checking the submit failure. I have addressed all the points you raised (point by point comments are included below). A new webrev which passes a submit run is here: http://cr.openjdk.java.net/~adinn/8224974/webrev.04 n.b. This webrev also include

Re: RFR: 8224974: Implement JEP 352

On 03/06/2019 14:17, Andrew Dinn wrote: > Hi Vladimir, > > Thanks for the follow-up and for checking the submit failure. I have > addressed all the points you raised (point by point comments are > included below). A new webrev which passes a submit run is here: > > http://cr.openjdk.java.ne

Problems with jpackage

 Hello, I noticed that the generated runtime image by the jpackage don't contains the modules specified with the --module-path nor the --add-modules arguments.  Also, I noticed that some dlls from javafx sdk (11 or 12) do not be copied to the same. --- Este email foi escaneado pelo Avast an

Fwd: Problem with jpackage/Windows and using a different runtime

Hi, I sent the a few weeks ago, but I don't get any answer. Is this the wrong place for my question? Klaus Weitergeleitete Nachricht Betreff:Problem with jpackage/Windows and using a different runtime Datum: Thu, 9 May 2019 13:50:47 +0200 Von:Klaus Friese An:

RFR: 6394787: Typos in javadoc of OIS.readObjectOverride and OOS.writeObjectOverride

Hello. I would like to contribute a small patch for bug: https://bugs.openjdk.java.net/browse/JDK-6394787 Index: src/java.base/share/classes/java/io/ObjectOutputStream.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 02/06/2019 22:35, Langer, Christoph wrote: Hi Alan, Lance, thanks for the updated wording in module-info, that really looks good. I incorporated it into my change, no we’d be here: http://cr.openjdk.java.net/~clanger/webrevs/8213031.13/ To be honest, I was hoping it would still make it i

Re: [11u] RFR (S): 8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize

I agree, looks fine. Paul On 6/2/19, 11:46 PM, "jdk-updates-dev on behalf of Langer, Christoph" wrote: Hi, please help reviewing a backport to OpenJDK 11u. Bug: https://bugs.openjdk.java.net/browse/JDK-8139965 11u-webrev: http://cr.openjdk.java.net/~clanger/webrevs/8

RFR 8225198 : Optimize regex tree for greedy quantifiers of type {N, }

Hello! When building a match-tree, the regex engine optimizes '*' and '+' greedy quantifiers by using special node of type CharPropertyGreedy. This later class can be used unmodified for other greedy quantifiers without the upper limit, i.e. of type '{N,}'. Would you please help review this

Re: Problem with jpackage/Windows and using a different runtime

Klaus: I sent you this reply a few weeks back, and didn't get any further reply ... /Andy On 5/16/2019 10:59 AM, Andy Herrick wrote: Klaus: My apologies for not getting back to you sooner. I have tried the (nearly) the exact steps you give and can run the resultant app on windows. My best

Re: Problems with jpackage

Can you send me the exact steps you use to show this problem ? /Andy On 6/2/2019 7:24 PM, Antônio Diego wrote:  Hello, I noticed that the generated runtime image by the jpackage don't contains the modules specified with the --module-path nor the --add-modules arguments.  Also, I noticed t

JDK 13 RFR of JDK-8164819: Make javac's toString() on annotation objects consistent with core reflection

Hello, Please review the webrev of changes for     JDK-8164819: Make javac's toString() on annotation objects consistent with core reflection     http://cr.openjdk.java.net/~darcy/8164819.2/ Some background, several years ago in JDK 9, the toString output of annotations was changed to be usa

Re: RFR 8220238 : Enhancing j.l.Runtime/System::gc specification with an explicit 'no guarantee' statement

> > > ...there is an internal API > (java.lang.ref.Reference#waitForReferenceProcessing) and a usage of it > (java.nio.Bits#reserveMemory) > Big picture: there is a need both within and outside jdk proper to manage non-heap-memory resources in Java, and we still have no good answer. Reference#wai

RFR: XXS,doc JDK-8225207: redundant in Instrumentation.java

Please review a tiny delete-one-line change to fix the last HTML error in the java.instrument module. Note to all: should only be used at the *beginning* of a paragraph. It is not a terminator or separator. In the context of a javadoc comment, it should not be used before the set of block tag

Re: RFR: XXS,doc JDK-8225207: redundant in Instrumentation.java

+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Jun 3, 2019, at 6:33 PM, Jonathan Gibbons > wrote: > > Please review a tiny delete-one-line change to f

RFR: JDK-8225213: Backport jsr166 tck tests to jdk8u

-- Forwarded message - From: Martin Buchholz (JBS) Date: Mon, Jun 3, 2019 at 5:11 PM Subject: [JBS] {Commented} (JDK-8225213) Backport jsr166 tck tests to jdk8u To: Martin Buchholz *commented* on [image: Enhance

Review Request JDK-8222448: java/lang/reflect/PublicMethods/PublicMethodsTest.java times out

test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java time out in certain configuration e.g. fastdebug -Xcomp.  Setting the empty class path significantly improves the execution time as it eliminates opening and scanning of the JAR files on the class path.  Alan has also experimented it

Review Request JDK-8221368: Error message when module main class cannot be loaded is missing exception details

The launcher prints out the error message when the main class fails to initialize but java.launcher.module.error5 resource that intends to print the Caused-by exception message when running in a named module but prints an incorrect parameter. Very simple fix - fix the resource param indices.  Als

Re: Review Request JDK-8222448: java/lang/reflect/PublicMethods/PublicMethodsTest.java times out

Hi Mandy, Functional fix looks good, but layout and indentation appears off in the diff. Thanks to Alan for the time spent investigating this! Thanks, David On 4/06/2019 1:02 pm, Mandy Chung wrote: test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java time out in certain configura

Re: Review Request JDK-8222448: java/lang/reflect/PublicMethods/PublicMethodsTest.java times out

On 6/3/19 10:06 PM, David Holmes wrote: Hi Mandy, Functional fix looks good, but layout and indentation appears off in the diff. Hmm..  I'll check and fix that up before pushing it. Thanks to Alan for the time spent investigating this! Indeed. Mandy Thanks, David On 4/06/2019 1:

PING: RFR(s): (new approach) 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

Hi all, may I please have reviews/opinions on this fix? Fix has been live in our test landscape since some weeks. If we do not want this fix to be in JDK13, we may want to revert the posix_spawn-by-default-on-Linux change. Thanks, Thomas On Mon, May 20, 2019 at 4:15 PM Thomas Stüfe wrote: >

Re: Review Request JDK-8221368: Error message when module main class cannot be loaded is missing exception details

Looks good. -Sundar On 04/06/19, 9:30 AM, Mandy Chung wrote: The launcher prints out the error message when the main class fails to initialize but java.launcher.module.error5 resource that intends to print the Caused-by exception message when running in a named module but prints an incorrect pa

RE: [11u] RFR (S): 8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize

Thanks Paul. > -Original Message- > From: Hohensee, Paul > Sent: Montag, 3. Juni 2019 21:33 > To: Langer, Christoph ; jdk-updates- > d...@openjdk.java.net > Cc: Java Core Libs > Subject: Re: [11u] RFR (S): 8139965: Hang seen when using > com.sun.jndi.ldap.search.replyQueueSize > > I agr

Re: RFR: 6394787: Typos in javadoc of OIS.readObjectOverride and OOS.writeObjectOverride

This looks right, I assume a cut&paste issue when the methods were originally added. -Alan On 02/06/2019 12:23, Andrey Turbanov wrote: Hello. I would like to contribute a small patch for bug: https://bugs.openjdk.java.net/browse/JDK-6394787 Index: src/java.base/share/classes/java/io/ObjectOut