Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

2018-10-14 Thread Alan Bateman
On 12/10/2018 20:16, Joe Wang wrote: Hi all, Here's an update based on all of the great reviews and comments (thanks all!): JBS: https://bugs.openjdk.java.net/browse/JDK-8202285 CSR: https://bugs.openjdk.java.net/browse/JDK-8202302 Current version: specdiff: http://cr.openjdk.java.net/~joeh

Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

2018-10-14 Thread Weijun Wang
Hi Joe Two comments: 1. How about (path1, path2)? I take a look at other similar APIs, some use (c1,c2) and some (a,b). 2. Could the method be non-reflexive even if fs is non static? isSameFile(f,f) is always true. + * This method may not be atomic with respect to other file system +

Re: Why Stream.concat is a static method - type variable contravariance

2018-10-14 Thread Tagir Valeev
Hello! Still from the practical point of view it would be really helpful to have instance methods like `Stream.append(T... elements)` and `Stream.prepend(T... elements)` (default implementation may utilize `concat`). Very often it's necessary to add one or two special elements to the stream, and u

Re: JDK 12 RFR of JDK-8212081: AnnotatedType.toString implementation don't print annotations on embedded types

2018-10-14 Thread joe darcy
Follow-up fix developed; details below. On 10/11/2018 12:12 PM, joe darcy wrote: Hi Werner, On 10/10/2018 1:23 PM, Werner Dietl wrote: Hi Joe, all, the logic looks good to me. In the tests I'm wondering whether to include an annotated wildcard bound. There is: 307 public @AnnotType(