Re: JDK 9 RFR of 8054720: Modifications of I/O methods for instrumentation purposes

2014-08-25 Thread Alan Bateman
On 20/08/2014 16:08, Brian Burkhalter wrote: JDK 9 reviewers: I would like to reprise this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028181.html with an updated patch Issue: https://bugs.openjdk.java.net/browse/JDK-8054720 Patch: http://cr.openjdk.java.net/~bpb

Re: Trusted service?

2014-08-25 Thread Alan Bateman
On 22/08/2014 09:09, Wang Weijun wrote: : Great, this works for me. But why does it need to be called in a doPrivileged() block? Isn't it only about JDK-internal classes/resources? It's a public API so it can be used by anyone. The question about privileges and limiting them is a good quest

Re: RFR(S): 8055032: Improve numerical parsing in java.net and sun.net

2014-08-25 Thread Alan Bateman
On 18/08/2014 22:12, Mike Duigou wrote: On Aug 14 2014, at 06:39 , Alan Bateman wrote: On 14/08/2014 14:23, Claes Redestad wrote: How about methods only taking beginIndex? Integer.parseInt("x: 1000", 3, 10)? I guess these could to be dropped to avoid ambiguity and instead allow for varia

Re: Replace concat String to append in StringBuilder parameters

2014-08-25 Thread Alan Bateman
On 25/08/2014 03:03, Wang Weijun wrote: New webrevs updated http://cr.openjdk.java.net/~weijun/8055723/core/webrev.00/ Includes modules java.base and security-related modules and the jarsigner tool http://cr.openjdk.java.net/~weijun/8055723/client/webrev.00 Includes the java.desktop mo

RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-08-25 Thread Martin Buchholz
Hi friends of ByteArrayOutputStream, I'm trying to clean up an apparent oversight when I tried to fix huge array resizing back in 6933217: Huge arrays handled poorly in core libraries https://bugs.openjdk.java.net/browse/JDK-8055949 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/ByteArrayOut

Re: RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-08-25 Thread Alan Bateman
On 25/08/2014 18:37, Martin Buchholz wrote: Hi friends of ByteArrayOutputStream, I'm trying to clean up an apparent oversight when I tried to fix huge array resizing back in 6933217: Huge arrays handled poorly in core libraries https://bugs.openjdk.java.net/browse/JDK-8055949 http://cr.openjd

Re: RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-08-25 Thread Martin Buchholz
Thanks, Alan. On Mon, Aug 25, 2014 at 1:28 PM, Alan Bateman wrote: > On 25/08/2014 18:37, Martin Buchholz wrote: > > Hi friends of ByteArrayOutputStream, > > I'm trying to clean up an apparent oversight when I tried to fix huge > array resizing back in > 6933217: Huge arrays handled poorly i

Re: RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-08-25 Thread Mike Duigou
This looks fine to me as well. I am fine with the @ignore as I don't suspect anyone would be able to sneak in a change which removed the @ignore without anyone noticing and the comment for why it is marked @ignore seems adequate. Mike On Aug 25 2014, at 13:28 , Alan Bateman wrote: > On 25/08

Re: About JDK-8042694

2014-08-25 Thread David Holmes
On 2/08/2014 11:40 PM, Harshad RJ wrote: Hi, I hit this bug in my own application today: https://bugs.openjdk.java.net/browse/JDK-8042694 My app uses the h2 database which installs a shutdown hook. Works fine, but while running with JNLP, the shutdown hook thrown an exception, probably because

Re: Replace concat String to append in StringBuilder parameters

2014-08-25 Thread Wang Weijun
New webrevs available at http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/ http://cr.openjdk.java.net/~weijun/8055723/core/webrev.01/ There are only 2 now. Everything non-client is in core. Everyone, please do code review quickly because the patch touches too many files and any

Re: Replace concat String to append in StringBuilder parameters

2014-08-25 Thread Xuelei Fan
I was wondering, is it nice to address it in Java compiler to use string builder for the string "+" operator? Xuelei On 8/26/2014 11:28 AM, Wang Weijun wrote: > New webrevs available at > > http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/ > http://cr.openjdk.java.net/~weijun/805