hg: jdk8/tl/jdk: 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError

Changeset: 4d9078b1f25b Author:peytoia Date: 2013-11-26 14:49 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d9078b1f25b 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Reviewed-by: okutsu - test/java/text/Bidi/Bug6665028.java

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi Phil, thanks a lot for the review. Please find my comments inline: On Tue, Nov 26, 2013 at 12:24 AM, Phil Race wrote: > Hi, > I see you've already received a ton of good feedback on this v2. > > I have just a few things to add. > I don't know what symlinks might exist on AIX but it seems o

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 2013-11-25, at 9:18 PM, David Holmes wrote: > We do have the jdk.internal namespace. But I think Unsafe is as good a place > as any - though maybe sun.misc.VM is marginally better? Does anyone have any problems with sun.misc.VM as a choice? I have to do a minor revision to the hotspot commit

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes wrote: We do have the jdk.internal namespace. But I think Unsafe is as good a place as any - though maybe sun.misc.VM is marginally better? Does anyone have any problems with sun.misc.VM as a choice? I have to

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 2013-11-26, at 7:12 AM, David Holmes wrote: > On 26/11/2013 9:56 PM, David Chase wrote: >> >> On 2013-11-25, at 9:18 PM, David Holmes wrote: >>> We do have the jdk.internal namespace. But I think Unsafe is as good a >>> place as any - though maybe sun.misc.VM is marginally better? >> >> Do

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes wrote: On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes wrote: We do have the jdk.internal namespace. But I think Unsafe is as good a place as any - though maybe sun.misc.VM

hg: jdk8/tl/langtools: 8028428: strictfp allowed as annotation element modifier

Changeset: 3ea55d523981 Author:jfranck Date: 2013-11-26 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ea55d523981 8028428: strictfp allowed as annotation element modifier Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java + test/tools/java

Re: RFR for JDK-6933803 Bring back test java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java

Hi Alan Could you sponsor this small change for me if you're ok with this change. Thank you very much. Tristan On 11/20/2013 12:45 PM, Tristan Yan wrote: Hi Everyone We have a test java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java that was put into ProblemList because of bug JDK

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 2013-11-26, at 7:32 AM, David Holmes wrote: > On 26/11/2013 10:16 PM, David Chase wrote: >> >> On 2013-11-26, at 7:12 AM, David Holmes wrote: >>> On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at 9:18 PM, David Holmes wrote: > We do have the jdk.internal namespace.

Poor Javadoc of Map default methods [Re: RFR: 8029055: Map.merge must refuse null values]

I took a quick look, but jumped back in horror at the start of the Javadoc for the new methods in Map. A Javadoc description should start with the positive, not the negative. I had to read the code to figure out what they are supposed to do. Here are the four poor Javadocs and some proposed enhacem

Proposed fix for JDK-8028804 (Deflater.deflateBytes() may produce corrupted output on Deflater level/strategy change)

Hello, My name is Thomas Stuefe, I'm with SAP and working on the SAP JVM. I'd like to propose a fix for https://bugs.openjdk.java.net/browse/JDK-8028804 . This may also be related to https://bugs.openjdk.java.net/browse/JDK-8028216. The problem: The following call sequence: Deflater.deflate()

Re: RFR: 8029055: Map.merge must refuse null values

See the new thread for the general Javadoc issues. I'll focus on null here. Given a map {"Key" -> null} I find the notion that putIfAbsent() or computeIfAbsent() ignore the existing mapping just plain wrong. While I can rationalise it (just) it is a horrible reworking of the meaning of "absent".

Re: Proposed fix for JDK-8028804 (Deflater.deflateBytes() may produce corrupted output on Deflater level/strategy change)

On 26/11/2013 13:27, Thomas Stüfe wrote: : The real problem is that zlib deflateParams(), unlike zlib deflate(), does not handle output-buffer-too-small correctly. The workaround is to fully flush the stream before calling deflateParams(), so that the deflate() call inside deflateParams() become

Re: Proposed fix for JDK-8028804 (Deflater.deflateBytes() may produce corrupted output on Deflater level/strategy change)

Hi Alan, On 26 November 2013 14:55, Alan Bateman wrote: > I think you're right but I wonder if this is something that needs to be > brought upstream to the zlib project in order to get the support in > deflateParams (or a new function). > I reported this bug to the authors of the zlib and they

Why are assertions in zlib on Unix switched off?

Hi everyone, When building the zlib on Unix platforms, zlib assertions are switched off explicitly using -UDEBUG: 84 ifeq ($(PLATFORM), windows) 87 else 88 CPPFLAGS += -UDEBUG 89 endif This switches off assertions inside the zlib (see zutil.h, zutil,c inside the zlib). Does

Re: Proposed fix for JDK-8028804 (Deflater.deflateBytes() may produce corrupted output on Deflater level/strategy change)

On 26/11/2013 14:06, Thomas Stüfe wrote: Hi Alan, On 26 November 2013 14:55, Alan Bateman > wrote: I think you're right but I wonder if this is something that needs to be brought upstream to the zlib project in order to get the support in deflatePara

hg: jdk8/tl/langtools: 2 new changesets

Changeset: 8acb838c9b79 Author:jlahoda Date: 2013-11-26 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8acb838c9b79 8026374: javac accepts void as a method parameter Summary: Changing Check.validate to reject void types. Reviewed-by: jjg, vromero ! src/share/clas

Re: RFR for JDK-6933803 Bring back test java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java

Tristan, The removal of this test from the ProblemList.txt looks like the right thing to do. I can push this for you. -Chris. On 26 Nov 2013, at 12:47, Tristan Yan wrote: > Hi Alan > Could you sponsor this small change for me if you're ok with this change. > Thank you very much. > Tristan > >

Re: RFR for JDK-6933803 Bring back test java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java

Thank you. Chris. Tristan On 11/26/2013 11:16 PM, Chris Hegarty wrote: Tristan, The removal of this test from the ProblemList.txt looks like the right thing to do. I can push this for you. -Chris. On 26 Nov 2013, at 12:47, Tristan Yan wrote: Hi Alan Could you sponsor this small change for

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 25/11/2013 21:51, huizhe wang wrote: Hi, This is a patch to fix an error in StAX factories' newFactory(String factoryId, ClassLoader classLoader). In the 3 step of the documentation, it should have stated that the specified ClassLoader is used. http://cr.openjdk.java.net/~joehw/jdk8/jaxp

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 2013-11-26, at 8:12 AM, David Chase wrote: > On 2013-11-26, at 7:32 AM, David Holmes wrote: >> On 26/11/2013 10:16 PM, David Chase wrote: >>> >>> On 2013-11-26, at 7:12 AM, David Holmes wrote: On 26/11/2013 9:56 PM, David Chase wrote: > > On 2013-11-25, at 9:18 PM, David Holme

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully build (and run some smoke tests) with these chang

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

On 26/11/2013 16:23, Volker Simonis wrote: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully buil

Re: Access Checking for MethodHandles.Lookup broken?

Hi, A few days ago I thought I had found a bug in MethodHandles.Lookup.findGetter/findSetter[0] , but i was wrong it seemed to be fixed in the latest JDK7 and JDK8 versions. I search the Bugdatabase for a ticket relating my issue and didn't found one. So i looked at the regressiontests for java/la

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On Nov 22, 2013, at 11:07 AM, David Chase wrote: > Webrev(s): > http://cr.openjdk.java.net/~drchase/8016839/webrev-hotspot.01/ > http://cr.openjdk.java.net/~drchase/8016839/webrev-jdk.01/ Excellent work. Count me as reviewer, please. — John

RE: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

> So overall it looks good to me and should be pushed to the staging > forest > once you hear from others that commented previously. I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan, please correct me if I'm wrong. Thanks, iris -Original Message- From: Alan

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ Thanks, Joe On 11/26/2013 8:09 AM, Alan Bateman wrote: On 25/11/2013 21:51, huizhe wang wrote: Hi, This is a patch to fix an error in StAX factorie

Re: ArrayStoreException in Class#getAnnotations

On 25.11.2013 23:01, Alan Bateman wrote: On 24/11/2013 17:07, Philippe Marschall wrote: Hi The following issue was been bothering me for a while: When you have an annotation with a value that is an array of classes [1] and one of those classes can't be loaded with the class loader of defining

RE: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi. >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > + src/solaris/classes/java/lang/UNIXProcess.java.aix > 2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights > reserved. > 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. Oracle copyrig

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Looking only at what you needed to change this time round, all seems fine now. -phil. On 11/26/13 8:23 AM, Volker Simonis wrote: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second rev

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 26/11/2013 18:38, huizhe wang wrote: Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ So is this handling the null case correctly? It is spec'ed to use the TCCL but it looks like it's going throug

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

Hi, I looked at that twice also.java.time had a similar situation. To get to the TCCL you need to call ServiceLoader.load(type). The FactoryFinder:348 findServiceProvider method should test if cl == null and call the original ServiceLoader function. Roger On 11/26/2013 4:37 PM, Alan Bat

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 11/26/2013 1:37 PM, Alan Bateman wrote: On 26/11/2013 18:38, huizhe wang wrote: Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ So is this handling the null case correctly? It is spec'ed to use

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 11/26/13 11:13 PM, huizhe wang wrote: On 11/26/2013 1:37 PM, Alan Bateman wrote: On 26/11/2013 18:38, huizhe wang wrote: Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ So is this handling the

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

On 11/26/2013 1:59 PM, roger riggs wrote: Hi, I looked at that twice also.java.time had a similar situation. To get to the TCCL you need to call ServiceLoader.load(type). The FactoryFinder:348 findServiceProvider method should test if cl == null and call the original ServiceLoader functi

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

HI, Volker. Thanks for clarification. The fix looks good. On 11/27/13 12:48 AM, Volker Simonis wrote: Hi Sergey, on AIX, there's already a typedef for "boolean_t" in sys/types.h that's why we have to omit it from ecc_impl.h to avoid compile errors. The question regarding the copyright header

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

looks OK Joe On Nov 26, 2013, at 5:27 PM, huizhe wang wrote: > > On 11/26/2013 1:59 PM, roger riggs wrote: >> Hi, >> >> I looked at that twice also.java.time had a similar situation. >> >> To get to the TCCL you need to call ServiceLoader.load(type). >> >> The FactoryFinder:348 findService

hg: jdk8/tl/jdk: 8016839: JSR292: AME instead of IAE when calling a method

Changeset: e822676cd3cd Author:jrose Date: 2013-11-26 17:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e822676cd3cd 8016839: JSR292: AME instead of IAE when calling a method Summary: Catch missing-because-illegal case for itable entries and use an exception-throwing meth

Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

This is a simple patch that adds a new jdeps -jdkinternals option to make it easier for developers to find dependencies on the JDK internal APIs: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8029216/webrev.00/ Mandy

hg: jdk8/tl/hotspot: 15 new changesets

Changeset: 854a42db7069 Author:amurillo Date: 2013-11-15 07:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/854a42db7069 8028444: new hotspot build - hs25-b60 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 570aaefce624 Author:morris Date: 2013-11-18 1

Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

+1 Mandy Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Nov 26, 2013, at 6:59 PM, Mandy Chung wrote: > This is a simple patch that adds a new jdeps -jdkinternals

hg: jdk8/tl/jdk: 8029181: ts.sh generates invalid file after JDK-8027026

Changeset: 1738dfb0c52a Author:weijun Date: 2013-11-27 09:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1738dfb0c52a 8029181: ts.sh generates invalid file after JDK-8027026 Reviewed-by: vinnie, mullan ! test/sun/security/tools/jarsigner/TimestampCheck.java

Re: RFR (S + L test) : 8016839 : JSR292: AME instead of IAE when calling a method

On 27/11/2013 2:16 AM, David Chase wrote: On 2013-11-26, at 8:12 AM, David Chase wrote: On 2013-11-26, at 7:32 AM, David Holmes wrote: On 26/11/2013 10:16 PM, David Chase wrote: On 2013-11-26, at 7:12 AM, David Holmes wrote: On 26/11/2013 9:56 PM, David Chase wrote: On 2013-11-25, at