Re: CR 6899850 Updated, jeff.dinkins now responsible manager, P4 java/classes_util TESTBUG: DateRegression fails with "Date hashCode misbehaves"

2012-08-20 Thread Eric Wang
Hi Alan, Please review the code changes http://dl.dropbox.com/u/90659131/fixes/6899850/webrev/java/util/Date/DateRegression.java.udiff.html As described in monaco, this bug is caused by wrong assumption that precision of Date is second instead of millionsecond. If you think OK, I'll send a form

Re: CR 6899850 Updated, jeff.dinkins now responsible manager, P4 java/classes_util TESTBUG: DateRegression fails with "Date hashCode misbehaves"

2012-08-20 Thread Chris Hegarty
Eric, The changes look fine to me. You can list me as reviewer, but Naoto and Alan may also want to take a quick look. -Chris. On 20/08/12 09:18, Eric Wang wrote: Hi Alan, Please review the code changes http://dl.dropbox.com/u/90659131/fixes/6899850/webrev/java/util/Date/DateRegression.java

hg: jdk8/tl/jdk: 7191777: test/java/lang/ProcessBuilder/Basic.java failing intermittently due to additions for 4244896

2012-08-20 Thread rob . mckenna
Changeset: 59aa7660ade4 Author:robm Date: 2012-08-20 14:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59aa7660ade4 7191777: test/java/lang/ProcessBuilder/Basic.java failing intermittently due to additions for 4244896 Reviewed-by: dholmes, alanb ! test/java/lang/ProcessB

hg: jdk8/tl/langtools: 7181320: javac NullPointerException for switch labels with cast to String expressions

2012-08-20 Thread sundararajan . athijegannathan
Changeset: 464f52f59f7d Author:sundar Date: 2012-08-20 21:24 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/464f52f59f7d 7181320: javac NullPointerException for switch labels with cast to String expressions Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/ja

Re: CR 6899850 Updated, jeff.dinkins now responsible manager, P4 java/classes_util TESTBUG: DateRegression fails with "Date hashCode misbehaves"

2012-08-20 Thread Naoto Sato
Looks good to me too. Naoto On 2012/08/20 1:47, Chris Hegarty wrote: Eric, The changes look fine to me. You can list me as reviewer, but Naoto and Alan may also want to take a quick look. -Chris. On 20/08/12 09:18, Eric Wang wrote: Hi Alan, Please review the code changes http://dl.dropbox.

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-20 Thread Naoto Sato
I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other changes have been made this time. http://cr.openjdk.java.net/~naoto/6336885/webre

hg: jdk8/tl/langtools: 7192744: fix up tests to accommodate jtreg spec change

2012-08-20 Thread jonathan . gibbons
Changeset: 37008b4cd97a Author:jjg Date: 2012-08-20 13:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37008b4cd97a 7192744: fix up tests to accommodate jtreg spec change Reviewed-by: darcy ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/proces