Re: zlib 1.2.3 -> 1.2.5

2011-11-30 Thread Xueming Shen
There is a > 2/4G support issue we will need to address when using the platform bundled zlib. The total_in/total_out variables of z_stream_s is "long", which is not "big" enough (32 bit) for ZIP64 support on a 32-bit platform. The zlib code bundled with JDK has been updated to use "long long", as

Re: zlib 1.2.3 -> 1.2.5

2011-11-30 Thread Chris Hegarty
On 30/11/2011 09:50, David Holmes wrote: On 30/11/2011 7:43 PM, Alan Bateman wrote: On 30/11/2011 01:31, Dr Andrew John Hughes wrote: On 10:23 Tue 29 Nov , Alan Bateman wrote: snip... When we talked about the zlib version here (I think back in February) we talked about having the option to u

Re: zlib 1.2.3 -> 1.2.5

2011-11-30 Thread David Holmes
On 30/11/2011 7:43 PM, Alan Bateman wrote: On 30/11/2011 01:31, Dr Andrew John Hughes wrote: On 10:23 Tue 29 Nov , Alan Bateman wrote: snip... When we talked about the zlib version here (I think back in February) we talked about having the option to use the system's zip library where appropri

Re: zlib 1.2.3 -> 1.2.5

2011-11-30 Thread Alan Bateman
On 30/11/2011 01:31, Dr Andrew John Hughes wrote: On 10:23 Tue 29 Nov , Alan Bateman wrote: snip... When we talked about the zlib version here (I think back in February) we talked about having the option to use the system's zip library where appropriate. Have you given this any thought rec

Re: zlib 1.2.3 -> 1.2.5

2011-11-29 Thread Alan Bateman
On 29/11/2011 17:29, Xueming Shen wrote: The test case has been updated accordingly to (1) reduced the data size to 500k (2) dialed down the loop iteration to 5 so it runs much faster now. The webrev has been updated. http://cr.openjdk.java.net/~sherman/7110149/webrev Thanks, looks fine to

Re: zlib 1.2.3 -> 1.2.5

2011-11-29 Thread Xueming Shen
The test case has been updated accordingly to (1) reduced the data size to 500k (2) dialed down the loop iteration to 5 so it runs much faster now. The webrev has been updated. http://cr.openjdk.java.net/~sherman/7110149/webrev -Sherman On 11/29/2011 02:23 AM, Alan Bateman wrote: On 28/11/

Re: zlib 1.2.3 -> 1.2.5

2011-11-29 Thread Xueming Shen
That would be a separate RFE for that. As Mark suggested (as the feedback for the EFP) we now divide the zlib related work into small/separate rfes. To use the platform zlib is still on my list. -Sherman On 11/29/2011 06:05 AM, Ulf Zibis wrote: Am 29.11.2011 11:23, schrieb Alan Bateman: When

Re: zlib 1.2.3 -> 1.2.5

2011-11-29 Thread Ulf Zibis
Am 29.11.2011 11:23, schrieb Alan Bateman: When we talked about the zlib version here (I think back in February) we talked about having the option to use the system's zip library where appropriate. Have you given this any thought recently? +1 Ulf

Re: zlib 1.2.3 -> 1.2.5

2011-11-29 Thread Alan Bateman
On 28/11/2011 22:06, Xueming Shen wrote: Hi, Here is the webrev for upgrading the bundled zlib from 1.2.3 to 1.2.5 for JDK8 http://cr.openjdk.java.net/~sherman/7110149/webrev The changes to the original zlib source code (other than the copyright attachment) is at http://cr.openjdk.java.ne

Re: zlib 1.2.3 -> 1.2.5

2011-11-28 Thread Xueming Shen
The zlib-1.2.3 folder will be deleted. I did not list them in the webrev. I should have mentioned in the request. -Sherman On 11/28/2011 2:47 PM, Ulf Zibis wrote: Would zlib 1.2.3 remain in JDK8 repo alongside 1.2.5 ? -Ulf Am 28.11.2011 23:06, schrieb Xueming Shen: Hi, Here is the webrev f

Re: zlib 1.2.3 -> 1.2.5

2011-11-28 Thread Ulf Zibis
Would zlib 1.2.3 remain in JDK8 repo alongside 1.2.5 ? -Ulf Am 28.11.2011 23:06, schrieb Xueming Shen: Hi, Here is the webrev for upgrading the bundled zlib from 1.2.3 to 1.2.5 for JDK8 http://cr.openjdk.java.net/~sherman/7110149/webrev The changes to the original zlib source code (other tha

zlib 1.2.3 -> 1.2.5

2011-11-28 Thread Xueming Shen
Hi, Here is the webrev for upgrading the bundled zlib from 1.2.3 to 1.2.5 for JDK8 http://cr.openjdk.java.net/~sherman/7110149/webrev The changes to the original zlib source code (other than the copyright attachment) is at http://cr.openjdk.java.net/~sherman/7110149/webrev/src/share/native