Re: test/java/util/Collection/ListDefaults.java updates

2013-05-13 Thread Mike Duigou
These changes look OK. I've been adding a description in my test providers which provides the test method with two params, a printable description and the test data. This has worked reasonably well and has the advantage that it can provide more information than just the class name. Mike On Ma

Re: test/java/util/Collection/ListDefaults.java updates

2013-05-13 Thread Chris Hegarty
Thanks Akhil, let me flesh it out a little more and send a formal webrev. -Chris. On 05/13/2013 05:58 PM, Akhil Arora wrote: Looks good to me. I have had to add similar print statements when debugging, but I deleted them before committing, to keep the default test output clean. Minor - it woul

Re: test/java/util/Collection/ListDefaults.java updates

2013-05-13 Thread Akhil Arora
Looks good to me. I have had to add similar print statements when debugging, but I deleted them before committing, to keep the default test output clean. Minor - it would be good to have a little more consistency... some tests print the class name always, some only on failure. Also would be go

test/java/util/Collection/ListDefaults.java updates

2013-05-13 Thread Chris Hegarty
Akil, Mike, I've recently been diagnosing failures with ListDefaults.java, when working on a separate issue. I found it difficult to determine which collection type was having problems, in some failure cases. The diffs below are what I had to implement in my local repo to help identify the c