I finally submitted this change
6944584: Improvements to subprocess handling on Unix
Thanks to all the reviewers.
Martin
David,
On Wed, Apr 21, 2010 at 20:15, David Schlosnagle wrote:
> On Wed, Apr 21, 2010 at 9:14 PM, Martin Buchholz wrote:
> Running ManyProcesses with Apple's version of 1.6.0_17-b04-248,
> averages around 45 seconds and 4010 started threads.
> Running ManyProcesses with the bsd-port of OpenJDK7
.
Fixed. (do you have a tool to detect extra imports?)
There are a number of tools:
IntelliJ: Free community version
:http://download.jetbrains.com/idea/ideaIC-9.0.2.exe
PMD: http://pmd.sourceforge.net/rules/imports.html
NetBeans: http://netbeans.org/kb/67/java/editor-tips.html
etc...
On Wed, Apr 21, 2010 at 9:14 PM, Martin Buchholz wrote:
> Thanks for the careful review.
No problem, I wanted test this patch out on OS X since the current
UNIXProcess.java.bsd is virtually identical to UNIXProcess.java.linux.
I slightly tweaked the ManyProcesses test to exec /usr/bin/true and
lo
Thanks for the careful review.
On Wed, Apr 21, 2010 at 17:47, David Schlosnagle wrote:
> Martin,
>
> In src/solaris/classes/java/lang/UNIXProcess.java.linux, are lines
> 177, 181, and 185 needed? If the assignment of these streams were in
> the constructor, they could be final.
Fixed.
Yes, the
Martin,
In src/solaris/classes/java/lang/UNIXProcess.java.linux, are lines
177, 181, and 185 needed? If the assignment of these streams were in
the constructor, they could be final.
176 synchronized void processExited(int exitcode) {
177 stdout = this.stdout;
178 if (stdout
I now have the second part of my planned improvements to
Linux process handling, and is now a serious proposal.
for Michael and others to review.
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/UNIXProcess/
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/UNIXProcess2/
This is a huge perfo
Martin,
Thanks for the answers. The changes look fine to me.
- Michael.
Martin Buchholz wrote:
On Mon, Apr 19, 2010 at 09:04, Michael McMahon wrote:
Martin Buchholz wrote:
On Fri, Apr 16, 2010 at 09:18, Mark Reinhold wrote:
For now I suggest leaving old @author tags as-is
On Mon, Apr 19, 2010 at 09:04, Michael McMahon wrote:
> Martin Buchholz wrote:
>>
>> On Fri, Apr 16, 2010 at 09:18, Mark Reinhold wrote:
>>
>>
>>>
>>> For now I suggest leaving old @author tags as-is.
>>>
>>
>> OK, done.
>>
>> Version 0.2 of the webrev is published.
>>
>> Martin
>>
>
> Martin,
>
Martin Buchholz wrote:
On Fri, Apr 16, 2010 at 09:18, Mark Reinhold wrote:
For now I suggest leaving old @author tags as-is.
OK, done.
Version 0.2 of the webrev is published.
Martin
Martin,
From what I can see, you've cleaned up the code and the functional changes
are the use
On Fri, Apr 16, 2010 at 09:18, Mark Reinhold wrote:
> For now I suggest leaving old @author tags as-is.
OK, done.
Version 0.2 of the webrev is published.
Martin
> Date: Fri, 16 Apr 2010 09:09:31 -0700
> From: Martin Buchholz
> On Fri, Apr 16, 2010 at 09:00, chris.hega...@oracle.com wrote:
>> I took a look at the preliminary changes.
>> * I'm not sure we can remove any previous authors names.
>
> We've considered doing that en masse.
Yes, and we might
I should have explicitly invited Michael and Xueming to review, as well.
On Fri, Apr 16, 2010 at 09:00, Chris Hegarty wrote:
> Martin,
>
> I filed the following to track this:
> 6944584: Improvements to subprocess handling on Unix
Thanks.
> I took a look at the preliminary changes.
> * I'm no
Martin,
I filed the following to track this:
6944584: Improvements to subprocess handling on Unix
I took a look at the preliminary changes.
* I'm not sure we can remove any previous authors names.
* I assume the second part, buffering of data after process
termination has not been impleme
Chris and/or Alan,
I am planning some improvements to Process.
Please file a bug.
Synopsis: Improvements to subprocess handling on Unix
Description:
Looking at UNIXProcess.java.linux, there are a number of possible improvements:
The "process reaper" thread should run in a thread pool to save on
t
15 matches
Mail list logo
