Re: SourceVersion::feature

2021-10-16 Thread Michael Bien
thank you! I replied on the PR. -michael On 16.10.21 01:19, Joseph D. Darcy wrote: PS See https://github.com/openjdk/jdk/pull/5973 -Joe On 10/14/2021 1:53 PM, Joseph D. Darcy wrote: On 10/14/2021 10:23 AM, Michael Bien wrote: is this the right mailing list for javax.lang.model.* discussions?

Re: SourceVersion::feature

2021-10-15 Thread Joseph D. Darcy
PS See https://github.com/openjdk/jdk/pull/5973 -Joe On 10/14/2021 1:53 PM, Joseph D. Darcy wrote: On 10/14/2021 10:23 AM, Michael Bien wrote: is this the right mailing list for javax.lang.model.* discussions? The compiler-dev list would be appropriate as well, but core-libs will work. F

Re: SourceVersion::feature

2021-10-14 Thread Joseph D. Darcy
On 10/14/2021 10:23 AM, Michael Bien wrote: is this the right mailing list for javax.lang.model.* discussions? The compiler-dev list would be appropriate as well, but core-libs will work. First, I understand the desire for a method like this. One of the potential issues is SourceVersion mode

Re: SourceVersion::feature

2021-10-14 Thread Michael Bien
is this the right mailing list for javax.lang.model.* discussions? if yes: instead of adding     /** * Returns the version as int representing the feature release. * @see Runtime.Version#feature() */     public int feature() {     return this.ordinal();     } to SourceVersion.

SourceVersion::feature

2021-10-09 Thread Michael Bien
Hello, could javax.lang.model.SourceVersion receive a feature() method returning the version as an int, analog to java.lang.Runtime.Version? if (SourceVersion.latest().feature() >= 18) {} is simpler than comparing enums which may or may not exist dependent on the deployed java version and cl