Re: Replace StringBuffers to StringBuilders in tests

2021-08-27 Thread Sergei Ustimenko
Hi Daniel and David, Thanks for your opinions and for sharing more context - it is definitely clearer now! I am glad that I reached out to the mailing list first instead of going ahead with the changes! :) Regards, Sergei Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On F

Replace StringBuffers to StringBuilders in tests

2021-08-27 Thread Sergei Ustimenko
Hi all, Some tests use StringBuffers instead of StringBuilders where additional thread-safety is not required as e.g. in test/jdk/sun/util/resources/TimeZone/Bug4640234.java:82 : ... StringBuffer errors = new StringBuffer( "" ); StringBuffer warnings = new StringBuffer( "" ); ... Th

Re: Replace StringBuffers to StringBuilders in tests

2021-08-27 Thread David Holmes
On 27/08/2021 8:42 pm, Daniel Fuchs wrote: Hi Sergei, I wouldn't bother replacing StringBuffers with StringDuilders in tests. It seems a bit gratuitous - and possibly could complicate future tests backports. But that's my personal opinion. Others might disagree. I agree with you. Complete was

Re: Replace StringBuffers to StringBuilders in tests

2021-08-27 Thread Daniel Fuchs
Hi Sergei, I wouldn't bother replacing StringBuffers with StringDuilders in tests. It seems a bit gratuitous - and possibly could complicate future tests backports. But that's my personal opinion. Others might disagree. best regards, -- daniel On 27/08/2021 11:00, Sergei Ustimenko wrote: Hi